opendevreview | Merged openstack/project-config master: Update post-review zuul pipeline definiton https://review.opendev.org/c/openstack/project-config/+/867282 | 00:02 |
---|---|---|
opendevreview | Ian Wienand proposed openstack/diskimage-builder master: tox jobs: pin to correct nodesets; use host networking for containerfile https://review.opendev.org/c/openstack/diskimage-builder/+/867579 | 00:13 |
opendevreview | Ian Wienand proposed openstack/diskimage-builder master: tox jobs: pin to correct nodesets; use host networking for containerfile https://review.opendev.org/c/openstack/diskimage-builder/+/867579 | 00:14 |
fungi | looks like the mm3 list mods let my questions through: https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/QWD5K6O5RHIVVKK5FUAWQS2VLF4PJMQT/ | 01:08 |
*** rlandy|bbl is now known as rlandy|out | 02:24 | |
*** ysandeep is now known as ysandeep|afk | 04:41 | |
*** yadnesh|away is now known as yadnesh | 05:08 | |
*** soniya29 is now known as soniya29|pto | 05:57 | |
*** ysandeep|afk is now known as ysandeep | 06:08 | |
*** jpena|off is now known as jpena | 07:54 | |
*** ysandeep is now known as ysandeep|lunch | 09:00 | |
opendevreview | Ade Lee proposed openstack/project-config master: Add FIPS job for ubuntu https://review.opendev.org/c/openstack/project-config/+/867112 | 10:37 |
*** ysandeep|lunch is now known as ysandeep | 11:01 | |
*** yadnesh is now known as yadnesh|afk | 11:05 | |
*** dviroel|out is now known as dviroel|rover | 11:12 | |
*** rlandy|out is now known as rlandy | 11:14 | |
*** yadnesh|afk is now known as yadnesh | 12:02 | |
*** gthiemon1e is now known as gthiemonge | 12:41 | |
opendevreview | Thierry Carrez proposed openstack/project-config master: Bring back the PTL+1 column in release dashboard https://review.opendev.org/c/openstack/project-config/+/867801 | 13:00 |
*** ysandeep is now known as ysandeep|dinner | 13:29 | |
*** pojadhav is now known as pojadhav|dr_appt | 13:50 | |
*** ysandeep|dinner is now known as ysandeep | 13:52 | |
*** dasm|off is now known as dasm | 14:30 | |
*** frenzy_friday is now known as frenzy_friday|food | 14:45 | |
*** yadnesh is now known as yadnesh|away | 15:01 | |
*** ysandeep is now known as ysandeep|afk | 15:23 | |
clarkb | https://storyboard.openstack.org/#!/story/2010472 I think the issue there is the calling environment's locale is used | 15:27 |
clarkb | I hesitate to hard code utf8 in git-review since you could be operating on other encodings and using the calling environment locale as it should already do might be necessary for other users? | 15:28 |
clarkb | fungi: ^ do you have ideas on that? | 15:28 |
fungi | looks like the reporter did not mention what their locale is, nor does the traceback/exception say what locale it's assuming during the decode | 15:30 |
fungi | that said, the plan in pep 686 (accepted by the sc) is to make utf-8 the default for everyone in python 3.15 | 15:31 |
clarkb | fungi: the traceback does show windows which is almost certainly not utf8 by default iirc | 15:32 |
fungi | and in python 3.11 you can set PYTHONUTF8=1 or pass -X utf8=1 to get that behavior early | 15:32 |
clarkb | I don't know what windows users expect but I expect if you run in a utf16 environment that you should be writing utf16 by default... | 15:32 |
*** frenzy_friday|food is now known as frenzy_friday | 15:33 | |
fungi | there's some rationale in https://peps.python.org/pep-0686/ that it's safe for windows | 15:34 |
fungi | "Visual Studio Code and Windows Notepad use UTF-8 by default" | 15:34 |
fungi | "this change mostly affects Windows users" | 15:34 |
opendevreview | Merged openstack/project-config master: Bring back the PTL+1 column in release dashboard https://review.opendev.org/c/openstack/project-config/+/867801 | 15:34 |
fungi | "Ruby changed the default external_encoding to UTF-8 on Windows in Ruby 3.0 (2020)." | 15:35 |
clarkb | fungi: I'm mostly concerned that if this person uses notepad to write a utf16 file that they will break in the other direction | 15:35 |
clarkb | I don't know how realistic that is. But I'm kind of thinking we should ask the user to set the locale properly instead of hardcode utf8? | 15:35 |
fungi | yes, or turn on PYTHONUTF8 in their environment (however windows users do that) | 15:36 |
clarkb | the underlying problem here being that the python process is interacting with files generated by git and $EDITOR which are likely to respect locale? | 15:36 |
fungi | oh, actually "utf-8 mode" is available as far back as 3.7 according to pep 540, so they wouldn't have to upgrade the interpreter to test it | 15:39 |
fungi | and yes, that's git's stdout which git-review is choking on, i think | 15:40 |
fungi | clarkb: i've added a comment with some suggestions, but also i don't think this is a bug for git-review to solve | 15:47 |
clarkb | fungi: I guess, we could accept a git-review flag to set locale expectations, but python will already respect the calling environment for tha | 15:48 |
fungi | right. "fixing" this on the git or python side is the right solution in my opinion, and since the python community is already planning to force utf-8 by default rather than doing locale detection for 3.15 it seems like the sort of thing which users should be trying out to make sure it does solve problems like this | 15:50 |
fungi | basically the python devs' collective opinion is that if your locale isn't utf-8 then that's probably a mistake. if you really know for sure that you don't want python to ignore your locale settings then you can still flip a switch to turn on the old locale detection/guessing behaviors | 15:52 |
*** ysandeep|afk is now known as ysandeep | 16:06 | |
clarkb | infra-root: I'm thinking today is a good day to start winding down iweb? That way its done before holidays begin in earnest? | 16:30 |
clarkb | If I hear no objections I'll approve https://review.opendev.org/c/openstack/project-config/+/867262 after breakfast | 16:30 |
fungi | clarkb: sgtm, i didn't know if those weren't wip for a reason so was hesitant to approve yet | 16:32 |
clarkb | mostly just wanting to be sure we landed them when we are ready. I think we are there now considering how things slow down for holidays. I've also got enough work to do when things slow down with annual report stuff and so on | 16:35 |
fungi | yeah, sounds fine. things have been pretty slow from a ci volume perspective for weeks already | 16:40 |
clarkb | I've approved it and will go find breakfast now | 16:43 |
fungi | thanks! | 16:43 |
opendevreview | Merged openstack/project-config master: Set iweb max-servers to 0 https://review.opendev.org/c/openstack/project-config/+/867262 | 16:55 |
*** jpena is now known as jpena|off | 17:16 | |
*** ysandeep is now known as ysandeep|out | 17:41 | |
*** pojadhav|dr_appt is now known as pojadhav | 18:01 | |
clarkb | iweb utilization has dropped to zero https://grafana.opendev.org/d/82725df382/nodepool-iweb?orgId=1 | 20:26 |
clarkb | I'm going to double check that we don't have any held nodes there since the graph doesn't seem to show held nodes? | 20:27 |
clarkb | corvus: ^ there is one node left and it is for a hold you created. Looks like zuul py38 stuff. Should I clean that up or do you want to take a look? | 20:28 |
corvus | clarkb: i marked it deleting, should be gone soon | 20:55 |
clarkb | yup its gone, thanks! | 20:56 |
clarkb | I'm going to approve https://review.opendev.org/c/openstack/project-config/+/867263/ now to remove iweb diskimages and labels | 20:56 |
corvus | fungi: i've not been paying attention so i don't know if there are changes, but lists.zuul-ci.org now shows all the lists, not just zuul lists | 21:06 |
opendevreview | Merged openstack/project-config master: Set iweb to empty labels and diskimages https://review.opendev.org/c/openstack/project-config/+/867263 | 21:07 |
clarkb | corvus that was a whole thing yesterday and the day before | 21:08 |
clarkb | corvus: it turns out that when you login as admin toe django that side effects the creation of site records that then impact the vhosting of mailman | 21:08 |
corvus | sorry! i'll try to catch up sometime | 21:08 |
fungi | corvus: https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/QWD5K6O5RHIVVKK5FUAWQS2VLF4PJMQT/ | 21:08 |
clarkb | corvus: on a held test node fungi wasable to reproduce this and fix it for lists.zuul-ci.org both under postorius and hyperkitty. But we were only able to fix it for lists.opendev.org under hyperkitty. | 21:08 |
fungi | that hopefully catches you up | 21:08 |
corvus | oh okay so this is related to the "link in the top left" thing we talked about at mtg | 21:09 |
clarkb | and ya that email upstream is meant to try and figure out how to fix postorius under lists.opendev.org then we can make a plan to fix it | 21:09 |
clarkb | ya | 21:09 |
fungi | right, i pulled on that thread and a lot of stuff unraveled | 21:09 |
fungi | clarkb: i feel like we have a bit of a blind spot on pbr-related packaging discussions too. this also seems to have cropped up in the wake of tox v4: https://github.com/tox-dev/tox/issues/2712 | 21:11 |
fungi | "Use of 'pbr' results in "Multiple top-level packages" error and "unkillable" process" | 21:12 |
fungi | i think this is what you were observing | 21:12 |
fungi | stephenfin: ^ we should try to coordinate | 21:12 |
corvus | fungi: thanks for the link, i feel much more caught up now | 21:12 |
clarkb | fungi: stephenfin adding the find: directive fixed it. So I don't think thats much of a problem | 21:12 |
clarkb | fungi: stephenfin: the real issue is that tox v4 appears to be invoking setup.py via the pyproject.toml invocation method which is not valid | 21:13 |
clarkb | when you use pbr with pyproject.toml you need to invokce it via the pbr entrypoint that will then invoke the setuptools entrypoint. And importantly build sorts all of this out for you | 21:13 |
clarkb | https://github.com/tox-dev/pyproject-api is what tox is using | 21:15 |
clarkb | which calls into https://github.com/tox-dev/pyproject-api/blob/main/src/pyproject_api/_frontend.py | 21:16 |
clarkb | fungi: stephenfin my takeaway from this is that you can only use tox v4 reliably if you are a prproject.toml project | 21:16 |
*** dviroel|rover is now known as dviroel|rover|afk | 21:16 | |
clarkb | https://github.com/tox-dev/pyproject-api/blob/main/src/pyproject_api/_frontend.py#L179-L180 thats the source of the issue | 21:17 |
fungi | yes, or at least gabor doesn't understand that the project in question doesn't use pyproject.toml at all | 21:17 |
fungi | i guess build doesn't call directly into setuptools.build_meta:__legacy__ | 21:18 |
clarkb | https://github.com/tox-dev/pyproject-api/blob/main/src/pyproject_api/_frontend.py#L228-L244 | 21:19 |
clarkb | I think weshould pick a brave soul to write an issue that explains tox doesn't properly support legacy setup.py projects anymore and explain our situation as the example | 21:19 |
fungi | https://github.com/pypa/build/blob/main/src/build/__init__.py#L59-L62 | 21:20 |
clarkb | we can suggest build as the fallback and have tox continue to do its pyproject.toml things for modern projects | 21:20 |
fungi | i wonder if build doesn't use _DEFAULT_BACKEND under some circumstances | 21:20 |
clarkb | fungi: I think it may only do that when pyproject.toml exists but doesn't declare the entrypoint | 21:20 |
clarkb | tox is using it when pyproject.toml does not exist at all which is fundamentally wrong | 21:21 |
fungi | the docstring here seems to imply they want to return that when there's no pyproject.toml: https://github.com/pypa/build/blob/main/src/build/__init__.py#L197-L202 | 21:21 |
* clarkb hacks up the local install of build | 21:22 | |
opendevreview | James E. Blair proposed zuul/zuul-jobs master: Add ensure-nox role https://review.opendev.org/c/zuul/zuul-jobs/+/867902 | 21:23 |
fungi | i need to take a break to cook/eat dinner but shall return | 21:23 |
clarkb | ya I haven't eaten lunch yet, but this too interesting | 21:24 |
JayF | Where does "Organizations" information come from in openstack.biterg.io? | 21:26 |
clarkb | JayF: bitergia maintains an affiliations db | 21:28 |
clarkb | I believe foundation staff can edit it for the openstack instance, but they also use some central content they've collected over time or something | 21:28 |
JayF | That sounds a bit ominous | 21:28 |
JayF | where can I look and see how Sauronergia has me categorized? lol | 21:28 |
JayF | Yeah; it has me categorized as "OpenStack Foundation", so I should fix that. Is there a documented process for fixing that? | 21:31 |
JayF | and also I know several Ironic contributors are misattributed as well | 21:32 |
clarkb | I'm not sure. I know I can do it for zuul but that is a separate instance. Let me ask | 21:33 |
clarkb | fungi: stephenfin: I did a lot more digging and both tox and build seem to call the setuptools build meta backend in the same way. At first this had me very stumpted but then I noticed that tox does use a slgiht difference. They run a separate process that processes potnatially many commands to setuptools legacy but build uses a fresh process | 22:13 |
clarkb | I think that very likely explains why the process isn't exiting (its getting stuck in the loop for that system) and may explain the version issues | 22:13 |
ianw | sorry running a bit late. assuming tox has broken everything :) | 22:15 |
fungi | JayF: clarkb: there's work in progress to collect affiliation information from the openinfra member profiles | 22:16 |
fungi | that should ideally become the official source of truth in time | 22:17 |
JayF | It makes me a little uncomfortable that my work is being misattributed, and that our project is now relying on information presumedly mined from somewhere on the internet. | 22:17 |
fungi | the idea is that contributors should be able to directly adjust their affiliation info | 22:18 |
fungi | there is a thread on the foundation mailing list where that work in progress is being discussed (note that the openstack.biterg.io dashboard is incomplete, still being worked on) | 22:18 |
JayF | I think my concerns are probably unique enough that such participation would be roadblocking without a better solution. I try not to NACK something unless I have a positive alternative to suggest, and in this case I have nothing :) | 22:19 |
fungi | yeah, it's also not done yet, as i mentioned. work in progress | 22:27 |
*** cloudnull1 is now known as cloudnull | 22:29 | |
fungi | that dashboard is mainly only publicly reachable because they don't have a good way to share it with us otherwise, but it's not ready for real use yet, just a preview | 22:30 |
JayF | Honestly, my concern was more with "it's not very open to use data that was mined/came from ??????" than the current status | 22:32 |
JayF | I don't love the ability of using data mined using "vendor magic" as part of our open statistics | 22:32 |
JayF | but there are lots of things I don't love and the world keeps spinning :P | 22:33 |
clarkb | ianw: long story short is in trying to make tox v4 work with zuul I think we may have discovered a more problematic issue with tox v4. sfinucan discovered it independently (and now I realized i used the wrong nick earlier) | 22:33 |
clarkb | ianw: I've updated the sfinucan issue upstream with what I've found: https://github.com/tox-dev/tox/issues/2712 | 22:33 |
fungi | JayF: that "magic" is mostly guessing based on people's e-mail address domains, as i understand it. inaccurate i agree, which is why we want it to use foundation profiles which are under the direct control of the contributors to adjust as they desire | 22:37 |
*** rlandy is now known as rlandy|out | 22:49 | |
JayF | interesting that it tagged my email as openstack; given I commit from an email domain only used by my immediate family :) maybe a default? | 22:51 |
JayF | that weirds me out a *lot* less though, knowing it's by domain | 22:51 |
JayF | I had ideas of like, scraping github and linkedin profiles and the like :) | 22:51 |
opendevreview | Ian Wienand proposed openstack/diskimage-builder master: tox jobs: pin to correct nodesets; use host networking for containerfile https://review.opendev.org/c/openstack/diskimage-builder/+/867579 | 22:53 |
ianw | i forgot to update the gate jobs in ^ | 22:53 |
clarkb | +W | 22:54 |
*** sfinucan is now known as stephenfin | 22:55 | |
fungi | JayF: i think they normally expect project leaders to go through and assign affiliations to all the contributors, but openstack is just too big for that to be a viable approach, which is why we want them to base it on something self-service from the contributor standpoint | 22:57 |
ianw | clarkb: thanks, watching the issue with interest, and quite a bit of relief that you seem to have it under control :) | 23:19 |
clarkb | I dunno if I would call this control... | 23:20 |
clarkb | I've tried to naively use the existing "SubprocessFrontend" which is supposed to create a new backend per command invocation and the whole thing just hangs running the first command | 23:20 |
clarkb | it is interesting that they've written a system that can do what I describe though but don't seem to use it... | 23:20 |
clarkb | I see now that the pep517 frontend is a bit specialized which probably explains why my naive version didn't work | 23:26 |
*** dasm is now known as dasm|off | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!