Clark[m] | I see virtualpdu changes in search now | 00:09 |
---|---|---|
fungi | manage-projects succeeded https://zuul.opendev.org/t/openstack/build/9891dc34ec3a4406b7eb34d39c7c91ff | 00:24 |
ianw | excellent | 00:29 |
fungi | 2023-04-07 00:04:18,879: jeepyb.utils - INFO - Executing command: git --git-dir=/opt/lib/jeepyb/openstack/virtualpdu/.git --work-tree=/opt/lib/jeepyb/openstack/virtualpdu push ssh://review.opendev.org:29418/openstack/virtualpdu HEAD:refs/meta/config | 00:29 |
fungi | did we expect that? | 00:29 |
Clark[m] | Yes the file was updated in one of them iirc | 00:30 |
Clark[m] | It added the meta openstack parent config iirc | 00:30 |
Clark[m] | But double check. The change for that project? | 00:30 |
fungi | yeah, i'm grabbing it | 00:31 |
Clark[m] | https://review.opendev.org/c/openstack/project-config/+/876231/3/gerrit/acls/openstack/virtualpdu.config ya it changed so that should be correct | 00:31 |
fungi | https://paste.opendev.org/show/b7FMBqZiyHilZBN0pATw/ | 00:33 |
fungi | that looks like it matches | 00:34 |
fungi | excellent | 00:34 |
fungi | i need to step away for a few | 00:35 |
fungi | i think i accidentally closed the screen session on bridge, but i think we were done in it anyway? | 00:36 |
fungi | also `gerrit show-queue --by-queue` doesn't have any more replication tasks | 00:37 |
Clark[m] | Ya I already detached | 00:37 |
fungi | what's step 21 about removing autoholds? | 00:37 |
fungi | but otherwise i think we're at post-maintenance fixups | 00:37 |
Clark[m] | I think that's for the test node(s) that were held | 00:38 |
fungi | oh, for the upgrade testing | 00:38 |
fungi | got it | 00:38 |
fungi | okay, stepping away, but will be back soon | 00:38 |
opendevreview | Merged opendev/system-config master: Upgrade Gerrit to version 3.7 https://review.opendev.org/c/opendev/system-config/+/879412 | 00:45 |
ianw | ^ that has deployed | 01:09 |
ianw | ok at the bottom of https://etherpad.opendev.org/p/gerrit-upgrade-3.7 i've added everything i think we need to follow up on | 01:12 |
ianw | i don't think anything is super urgent | 01:13 |
clarkb | thanks! I'll take a look in the morning. Other than the todos everyhting is done at this point right? Looks like it from my read of scrollback | 01:36 |
fungi | yep, that's my take on it | 01:37 |
JayF | I have not read all backscroll, so apologies if this is a repeat, but it looks like github.com/openstack/virtualpdu was archived at some point, and is still showing old content/redirects | 01:51 |
JayF | it's not urgent, and things look right on opendev, but something else to follow up on perhaps | 01:51 |
fungi | JayF: this was a move out and then back into the openstack namespace i guess? i think some of the tc members have github accounts with access to do the unarchiving | 01:57 |
*** Trevor is now known as Guest10224 | 01:57 | |
fungi | oh, i see, it got transferred to https://github.com/openstack-archive | 02:02 |
fungi | so we'd need to un-transfer it maybe | 02:02 |
ianw | JayF / fungi: hrm, i tried logging in as what i thought was our user that would own that, but doesn't seem they do. so might have to do some digging to find the right way to unarchive that | 04:55 |
*** TheMaster is now known as Unit193 | 08:54 | |
*** elodilles is now known as elodilles_pto | 10:11 | |
JayF | IIRC that used to require a github support round trip | 13:27 |
JayF | to get a repo redirected | 13:27 |
fungi | when we added the redirects, we did it via github's feature to transfer repositories between orgs | 14:04 |
noonedeadpunk | folks, is it possible to get an auto-hold for 879732 on job openstack-ansible-deploy-aio_metal-rockylinux-9 ? GPG thing again, but now I can't reproduce that in any way localy and it looks related to the patch... And what's more interesting is that lxc job is passing, so sounds like smth specific to the image.... | 14:55 |
clarkb | noonedeadpunk: ya I'm sitting down now and will load ssh keys and do that | 15:12 |
noonedeadpunk | ssh keys btw: https://launchpad.net/~noonedeadpunk/+sshkeys | 15:13 |
noonedeadpunk | ah. damn, just failed | 15:14 |
clarkb | noonedeadpunk: do you want to recheck it? | 15:14 |
clarkb | ok the hold is placed with zuul | 15:16 |
noonedeadpunk | yup, decided to leave this only job not to waste resources | 15:17 |
clarkb | infra-root one thing I've noticed on jammy static02 is that the ubuntu universe package for openafs-client is slightly newer than that in our ppa so we are not using our ppa client. I don't think this is a problem but wanted to call it out | 15:19 |
clarkb | infra-root I'm going to test all of the names I identified as being hosted by static with local /etc/hosts overrides and if that looks good I'd like to land the DNS updates to switch the static.opendev.org CNAME over to the new server | 15:19 |
clarkb | then I'll start looking at gerrit things. I'll probably start by writing that upstream bug for the migration thing. | 15:19 |
clarkb | https://paste.opendev.org/show/bYHz6TNAzx9jsehRmIJx/ is the list of names I'm checking | 15:21 |
clarkb | ok all of the names in ^ lgtm when overridden in local /etc/hosts. I would like to merge https://review.opendev.org/c/opendev/zone-opendev.org/+/879780 https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/879782 and https://review.opendev.org/c/opendev/zone-gating.dev/+/879784 | 15:35 |
clarkb | infra-root ^ let me know if you think that is safe at this point. I think the main risks are that I've missed some names somewhere (there are a lot of them) or that the ubuntu upstream afs package is unhappy somehow (it has had a lot less trial by fire than our version but the versions are similar) | 15:36 |
clarkb | I think if we land those three and I update devstack.org records we can stop apache on the old server then wait a while before we start removing old stuff | 15:36 |
clarkb | which means it is easy to rollback if necessary | 15:36 |
fungi | using newer openafs from distro sounds fine (even better) to me, since our ppa was to deal with too-old openafs in ubuntu lts | 15:45 |
fungi | clarkb: spot checks with dns overridden look right to me | 15:45 |
opendevreview | Clark Boylan proposed opendev/system-config master: Extra debugging around gerrit config and cache diffs https://review.opendev.org/c/opendev/system-config/+/879901 | 15:47 |
opendevreview | Clark Boylan proposed opendev/system-config master: Fix gerrit 3.7 config diff https://review.opendev.org/c/opendev/system-config/+/879902 | 15:47 |
clarkb | I've added ^ to the todo section of our etherpad to track that | 15:48 |
clarkb | first change is made to get more info out of our checks and second one corrects the delta. I'm hoping we can fix whatever the issue is in the checking and then squash the two together for merging | 15:48 |
clarkb | fungi: cool you're good with me approving the dns updates now then? or do you want to do it? | 15:49 |
noonedeadpunk | clarkb: job has just failed :) | 15:50 |
fungi | that was nice and fast | 15:50 |
fungi | clarkb: i can approve them, just pulling them up now | 15:50 |
fungi | i think i won't be able to approve 879782 until 879780 merges (or do they share a queue?) | 15:52 |
clarkb | fungi: ya may have to be one after the other | 15:53 |
clarkb | I don't recall if they share queues | 15:53 |
clarkb | noonedeadpunk: looking | 15:53 |
opendevreview | Merged opendev/zone-opendev.org master: Update static.o.o CNAME to point at static02 https://review.opendev.org/c/opendev/zone-opendev.org/+/879780 | 15:54 |
hashar | clarkb: my warm congratulations for the Gerrit 3.7 upgrade \o/ | 15:54 |
clarkb | noonedeadpunk: root@23.253.56.21 | 15:55 |
fungi | thanks hashar! | 15:55 |
noonedeadpunk | that worked, thanks! | 15:56 |
fungi | ianw did all the hard work | 15:56 |
hashar | well congratulations to ianw as well so :-]]] | 15:56 |
clarkb | this is the first time we're running the latest version of gerrit since like 2013/2014 maybe? | 15:56 |
clarkb | (if you exclude the 3.8 rc0 that was just made a few days ago) | 15:57 |
fungi | i'm definitely going to exclude that, so it doesn't ruin the party | 15:57 |
clarkb | ya I don't think release candidates count :) | 15:57 |
fungi | i've decided that they definitely don't | 15:58 |
hashar | well 3.8 is going to be out soon :] | 15:59 |
clarkb | ya I know so we'll enjoy this for a couple of weeks while it lasts :) | 15:59 |
opendevreview | Merged opendev/zone-zuul-ci.org master: Update zuul dns records to the new static02 server https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/879782 | 16:01 |
clarkb | fungi: since you did the previous All-Projects surgery to fix and/AND what are your thoughts on essentially reverting the copyConditions from the migration? | 16:06 |
clarkb | since trivial rebase inlcudes no change we don't need both of them under code-review and alraedy had trivial rebase. And Idon't think we want the copy conditions for verified or workflow set. I think that means a straight up revert with a commit message indicating why is a good next step there | 16:06 |
fungi | is it going to undo them, or was that a one-time "upgrade" of the config? | 16:06 |
clarkb | fungi: like sql db migrations it tracks what version it is at and won't reapply that migration as long as our recorded version is >= to the current value | 16:07 |
clarkb | effectively making it a one time thing | 16:07 |
noonedeadpunk | that is really interesting thing... https://paste.openstack.org/show/beRFJTVnrgJ3TX4IZdPJ/ | 16:07 |
noonedeadpunk | How gpg check might fail, but if retry - it will pass.... | 16:07 |
clarkb | if you look at the revert notes in etherpad one of the steps is resetting that migration version value in notedb | 16:08 |
clarkb | fungi: thats line 273 if curious | 16:08 |
clarkb | noonedeadpunk: does dnf/yum have some sort of refresh command? | 16:08 |
clarkb | I wonder if doing that would resync things | 16:08 |
noonedeadpunk | well, re-runing playbook doesn't fix this as well as `dnf clean all` doesn't help | 16:10 |
noonedeadpunk | I will play around with that for a while I guess... As I'm quite o_O right now | 16:11 |
fungi | looking around, it seems once upon a time ansible didn't check package signatures with dnf, and then maybe added their own checker to solve that? | 16:12 |
fungi | ah, no, they just enabled it in dnf's config i think: https://github.com/ansible/ansible/pull/47455/files | 16:13 |
noonedeadpunk | well, asnible tend to re-write package managers logic, true... But I kinda see issue even without ansible in that image | 16:14 |
fungi | unfortunately a web search on the vague error there turns up every conceivable reason someone might encounter signature verification errors | 16:15 |
fungi | centos was also hitting a similar error this week, right? | 16:18 |
noonedeadpunk | Well, yes, it was. It was more consistent and caused by gnupg2-2.3.3-3 | 16:20 |
noonedeadpunk | And here is gnupg2-2.3.3-2 | 16:20 |
fungi | though looking at the paste, i wonder if there's something racing the key addition, such that accepting the key only causes it to be checked on subsequent runs. maybe adding the archive key before installing packages would work? | 16:21 |
fungi | for adding external debian repositories that's basically the only way to do it, because they sign the package indices instead of individual packages, so you can't even successfully pull the package list for a repository if the key hasn't been added to the package manager's keyring in advance | 16:22 |
noonedeadpunk | yeah, might be... Btw, while I can reproduce paste outside of the nodepool VM, it doesn't hurt ansible run somehow | 16:22 |
clarkb | https://bugs.chromium.org/p/gerrit/issues/detail?id=16839 file for the copyConditions issue | 16:24 |
noonedeadpunk | It actually looks like even more progressive issue then centos had, as you could workaround gpg import with `rpm --import` and here it refuses to do so | 16:26 |
clarkb | NeilHanlon: may have ideas | 16:27 |
noonedeadpunk | yep, pinged him already | 16:27 |
clarkb | the diff of gerrit.config is empty in our test job https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_590/879901/1/check/system-config-upgrade-review/5900f3e/bridge99.opendev.org/ara-report/results/487.html | 16:32 |
fungi | infra-root: i have this prepared i can push to all-projects: https://paste.opendev.org/show/bgyUBan3JmqrEMYt6TrI/ | 16:36 |
clarkb | fungi: that diff looks great to me and thank you for the extra context in the commit message should we ever need to spelunk this in the future | 16:37 |
fungi | i improved the wording in the commit message a little more for added clarity | 16:38 |
fungi | i feel like there's probably no other infra-root around to object, so i'll go ahead and push it. can always revert the revert if there are concerns raised later | 16:40 |
fungi | and done | 16:42 |
fungi | https://paste.opendev.org/show/b6MyKcWphBQ7SPJsThiu/ | 16:43 |
fungi | i had to temporarily add my fungi.admin account to the project bootstrappers group | 16:43 |
clarkb | thank you! | 16:43 |
fungi | apparently it had perms to pull but not to push? | 16:43 |
clarkb | ya read access to admins but push access is bootstrappers iirc | 16:43 |
clarkb | can you update the etherpad with that paste too just to captuer that? | 16:43 |
fungi | yep | 16:44 |
opendevreview | Clark Boylan proposed opendev/system-config master: Extra debugging around gerrit config and cache diffs https://review.opendev.org/c/opendev/system-config/+/879901 | 16:46 |
opendevreview | Clark Boylan proposed opendev/system-config master: Fix gerrit 3.7 config diff https://review.opendev.org/c/opendev/system-config/+/879902 | 16:46 |
clarkb | fungi: the git-review output from gerrit ssh push tells you that votes are removed too | 16:47 |
clarkb | they would've been removed before your all-projects update since I actually made changes but thats neat | 16:47 |
clarkb | oh wait no this was on the child change which had no delta so that confirms your update is working | 16:47 |
clarkb | https://paste.opendev.org/show/b5Am2sBp2Dgm0kNIwTto/ | 16:48 |
fungi | clarkb: for any other acls that may have acquired that addition, i expect a full manage-projects run will correct it, yeah? | 16:48 |
clarkb | fungi: yes | 16:48 |
clarkb | I think before we run that it might be worth spot checking to see what impact there is if any then plan to do that next week? I know ianw did it recently so should be familiar with the process | 16:49 |
fungi | wfm | 16:50 |
fungi | just a reminder, i won't be around to help next week, not that it sounds all that complicated | 16:50 |
clarkb | ya I think we've got it. Just need to spend a bit more time understanding the impact outside of all-projects | 16:50 |
clarkb | opendev.org static records are updated as are the zuul domain records. gating.dev has not updated. fungi want to approve https://review.opendev.org/c/opendev/zone-gating.dev/+/879784 too? | 16:52 |
fungi | can do | 16:52 |
clarkb | and as far I can tell things are working | 16:52 |
fungi | also, here's the openstack/releases acl migration update for an example: https://paste.opendev.org/show/bYNAxQ5OMElHAzYEkNfj/ | 16:53 |
fungi | looks like indentation has changed too? | 16:53 |
clarkb | I'll get devstack.org records updated at some point today as well then put static01 in emergency file and shutdown its apache process | 16:53 |
fungi | um | 16:53 |
fungi | -requireContributorAgreement = true | 16:53 |
clarkb | fungi: it added it back with indentation | 16:54 |
fungi | oh, so it did. i cancelled the pager without scrolling | 16:54 |
clarkb | I think the only functional chagne in that file is the changekind:NO_CHANGE addition which is a noop | 16:54 |
fungi | *phew* | 16:54 |
clarkb | considering that gerrit seems to think the tabbed version is canonical we might want to switch to that so that future migrations that may occur have easier to read diffs | 16:55 |
fungi | but yeah, mainly confirming that it did alter the acls | 16:55 |
clarkb | but I think as far as functionality goes for right now we are ok | 16:55 |
fungi | so definitely some impact outside all-projects but yes i doubt it's going to be significant | 16:55 |
clarkb | I'll need to think through what a convert everything to tabbed indentation update looks like | 16:57 |
clarkb | I think we will want ot incorporate that into the run mangae-projects by hand run so that we don't have to do that multiple times | 16:57 |
fungi | i think we can just change the normalizer and then accept the next normalization change | 16:57 |
clarkb | basically update our "linter" and all the files then do manual run | 16:57 |
clarkb | ++ | 16:57 |
fungi | or use it to generate the diff | 16:58 |
fungi | all the original acl cleanup i did was via the normalizer, for precisely that reason | 16:58 |
clarkb | cool so do that then do the manual run to fixup the copyConditions | 16:58 |
clarkb | should be something we can put together next week | 16:58 |
fungi | tools/normalize_acl.py | 16:59 |
fungi | i would maybe alter transformation #1 since it's what currently unindents everything | 17:00 |
fungi | i'll see if i can hack that together real quickly | 17:01 |
clarkb | cool I've put some notes about this into the etherpad too | 17:01 |
opendevreview | Jeremy Stanley proposed openstack/project-config master: Indent Gerrit ACL options https://review.opendev.org/c/openstack/project-config/+/879906 | 17:09 |
clarkb | fungi: what is interesting is that our all-projects config seems to be space indented not hard tabs. And it didn't undo that so whatever formatter it uses seems to respect tabs vs spaces but seems to default to tabs if there are none? | 17:10 |
fungi | now that i've written that ^ i'm not sure whether it's a good idea. lots of people are probably going to struggle with the enforced hard tab indentation, using editors which may end up using spaces magically instead | 17:10 |
fungi | oh! interesting. i'll switch to four space tabs | 17:10 |
clarkb | fungi: I'm sad that this is a liekly problem :/ | 17:10 |
clarkb | I've configured my editor so that I can be specific about it and get proper annotations to distinguish between the two. But ya especially if you open the jenkins code base its a huge mess of mixed tabbing for example | 17:11 |
clarkb | fungi: oh wait your paste for the rever tand the paste from yesterday showing the change differ in tabs vs spaces | 17:12 |
clarkb | so now I'm more confused | 17:12 |
clarkb | maybe ianw's copy pasting converted them for us but your rever is actually tabs? | 17:12 |
clarkb | this probably need more investigating and testing unfrotunately | 17:12 |
fungi | yeah | 17:12 |
fungi | i pushed the change as wip regardless | 17:12 |
fungi | because it will still need to be run against all the acl files to create a diff if/when we're ready to do that | 17:13 |
clarkb | honestly, it shouldn't be difficult for people to use hard tabs or spaces depending on which is required. But I agree that certainly there will be trouble | 17:13 |
noonedeadpunk | clarkb: you can remove hold now, many thanks! | 17:17 |
clarkb | noonedeadpunk: will do. Did you manage to sort it out? | 17:18 |
noonedeadpunk | well... not the mistery why thi key didn't work, but I realized that gpg key from other mirror was matching as well (somehow) | 17:18 |
noonedeadpunk | so just using gpg from repo a to verify repo b... or well, since it's packages that are signed, might be it's not that a big deal... but still nasty | 17:20 |
clarkb | hrm i don't know if gating.dev updated dns properly. I don't see any pending jobs for it and if I dig against our nameservers I get the old values back | 17:20 |
noonedeadpunk | also Nail has grabbed data to reproduce the setup if needed | 17:20 |
clarkb | autohold delete has been issued | 17:21 |
clarkb | based on my latest patchset to the gerrit config debugging thing the quotes are removed on the old side and the new side of the diff. I think this is because we write gerrit.confg and then start gerrit 3.6 then it normalizes things. Then we capture the config for the old side | 17:24 |
clarkb | I think we need to capture the configs before starting the old gerrit side but sorting that out in a generic way that doesn't leak into production deployments might be a pain. Ill look into that though | 17:24 |
clarkb | maybe we can run the playbook without starting anything, capture the logs, run the playbook and start things, then do upgrade | 17:25 |
clarkb | * capture the configs | 17:25 |
opendevreview | Jeremy Stanley proposed openstack/project-config master: Indent Gerrit ACL options https://review.opendev.org/c/openstack/project-config/+/879906 | 17:40 |
opendevreview | Clark Boylan proposed opendev/system-config master: Extra debugging around gerrit config and cache diffs https://review.opendev.org/c/opendev/system-config/+/879901 | 17:43 |
opendevreview | Clark Boylan proposed opendev/system-config master: Fix gerrit 3.7 config diff https://review.opendev.org/c/opendev/system-config/+/879902 | 17:43 |
clarkb | if that works it will make the job take a little longer but hsould be more robust diffing | 17:43 |
clarkb | I don't think the gating.dev change triggered jobs to update the nameservers. I suspect this will self correct during our daily job runs and I'm happy to followup on this next week since I'vegot enough other stuff going on I can focus on today | 17:51 |
clarkb | just a heads up to what I think happened there. The jobs didn't run at all not jobs failed | 17:51 |
clarkb | the bulk change update abilities in gerrit 3.7's web ui are a nice update. Gerrit is adding Gertty features now. corvus should be proud | 17:55 |
fungi | clarkb: oh! the cross-tenant triggering problem i guess? | 17:56 |
clarkb | fungi: either that or we don't have the jobs declared at all for some other reason? | 17:56 |
clarkb | but ya I think it will correct itself when daily jobs run? | 17:56 |
clarkb | which means I can finish things up next week. I'm not in a massive rush | 17:56 |
clarkb | ok getting closer with the commit diffs. Capturing the file before starting gerrit 3.6 shows it with ""s then starting 3.6 removes them. But the diffing didn't fail the job for some reason | 18:17 |
clarkb | I think I see it this is fun | 18:18 |
opendevreview | Clark Boylan proposed opendev/system-config master: Extra debugging around gerrit config and cache diffs https://review.opendev.org/c/opendev/system-config/+/879901 | 18:21 |
opendevreview | Clark Boylan proposed opendev/system-config master: Fix gerrit 3.7 config diff https://review.opendev.org/c/opendev/system-config/+/879902 | 18:21 |
clarkb | set -o pipefail is necessary because of the tee capturing the diff for logging | 18:22 |
clarkb | assuming the parent fails and the child succeeds I'll work on condensing those two into a mergable change | 18:22 |
opendevreview | Jeremy Stanley proposed openstack/project-config master: Deploy gating.dev DNS changes https://review.opendev.org/c/openstack/project-config/+/879910 | 18:47 |
fungi | it was already in the openstack tenant apparently | 18:47 |
Clark[m] | I'll take a look after lunch | 18:50 |
fungi | it's in no way urgent, just thought i'd push a patch since i bothered to look | 19:02 |
opendevreview | Clark Boylan proposed opendev/system-config master: Fix gerrit upgrade config diff checking https://review.opendev.org/c/opendev/system-config/+/879901 | 20:59 |
clarkb | I think ^ is now in a mergeable state and that should address this going forward | 20:59 |
clarkb | fungi: I didn't approve 879910 only because it wouldn't trigger the job we want now so waiting for a second reviewer doesn't seem like a big deal | 21:01 |
clarkb | but feel free to +A if you like to keep one thing off our backlog before being afk | 21:01 |
ianw | thanks for looking at the all proejcts | 21:07 |
ianw | one thing i couldn't determine, was how do you actually get into a situation of pushing something that is NO_CHANGE? | 21:07 |
clarkb | ianw: only updating the commit itself maybe? liek a cherrypick and push? | 21:08 |
clarkb | maybe upstream can help clarify that on the bug I filed | 21:08 |
ianw | yeah, i mean you'd think cherry-picking and pushing would change the parent? | 21:08 |
ianw | i agree on the tabs; it seems gerrit really likes those for config files | 21:10 |
clarkb | but also enjoy your weekend. I think everything is mostly happy at this point. I ran down the diff thing and got that into shape. fungi updated All-Projects. Gerrit seems happy. static02 is half into production now too tldr no reason to interrupt your weekend | 21:11 |
clarkb | oh someone else noted that they have observed similar with replication. Hoepfully we can run it down together. But they are enjoying the holiday weekend so won't get to it any quciker than we will | 21:12 |
ianw | yep and i saw that the replication issue was half-known about | 21:12 |
ianw | heh, yeah :) | 21:12 |
ianw | ++ thanks! this was certainly an interesting upgrade cycle :) | 21:13 |
clarkb | and thank you. I think that went reall well at the end of the day. We kept the outage period within the block we notified about. No accidental project (re)creations and everything that did go unexpected has been minor | 21:15 |
clarkb | I'm noticing all the little UI updates in gerrit and I feel like for once I have yet to find one I don't like. The submit requirements view conditions expander now shows you how each individual condition evaluates | 23:32 |
clarkb | and bulk topic updates are going to be great | 23:32 |
opendevreview | Merged openstack/project-config master: Deploy gating.dev DNS changes https://review.opendev.org/c/openstack/project-config/+/879910 | 23:32 |
fungi | i'm still not convinced the labels are being cleared correctly. looking at 879906 when i pushed a revision which just altered the commit message, gerrit added a note that says "outdated votes: verified+1" | 23:34 |
fungi | does that mean it was cleared by the upload, or carried over? | 23:34 |
clarkb | I believe cleared | 23:36 |
clarkb | its letting you know the vote was outdated and not applicable to the new patchset | 23:36 |
clarkb | but you'd have to catch it between when zuul applies its latest CI run to be sure. I am prett sure I checked on one of my patchset updates earlier today though | 23:36 |
fungi | if so, then cool. just sort of vaguely communicated in the comment it added | 23:36 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!