| opendevreview | Jeremy Stanley proposed openstack/project-config master: Add a convenient normalize-gerrit-acl tox testenv https://review.opendev.org/c/openstack/project-config/+/882750 | 00:29 |
|---|---|---|
| *** amoralej|off is now known as amoralej | 07:21 | |
| *** Guest924 is now known as diablo_rojo_phone | 08:11 | |
| *** amoralej is now known as amoralej|lunch | 10:56 | |
| *** amoralej|lunch is now known as amoralej | 12:39 | |
| *** iurygregory_ is now known as iurygregory | 14:25 | |
| clarkb | I've gone ahead and approved the three changes related to and including ^ | 15:11 |
| clarkb | corvus: ianw fwiw after sleeping on it I think I like the consistency of https://review.opendev.org/c/zuul/zuul-jobs/+/882724 for users. It makes things slightly more complicated on the zuul setup side, but I think having consistent jobs for users ends up being simpler for them | 15:12 |
| corvus | ++ | 15:14 |
| clarkb | corvus: it does need rereview if we want to proceed in that direction (sounds like we do) | 15:23 |
| opendevreview | Merged openstack/project-config master: Add an "apply" transformation which applies all https://review.opendev.org/c/openstack/project-config/+/882075 | 15:24 |
| opendevreview | Merged openstack/project-config master: Add a convenient normalize-gerrit-acl tox testenv https://review.opendev.org/c/openstack/project-config/+/882750 | 15:25 |
| opendevreview | Merged openstack/project-config master: Make option indenting a selectable transformation https://review.opendev.org/c/openstack/project-config/+/882080 | 15:25 |
| *** gthiemon1e is now known as gthiemonge | 15:55 | |
| clarkb | fungi: did you want to weigh in on https://review.opendev.org/c/zuul/zuul-jobs/+/882724 vs https://review.opendev.org/c/opendev/system-config/+/882628 before we land one? I think corvus and I are heavily leaning to 882724 and ianw is +2 on that change now as well | 16:18 |
| fungi | i can, but not until later today | 16:22 |
| corvus | +2 from me | 16:26 |
| fungi | without paying attention to which one was preferred by whom, i also liked the effect of 882724 making the behavior toggleable through a var, defaulting to the old workflow | 19:51 |
| fungi | and the fact that it finished implementation which was missing but documented in the playbook | 19:51 |
| fungi | +2'd but did not approve since i've got other things going on and won't be able to devote much attention if it causes unforeseen problems (though it shouldn't since the default behavior looks to be preserved) | 19:53 |
| clarkb | thanks I'm going to approve it now and once it lands I'll also approve the grafyaml updates which should exercise it | 19:58 |
| fungi | sgtm | 19:58 |
| clarkb | corvus: once that lands you may want to approve one or more of the zuul/* base python image updates as well as those should be a good sanity check too | 20:05 |
| opendevreview | Merged zuul/zuul-jobs master: Gracefully handle use of intermediate registry in container upload role https://review.opendev.org/c/zuul/zuul-jobs/+/882724 | 20:11 |
| clarkb | grafyaml change is approved | 20:12 |
| opendevreview | Merged opendev/grafyaml master: Migrate grafyaml container images to quay.io https://review.opendev.org/c/opendev/grafyaml/+/882493 | 20:17 |
| clarkb | https://quay.io/repository/opendevorg/grafyaml?tab=tags looks good to me so I Think this is working | 20:20 |
| opendevreview | Clark Boylan proposed opendev/grafyaml master: Fix up tag release container build jobs https://review.opendev.org/c/opendev/grafyaml/+/882894 | 20:25 |
| clarkb | everything seems to have worked but I noticed ^ was missed | 20:25 |
| clarkb | I don't think anything else has had a similar miss so far | 20:26 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Pull grafyaml from quay.io https://review.opendev.org/c/opendev/system-config/+/882573 | 20:27 |
| clarkb | fungi: ^ that is a minor typo fix if you have time for a quick rereview | 20:27 |
| clarkb | I'm going to look at cleaning up the change tags for things that have migrated now | 20:30 |
| clarkb | for example on https://quay.io/repository/opendevorg/zookeeper-statsd?tab=tags all the change tags should be removed | 20:32 |
| clarkb | that seemed easy enough. I just need to make a list and go through them all | 20:33 |
| clarkb | and that should now be done for all of the images that have been pushed so far | 20:40 |
| clarkb | I'm going to proceed with lodgeit now. Then after that is etherpad, refstack, hound | 20:43 |
| opendevreview | Merged openstack/project-config master: Pull grafyaml from quay.io https://review.opendev.org/c/openstack/project-config/+/882576 | 20:48 |
| corvus | clarkb: you ready for https://review.opendev.org/882468 ? | 20:51 |
| clarkb | corvus: yes I think all of those changes on the zuul side are good to go | 20:52 |
| clarkb | the base images are on quay now and the fix we just landed for change tags appears to be working so I think we're rolling forward now | 20:52 |
| corvus | cool, i'll approve the whole set then | 20:53 |
| clarkb | corvus: on the opendev side I'm finishing up grafyaml and moving on to lodgeit. Then will approve the chnage that updates etherpad, hound, and refstack | 20:54 |
| clarkb | once those are all done I need to go and write more changes and gitea, gerrit, mailman3 will be next up | 20:54 |
| opendevreview | Merged opendev/lodgeit master: Move lodgeit image publication to quay.io https://review.opendev.org/c/opendev/lodgeit/+/882590 | 21:01 |
| clarkb | lodgeit promotion failed. I'll take a look at that momentarily | 21:10 |
| opendevreview | Clark Boylan proposed opendev/lodgeit master: Fix quay publishing https://review.opendev.org/c/opendev/lodgeit/+/882896 | 21:12 |
| clarkb | argh I knew I needed to fix all of these and thought I had. Will try to be extra careful and check for that now | 21:12 |
| clarkb | anyway 882896 now needed | 21:13 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Migrate jinja-init to quay.io https://review.opendev.org/c/opendev/system-config/+/882897 | 21:17 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Migrate gitea images to quay.io https://review.opendev.org/c/opendev/system-config/+/882898 | 21:17 |
| clarkb | these last two can be ignored for now. I won't get to them until tomorrow but I wanted a headstart on the conversion because we do things like buildkit | 21:18 |
| clarkb | changes that need reviews today are https://review.opendev.org/c/opendev/grafyaml/+/882894 and https://review.opendev.org/c/opendev/lodgeit/+/882896?usp=dashboard | 21:19 |
| corvus | clarkb: i should be able to manually delete quay tags now right? | 21:20 |
| clarkb | corvus: yes I believe so. I already did so for images under opendevorg/ | 21:21 |
| corvus | i will do so for zuul now | 21:21 |
| clarkb | corvus: you can select them in the web ui using check boxes then there is an action drop down to select delete tags. It gives you a little summar of what it will delete and you hit go | 21:21 |
| corvus | yeah, and i think you can filter for "change" and then hit the select-all checkbox | 21:22 |
| corvus | okiedokie all done | 21:26 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Migrate gerrit images to quay.io https://review.opendev.org/c/opendev/system-config/+/882900 | 21:38 |
| clarkb | is anyone able to review 882894 and 882896? Would be good to have both grafyaml and lodgeit completely marked off so I can focus on other things :) | 21:41 |
| fungi | i can in a sec | 21:44 |
| fungi | i approved both of those | 21:48 |
| clarkb | thanks! | 21:49 |
| opendevreview | Merged opendev/system-config master: Pull grafyaml from quay.io https://review.opendev.org/c/opendev/system-config/+/882573 | 21:57 |
| opendevreview | Merged opendev/grafyaml master: Fix up tag release container build jobs https://review.opendev.org/c/opendev/grafyaml/+/882894 | 21:58 |
| opendevreview | Merged opendev/lodgeit master: Fix quay publishing https://review.opendev.org/c/opendev/lodgeit/+/882896 | 22:00 |
| clarkb | That worked ^ I've approved the change to pull lodgeit from the new location | 22:04 |
| clarkb | our complicated gerrit stuff isn't working with a naive translation of container build jobs | 22:08 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Migrate gerrit images to quay.io https://review.opendev.org/c/opendev/system-config/+/882900 | 22:16 |
| clarkb | ok I think maybe that will fix the issue I just saw | 22:16 |
| opendevreview | Merged opendev/system-config master: Pull lodgeit from quay.io https://review.opendev.org/c/opendev/system-config/+/882593 | 22:30 |
| clarkb | https://paste.opendev.org/show/bR2Sfa32BYrlt055I2eG/ new lodgeit image seems to work | 22:33 |
| clarkb | everything in the quay eitherpad up to line 72 should be done now | 22:35 |
| clarkb | gerrit and gitea images appear to be building in the proposed changes too | 22:35 |
| fungi | the zuul change hit unit test failures in the gate | 23:28 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Migrate gerrit images to quay.io https://review.opendev.org/c/opendev/system-config/+/882900 | 23:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!