*** dasm is now known as Guest1011 | 04:31 | |
*** Guest1011 is now known as dasm | 04:31 | |
opendevreview | Merged openstack/project-config master: Update acl for retiring TripleO projects https://review.opendev.org/c/openstack/project-config/+/910103 | 06:36 |
---|---|---|
*** tosky_ is now known as tosky | 09:40 | |
opendevreview | Aleksei Stepanov proposed ttygroup/gertty master: Drop prehistoric hack for urwid.GridFlow https://review.opendev.org/c/ttygroup/gertty/+/910173 | 10:04 |
opendevreview | Sven Kieske proposed openstack/project-config master: enforce BackportCandidate voting for kolla https://review.opendev.org/c/openstack/project-config/+/910212 | 11:03 |
opendevreview | Alfredo Moralejo proposed opendev/system-config master: Exclude CentOS automotive SIGs repos from mirror synchronization https://review.opendev.org/c/opendev/system-config/+/910228 | 12:45 |
amoralej | apevec, tonyb ^ | 12:46 |
corvus | frickler: i believe the issue with the recheck of the change that depends on a patch series has been fixed. | 15:41 |
opendevreview | Michal Nasiadka proposed openstack/project-config master: Add magnum-capi-helm repo to Magnum project https://review.opendev.org/c/openstack/project-config/+/910239 | 15:53 |
opendevreview | Michal Nasiadka proposed openstack/project-config master: Add magnum-capi-helm repo to Magnum project https://review.opendev.org/c/openstack/project-config/+/910239 | 16:17 |
frickler | corvus: thx, I'll need to check whether my example is still in place | 16:18 |
frickler | config-core: please check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/909308 amd the dep | 16:18 |
opendevreview | Clark Boylan proposed opendev/system-config master: Update gerrit image to 3.8.4 https://review.opendev.org/c/opendev/system-config/+/907478 | 16:18 |
opendevreview | Clark Boylan proposed opendev/system-config master: Upgrade gitea to 1.21.7 https://review.opendev.org/c/opendev/system-config/+/909941 | 16:21 |
clarkb | frickler: ianychoi is the weblate stuff far enough along we can skip zanata here? | 16:22 |
clarkb | It seems like a step backwards to keep adding projects to zanata if the weblate work is in progress | 16:22 |
clarkb | upstream openafs folks have a reproducer of the arm problem in a mimimal C snippet so I've gone ahead and deleted my held nodes as they no longer seem useful to debugging this issue | 16:25 |
opendevreview | John Garbutt proposed openstack/project-config master: Add magnum-capi-helm repo to Magnum project https://review.opendev.org/c/openstack/project-config/+/910239 | 16:26 |
frickler | clarkb: IMO ianychoi is the person to know best how far the transition is, so proposing this to me says that it still makes sense | 16:34 |
opendevreview | Merged opendev/system-config master: Replace buster with bookworm in role integration testing https://review.opendev.org/c/opendev/system-config/+/909787 | 16:46 |
opendevreview | Michal Nasiadka proposed openstack/project-config master: Add magnum-capi-helm repo to Magnum project https://review.opendev.org/c/openstack/project-config/+/910239 | 16:47 |
opendevreview | Edward Hope-Morley proposed openstack/project-config master: Add ovn charms to charms-stable-maint purview https://review.opendev.org/c/openstack/project-config/+/909445 | 16:48 |
opendevreview | Merged openstack/project-config master: Set debian-buster min servers to 0 https://review.opendev.org/c/openstack/project-config/+/910012 | 16:52 |
opendevreview | Sven Kieske proposed openstack/project-config master: enforce BackportCandidate voting for kolla https://review.opendev.org/c/openstack/project-config/+/910212 | 17:19 |
clarkb | gitea 1.21.6 actually changes how the jwt secret keys for lfs and oauth2 are handled | 17:30 |
clarkb | It looks like they may have done so in a backward compatible manner, but it isn't clear to me yet | 17:30 |
clarkb | maybe this is just a code refactor but the config options remain the same? | 17:32 |
opendevreview | James E. Blair proposed zuul/zuul-jobs master: prepare-workspace-git: Add ability to define synced pojects https://review.opendev.org/c/zuul/zuul-jobs/+/887917 | 17:34 |
clarkb | fungi: the gerrit 3.8.4 system-config-run job finished if you want to check those screenshots too (I think your +2 predated the job completion) | 18:16 |
fungi | i was less concerned about that since we don't override its ui templating | 18:19 |
fungi | but sure | 18:19 |
clarkb | ah got it | 18:19 |
clarkb | my main concern here is the big mina update | 18:19 |
clarkb | but I think we have ssh interaction with the gerrit server in that test job | 18:20 |
clarkb | so we're probably well covered | 18:20 |
fungi | right, i mainly rely on the current regression testing to tell us whether things are generally working | 18:21 |
fungi | but for things like new features we don't want quietly being added to the gitea webui, testing alone doesn't catch that | 18:22 |
clarkb | does anyone else want to review the gerrit 3.8.4 upgrade chagne? https://review.opendev.org/c/opendev/system-config/+/907478 if not maybe we should approve that then plan to restart gerrit later today as things quiet down | 18:53 |
opendevreview | James E. Blair proposed zuul/zuul-jobs master: prepare-workspace-git: Add ability to define synced pojects https://review.opendev.org/c/zuul/zuul-jobs/+/887917 | 18:54 |
opendevreview | Aleksei Stepanov proposed ttygroup/gertty master: Fix urwid > 2.4.2 compatibility https://review.opendev.org/c/ttygroup/gertty/+/910265 | 19:50 |
opendevreview | James E. Blair proposed zuul/zuul-jobs master: prepare-workspace-git: Add ability to define synced pojects https://review.opendev.org/c/zuul/zuul-jobs/+/887917 | 19:57 |
opendevreview | Ghanshyam proposed openstack/project-config master: Retire OpenStack-Chef: remove project from infra https://review.opendev.org/c/openstack/project-config/+/910100 | 20:05 |
opendevreview | Jeremy Stanley proposed opendev/git-review master: Don't make hook script read-only https://review.opendev.org/c/opendev/git-review/+/910268 | 20:13 |
opendevreview | Ghanshyam proposed openstack/project-config master: Retire TripleO: remove project from infra https://review.opendev.org/c/openstack/project-config/+/910270 | 20:28 |
opendevreview | Aleksei Stepanov proposed ttygroup/gertty master: Fix urwid > 2.4.2 compatibility https://review.opendev.org/c/ttygroup/gertty/+/910265 | 20:32 |
opendevreview | Jeremy Stanley proposed opendev/git-review master: Don't make hook script read-only https://review.opendev.org/c/opendev/git-review/+/910268 | 20:50 |
fungi | prometheanfire: 910265 looks like confirmation you're not the only one who ran into it | 20:51 |
opendevreview | Jeremy Stanley proposed opendev/git-review master: Vendor a copy of Gerrit's commit-msg Git hook https://review.opendev.org/c/opendev/git-review/+/910275 | 21:06 |
clarkb | the gerrit upgrade has two +2s so I went ahead and approved it | 21:08 |
clarkb | fungi: any chance you'll be around later today when that merges for a gerrit restart? | 21:08 |
clarkb | (I can do the restarting just hoping I won't be alone) | 21:08 |
fungi | yep, i'll be here | 21:08 |
clarkb | unless you want to do it :) the only thing to remember is moving aside the replication queue dir if possible | 21:09 |
fungi | i'm still thinking a bit slowly today, but can do the restart if you prefer | 21:09 |
clarkb | nah its fine I intended on doing it. Just wasn't sure if there was interest elsewhere | 21:10 |
clarkb | and then maybe tomorrow we upgrade gitea | 21:11 |
fungi | sounds good to me | 21:11 |
prometheanfire | fungi: it's the guy I reported it to upstream :P | 21:13 |
fungi | aha, i take that to indicate he disagreed it was a regression in that case | 21:15 |
fungi | and/or that the library doesn't attempt to maintain much backward-compatibility | 21:16 |
opendevreview | James E. Blair proposed zuul/zuul-jobs master: prepare-workspace-git: Add ability to define synced pojects https://review.opendev.org/c/zuul/zuul-jobs/+/887917 | 21:20 |
opendevreview | Jeremy Stanley proposed opendev/git-review master: Vendor a copy of Gerrit's commit-msg Git hook https://review.opendev.org/c/opendev/git-review/+/910275 | 21:24 |
prometheanfire | fungi: doesnt look like a full fix https://gist.github.com/prometheanfire/9c6be17be0f6118740198f86b8d238a2 | 21:27 |
prometheanfire | fungi: or both | 21:28 |
clarkb | I've just updated the meeting agenda with the stuff I know I've got floating around. fungi do you think the git-review vendored commit hook should go on the agenda? | 21:51 |
fungi | clarkb: it can't hurt. it's ready for review i think | 22:13 |
clarkb | added | 22:14 |
clarkb | The gerrit change should be merging soon | 22:14 |
fungi | i'll also be eating dinner soon, but can certainly multi-task | 22:15 |
clarkb | The process for restarting is a docker-compose pull, docker-compose down, mv aside the waiting/ queue dir, docker-compose up -d | 22:15 |
opendevreview | Merged opendev/system-config master: Update gerrit image to 3.8.4 https://review.opendev.org/c/opendev/system-config/+/907478 | 22:15 |
clarkb | any concerns with that rough process? | 22:15 |
fungi | that sounds like what we've done previously (when we don't forget the mv) | 22:15 |
clarkb | I'll wait for the deploy jobs to complete (need the promote to finish at the very least) and then I'll ssh in and get ready to do the upgrade | 22:17 |
clarkb | we can do something like this too #status notice Gerrit on review.opendev.org will be restarted to perform a minor upgrade to the service. | 22:18 |
clarkb | ok the jobs appear all done. i'll do the pull now and check the image looks good then we can send that notice and proceed | 22:23 |
clarkb | https://hub.docker.com/layers/opendevorg/gerrit/3.8/images/sha256-946b5b13feb86fa1e3d0f1beb8b66844f8481fd8500607c8a92c579793705d43?context=explore seems to match "opendevorg/gerrit@sha256:946b5b13feb86fa1e3d0f1beb8b66844f8481fd8500607c8a92c579793705d43" from docker inspect against the new image on review02 | 22:26 |
clarkb | fungi: does that #status notice look ok to you? | 22:26 |
fungi | clarkb: sorry, which status notice? | 22:27 |
clarkb | this one #status notice Gerrit on review.opendev.org will be restarted to perform a minor upgrade to the service. | 22:27 |
clarkb | I'm read to start that if you are | 22:28 |
fungi | oh, now i see where you said it earlier, sorry, skimming too quickly | 22:28 |
fungi | yes that works | 22:28 |
clarkb | ok I'll send that now and when it completes I will proceed with the gerrit update | 22:28 |
clarkb | #status notice Gerrit on review.opendev.org will be restarted to perform a minor upgrade to the service. | 22:28 |
clarkb | hrm no statusbot | 22:29 |
opendevreview | Merged opendev/system-config master: Exclude CentOS automotive SIGs repos from mirror synchronization https://review.opendev.org/c/opendev/system-config/+/910228 | 22:29 |
clarkb | I'll restart statusbot | 22:29 |
clarkb | #status notice Gerrit on review.opendev.org will be restarted to perform a minor upgrade to the service. | 22:30 |
clarkb | oh it is still slowly joining channels first | 22:31 |
opendevstatus | clarkb: sending notice | 22:32 |
-opendevstatus- NOTICE: Gerrit on review.opendev.org will be restarted to perform a minor upgrade to the service. | 22:32 | |
opendevstatus | clarkb: finished sending notice | 22:35 |
clarkb | ok I'm proceedign now | 22:35 |
fungi | sounds good, i'm here | 22:35 |
clarkb | [main] INFO com.google.gerrit.pgm.Daemon : Gerrit Code Review 3.8.4-1-gcffab29322-dirty ready | 22:37 |
fungi | yep, looks right to me | 22:37 |
fungi | Powered by Gerrit Code Review (3.8.4-1-gcffab29322-dirty) | 22:37 |
fungi | webui is up again | 22:37 |
clarkb | I'm experiencing the "diffs aren't quite loaded yet" problem but otherwise web ui is working for me | 22:37 |
clarkb | I expect diffs to be available shortly (this seems to be a cold cache on startup problem) | 22:38 |
clarkb | yup I have diffs now so it only lasts for a few minutes | 22:38 |
clarkb | TheJulia: FYI ^ gerrit has been updated | 22:38 |
fungi | thanks clarkb! | 22:38 |
fungi | i should continue to be around some this evening in case anyone spots any odd issues with it (not that we expect any) | 22:39 |
clarkb | using the ssh gerrit ls-project command succeeds for me | 22:40 |
clarkb | I jsut wanted to do a simple ssh test since that was the major change in this udpate | 22:40 |
clarkb | I don't think any code has been pushed yet | 22:41 |
* clarkb finds something to push | 22:41 | |
opendevreview | Clark Boylan proposed opendev/bindep master: Drop centos-7 and ubuntu-xenial testing https://review.opendev.org/c/opendev/bindep/+/910281 | 22:42 |
clarkb | that seems to work too | 22:42 |
opendevreview | Clark Boylan proposed opendev/bindep master: Add centos-9-stream and ubuntu-jammy functional testing https://review.opendev.org/c/opendev/bindep/+/910282 | 22:44 |
clarkb | I suspect they are both approvable too if you want to give them a quick review. We should be able tosee zuul do a full round trip on those changes | 22:45 |
fungi | can do | 22:57 |
fungi | yep, both lgtm | 22:58 |
zigo | Why "-dirty" ? :) | 22:58 |
fungi | zigo: because we build our own images rather than using gerrit upstream's "clean" release images | 22:58 |
clarkb | but there are no local changes. The hash in the version should be in the upstream tree | 22:59 |
zigo | Ok. | 22:59 |
fungi | it's so that we can backport fixes for immediate relief in cases where getting things merged in the upstream gerrit project is taking time | 22:59 |
clarkb | oh it looks like it may be because we copy things into the git repo to build it | 23:00 |
clarkb | which is a side effect of needing to build it though so not sure how upstream gets rid of the -dirty | 23:00 |
clarkb | meh not a big deal and the entire build process is auditable too | 23:01 |
opendevreview | Merged opendev/bindep master: Drop centos-7 and ubuntu-xenial testing https://review.opendev.org/c/opendev/bindep/+/910281 | 23:06 |
clarkb | https://opendev.org/opendev/system-config/src/branch/master/playbooks/zuul/gerrit/repos.yaml#L56-L63 this is (at least one reason) why we get a dirty version | 23:10 |
fungi | aha, we add core plugins | 23:11 |
opendevreview | Merged opendev/bindep master: Add centos-9-stream and ubuntu-jammy functional testing https://review.opendev.org/c/opendev/bindep/+/910282 | 23:12 |
clarkb | not a reason why we get the -dirty flag but a weird thing is we build the base gerrit container image against jeepyb | 23:12 |
clarkb | ebcause we want jeepyb to be installed. Then we do the version specific gerrit container images that copy the correct war into the final image location | 23:13 |
clarkb | that could probably use a refactor but it works so I guess its fine | 23:13 |
clarkb | I think refactoring this would look something like installing jeepyb from pypi instead of local disk location with the docker build. I think we can still use the assembly script in our python base/build images for that | 23:15 |
clarkb | but would make this perhaps a little less roundabout and awkward | 23:15 |
ianychoi | seongsoocho: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/909308 is pending due to dependency check - how long do you think if we test with governance repo doc translation with Weblate instead of Zanata? I initially think that just adding governance doc target on Zanata is easy but according to clarkb, dep check needs some step backwards | 23:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!