| *** ykarel_ is now known as ykarel | 14:33 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: Handle borg 1.2 rc 1 for warnings behavior https://review.opendev.org/c/opendev/system-config/+/939667 | 16:09 |
|---|---|---|
| clarkb | that updated the conditional to be a little less version specific. It isn't perfect and i'm open to suggestions on how to do that better without adding dependencies or making it super complicated | 16:10 |
| fungi | clarkb: question there, i don't think < does what you want | 16:16 |
| clarkb | fungi: yes that is why i isn't perfect. But the newest version we have deployed is 1.2.8 | 16:16 |
| clarkb | I don't want to worry about oldest versions so < addresses those | 16:17 |
| clarkb | there is no 1.2.10 or 1.2.11 but there may be 1.1.8 and 1.1.18 | 16:17 |
| fungi | i'm more worried about future versions | 16:17 |
| clarkb | fungi: maybe just check against 1.2? | 16:18 |
| fungi | or != the old version(s) | 16:18 |
| fungi | since we theoretically know which ones we have in use | 16:18 |
| clarkb | I think not less than 1.2 should work actually | 16:18 |
| clarkb | until version 1.10 (which won't exist because they are going to 2.0 | 16:19 |
| fungi | yeah, at least until upstream gets to 1.10.x versions, which will likely take a while | 16:19 |
| fungi | or forever ;) | 16:19 |
| clarkb | ya they went 1.0 -> 1.1 -> 1.2 -> 1.4 -> 2.0 | 16:19 |
| clarkb | so I think checking against 1.2 should be sufficient | 16:20 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Handle borg 1.2 rc 1 for warnings behavior https://review.opendev.org/c/opendev/system-config/+/939667 | 16:20 |
| clarkb | also if we get it wrong it shouldn't break the actual backups just our reporting of them | 16:22 |
| clarkb | side note: its interesting that help test doesn't say anything about escaping < and > when using them as operators. I guess that is implied | 16:26 |
| fungi | if you use [[ ]] in a quoted string as a parameter to bash -c, it's not necessary | 16:29 |
| fungi | $ bash -c "[[ foo < xyzzy ]]" && echo true || echo false | 16:32 |
| fungi | true | 16:32 |
| fungi | $ bash -c "[[ foo < bar ]]" && echo true || echo false | 16:32 |
| clarkb | ya I guess beacuse [/test may not be a builtin but an actual command you need to escape things for compatibility | 16:32 |
| fungi | false | 16:32 |
| clarkb | whereas [[ is always a builtin so the shell can do magic | 16:32 |
| fungi | right | 16:32 |
| clarkb | oh and test(1) doesn't do < and > that is a bashism in the builtin | 16:34 |
| clarkb | we explicitly use bash in the shebang so not a problem here | 16:34 |
| *** eandersson0 is now known as eandersson | 17:51 | |
| tonyb | Finally caught up on my IRC backlog. I'm sorry I didn't see the pings WRT the Noble image on RAX, it is identical to others just converted for RAX. | 20:15 |
| tonyb | The reason it wasn't declared as done/blessed was I couldn't get SSH working, but you figured that out and it wasn't a problem with the image. | 20:16 |
| tonyb | I ran the image_upload ansible play with `/usr/ansible-venv/bin/ansible-playbook /home/tonyb/image_upload.yaml` as root | 20:19 |
| tonyb | If you look at root's history on bridge (from around 2024-07-26 and 2024-07-31) you'll see most of the testing I did | 20:20 |
| tonyb | ... but now I see you found all that | 20:22 |
| clarkb | tonyb: image list never showed the image though. Did you delete it? | 20:29 |
| clarkb | I'm mostly interested in knowing as a way of knowing if the ansible module is capable of uploading to rax | 20:29 |
| tonyb | I'm trying to verify that I did delete it but I'm 90% sure I used that ansible play to upload it originally | 20:30 |
| tonyb | I can't see the evidence, but I'm also reasonably sure I did delete the image via the Web UI. I remember talking to support at the time (hence the edit-secrets in history) and when I couldn't get ssh working I deleted the image as I was expecting that I needed to change it to get networking. | 20:35 |
| fungi | deleting through the web dashboard would explain the lack of evidence in bash history | 20:35 |
| tonyb | Yeah, poor choice that with hindsight I won't repeat | 20:36 |
| clarkb | ya that may be the missing peice of info | 20:36 |
| tonyb | Also I'm sorry for not seeing the pings, seems my IRC client logged out on my phone and "no notifications" != "no one is pinging" :/ | 20:38 |
| clarkb | nah you were on vacation and we made some educated guesses | 20:38 |
| clarkb | tonyb: now that you are back though it might be a good idea to clean up the non qcow2 version of that image to free the disk space ? | 20:39 |
| tonyb | Yup I think we can remove them all | 20:39 |
| tonyb | Or do we need to upload the vhd to other rax regions? | 20:39 |
| clarkb | tonyb: I uploaded to dfw, iad, and ord. But you can double check if you like first | 20:40 |
| clarkb | I don't think I test booted in each region | 20:40 |
| clarkb | I think I test booted in iad and dfw but not ord (because ord's api is slowest) | 20:40 |
| tonyb | Noted. | 20:40 |
| tonyb | I'll handle the clean up | 20:41 |
| clarkb | tonyb: if you have time for https://review.opendev.org/c/opendev/system-config/+/939667 this should make the paste02 backups less noisy. | 23:03 |
| clarkb | fungi: I reviewed the PBR changes and approved the first. The second needs another reviewer | 23:03 |
| clarkb | I need a break after the meetup block but will get the email out making service coordinator election details official afterwards | 23:03 |
| clarkb | https://lists.opendev.org/archives/list/service-discuss@lists.opendev.org/thread/NGS2APEFQB45OCJCQ645P5N6XCH52BXW/ made the election details official | 23:29 |
| fungi | thanks! | 23:34 |
| clarkb | I think I just found a bug in the brog backup script change | 23:38 |
| clarkb | I'm going to WIP it while I fix it | 23:38 |
| fungi | k | 23:39 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Handle borg 1.2 rc 1 for warnings behavior https://review.opendev.org/c/opendev/system-config/+/939667 | 23:41 |
| clarkb | I needed to default stream_exit to 0 as we may not have any streams to backup but we use the value later to determine the final rc value. Also we can't reset stream-exit to 0 if a stream succeeds after a stream fails | 23:41 |
| clarkb | so basically just preset the value to success and then only set it to failure later so that we preserve the failure value if some streams succeed | 23:42 |
| clarkb | oh wow I just got teh -W in in time to prevent merging. Nice | 23:46 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Reapply "Pull lodgeit from quay.io" https://review.opendev.org/c/opendev/system-config/+/939767 | 23:49 |
| tonyb | ^^ and the dependent patch look good to me. I haven't +A'd https://review.opendev.org/c/opendev/lodgeit/+/939385 just in case | 23:57 |
| Clark[m] | Ack I can deploy them tomorrow morning and check the jobs for what we expect | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!