| opendevreview | OpenStack Proposal Bot proposed openstack/project-config master: Normalize projects.yaml https://review.opendev.org/c/openstack/project-config/+/952006 | 02:39 |
|---|---|---|
| frickler | infra-root: I did some local testing, seems ^^ is triggered by ruamel.yaml==0.18.13 which was released 5 days ago, matching when this change was first created. https://sourceforge.net/p/ruamel-yaml/tickets/546/ looks related. I guess we could probably pin that lib for now? | 05:38 |
| opendevreview | Dr. Jens Harbott proposed openstack/project-config master: Block broken ruamel.yaml versions https://review.opendev.org/c/openstack/project-config/+/952315 | 05:46 |
| ianw | oh interesting i had problem too with https://sourceforge.net/p/ruamel-yaml/tickets/545/ in ansible-lint | 06:23 |
| ianw | the comment there was "If you want to preserve multiline strings. I recommend defining them als literal style scalars before dumping." (https://sourceforge.net/p/ruamel-yaml/tickets/545/#70fd) | 06:25 |
| ianw | i wonder if for ongoing sanity we should update that to be like | 06:26 |
| ianw | description: > | 06:27 |
| ianw | ... | 06:27 |
| opendevreview | Dr. Jens Harbott proposed openstack/project-config master: Normalize projects.yaml https://review.opendev.org/c/openstack/project-config/+/952006 | 06:50 |
| frickler | ianw: nice idea, that would result in ^^ with only three trailing spaces that ruamel thinks need to be inserted, which likely might match be bug I cited | 06:50 |
| ianw | cool; no dispute to the letter of YAML the original is valid, but ... well, there's a lot of flexibility in yaml, to say the least :) | 06:52 |
| ianw | every week I take my kid to his music lesson and it's next to this motorcycle shop, and they have a truck with a giant YAMALUBE sign on it (it's oil for Yamaha bikes). It always makes me do a double take ... maybe we just need a bit of yamllube to keep this working smoothly ;) | 06:55 |
| frickler | lol | 07:08 |
| opendevreview | Tony Breeds proposed openstack/diskimage-builder master: Add new openstack/devstack based functional testing https://review.opendev.org/c/openstack/diskimage-builder/+/949942 | 08:43 |
| frickler | I wonder if this is still valid, would mess up the above solution "# newlines here mess up cgit "repo.desc" https://opendev.org/openstack/project-config/src/branch/master/tools/check_valid_gerrit_projects.py#L205 | 11:18 |
| fungi | probably not since we dropped the cgit code browser webui in favor of gitea many years ago now | 12:28 |
| fungi | if it matters, the gitea equivalent happens in https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/gitea-git-repos/library/gitea_create_repos.py now (not jeepyb) | 12:40 |
| opendevreview | Michal Nasiadka proposed openstack/diskimage-builder master: Add new openstack/devstack based functional testing https://review.opendev.org/c/openstack/diskimage-builder/+/949942 | 13:38 |
| frickler | that sounds like we would want to have a sanity check on a maximum description length of 255c maybe? how difficult would it be to test this on a held gitea (+ maybe gerrit) deployment? | 13:41 |
| Clark[m] | Shouldn't be difficult since we run that tooling against the test gitea with our actual project list already. We only populate the system-config repo in gitea but that shouldn't matter for repo descriptions. Just do a depends on I think | 13:45 |
| fungi | yeah, easy i think would be to change the system-config description in a dnm project-config change, then check the screenshots and test results? | 14:25 |
| opendevreview | Michal Nasiadka proposed openstack/diskimage-builder master: Add new openstack/devstack based functional testing https://review.opendev.org/c/openstack/diskimage-builder/+/949942 | 14:42 |
| Clark[m] | fungi: yup exactly | 15:02 |
| Clark[m] | mnasiadka: tonyb: looking at 949942 it appears we still need a way to set the CPU type for CentOS 10 builds. Do we want to convert all existing jobs then let the CentOS 10 change do that? | 15:20 |
| Clark[m] | Also I think we can probably optimize the service list if we want to (dropping swift for example) which may make things run slightly quicker | 15:21 |
| mnasiadka | Clark[m]: I think for now tonyb (with my minimal help) is trying to get that working - but I assume setting a nodeset for specific jobs should work (for now it's inherited from the devstack base job from what I see) | 15:31 |
| mnasiadka | but yes, we should rework everything in that patch, and then adapt CentOS 10 DIB change to do that properly | 15:32 |
| Clark[m] | I think devstack also needs to be configured to use host pass through | 15:32 |
| mnasiadka | right | 15:35 |
| mnasiadka | for now it seems even though the approach uses public network, the instance is unreachable - getting some console logs could help | 15:35 |
| opendevreview | Michal Nasiadka proposed openstack/diskimage-builder master: Add new openstack/devstack based functional testing https://review.opendev.org/c/openstack/diskimage-builder/+/949942 | 15:38 |
| clarkb | mnasiadka: made a note about one more small thing I noticed | 16:15 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Update to Gitea 1.24.0 https://review.opendev.org/c/opendev/system-config/+/948560 | 16:44 |
| clarkb | fungi: ^ there were some minor updates to the gitea home.tmpl in 1.24.0, but looking at the way we override thigns I don't think we need to port them over | 16:59 |
| clarkb | our home.tmpl is sufficiently different that as long as the page renders for us in testing I think we're good | 16:59 |
| fungi | awesome! i'll try to take a look in a bit | 17:00 |
| opendevreview | Michal Nasiadka proposed openstack/diskimage-builder master: Add new openstack/devstack based functional testing https://review.opendev.org/c/openstack/diskimage-builder/+/949942 | 17:42 |
| clarkb | https://review.opendev.org/c/opendev/system-config/+/948560 passes testing and I don't see anything immediately wrong with the screenshots. I do think that we should probably udpate the content first before upgrading though | 18:06 |
| fungi | yeah, screenshots look correct, including the md rendering of the system-config readme | 18:27 |
| fungi | content update is fine to go in whenever, mainly holding off because frickler wanted to look through it still | 18:27 |
| frickler | sorry, I still didn't get to it, so just go ahead, we can always update if needed | 18:37 |
| fungi | no worries, and yeah happy to review any follow-up changes you'd like to make to the content as well, of course! | 18:39 |
| fungi | i've approved the infra-manual addition of the faq chapter, and once that merges i'll approve the change to remove the duplicate content from the main page in gitea and reword/reorganize what remains | 18:40 |
| opendevreview | Merged opendev/infra-manual master: Add frequently asked questions https://review.opendev.org/c/opendev/infra-manual/+/949924 | 18:42 |
| fungi | fingers crossed dockerhub is feeling gracious today | 18:43 |
| opendevreview | Merged openstack/project-config master: Add missing ACL inheritance for openstack/grian-ui https://review.opendev.org/c/openstack/project-config/+/951010 | 19:05 |
| opendevreview | Merged openstack/project-config master: Revert "Temporarily require Signed-Off-By in the sandbox" https://review.opendev.org/c/openstack/project-config/+/950997 | 19:06 |
| opendevreview | Jeremy Stanley proposed openstack/project-config master: Deduplicate OpenStack ACL content https://review.opendev.org/c/openstack/project-config/+/951014 | 19:32 |
| opendevreview | Jeremy Stanley proposed openstack/project-config master: Replace OpenStack's CLA enforcement with the DCO https://review.opendev.org/c/openstack/project-config/+/950998 | 19:32 |
| clarkb | fungi: the only change in ps2 for 951014 was the removal of a the helm infra config file in some other change that you rebased on top of? | 19:42 |
| fungi | correct | 19:52 |
| opendevreview | Merged openstack/project-config master: Deduplicate OpenStack ACL content https://review.opendev.org/c/openstack/project-config/+/951014 | 20:18 |
| opendevreview | Merged opendev/system-config master: Remove duplicated content and reword/reorganize https://review.opendev.org/c/opendev/system-config/+/949939 | 20:21 |
| clarkb | fungi: opendev.org frontpage has udpated for me | 21:20 |
| clarkb | fits on a single screen now too which is nice | 21:20 |
| fungi | yep! https://opendev.org/ looks great now | 21:21 |
| clarkb | fungi: one thought is maybe the icons for code review, ci, and collaborative editing should be links too | 21:23 |
| clarkb | but not urgent. This looks good | 21:23 |
| fungi | yeah, completely agree | 21:28 |
| fungi | we can probably just move the start of the <a> | 21:29 |
| fungi | yep, totally, i'll get that change up after i make dinner | 21:29 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Fix indentation on Gitea splash page https://review.opendev.org/c/opendev/system-config/+/952407 | 22:12 |
| opendevreview | Jeremy Stanley proposed opendev/system-config master: Hyperlink service icons on Gitea splash page https://review.opendev.org/c/opendev/system-config/+/952408 | 22:12 |
| fungi | had a few minutes waiting on the charcoal to get going | 22:12 |
| fungi | i wonder if opendev-buildset-registry will ever unpause for 952408,1 | 23:11 |
| fungi | image build job timeout that provides a required artifact on a parent change corner case maybe? | 23:23 |
| fungi | i'll dequque it tomorrow if it doesn't complete before then | 23:24 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!