| opendevreview | Simon Westphahl proposed zuul/zuul-jobs master: Add default for build diskimage image name https://review.opendev.org/c/zuul/zuul-jobs/+/956219 | 07:00 |
|---|---|---|
| opendevreview | Bartosz Bezak proposed opendev/system-config master: Mirror docker registry v3 https://review.opendev.org/c/opendev/system-config/+/956354 | 11:24 |
| corvus | https://zuul.opendev.org/t/openstack/build/81c430709fb1414598ef9766362db918/log/job-output.txt#6474 | 13:43 |
| corvus | fungi: thanks for the recheck. that was a really weird timeout ^ | 13:43 |
| corvus | it looks like that was in the middle of some tasks that just "echo text > file" | 13:43 |
| corvus | maybe one of the remote nodes became unresponsive in some way that didn't cause an unreachable error | 13:44 |
| opendevreview | James E. Blair proposed opendev/zuul-providers master: Remove build_diskimage_image_name variable https://review.opendev.org/c/opendev/zuul-providers/+/956373 | 13:56 |
| stephenfin | clarkb: fungi: Would you be able to take a look through the remaining pbr patches early next week? I'd really like to cut a release asap just to catch any issues I may have introduced | 14:20 |
| * stephenfin is concerned about upcoming deadlines | 14:20 | |
| fungi | stephenfin: i can try to take a look today even | 14:21 |
| stephenfin | sweet, thanks. though I do think you've reviewed nearly all of them at this point | 14:22 |
| stephenfin | in fact you have, so clarkb is up | 14:22 |
| fungi | i switched to running gertty on a different machine and redid my subscription list, just realized i forgot to include pbr | 14:22 |
| fungi | so this was a good reminder | 14:22 |
| stephenfin | I was hoping to get the proper pyproject.toml support done in case they plan to remove support for distutils keywords also but it seems unlikely in the two weeks remaining | 14:24 |
| stephenfin | (as in support for a '[tool.pbr]' section, whose mere presence would enable pbr magic | 14:24 |
| stephenfin | ) | 14:24 |
| Clark[m] | I thought the deadline was October 31? I'm out Monday but can try to take a look today | 14:25 |
| fungi | ah, so it could contain toggles for different features in the future too, i guess | 14:25 |
| stephenfin | yeah, exactly. We already have that in setup.cfg so it's more of a continuation of that functionality | 14:27 |
| opendevreview | Bartosz Bezak proposed opendev/system-config master: Add Registry v3 (3.0.0) to OpenDev mirror https://review.opendev.org/c/opendev/system-config/+/956354 | 14:29 |
| opendevreview | Bartosz Bezak proposed opendev/system-config master: Add Registry v3 to OpenDev mirror https://review.opendev.org/c/opendev/system-config/+/956354 | 14:30 |
| opendevreview | Merged opendev/system-config master: Update zuul-launcher logging config https://review.opendev.org/c/opendev/system-config/+/956311 | 14:36 |
| opendevreview | Merged opendev/zone-opendev.org master: Add eavesdrop02 records https://review.opendev.org/c/opendev/zone-opendev.org/+/956121 | 14:36 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update upload-image-swift https://review.opendev.org/c/zuul/zuul-jobs/+/956377 | 14:37 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update upload-image-swift https://review.opendev.org/c/zuul/zuul-jobs/+/956377 | 14:39 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Synchronize upload-image-s3 to upload-image-swift https://review.opendev.org/c/zuul/zuul-jobs/+/956378 | 14:45 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Update upload-image-swift https://review.opendev.org/c/zuul/zuul-jobs/+/956377 | 16:04 |
| opendevreview | James E. Blair proposed zuul/zuul-jobs master: Synchronize upload-image-s3 to upload-image-swift https://review.opendev.org/c/zuul/zuul-jobs/+/956378 | 16:04 |
| clarkb | stephenfin: I've just approved https://review.opendev.org/c/openstack/pbr/+/954049 but left some inline commenst where my diffing found differences between the source and final setup post refactor. One of which I think may be worth a followup change. | 16:34 |
| clarkb | I don't think you should push a new patchset. A followup would e fine | 16:34 |
| opendevreview | Corey Leong proposed openstack/project-config master: New Project Cascade https://review.opendev.org/c/openstack/project-config/+/956386 | 16:36 |
| clarkb | stephenfin: fungi: I approved everything up to https://review.opendev.org/c/openstack/pbr/+/949055/ I +2'd that change but didn't approve it as I'm slightly worried the documentation update there may paint pbr in a bad light when it comes to setuptools and setup.cfg and compatibility between the two | 16:48 |
| clarkb | If others disagree with me its fine to approve (this is why I +2'd anyway) but I left a suggestion on how we might rephrase that and make it less problematic for pbr (in my opinion anyway) | 16:49 |
| stephenfin | No, I agree. I wasn't happy with my wording of that either | 16:49 |
| fungi | sgtm | 16:50 |
| stephenfin | It's the end of my day/week, so I am happy for you to reword as you see fit and re-approve, if that works for you | 16:50 |
| stephenfin | Otherwise I can do a follow-up next week, whatever works | 16:50 |
| clarkb | sure I can push an update to that change. fungi did you want to check what I had written to see if it makes sense? | 16:51 |
| fungi | i did already, read it in the e-mail notification gerrit sent me | 16:51 |
| fungi | hence my rather terse "sgtm" in here ;) | 16:51 |
| fungi | happy to +2/approve it once pushed | 16:51 |
| clarkb | ack I should have that up in a few minutes | 16:52 |
| fungi | the subsequent changes will require rebasing, unless you want to throw it into a new change at the end | 16:52 |
| fungi | i'm good either way | 16:52 |
| clarkb | I'll just do a change at the end and I can also remove that redundant line in that one test that snuck in during the refactor | 16:53 |
| clarkb | (as two separate changes) | 16:53 |
| clarkb | current problem: copying text out of gerrit comment literal blocks is not easy in the brwoser | 16:53 |
| clarkb | hittingthe quote button helps | 16:54 |
| fungi | wfm | 16:57 |
| fungi | the plan i mean | 16:58 |
| fungi | i agree the gerrit webui gets in the way of a lot of things, not just hughlighting/copy-paste but also things like conflicting with my browser's keybindings | 16:58 |
| clarkb | ok both changes are pushed. I'll go ahead and approve the one I held off on and defer review/approval on the two new changes to others | 16:59 |
| fungi | all problems i don't have with gertty, hence my avoidance of the webui | 16:59 |
| clarkb | frickler: I've updated my zuul python3.13 change to run on trixie but then it immediately fails as we don't have a mirror for it yet. Is there some easy way to disable that that jobs are using elsewhere already? | 17:26 |
| clarkb | I'll revert for now back to the ubuntu-noble compile python 3.13 version | 17:29 |
| fungi | clarkb: looks like it checks a zj_repo.condition flag? https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/configure-mirrors/tasks/mirror/Debian.yaml#L18 | 17:35 |
| fungi | oh, though that's only used directly for configure_mirrors_extra_repos | 17:35 |
| fungi | yeah i'm not seeing any obvious toggle | 17:35 |
| opendevreview | Corey Leong proposed openstack/project-config master: New Project Cascade https://review.opendev.org/c/openstack/project-config/+/956401 | 18:39 |
| fungi | looks like the first pbr change in that series failed in the gate | 18:58 |
| profcorey | What did I do wrong this time | 19:05 |
| profcorey | Used hard tabs and replaced the inheritance from openstack | 19:06 |
| fungi | profcorey: for starters, it looks like you pushed a new change rather than revising the existing change https://docs.opendev.org/opendev/infra-manual/latest/developers.html#updating-a-change | 19:07 |
| fungi | profcorey: but also it looks like some of the lines may still have spaces in their indentation or mixed spaces+tabs, and you added a tab inside the [access "refs/heads/*"] label too | 19:09 |
| fungi | https://zuul.opendev.org/t/openstack/build/e604bbf1cc93432d80775328a7d30c0e/console | 19:10 |
| fungi | you can use `tox -e gerrit` to run the same checks locally too | 19:10 |
| profcorey | I thought I saw in the docs to push a new change rather then the existing | 19:10 |
| profcorey | Gosh ok I'll start from scratch again | 19:11 |
| profcorey | run a check locally first | 19:12 |
| profcorey | thanks! | 19:12 |
| fungi | profcorey: if you just make sure "Change-Id: I95e59c64a2f7a9766176acae0f3ee21519d0a125" is at the end of your commit message (a line by itself in the last paragraph, what git docs refer to as a "trailer"), it'll be a revision to the existing change automatically | 19:13 |
| profcorey | ok will do | 19:13 |
| fungi | basically gerrit uses that id in combination with the project name and target branch name to identify a commit as a revision to a specific change | 19:14 |
| profcorey | gotcha | 19:16 |
| fungi | there is also an acl normalizer command you can run to justy fix it up rather than trying to edit it into shape, lemme see if i can remember the magic incantation | 19:18 |
| profcorey | ok | 19:18 |
| fungi | sometimes that's easier if your editor doesn't do a good job of differentiating spaces from tabs visually, or you have trouble telling whether things are sorted into alpha order | 19:19 |
| profcorey | I'm using vi to edit my files | 19:20 |
| fungi | profcorey: `python3 tools/normalize_acl.py x gerrit/acls/x/cascade.config apply` | 19:23 |
| profcorey | super, thank you! | 19:24 |
| profcorey | I'll give that a try when I can | 19:24 |
| fungi | there's a ton of code comments at the top of the normalize_acl.py script too, for the curious | 19:25 |
| profcorey | ok | 19:25 |
| profcorey | thank you! | 19:26 |
| fungi | profcorey: tip from a fellow vim user, i set "listchars=tab:»·" and "trail:·" so that i see "»·" in place of a hard tab and "·" for spaces at the end of lines, but there are a lot of alternative solutions out there too | 19:28 |
| profcorey | [REDACTED] | 19:28 |
| fungi | (you might want to change that) | 19:28 |
| profcorey | sorry about that | 19:28 |
| profcorey | will do | 19:28 |
| fungi | i can redact it from the web logs for the channel | 19:28 |
| profcorey | Thank you! | 19:29 |
| profcorey | It's changejd | 19:29 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!