| -@gerrit:opendev.org- Monty Taylor https://matrix.to/#/@mordred:inaugust.com proposed: [opendev/base-jobs] 976841: Add job to pull images from dockerhub using auth https://review.opendev.org/c/opendev/base-jobs/+/976841 | 15:15 | |
| @mordred:waterwanders.com | corvus: ^^ any interest in generalizing that or something like it? It's basically a fork of pull-from-intermediate-registry but doing an auth'd pull from a remote registry instead via passed-in secret. I've been trying to sort a good way to do that as a non-privileged user, but there isn't an awesome answer without putting something in a config-project. ... although just having typed that I think I'm realizing that it this should run _before_ pull-from-intermediate, in case there is a locally built image targeted to docker.io that should be pulled instead of the upstream version so you get correct overrides. (I'm just consuming a couple of images for an integration test that are pure "just use it", so this isn't handling dockerhub as a publish target for a repo at all) | 15:22 |
|---|---|---|
| @jim:acmegating.com | mordred: makes sense, but, yeah, i think the generalized form would be more appropriate for opendev base-jobs -- a role in zuul-jobs (probably more like the "container" roles than the "docker" ones -- the container roles work with any registry and either command). then the playbook just uses that. | 16:21 |
| @mordred:waterwanders.com | [@jim:acmegating.com](https://matrix.to/#/@jim:acmegating.com) since it's ultimately "copy from list of source repos into buildset registry" ... Would you prefer a separate role, or add logic to the intermediate repo copy role? | 16:45 |
| @jim:acmegating.com | mordred: it's a near toss-up, but i think separate role because the existing roles are so complex already, and i think the composability of roles here would be nice. (having said that -- perhaps there's opportunity for consolidating some stuff in a central python lib or something that's used by multiple roles (like we do with logs)... depending on how many saturdays you feel like dedicating to this. :) | 16:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!