*** ricolin has quit IRC | 06:48 | |
*** pleia2 has quit IRC | 07:12 | |
*** pleia2 has joined #openinfra | 08:40 | |
*** slaweq has quit IRC | 12:22 | |
*** slaweq has joined #openinfra | 12:25 | |
*** ricolin has joined #openinfra | 12:44 | |
*** pcaruana has quit IRC | 12:58 | |
*** pcaruana has joined #openinfra | 13:59 | |
*** sgw has joined #openinfra | 16:47 | |
sgw | Morning folks, dumb gerrit question, I recently tried pushing a change to an existing review and it added a new Change-Id: making it a new review. Is there something going on or did I screw somewhere? | 16:49 |
---|---|---|
fungi | sgw: did you accidentally remove the change-id footer from the commit message when amending that commit, or maybe add an additional paragraph after it? | 16:51 |
fungi | those are the only times i've seen that happen | 16:51 |
sgw | sgw: Ok that's it I added a v2: <comment> after the existing Change-Id: tag! I did thought it would see the since change-id tag. I will move the v2: comment before | 16:52 |
fungi | the easy solution is to amend the commit again, putting the desired change-id in the footers (final parahraph of the commit message) and push again, then abandon the stray change you accidentally created | 16:52 |
sgw | Yup, doing that and already abandon'ed the dup | 16:53 |
fungi | basically gerrit expects the commit-id line to be in the last "paragraph" of the commit message, where paragraphs are defined as blank-line-separated blocks of text | 16:53 |
fungi | so you can have lines after the change-id line, they just can't be blank lines | 16:54 |
sgw | Devil's in the details, that's one I was not super aware of, thanks for the clarification | 16:54 |
*** openstackstatus has quit IRC | 21:26 | |
*** openstackstatus has joined #openinfra | 21:31 | |
*** ChanServ sets mode: +v openstackstatus | 21:31 | |
*** openstack has joined #openinfra | 21:39 | |
*** ChanServ sets mode: +o openstack | 21:39 | |
*** openstack has joined #openinfra | 22:04 | |
*** ChanServ sets mode: +o openstack | 22:04 | |
*** jbrooks has quit IRC | 22:25 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!