Thursday, 2021-03-18

*** ricolin has quit IRC06:48
*** pleia2 has quit IRC07:12
*** pleia2 has joined #openinfra08:40
*** slaweq has quit IRC12:22
*** slaweq has joined #openinfra12:25
*** ricolin has joined #openinfra12:44
*** pcaruana has quit IRC12:58
*** pcaruana has joined #openinfra13:59
*** sgw has joined #openinfra16:47
sgwMorning folks, dumb gerrit question, I recently tried pushing a change to an existing review and it added a new Change-Id: making it a new review. Is there something going on or did I screw somewhere?16:49
fungisgw: did you accidentally remove the change-id footer from the commit message when amending that commit, or maybe add an additional paragraph after it?16:51
fungithose are the only times i've seen that happen16:51
sgwsgw: Ok that's it I added a v2: <comment> after the existing Change-Id: tag!  I did thought it would see the since change-id tag.  I will move the v2: comment before16:52
fungithe easy solution is to amend the commit again, putting the desired change-id in the footers (final parahraph of the commit message) and push again, then abandon the stray change you accidentally created16:52
sgwYup, doing that and already abandon'ed the dup16:53
fungibasically gerrit expects the commit-id line to be in the last "paragraph" of the commit message, where paragraphs are defined as blank-line-separated blocks of text16:53
fungiso you can have lines after the change-id line, they just can't be blank lines16:54
sgwDevil's in the details, that's one I was not super aware of, thanks for the clarification16:54
*** openstackstatus has quit IRC21:26
*** openstackstatus has joined #openinfra21:31
*** ChanServ sets mode: +v openstackstatus21:31
*** openstack has joined #openinfra21:39
*** ChanServ sets mode: +o openstack21:39
*** openstack has joined #openinfra22:04
*** ChanServ sets mode: +o openstack22:04
*** jbrooks has quit IRC22:25

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!