*** gtema has joined #openstack-ansible-sig | 00:47 | |
*** gtema has quit IRC | 00:52 | |
*** gtema has joined #openstack-ansible-sig | 02:48 | |
*** gtema has quit IRC | 02:54 | |
*** gtema has joined #openstack-ansible-sig | 04:49 | |
*** gtema has quit IRC | 04:54 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-ansible-sig | 05:34 | |
*** gtema has joined #openstack-ansible-sig | 06:50 | |
*** gtema has quit IRC | 06:55 | |
*** gtema has joined #openstack-ansible-sig | 07:45 | |
*** johanssone has quit IRC | 08:28 | |
*** johanssone has joined #openstack-ansible-sig | 08:32 | |
*** gtema has quit IRC | 08:42 | |
*** gtema has joined #openstack-ansible-sig | 08:42 | |
*** priteau has joined #openstack-ansible-sig | 08:58 | |
*** sshnaidm|afk is now known as sshnaidm | 09:59 | |
*** dtantsur|afk is now known as dtantsur | 10:05 | |
odyssey4me | sshnaidm: if you have a few mins, another gremlin has crawled in and the fix needs a review: https://review.opendev.org/708119 | 12:12 |
---|---|---|
sshnaidm | odyssey4me, thanks, commented | 12:20 |
sshnaidm | odyssey4me, I think we need to come with general method to check openstacksdk version for an argument | 12:20 |
sshnaidm | just a point to think about.. | 12:21 |
sshnaidm | like having "map" of arg and min/max version, and then to check it at once in openstack.py module | 12:22 |
sshnaidm | mordred, hi, did you have a chance to check what's required to add a session to ptg? | 12:23 |
odyssey4me | sshnaidm: yeah, although having the check in the module itself is kinda nice because it's easy to see in context - it would be nice to have a generalised way of expressing it so that the docs can inherit it too | 12:28 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release https://review.opendev.org/708372 | 12:29 |
odyssey4me | sshnaidm: passing None as min_version appears to me to result in min_version not using the default from module_utils/openstack.py | 12:37 |
sshnaidm | odyssey4me, what do you mean? | 12:38 |
odyssey4me | sshnaidm: http://paste.openstack.org/show/789696/ | 12:38 |
sshnaidm | odyssey4me, https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/module_utils/openstack.py#L122-L125 | 12:39 |
sshnaidm | odyssey4me, it's rewritten | 12:39 |
odyssey4me | sshnaidm: ah yeah - that works - apologies, I'll revise now | 12:41 |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu} https://review.opendev.org/708119 | 12:45 |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu} https://review.opendev.org/708119 | 12:46 |
odyssey4me | sshnaidm dtantsur ^ done | 12:46 |
*** gtema has quit IRC | 12:56 | |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release https://review.opendev.org/708372 | 13:26 |
*** gtema has joined #openstack-ansible-sig | 13:55 | |
*** owalsh_ is now known as owalsh | 14:26 | |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release https://review.opendev.org/708372 | 14:48 |
mordred | sshnaidm: my last week got eaten by the virtualenv upgrade - I'll work on both that and the collection upload today | 14:53 |
*** holser has joined #openstack-ansible-sig | 14:56 | |
sshnaidm | mordred, ack | 14:59 |
sshnaidm | mordred, venv and six were a real PITA these days indeed :( | 14:59 |
sshnaidm | thanks for working on that | 15:00 |
sshnaidm | OK, time for a meeting | 15:01 |
sshnaidm | #startmeeting ansible-sig | 15:01 |
openstack | Meeting started Tue Feb 18 15:01:14 2020 UTC and is due to finish in 60 minutes. The chair is sshnaidm. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
*** openstack changes topic to " (Meeting topic: ansible-sig)" | 15:01 | |
openstack | The meeting name has been set to 'ansible_sig' | 15:01 |
sshnaidm | who is available today? | 15:01 |
noonedeadpunk | o/ | 15:01 |
mordred | o/ | 15:02 |
*** johanssone has quit IRC | 15:02 | |
sshnaidm | dtantsur, odyssey4me jrosser mnaser cloudnull just fyi, openstack ansible modules meeting started | 15:02 |
dtantsur | o/ | 15:02 |
sshnaidm | agenda is: | 15:03 |
sshnaidm | #link https://etherpad.openstack.org/p/openstack-ansible-modules | 15:03 |
sshnaidm | so from action items: | 15:03 |
sshnaidm | we'll deal with pushing collection and ptg stuff later this week, as mordred pointed above | 15:04 |
holser | o/ | 15:04 |
sshnaidm | job for build&push collections is in WIP https://review.opendev.org/#/c/708372/ | 15:05 |
mordred | yah. stupid virtualenv | 15:05 |
odyssey4me | o/ | 15:05 |
odyssey4me | re: virtualenv - https://github.com/ansible/ansible/pull/67407 may help make it easier to do better things | 15:05 |
sshnaidm | thanks odyssey4me | 15:06 |
sshnaidm | we have also a few reviews pending, please get some in your time | 15:06 |
mordred | odyssey4me: yah- in fairness to the virtualenv devs, they heard and responded pretty quickly | 15:06 |
mordred | sshnaidm: ++ reviews | 15:07 |
sshnaidm | yeah, I think we can proceed as a start with mordred patch, at least it has +2 from me and I saw gtema worked on it | 15:07 |
*** johanssone has joined #openstack-ansible-sig | 15:08 | |
sshnaidm | for using a class for openstack module | 15:08 |
mordred | sshnaidm: cool - I thnik that'll open the door for us to clean and simplify in a bunch of places | 15:08 |
sshnaidm | #link https://review.opendev.org/#/c/698044/ | 15:08 |
sshnaidm | mordred, totally | 15:08 |
sshnaidm | another problem that we hit a few times and should be handled there is matching various options and openstacksdk versions | 15:09 |
mordred | also - those checks were complex enough that last time I tried to required_if them it didn't work -but maybe required_if is better todauy - or maybe you're smarter :) | 15:09 |
mordred | yah | 15:09 |
sshnaidm | mordred, I think it worked for me, maybe it's ok now | 15:10 |
mordred | sweet | 15:10 |
sshnaidm | for being more compatible with various openstcksdk versions, I'd propose a job matrix to test code | 15:10 |
mordred | I totally agree - doing as much with those declarations is nicer | 15:10 |
mordred | ++ | 15:10 |
sshnaidm | openstacksdk versions to test: | 15:11 |
sshnaidm | master | 15:11 |
sshnaidm | 0.36.1 (stable/train) | 15:11 |
sshnaidm | 0.27.0 (stable/stein) | 15:11 |
sshnaidm | 0.17.3 (stable/rocky) | 15:11 |
sshnaidm | Ansible: | 15:11 |
sshnaidm | devel | 15:11 |
sshnaidm | 2.9 | 15:11 |
sshnaidm | 2.8 | 15:11 |
sshnaidm | as I noticed the minimum required version is 0.12 and it's rocky | 15:11 |
mordred | yeah - I mean - one definitely needs at least whatever version we did the shade merge from - I think that's 0.12 | 15:12 |
sshnaidm | https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/module_utils/openstack.py#L112 | 15:12 |
sshnaidm | mordred, so it shouldn't work for queens at all? | 15:12 |
mordred | for queens you'd need to use shade | 15:13 |
mordred | BUT | 15:13 |
mordred | it's important to point out that it has never been these modules intentions to release match with openstack releases- master openstacksdk should totally work with queens - or even diablo | 15:13 |
mordred | so while I do think we shoudl support some older sdks within reason | 15:13 |
mordred | it's also important that we point out to people in docs that they do _not_ need an older version of something to work with an older cloud | 15:14 |
sshnaidm | mordred, so you mean we don't want "max_version" | 15:14 |
odyssey4me | mordred: yeah, the issue has actually been people adding arguments to modules which don't work with the sdk at older versions - for example https://review.opendev.org/708119 is upping the minimum if certain parameters are used | 15:14 |
sshnaidm | only min_version | 15:14 |
mordred | (I know we have vendors shipping stuff side-by-side, so running modules with older versions of libraries may be unavoidable in some cases - but it would be really nice if we could get those vendors to update sdk :) ) | 15:14 |
mordred | sshnaidm: ++ | 15:15 |
mordred | odyssey4me: ++ | 15:15 |
sshnaidm | great | 15:15 |
sshnaidm | #action sshnaidm to point about min and max version in docs | 15:16 |
sshnaidm | wrt docs | 15:16 |
sshnaidm | I just copypasted this from ansible: https://review.opendev.org/#/c/704558/ | 15:16 |
sshnaidm | so if somebody wants to update this doc, please feel free to hijack this patch :) | 15:17 |
sshnaidm | consider it as a wiki :) | 15:17 |
sshnaidm | #link https://review.opendev.org/#/c/704558/ | 15:17 |
mordred | haha | 15:17 |
odyssey4me | heh, *hint* at ekultails and mordred there :p | 15:18 |
sshnaidm | well, we need something to show to new contributors, after they are shocked after github->gerrti switch | 15:19 |
sshnaidm | maybe I'll add there a "transition" section with links how to create gerrit acc, etc | 15:20 |
sshnaidm | ok, moving on | 15:20 |
sshnaidm | so we agree on proposed jobs matrix, right? | 15:20 |
mordred | yes. although we might want to start with ansible-devel being non-voiting - just because sometimes the devel branch can itself be flaky | 15:21 |
sshnaidm | mordred, yeah, good point, maybe same with master openstacksdk? | 15:21 |
sshnaidm | or no, it's actually under our control | 15:21 |
sshnaidm | I think we can run these jobs later on openstacksdk branches and master, to prevent breakages for ansible module actually | 15:22 |
sshnaidm | or at least fast fixing them | 15:22 |
sshnaidm | dtantsur, no objections, right? ^ | 15:22 |
mordred | yeah - master openstacksdk should be fine - it's gated :) | 15:23 |
sshnaidm | great | 15:23 |
dtantsur | ++ | 15:23 |
sshnaidm | so, this is it for agenda today, please feel free to raise topics for open discussions | 15:23 |
mordred | I just replied to that docs patch above (and I'll take a stab at a new patch update) - but we should totally do co-gating with openstacksdk | 15:23 |
sshnaidm | mordred, cool | 15:24 |
sshnaidm | gtema, thanks for working on tags stuff https://review.opendev.org/#/c/705343/ | 15:25 |
sshnaidm | I'm quite lost in this tags thing.. | 15:25 |
gtema | wlcm, still thinking for the better way and would like to ask perhaps not to merge anything tag related | 15:26 |
odyssey4me | sshnaidm mordred wrt ansible-devel - I suspect that once the collections split out happens, core will be more stable... that said, it might be better for us to do a periodic job for devel rather than gate on it | 15:26 |
sshnaidm | odyssey4me, from my experience periodic jobs are less important for people | 15:27 |
sshnaidm | odyssey4me, and it's visible only if someone is looking for it in particular | 15:27 |
mordred | odyssey4me: yeah - I'd hope it'll be more stable then - and also the things in it that impact *US* should be fairly low | 15:28 |
sshnaidm | odyssey4me, I'd compromise on non-voting job | 15:28 |
sshnaidm | gtema, you can always -2 these patches :) | 15:28 |
gtema | I know | 15:28 |
sshnaidm | gtema, I'll mention this in ML after a mtg, but you know... | 15:29 |
odyssey4me | sshnaidm: fair enough - although non-voting jobs tend to be ignored... but at least they're more visible | 15:29 |
sshnaidm | odyssey4me, yeah, and you can get feedback for your change immediately | 15:29 |
gtema | mordred: any chance to refer in the zuul job definition project on the different connection? github repo with job definition does require-project in opendev | 15:29 |
gtema | sorry for missusing channel | 15:30 |
mordred | gtema: yes - cross-source stuff works perfectly fine | 15:30 |
gtema | do I need required-projects: -opendev/opendev/refstack-client? | 15:31 |
gtema | opendev/openstack/refstack-client | 15:31 |
gtema | ok, thks | 15:31 |
sshnaidm | opendev.org/openstack/.. I think | 15:31 |
mordred | yeah - opendev.org/openstack/refstack-client ... you'll need to have those in your zuul - is this in opendev's zuul? | 15:32 |
gtema | nope, in mine | 15:32 |
gtema | enabling refstack tests of my cloud | 15:32 |
mordred | kk. yeah - just make sure you have both repos in the main zuul config | 15:32 |
gtema | thks | 15:32 |
sshnaidm | all right | 15:33 |
mordred | you don[t ACTUALLY need the opendev.org prefix if it's unique | 15:33 |
sshnaidm | mordred, or, is it just a default? | 15:33 |
sshnaidm | ok, I think I can finish the meeting and feel free to continue | 15:34 |
mordred | zuul will figure it out | 15:34 |
sshnaidm | #endmeeting | 15:34 |
*** openstack changes topic to "OpenStack Ansible SIG | https://etherpad.openstack.org/p/ansible-sig" | 15:34 | |
openstack | Meeting ended Tue Feb 18 15:34:14 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:34 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.html | 15:34 |
odyssey4me | sshnaidm: yep, looks like it - thanks! | 15:34 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.txt | 15:34 |
openstack | Log: http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.log.html | 15:34 |
sshnaidm | thanks to all participants | 15:34 |
mordred | you could actually say "required-projects: ansible" and zuul will figure out to expand that to github.com/ansible/ansible if it's the only repo named ansible | 15:34 |
mordred | obviously that's fragie and you sholndn't do it | 15:34 |
sshnaidm | mordred, but there are a lot of forks, like github.com/sshnaidm/ansible | 15:35 |
mordred | sure - but thoe aren't listed in your zuul config | 15:35 |
mordred | https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L40-L48 <-- this is where we add ansible/ansible to the opendev tenant in opendev's zuul | 15:35 |
sshnaidm | oh, you mean ansible/ansible | 15:35 |
gtema | good, trying around | 15:35 |
mordred | note we have include: [] - that's saying "don't load any config objects" | 15:35 |
mordred | gtema: you almost certainly want to have an include list there - that includes job - but probably doesn't want to include project (the stanza in opendev's repo assigning jobs to pipelines is almost certainly incorrect for your zuul) | 15:36 |
gtema | sure | 15:36 |
sshnaidm | gtema, you can look at our reproducers config as an example: https://github.com/rdo-infra/ansible-role-tripleo-ci-reproducer/blob/master/templates/main.yaml.j2 | 15:37 |
mordred | ++ | 15:37 |
mordred | you almost certainly want "job" | 15:37 |
gtema | perfect, thks | 15:38 |
noonedeadpunk | root | 15:38 |
noonedeadpunk | disregrd pls - wrong window | 15:38 |
sshnaidm | noonedeadpunk, and the password..? | 15:39 |
noonedeadpunk | it was password xD | 15:39 |
sshnaidm | :D | 15:39 |
noonedeadpunk | so worth asking for ip | 15:39 |
sshnaidm | mordred, if we are talking about zuul config, is there a way not to see patches updates coming in zuul scheduler? for the config I listed before: https://github.com/rdo-infra/ansible-role-tripleo-ci-reproducer/blob/master/templates/main.yaml.j2 | 15:47 |
sshnaidm | mordred, it's just so noisy.. | 15:47 |
mordred | sshnaidm: I'm not sure I understand the question? | 15:51 |
sshnaidm | mordred, when I run zuul with such config I see patches updates in zuul logs from all these projects in config | 15:53 |
sshnaidm | like that: https://logserver.rdoproject.org/44/24744/7/check/tripleo-ci-reproducer-centos-7-host/4cbb65d/tripleo-ci-reproducer/scheduler.log | 15:53 |
sshnaidm | I wondered if I can somehow tell zuul not to show all this noise | 15:53 |
sshnaidm | or not to load incoming patches | 15:54 |
sshnaidm | updates from gerrit I mean ^ | 15:54 |
sshnaidm | lines with zuul.GerritConnection.io - DEBUG - [e: fb711286d8ed4359a291ffc92dac6105] Received data from Gerrit query: | 15:55 |
sshnaidm | well, looks like it's not possible when debug is on.. | 15:56 |
cloudnull | o/ | 15:57 |
sshnaidm | cloudnull, hey | 15:57 |
cloudnull | hi | 15:58 |
mordred | sshnaidm: the logging config is actually really flexible | 15:58 |
cloudnull | sorry couldn't make the meeting, was in a different meeting :D | 15:58 |
mordred | so if it's just the logging you're worried about - let me see if I can find you an example | 15:59 |
sshnaidm | mordred, yeah, it's more about logging | 15:59 |
sshnaidm | cloudnull, np, the logs are above and we can still talk here :) | 15:59 |
* cloudnull is reading | 16:00 | |
mordred | sshnaidm: https://opendev.org/opendev/puppet-zuul/src/branch/master/files/logging.conf | 16:00 |
mordred | sshnaidm: you can get as specific about what you want to see as you want | 16:01 |
sshnaidm | mordred, nice.. I suppose I can find the explanations about keys in zuul docs somewhere? | 16:04 |
mordred | sshnaidm: I can't find any - I'm asking about that in #zuul | 16:08 |
sshnaidm | mordred, thanks | 16:08 |
*** gshippey has joined #openstack-ansible-sig | 16:12 | |
*** holser has quit IRC | 16:45 | |
*** spatel has joined #openstack-ansible-sig | 16:57 | |
*** dtantsur is now known as dtantsur|afk | 17:06 | |
*** spatel has quit IRC | 17:18 | |
*** spatel has joined #openstack-ansible-sig | 17:18 | |
*** spatel has quit IRC | 17:34 | |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-ansible-sig | 17:34 | |
*** spatel has joined #openstack-ansible-sig | 17:49 | |
*** gtema has quit IRC | 18:22 | |
mordred | sshnaidm: in the collections repo we're using changelogs/fragments and not reno - is upstream ansible processing those fragments in some way that makes use of fragments a better choice? | 18:37 |
mordred | if they are - that's awesome - but if we need to cook up a changelog publication job I'd rather just use reno since we have the infrastructure for that in place | 18:38 |
sshnaidm | mordred, good question, I think they use it for changelogs, but we don't have to do the same imho | 18:38 |
sshnaidm | mordred, I'm pretty sure they are not gonna publish our changelogs in ansible somewhere | 18:39 |
*** priteau has quit IRC | 18:39 | |
mordred | yeah - I didn't thinkj so | 18:39 |
sshnaidm | gundalow, but just for a confirmation ^^ do you know is it matters to use reno in our changelogs or to do fragments as in ansible? | 18:39 |
mordred | the format is close enough that we can probably just do a conversation automatically in a patch in a little bit - it's not super important to deal with now - mostly just curious | 18:40 |
sshnaidm | mordred, yeah, I think it's better to continue our way than starting setting up something external from ansible | 18:41 |
gundalow | sshnaidm: for collections you can use whatever process works best for gh ou to generate release notes | 18:41 |
sshnaidm | gundalow, thanks | 18:41 |
gundalow | Ie use what you know | 18:41 |
mordred | cool | 18:41 |
sshnaidm | gundalow, just curios, what's used in ansible for that? any library..? | 18:42 |
gundalow | There is no (current) plan to pull and combine release notes from individual collections | 18:42 |
mordred | gundalow: you seem to still be in one piece with Storm Dennis | 18:42 |
gundalow | sshnaidm: https://github.com/ansible/ansible/blob/devel/packaging/release/changelogs/changelog.py | 18:44 |
gundalow | mordred: for the moment | 18:45 |
*** priteau has joined #openstack-ansible-sig | 18:47 | |
mordred | gundalow: I saw this: https://www.euronews.com/2020/02/17/watch-pilot-lands-394-ton-a380-sideways-as-storm-dennis-rages | 18:47 |
mordred | gundalow: I do not want to be in that plane | 18:48 |
gundalow | Yes, that was equal measure of impressed/scared | 18:48 |
mordred | gundalow: I suppose it underscores just how safe those things actually are- they can handle WAY more stress than they are put through | 18:49 |
sshnaidm | it's kinda helicopter way of landing.. | 18:51 |
*** priteau has quit IRC | 18:51 | |
mordred | sshnaidm: in a *very* large jet powered helicopter | 18:57 |
*** priteau has joined #openstack-ansible-sig | 19:18 | |
*** priteau has quit IRC | 19:23 | |
openstackgerrit | Merged openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu} https://review.opendev.org/708119 | 19:26 |
*** priteau has joined #openstack-ansible-sig | 19:52 | |
*** priteau has quit IRC | 19:57 | |
*** priteau has joined #openstack-ansible-sig | 20:33 | |
*** priteau has quit IRC | 20:37 | |
*** gtema has joined #openstack-ansible-sig | 21:53 | |
*** gtema has quit IRC | 22:00 | |
*** spatel has quit IRC | 23:27 | |
*** gtema has joined #openstack-ansible-sig | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!