Tuesday, 2020-02-18

*** gtema has joined #openstack-ansible-sig00:47
*** gtema has quit IRC00:52
*** gtema has joined #openstack-ansible-sig02:48
*** gtema has quit IRC02:54
*** gtema has joined #openstack-ansible-sig04:49
*** gtema has quit IRC04:54
*** evrardjp has quit IRC05:34
*** evrardjp has joined #openstack-ansible-sig05:34
*** gtema has joined #openstack-ansible-sig06:50
*** gtema has quit IRC06:55
*** gtema has joined #openstack-ansible-sig07:45
*** johanssone has quit IRC08:28
*** johanssone has joined #openstack-ansible-sig08:32
*** gtema has quit IRC08:42
*** gtema has joined #openstack-ansible-sig08:42
*** priteau has joined #openstack-ansible-sig08:58
*** sshnaidm|afk is now known as sshnaidm09:59
*** dtantsur|afk is now known as dtantsur10:05
odyssey4messhnaidm: if you have a few mins, another gremlin has crawled in and the fix needs a review: https://review.opendev.org/70811912:12
sshnaidmodyssey4me, thanks, commented12:20
sshnaidmodyssey4me, I think we need to come with general method to check openstacksdk version for an argument12:20
sshnaidmjust a point to think about..12:21
sshnaidmlike having "map" of arg and min/max version, and then to check it at once in openstack.py module12:22
sshnaidmmordred, hi, did you have a chance to check what's required to add a session to ptg?12:23
odyssey4messhnaidm: yeah, although having the check in the module itself is kinda nice because it's easy to see in context - it would be nice to have a generalised way of expressing it so that the docs can inherit it too12:28
openstackgerritSagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release  https://review.opendev.org/70837212:29
odyssey4messhnaidm: passing None as min_version appears to me to result in min_version not using the default from module_utils/openstack.py12:37
sshnaidmodyssey4me, what do you mean?12:38
odyssey4messhnaidm: http://paste.openstack.org/show/789696/12:38
sshnaidmodyssey4me, https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/module_utils/openstack.py#L122-L12512:39
sshnaidmodyssey4me, it's rewritten12:39
odyssey4messhnaidm: ah yeah - that works - apologies, I'll revise now12:41
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu}  https://review.opendev.org/70811912:45
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu}  https://review.opendev.org/70811912:46
odyssey4messhnaidm dtantsur ^ done12:46
*** gtema has quit IRC12:56
openstackgerritSagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release  https://review.opendev.org/70837213:26
*** gtema has joined #openstack-ansible-sig13:55
*** owalsh_ is now known as owalsh14:26
openstackgerritSagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: build ansible collection before release  https://review.opendev.org/70837214:48
mordredsshnaidm: my last week got eaten by the virtualenv upgrade - I'll work on both that and the collection upload today14:53
*** holser has joined #openstack-ansible-sig14:56
sshnaidmmordred, ack14:59
sshnaidmmordred, venv and six were a real PITA these days indeed :(14:59
sshnaidmthanks for working on that15:00
sshnaidmOK, time for a meeting15:01
sshnaidm#startmeeting ansible-sig15:01
openstackMeeting started Tue Feb 18 15:01:14 2020 UTC and is due to finish in 60 minutes.  The chair is sshnaidm. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
*** openstack changes topic to " (Meeting topic: ansible-sig)"15:01
openstackThe meeting name has been set to 'ansible_sig'15:01
sshnaidmwho is available today?15:01
*** johanssone has quit IRC15:02
sshnaidmdtantsur, odyssey4me jrosser mnaser cloudnull just fyi, openstack ansible modules meeting started15:02
sshnaidmagenda is:15:03
sshnaidm#link https://etherpad.openstack.org/p/openstack-ansible-modules15:03
sshnaidmso from action items:15:03
sshnaidmwe'll deal with pushing collection and ptg stuff later this week, as mordred pointed above15:04
sshnaidmjob for build&push collections is in WIP https://review.opendev.org/#/c/708372/15:05
mordredyah. stupid virtualenv15:05
odyssey4mere: virtualenv - https://github.com/ansible/ansible/pull/67407 may help make it easier to do better things15:05
sshnaidmthanks odyssey4me15:06
sshnaidmwe have also a few reviews pending, please get some in your time15:06
mordredodyssey4me: yah- in fairness to the virtualenv devs, they heard and responded pretty quickly15:06
mordredsshnaidm: ++ reviews15:07
sshnaidmyeah, I think we can proceed as a start with mordred patch, at least it has +2 from me and I saw gtema worked on it15:07
*** johanssone has joined #openstack-ansible-sig15:08
sshnaidmfor using a class for openstack module15:08
mordredsshnaidm: cool - I thnik that'll open the door for us to clean and simplify in a bunch of places15:08
sshnaidm#link https://review.opendev.org/#/c/698044/15:08
sshnaidmmordred, totally15:08
sshnaidmanother problem that we hit a few times and should be handled there is matching various options and openstacksdk versions15:09
mordredalso - those checks were complex enough that last time I tried to required_if them it didn't work -but maybe required_if is better todauy - or maybe you're smarter :)15:09
sshnaidmmordred, I think it worked for me, maybe it's ok now15:10
sshnaidmfor being more compatible with various openstcksdk versions, I'd propose a job matrix to test code15:10
mordredI totally agree - doing as much with those declarations is nicer15:10
sshnaidm    openstacksdk versions to test:15:11
sshnaidm    master15:11
sshnaidm    0.36.1 (stable/train)15:11
sshnaidm    0.27.0 (stable/stein)15:11
sshnaidm    0.17.3 (stable/rocky)15:11
sshnaidm    Ansible:15:11
sshnaidm    devel15:11
sshnaidm    2.915:11
sshnaidm    2.815:11
sshnaidmas I noticed the minimum required version is 0.12 and it's rocky15:11
mordredyeah - I mean - one definitely needs at least whatever version we did the shade merge from - I think that's 0.1215:12
sshnaidmmordred, so it shouldn't work for queens at all?15:12
mordredfor queens you'd need to use shade15:13
mordredit's important to point out that it has never been these modules intentions to release match with openstack releases- master openstacksdk should totally work with queens - or even diablo15:13
mordredso while I do think we shoudl support some older sdks within reason15:13
mordredit's also important that we point out to people in docs that they do _not_ need an older version of something to work with an older cloud15:14
sshnaidmmordred, so you mean we don't want "max_version"15:14
odyssey4memordred: yeah, the issue has actually been people adding arguments to modules which don't work with the sdk at older versions - for example https://review.opendev.org/708119 is upping the minimum if certain parameters are used15:14
sshnaidmonly min_version15:14
mordred(I know we have vendors shipping stuff side-by-side, so running modules with older versions of libraries may be unavoidable in some cases - but it would be really nice if we could get those vendors to update sdk :) )15:14
mordredsshnaidm: ++15:15
mordredodyssey4me: ++15:15
sshnaidm#action sshnaidm to point about min and max version in docs15:16
sshnaidmwrt docs15:16
sshnaidmI just copypasted this from ansible: https://review.opendev.org/#/c/704558/15:16
sshnaidmso if somebody wants to update this doc, please feel free to hijack this patch :)15:17
sshnaidmconsider it as a wiki :)15:17
sshnaidm#link https://review.opendev.org/#/c/704558/15:17
odyssey4meheh, *hint* at ekultails and mordred there :p15:18
sshnaidmwell, we need something to show to new contributors, after they are shocked after github->gerrti switch15:19
sshnaidmmaybe I'll add there a "transition" section with links how to create gerrit acc, etc15:20
sshnaidmok, moving on15:20
sshnaidmso we agree on proposed jobs matrix, right?15:20
mordredyes. although we might want to start with ansible-devel being non-voiting - just because sometimes the devel branch can itself be flaky15:21
sshnaidmmordred, yeah, good point, maybe same with master openstacksdk?15:21
sshnaidmor no, it's actually under our control15:21
sshnaidmI think we can run these jobs later on openstacksdk branches and master, to prevent breakages for ansible module actually15:22
sshnaidmor at least fast fixing them15:22
sshnaidmdtantsur, no objections, right? ^15:22
mordredyeah - master openstacksdk should be fine - it's gated :)15:23
sshnaidmso, this is it for agenda today, please feel free to raise topics for open discussions15:23
mordredI just replied to that docs patch above (and I'll take a stab at a new patch update) - but we should totally do co-gating with openstacksdk15:23
sshnaidmmordred, cool15:24
sshnaidmgtema, thanks for working on tags stuff https://review.opendev.org/#/c/705343/15:25
sshnaidmI'm quite lost in this tags thing..15:25
gtemawlcm, still thinking for the better way and would like to ask perhaps not to merge anything tag related15:26
odyssey4messhnaidm mordred wrt ansible-devel - I suspect that once the collections split out happens, core will be more stable... that said, it might be better for us to do a periodic job for devel rather than gate on it15:26
sshnaidmodyssey4me, from my experience periodic jobs are less important for people15:27
sshnaidmodyssey4me, and it's visible only if someone is looking for it in particular15:27
mordredodyssey4me: yeah - I'd hope it'll be more stable then - and also the things in it that impact *US* should be fairly low15:28
sshnaidmodyssey4me, I'd compromise on non-voting job15:28
sshnaidmgtema, you can always -2 these patches :)15:28
gtemaI know15:28
sshnaidmgtema, I'll mention this in ML after a mtg, but you know...15:29
odyssey4messhnaidm: fair enough - although non-voting jobs tend to be ignored... but at least they're more visible15:29
sshnaidmodyssey4me, yeah, and you can get feedback for your change immediately15:29
gtemamordred: any chance to refer in the zuul job definition project on the different connection? github repo with job definition does require-project in opendev15:29
gtemasorry for missusing channel15:30
mordredgtema: yes - cross-source stuff works perfectly fine15:30
gtemado I need required-projects: -opendev/opendev/refstack-client?15:31
gtemaok, thks15:31
sshnaidmopendev.org/openstack/.. I think15:31
mordredyeah - opendev.org/openstack/refstack-client ... you'll need to have those in your zuul - is this in opendev's zuul?15:32
gtemanope, in mine15:32
gtemaenabling refstack tests of my cloud15:32
mordredkk. yeah - just make sure you have both repos in the main zuul config15:32
sshnaidmall right15:33
mordredyou don[t ACTUALLY need the opendev.org prefix if it's unique15:33
sshnaidmmordred, or, is it just a default?15:33
sshnaidmok, I think I can finish the meeting and feel free to continue15:34
mordredzuul will figure it out15:34
*** openstack changes topic to "OpenStack Ansible SIG | https://etherpad.openstack.org/p/ansible-sig"15:34
openstackMeeting ended Tue Feb 18 15:34:14 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:34
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.html15:34
odyssey4messhnaidm: yep, looks like it - thanks!15:34
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.txt15:34
openstackLog:            http://eavesdrop.openstack.org/meetings/ansible_sig/2020/ansible_sig.2020-02-18-15.01.log.html15:34
sshnaidmthanks to all participants15:34
mordredyou could actually say "required-projects: ansible" and zuul will figure out to expand that to github.com/ansible/ansible if it's the only repo named ansible15:34
mordredobviously that's fragie and you sholndn't do it15:34
sshnaidmmordred, but there are a lot of forks, like github.com/sshnaidm/ansible15:35
mordredsure - but thoe aren't listed in your zuul config15:35
mordredhttps://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L40-L48 <-- this is where we add ansible/ansible to the opendev tenant in opendev's zuul15:35
sshnaidmoh, you mean ansible/ansible15:35
gtemagood, trying around15:35
mordrednote we have include: [] - that's saying "don't load any config objects"15:35
mordredgtema: you almost certainly want to have an include list there - that includes job - but probably doesn't want to include project (the stanza in opendev's repo assigning jobs to pipelines is almost certainly incorrect for your zuul)15:36
sshnaidmgtema, you can look at our reproducers config as an example: https://github.com/rdo-infra/ansible-role-tripleo-ci-reproducer/blob/master/templates/main.yaml.j215:37
mordredyou almost certainly want "job"15:37
gtemaperfect, thks15:38
noonedeadpunkdisregrd pls - wrong window15:38
sshnaidmnoonedeadpunk, and the password..?15:39
noonedeadpunkit was password xD15:39
noonedeadpunkso worth asking for ip15:39
sshnaidmmordred, if we are talking about zuul config, is there a way not to see patches updates coming in zuul scheduler? for the config I listed before:  https://github.com/rdo-infra/ansible-role-tripleo-ci-reproducer/blob/master/templates/main.yaml.j215:47
sshnaidmmordred, it's just so noisy..15:47
mordredsshnaidm: I'm not sure I understand the question?15:51
sshnaidmmordred, when I run zuul with such config I see patches updates in zuul logs from all these projects in config15:53
sshnaidmlike that: https://logserver.rdoproject.org/44/24744/7/check/tripleo-ci-reproducer-centos-7-host/4cbb65d/tripleo-ci-reproducer/scheduler.log15:53
sshnaidmI wondered if I can somehow tell zuul not to show all this noise15:53
sshnaidmor not to load incoming patches15:54
sshnaidmupdates from gerrit I mean ^15:54
sshnaidmlines with zuul.GerritConnection.io - DEBUG - [e: fb711286d8ed4359a291ffc92dac6105] Received data from Gerrit query:15:55
sshnaidmwell, looks like it's not possible when debug is on..15:56
sshnaidmcloudnull, hey15:57
mordredsshnaidm: the logging config is actually really flexible15:58
cloudnullsorry couldn't make the meeting, was in a different meeting :D15:58
mordredso if it's just the logging you're worried about - let me see if I can find you an example15:59
sshnaidmmordred, yeah, it's more about logging15:59
sshnaidmcloudnull, np, the logs are above and we can still talk here :)15:59
* cloudnull is reading 16:00
mordredsshnaidm: https://opendev.org/opendev/puppet-zuul/src/branch/master/files/logging.conf16:00
mordredsshnaidm: you can get as specific about what you want to see as you want16:01
sshnaidmmordred, nice.. I suppose I can find the explanations about keys in zuul docs somewhere?16:04
mordredsshnaidm: I can't find any - I'm asking about that in #zuul16:08
sshnaidmmordred, thanks16:08
*** gshippey has joined #openstack-ansible-sig16:12
*** holser has quit IRC16:45
*** spatel has joined #openstack-ansible-sig16:57
*** dtantsur is now known as dtantsur|afk17:06
*** spatel has quit IRC17:18
*** spatel has joined #openstack-ansible-sig17:18
*** spatel has quit IRC17:34
*** evrardjp has quit IRC17:34
*** evrardjp has joined #openstack-ansible-sig17:34
*** spatel has joined #openstack-ansible-sig17:49
*** gtema has quit IRC18:22
mordredsshnaidm: in the collections repo we're using changelogs/fragments and not reno - is upstream ansible processing those fragments in some way that makes use of fragments a better choice?18:37
mordredif they are - that's awesome - but if we need to cook up a changelog publication job I'd rather just use reno since we have the infrastructure for that in place18:38
sshnaidmmordred, good question, I think they use it for changelogs, but we don't have to do the same imho18:38
sshnaidmmordred, I'm pretty sure they are not gonna publish our changelogs in ansible somewhere18:39
*** priteau has quit IRC18:39
mordredyeah - I didn't thinkj so18:39
sshnaidmgundalow, but just for a confirmation ^^ do you know is it matters to use reno in our changelogs or to do fragments as in ansible?18:39
mordredthe format is close enough that we can probably just do a conversation automatically in a patch in a little bit - it's not super important to deal with now - mostly just curious18:40
sshnaidmmordred, yeah, I think it's better to continue our way than starting setting up something external from ansible18:41
gundalowsshnaidm: for collections you can use whatever process works best for gh ou to generate release notes18:41
sshnaidmgundalow, thanks18:41
gundalowIe use what you know18:41
sshnaidmgundalow, just curios, what's used in ansible for that? any library..?18:42
gundalowThere is no (current) plan to pull and combine release notes from individual collections18:42
mordredgundalow: you seem to still be in one piece with Storm Dennis18:42
gundalowsshnaidm: https://github.com/ansible/ansible/blob/devel/packaging/release/changelogs/changelog.py18:44
gundalowmordred: for the moment18:45
*** priteau has joined #openstack-ansible-sig18:47
mordredgundalow: I saw this: https://www.euronews.com/2020/02/17/watch-pilot-lands-394-ton-a380-sideways-as-storm-dennis-rages18:47
mordredgundalow: I do not want to be in that plane18:48
gundalowYes, that was equal measure of impressed/scared18:48
mordredgundalow: I suppose it underscores just how safe those things actually are- they can handle WAY more stress than they are put through18:49
sshnaidmit's kinda helicopter way of landing..18:51
*** priteau has quit IRC18:51
mordredsshnaidm: in a *very* large jet powered helicopter18:57
*** priteau has joined #openstack-ansible-sig19:18
*** priteau has quit IRC19:23
openstackgerritMerged openstack/ansible-collections-openstack master: Bump min openstacksdk version for os_network/{port_security_enabled,mtu}  https://review.opendev.org/70811919:26
*** priteau has joined #openstack-ansible-sig19:52
*** priteau has quit IRC19:57
*** priteau has joined #openstack-ansible-sig20:33
*** priteau has quit IRC20:37
*** gtema has joined #openstack-ansible-sig21:53
*** gtema has quit IRC22:00
*** spatel has quit IRC23:27
*** gtema has joined #openstack-ansible-sig23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!