*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-ansible-sig | 05:35 | |
*** gtema has joined #openstack-ansible-sig | 08:02 | |
*** gtema has quit IRC | 08:14 | |
*** gtema has joined #openstack-ansible-sig | 08:16 | |
*** gtema has quit IRC | 08:22 | |
*** dtantsur|afk is now known as dtantsur | 08:35 | |
*** owalsh^ is now known as owalsh | 10:00 | |
*** gshippey has joined #openstack-ansible-sig | 10:01 | |
*** zbr|pto is now known as zbr | 10:20 | |
*** sshnaidm|afk is now known as sshnaidm | 10:27 | |
*** holser has joined #openstack-ansible-sig | 10:33 | |
*** holser has quit IRC | 10:42 | |
*** holser has joined #openstack-ansible-sig | 10:43 | |
*** sshnaidm has quit IRC | 11:36 | |
*** sshnaidm has joined #openstack-ansible-sig | 11:40 | |
*** sshnaidm has quit IRC | 11:53 | |
*** sshnaidm has joined #openstack-ansible-sig | 11:54 | |
*** weshay is now known as weshay|ruck | 11:54 | |
*** sshnaidm has quit IRC | 13:08 | |
*** sshnaidm has joined #openstack-ansible-sig | 13:09 | |
*** sshnaidm has quit IRC | 13:10 | |
*** sshnaidm has joined #openstack-ansible-sig | 13:18 | |
*** sshnaidm has quit IRC | 13:18 | |
*** sshnaidm has joined #openstack-ansible-sig | 13:19 | |
*** sshnaidm has quit IRC | 14:15 | |
*** sshnaidm has joined #openstack-ansible-sig | 14:28 | |
*** sshnaidm has quit IRC | 14:35 | |
*** sshnaidm has joined #openstack-ansible-sig | 14:50 | |
*** sshnaidm_ has joined #openstack-ansible-sig | 14:52 | |
*** sshnaidm has quit IRC | 14:54 | |
*** sshnaidm_ is now known as sshnaidm | 14:56 | |
*** dtantsur is now known as dtantsur|afk | 17:30 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-ansible-sig | 17:35 | |
gundalow | mordred: yes you will be able to do $package_manager install ansible-base` | 19:13 |
---|---|---|
gundalow | sshnaidm: mordred `$package_manager install ansible` will install the "ACD Package" (a load of collections) and depend on ansible-base | 19:14 |
gundalow | Could someone please check what's in Gerrit against https://github.com/ansible-collection-migration/openstack.cloud see https://github.com/ansible-collections/ansible.windows/issues/6 for the type of things to watch out for | 19:15 |
sshnaidm | gundalow, in gerrit we already changed and added things | 19:16 |
sshnaidm | gundalow, this could be deleted imho | 19:16 |
gundalow | sshnaidm: Yup. Though my concern is that there may have been commits into ansible/ansible:devel since the your fork was created | 19:17 |
gundalow | I know you went through and `-1` all the OpenStack PRs in ansible/ansible | 19:17 |
gundalow | This is just a belt and braces check. | 19:18 |
gundalow | If as as group you tell me you are happy, I'm happy | 19:18 |
gundalow | :) | 19:18 |
sshnaidm | gundalow, should be fine according to history https://github.com/ansible/ansible/commits/devel/lib/ansible/modules/cloud/openstack | 19:18 |
sshnaidm | gundalow, if we missed somehow one commit, not critical.. | 19:18 |
gundalow | `migrate.py` also rewrites docs fragments, and bits of python | 19:19 |
gundalow | If it was me I'd check out both repos and check via something like meldmerge.org/ | 19:19 |
sshnaidm | gundalow, we merged and changed already enough changes to be difficult to compare :) | 19:20 |
*** holser has quit IRC | 19:20 | |
sshnaidm | gundalow, not sure what this commit means though https://github.com/ansible/ansible/commits/devel/lib/ansible/modules/cloud/openstack | 19:20 |
sshnaidm | gundalow, sorry, this one https://github.com/ansible/ansible/commit/0e46af17a54546992626074d862f598bc683c7d0#diff-241b4b84be86a9344a7d61a551a38bd0 | 19:21 |
gundalow | sshnaidm: ah, we decided to no longer have stub modules in | 19:22 |
sshnaidm | gundalow, should we port it to our repo? I see it touches _os_server_actions.py | 19:23 |
gundalow | wouldn't hurt | 19:24 |
gundalow | with that stub i someone tries to use that module Ansible will error with "This module is deprecated", once the file is removed users will get the generic "Module not found, did you typo"? | 19:24 |
sshnaidm | gundalow, ok, I see we don't have it, so that's fine :) | 19:25 |
sshnaidm | gundalow, all the rest is handled, so we're good to remove it | 19:25 |
* gundalow honestly isn't trying to make more work for you :( | 19:27 | |
sshnaidm | gundalow, no worries :) I was keeping eye on os module changes till now | 19:29 |
sshnaidm | gundalow, so got mails every time somebody tried to commit change there :D | 19:29 |
sshnaidm | gundalow, btw, this one I migrated just yesterday: https://github.com/ansible-collection-migration/containers.podman | 19:30 |
sshnaidm | gundalow, so should be fine too | 19:30 |
gundalow | sshnaidm: as in you ran migrate.py yesterday? | 19:31 |
gundalow | reminder, migrate.py does a lot more than just copy files around | 19:31 |
sshnaidm | gundalow, yeah, and committed scenario to /nwo | 19:33 |
sshnaidm | gundalow, ack, I've tested things there, all works | 19:33 |
sshnaidm | gundalow, I saw it even creates github workflow for testing migrated modules, very nice! | 19:34 |
gundalow | aye, though you can delete that GitHub action now | 19:34 |
sshnaidm | gundalow, do you know if it's possible to use ansible CI resources from different repos? | 19:37 |
mordred | sshnaidm: do we need to? we should be able to make a job that include ansible/ansible and ansible-collections-openstack and runs whatever script needs to be run | 20:01 |
mordred | gundalow: just to be supid and make sure I 100% sure know ... does $package_manager include pip? | 20:02 |
gundalow | sshnaidm: what CI resources would you like? | 20:03 |
gundalow | mordred: ansible and ansible-base will exist in PyPi | 20:03 |
mordred | gundalow: awesome. thanks! that makes me happy - I think that's great choice | 20:03 |
mordred | also - where is migrate.py ? | 20:04 |
gundalow | https://github.com/ansible-community/collection_migration/ | 20:04 |
mordred | ah - that's the thing that split collections out, yes? | 20:05 |
gundalow | yup | 20:06 |
mordred | neat. thanks! | 20:06 |
gundalow | As of Friday evening no longer needed/updated | 20:06 |
mordred | yeah. all is now split \o/ | 20:06 |
sshnaidm | gundalow, I was thinking maybe to use some resources for podman modules, but we'll talk later about it, no rush | 20:08 |
gundalow | sshnaidm: Should be doable | 20:09 |
mordred | gundalow: is there a $something to generate ACD that's runnable by us? like if we wanted to take a change to the ansible collection, generate the collection tarball, run $something to generate an ACD including our updated collection, then install the ACD we made and run tests to make sure the various things work right? | 20:09 |
sshnaidm | gundalow, great | 20:09 |
mordred | (should probably be fine - mostly trying to think ahead) | 20:10 |
sshnaidm | Interesting actually what ACD looks like | 20:10 |
mordred | yah | 20:11 |
mordred | I mean, I'm obvs mostly interested to make sure we don't break backwards compat for people accidentally | 20:12 |
gundalow | mordred: nothing runnable yet, though https://gist.github.com/abadger/1f14caded92117fbd3036842c875701c has some info | 20:16 |
gundalow | Once contributor process (CI, Ansibulbot) is working for the collections ACD is the next thing on the list | 20:17 |
gundalow | sshnaidm: example of things that has changed https://github.com/ansible-collections/kubernetes/issues/49?email_source=notifications&email_token=AAHFUDICBXPUQ7JAB2DQDWTRGVI3XA5CNFSM4LEKD4OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIZ43Q#issuecomment-596745838 | 20:19 |
mordred | gundalow: cool! I'll keep my eyes peeled - once there is something runnable I'd love to start running it over here - even if it's flaky | 20:19 |
gundalow | oh, ffs, sorry for the horrible URl | 20:20 |
mordred | gundalow: did meta/routing.yml get decided on? | 20:20 |
gundalow | mordred: yup, expect a proposal soon, then a pre-release that people can play with | 20:20 |
gundalow | mordred: I'm personally very lost on that stuff, best to ask in #ansible-devel | 20:20 |
mordred | gundalow: I'll just wait until you understand it all and can explain it to me ;) | 20:21 |
gundalow | mordred: I hope you are a patient person | 20:21 |
mordred | gundalow: mostly just forgetful - so I forget that I'm impatiently waiting. same result | 20:22 |
gundalow | :D | 20:22 |
sshnaidm | gundalow, ack, I confirmed with diff tool for podman modules | 20:23 |
sshnaidm | gundalow, what is action_groups for? https://github.com/ansible-collection-migration/openstack.cloud/blob/master/meta/action_groups.yml | 20:27 |
mordred | I had a similar question | 20:28 |
*** sshnaidm is now known as sshnaidm|afk | 20:40 | |
*** trident has quit IRC | 20:57 | |
*** trident has joined #openstack-ansible-sig | 20:58 | |
*** trident has quit IRC | 21:04 | |
*** trident has joined #openstack-ansible-sig | 21:05 | |
gundalow | sshnaidm|afk: mordred I've never seen that file before, please ask in #ansible-devel | 21:18 |
*** gshippey has quit IRC | 23:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!