| *** holser has joined #openstack-ansible-sig | 04:35 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-ansible-sig | 04:36 | |
| *** gtema has joined #openstack-ansible-sig | 06:39 | |
| *** gtema_ has joined #openstack-ansible-sig | 06:41 | |
| *** dtantsur|afk is now known as dtantsur | 07:54 | |
| *** rpittau|afk is now known as rpittau | 07:58 | |
| *** holser has quit IRC | 07:59 | |
| *** holser has joined #openstack-ansible-sig | 07:59 | |
| *** sshnaidm|afk is now known as sshnaidm | 08:52 | |
| *** priteau has joined #openstack-ansible-sig | 09:02 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952 | 09:06 |
|---|---|---|
| *** rpittau is now known as rpittau|bbl | 10:19 | |
| *** gtema_ has quit IRC | 11:22 | |
| *** gtema_ has joined #openstack-ansible-sig | 11:59 | |
| *** gtema_ has quit IRC | 12:04 | |
| *** gshippey has joined #openstack-ansible-sig | 12:19 | |
| *** rpittau|bbl is now known as rpittau | 12:21 | |
| *** zbr_ has joined #openstack-ansible-sig | 12:35 | |
| *** zbr_ has quit IRC | 12:36 | |
| *** gtema_ has joined #openstack-ansible-sig | 12:50 | |
| *** gtema_ has quit IRC | 12:53 | |
| *** gtema_ has joined #openstack-ansible-sig | 12:53 | |
| *** gtema_ has quit IRC | 13:05 | |
| mordred | sshnaidm: +2 on your changes to the tempdir patch | 13:24 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 13:25 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538 | 13:25 |
| mordred | jrosser, odyssey4me: how hard is it to test that the rename patchs there ^^ don't screw osa? | 13:31 |
| sshnaidm | mordred, seems like we need to remove "deprecate" from routing | 13:32 |
| mordred | sshnaidm: we do? what's that? | 13:32 |
| sshnaidm | and add it to every module with self.module.deprecate(...) | 13:32 |
| mordred | oh - because in 2.9 routing isn't a thing yet right? | 13:32 |
| sshnaidm | mordred, https://review.opendev.org/#/c/713056/12/meta/routing.yml | 13:32 |
| sshnaidm | mordred, well, ansible-test requires deprecation be in the documentation as well | 13:33 |
| sshnaidm | and it doesn't understand it's symlink *sigh | 13:33 |
| jrosser | mordred: i'm not sure - we've not merged the collections changes yet, and install them from the release. We need to figure out how to do depends-on there i think | 13:33 |
| mordred | sshnaidm: UGH | 13:33 |
| mordred | jrosser: nod. I'll see if i can work up a patch today | 13:34 |
| jrosser | oh right yes - wasn't it that you could not use ansible-glaxay to install from a git repo? | 13:34 |
| jrosser | which made a depends-on all kind of difficuly | 13:34 |
| jrosser | difficult* | 13:34 |
| mordred | jrosser: yea - we have to copy stuff explicitly into a dir ourselves | 13:35 |
| mordred | it'll suck | 13:35 |
| sshnaidm | mordred, I think we can do it, just adding a function to every module to check if it's using the old name, should be fine I think | 13:35 |
| *** redrobot has quit IRC | 13:39 | |
| *** openstackstatus has quit IRC | 13:53 | |
| *** openstackstatus has joined #openstack-ansible-sig | 13:53 | |
| *** ChanServ sets mode: +v openstackstatus | 13:53 | |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 13:55 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538 | 13:55 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: WIP Use stub modules for deprecated aliases https://review.opendev.org/727197 | 13:55 |
| mordred | sshnaidm: maybe something like that ^^ | 13:58 |
| sshnaidm | mordred, metadata and examples can be imported as well | 14:04 |
| sshnaidm | mordred, but idk, I'm not so fan of this way, too fragile imho | 14:05 |
| sshnaidm | just to satisfy ansible-test is kind of overhead | 14:06 |
| mordred | sshnaidm: yeah - I agree. maybe instead we should just have the migration script generate a bunch of ansible-test exclusions | 14:07 |
| sshnaidm | mordred, is server symlink to os_server, or vice versa? | 14:30 |
| mordred | sshnaidm: os_server is symlink to server | 14:32 |
| mordred | server is the real thing - os_server is just there for backwards compat | 14:32 |
| sshnaidm | mordred, I'm going to change how ansible-test works, seems like default "run all" is not a good option, let's really test only we need to test | 14:42 |
| mordred | sshnaidm: ++ | 14:42 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add template for generation of artibtrary module https://review.opendev.org/727216 | 14:53 |
| sshnaidm | gtema, mordred dtantsur odyssey4me please take a look ^ | 14:54 |
| mordred | sshnaidm: +2 with a comment | 14:57 |
| sshnaidm | try to generate something :) | 14:58 |
| sshnaidm | are there people to discuss something today in a meeting? odyssey4me dtantsur gtema mordred jrosser noonedeadpunk and all others | 15:01 |
| dtantsur | not feeling well, was planning to leave early | 15:01 |
| sshnaidm | dtantsur, ack, be healthy | 15:01 |
| dtantsur | thx | 15:01 |
| sshnaidm | please feel free to add topics for PTG: https://etherpad.opendev.org/p/openstack-ansible-modules-ptg | 15:02 |
| sshnaidm | currently we have hardly for one hour | 15:02 |
| sshnaidm | and we have 3 hours available | 15:03 |
| noonedeadpunk | drink-and-tell section can take the way more than an hour :D | 15:03 |
| sshnaidm | noonedeadpunk, yeah, seems like it will be :D | 15:03 |
| sshnaidm | and can be a main topic for this project :) | 15:03 |
| sshnaidm | also would like opinions on a structure of a standard openstack ansible module: https://review.opendev.org/727216 - would it help people not so familiar with ansible modules to create one or not | 15:05 |
| *** spatel has joined #openstack-ansible-sig | 15:05 | |
| mordred | sshnaidm: I thnik it might be helpful to nudge people towards our base class too | 15:06 |
| mordred | gtema, mnaser: https://review.opendev.org/#/c/726952/ if you get a sec (we learned a thing about the ansible-test linter) | 15:07 |
| *** dtantsur is now known as dtantsur|afk | 15:08 | |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 15:20 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538 | 15:20 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226 | 15:20 |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538 | 15:20 |
| gtema | mordred, that's nice. All this linters and pep madness (facepalm) | 15:41 |
| mordred | gtema: \o/ | 15:49 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952 | 16:03 |
| *** rpittau is now known as rpittau|afk | 16:10 | |
| *** holser has quit IRC | 16:31 | |
| *** holser has joined #openstack-ansible-sig | 16:33 | |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-ansible-sig | 16:36 | |
| *** gtema has quit IRC | 16:53 | |
| *** gtema has joined #openstack-ansible-sig | 16:54 | |
| *** gtema has quit IRC | 16:55 | |
| mordred | sshnaidm: the rename patch is green! | 17:16 |
| sshnaidm | mordred, yep, let's merge it while it's possible :) | 17:17 |
| *** priteau has quit IRC | 17:17 | |
| mordred | sshnaidm: ++ | 17:17 |
| mordred | mnaser, odyssey4me: ^^ | 17:18 |
| mordred | sshnaidm: https://review.opendev.org/#/c/727226 too | 17:18 |
| mordred | sshnaidm: now I need to go update the ansible/ansible routing.yml PR | 17:19 |
| mordred | sshnaidm: I was thinking also that maybe making a utility script that people could run on their playbooks or roles to update to the new names might be friendly | 17:19 |
| sshnaidm | mordred, yeah, a bunch of "sed"s should do the work I suppose | 17:20 |
| mordred | yeah | 17:20 |
| mordred | because we really only need to match os_server: - with the trailing : makes it easier | 17:21 |
| mordred | sshnaidm: I think also once that's in - maybe we cut a 1.0 - any other outstanding patches we should get in? | 17:21 |
| sshnaidm | mordred, no, I think we're good | 17:22 |
| sshnaidm | mordred, the renaming was only big thing I think | 17:22 |
| mordred | yeah | 17:22 |
| mordred | other things, like the base class, are impl details | 17:22 |
| sshnaidm | the new openstack module class can wait, it's just redesign, doesn't change functionality | 17:22 |
| mordred | yup | 17:22 |
| *** iurygregory has quit IRC | 17:27 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226 | 18:16 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056 | 18:16 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538 | 18:24 |
| sshnaidm | \o/ | 18:24 |
| *** iurygregory has joined #openstack-ansible-sig | 18:31 | |
| *** gshippey has quit IRC | 19:09 | |
| openstackgerrit | Monty Taylor proposed openstack/ansible-collections-openstack master: Revert "Run linters in a temp dir instead of an install" https://review.opendev.org/727400 | 19:34 |
| mordred | sshnaidm: ^^ let's see what blows up | 19:34 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411 | 19:52 |
| sshnaidm | mordred, ^^ | 20:00 |
| mordred | sshnaidm: "Remove galaxy.yml from .gitignore, because otherwise it's ignored | 20:03 |
| mordred | by ansible-test." | 20:03 |
| mordred | you're kidding | 20:03 |
| sshnaidm | mordred, oh yes | 20:03 |
| mordred | that's what you were asking about before in ansible-devel isn't it? | 20:03 |
| sshnaidm | mordred, yeah, I couldn't believe it's related | 20:03 |
| mordred | that's insane | 20:03 |
| sshnaidm | took me to understand about a half hour | 20:03 |
| mordred | welp. we'll just have to make sure we don't accidentally commit it | 20:04 |
| sshnaidm | maybe we need a test like ansible-test insanity --.. | 20:04 |
| mordred | sshnaidm: but it's ok with it if it's not in git but also not in .gitignore | 20:04 |
| sshnaidm | yeah, people can commit it just accidentally (like me) | 20:05 |
| sshnaidm | oh, we can fail before build.py if there is galaxy.yml | 20:05 |
| mordred | sshnaidm: if we remove those skip files ... | 20:07 |
| mordred | if galaxy starts running ansible-test sanity on uploads, won't that break us? | 20:07 |
| openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411 | 20:10 |
| sshnaidm | mordred, if it will run all ansible-test default tests, I think barely any collection could upload :) | 20:10 |
| mordred | sshnaidm: yeah | 20:11 |
| mordred | sshnaidm: that's not going to quite work for local dev | 20:11 |
| mordred | sshnaidm: because you'll have a galaxy.yml after the first time you run a buid, so on a second invocation it'll fail | 20:12 |
| mordred | even though build.py will rebuild it | 20:12 |
| mordred | I think if we want to do that we might need to have build.py unlink it and then check to see if git says there are changes | 20:12 |
| mordred | or something | 20:12 |
| * sshnaidm always forgets people run tox locally | 20:13 | |
| sshnaidm | mordred, but we copy it every time to different place | 20:14 |
| sshnaidm | to random tmpdir | 20:14 |
| sshnaidm | oh, it's different.. | 20:15 |
| mordred | yeah | 20:15 |
| sshnaidm | I think I'll come to it tomorrow.. the brain is fully ansible-tested now | 20:15 |
| mordred | sshnaidm: good life choice | 20:15 |
| sshnaidm | will figure out something tomorrow.. | 20:16 |
| sshnaidm | mordred, cool, thanks, seems like a big step behind :) | 20:16 |
| *** sshnaidm is now known as sshnaidm|afk | 20:18 | |
| mordred | \o. | 20:21 |
| *** holser has quit IRC | 22:11 | |
| *** spatel has quit IRC | 22:32 | |
| *** spatel has joined #openstack-ansible-sig | 23:53 | |
| *** spatel has quit IRC | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!