| holtgrewe | Hi, I'm looking at the ansible collection for openstack management. It looks like some things are missing, such as network RBAC. What's the right workflow to contribute if I'm interested to add this? | 09:42 |
|---|---|---|
| jrosser | holtgrewe: https://docs.openstack.org/contributors/code-and-documentation/index.html | 10:18 |
| holtgrewe | jrosser, thanks. Does everything start with a ticket on the story board? | 10:19 |
| jrosser | not necessarily, and there is a split of bugs being reported in storyboard and launchpad | 10:19 |
| holtgrewe | OK... If I "only" have a patch with an added feature, what's usually the first step? | 10:20 |
| jrosser | i would get set up with your accounts and contributor agreement, then push the patch to gerrit | 10:20 |
| jrosser | here is the current work in progress for the ansible collection https://review.opendev.org/q/project:openstack%252Fansible-collections-openstack+status:open | 10:21 |
| jrosser | maybe check that https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 isnt the RBAC stuff you need :) | 10:22 |
| holtgrewe | ohh, there already is a patch set for neutron_rbac_policy | 10:22 |
| holtgrewe | I'd be interested in helping to get this merged. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896 What would be the best way to help out there? | 10:28 |
| noonedeadpunk | holtgrewe: um, eventually it seems that it's not passing CI | 14:05 |
| noonedeadpunk | So I would say you can try fetching the code, fix issues there and push it back. Eventually you can also edit current patch I guess | 14:06 |
| holtgrewe | noonedeadpunk, thanks. I'm not the original author. I have no experience with gerrit. I'll look into the issues first and then ask where to push it ;-) thanks. | 14:07 |
| noonedeadpunk | So you will anyway need gerrit account setup | 14:08 |
| noonedeadpunk | after that you will be able to do `git clone https://opendev.org/openstack/ansible-collections-openstack; cd ansible-collections-openstack; git review -d 799896` to retireve change locally | 14:09 |
| noonedeadpunk | you can run tests locally with tox | 14:09 |
| sshnaidm | holtgrewe, seem my last comment in the patch, it's an issue with test https://review.opendev.org/c/openstack/ansible-collections-openstack/+/799896/comment/001fb9c2_a66d567c/ | 14:10 |
| holtgrewe | thanks for all the pointers, I'll start by digging into the gerrit setup | 14:11 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!