| sshnaidm|afk | gtema, do you know why object test fail with "msg": "Could not determine container access for ACL: None." ? https://d683bf64be57725b07bf-9eecc5f5b2306eceabd25b057aacac8a.ssl.cf5.rackcdn.com/825291/9/check/ansible-collections-openstack-functional-devstack-ansible-new_sdk/a23de6e/controller/logs/test_output_log.txt | 01:12 |
|---|---|---|
| gtema | sshnaidm|afk, will have a look today | 05:36 |
| gtema | sshnaidm: as I see it should have been always like that. test is not setting any ACL and the code is explicitly not handling this as "public" container - even before | 08:05 |
| gtema | of course I might oversee something, but I do not see currently why it should be different | 08:06 |
| sshnaidm | hmm, that's weird it fails now then | 08:07 |
| gtema | ah wait, I might have looked to wrong test case (just greped first read_acl) | 08:08 |
| gtema | maybe the issue is None vs '' | 08:10 |
| gtema | https://review.opendev.org/c/openstack/openstacksdk/+/826993 - you might try using that | 08:14 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: WIP fix collection for new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/825291 | 08:56 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Add zuul artifact https://review.opendev.org/c/openstack/ansible-collections-openstack/+/826746 | 11:45 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add CentOS 9 tripleo job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/827066 | 12:36 |
| sshnaidm | gtema, that worked - https://review.opendev.org/c/openstack/openstacksdk/+/826993 | 12:55 |
| gtema | great | 12:55 |
| gtema | then let's merge it | 12:55 |
| sshnaidm | gtema, seems like "properties" for projects stopped to work, is it expected? https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/project.py#L36-L41 | 12:56 |
| gtema | nope, it's not that expected, but not that I would immediately say I need to turn back | 12:57 |
| gtema | nowadays all additional stuff in project comes under "options" | 13:01 |
| gtema | maybe in identity v2 it was not like that and I pretty much dropped v2 support in the cloud layer (still work through proxy) | 13:01 |
| gtema | so I would say here we might consider changing properties to options | 13:02 |
| gtema | or I can also add synonym for options to be properties for backward compat | 13:02 |
| sshnaidm | gtema, ack, let me try | 13:02 |
| sshnaidm | gtema, if it's just alias, I can do it in module itself | 13:02 |
| gtema | yeah, I would really try it this way | 13:03 |
| sshnaidm | gtema, https://linediff.com/?id=61f80ced687f4b3b738b4567 fyi | 16:23 |
| sshnaidm | no "properties" in new sdk afaiu | 16:23 |
| gtema | yupp, it was done as a "fake" composition attribute | 16:24 |
| sshnaidm | gtema, call in 3 mins | 16:27 |
| gtema | ack | 16:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!