| *** dviroel is now known as dviroel|out | 00:20 | |
| *** ysandeep|out is now known as ysandeep | 05:15 | |
| *** ysandeep is now known as ysandeep|lunch | 08:49 | |
| *** ysandeep|lunch is now known as ysandeep | 09:24 | |
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Move compute flavor info to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828108 | 10:05 |
|---|---|---|
| opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update compute service info module to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828698 | 10:09 |
| arxcruz | sshnaidm jm1 can you guys review it? ^ | 10:41 |
| sshnaidm | arxcruz, sure | 10:41 |
| sshnaidm | arxcruz, I'm not sure we need to use 'original_names': True | 10:43 |
| sshnaidm | in this case it will return ONLY old names | 10:43 |
| arxcruz | sshnaidm it will keep compatibility for example zone not change to availability_zone | 10:43 |
| sshnaidm | we can break this now, we'll release 2.0.0 | 10:44 |
| arxcruz | but it's up to you, it was something jm1 pointed | 10:44 |
| sshnaidm | in the new major version we don't need to keep backward compatibility with old sdk | 10:44 |
| sshnaidm | let's clarify it in today mtg | 10:45 |
| arxcruz | ok | 10:47 |
| jm1 | sshnaidm: if we allow to break backward compatibility then we can drop the hasattr(...'to_dict') checks as well, cant we? | 11:16 |
| *** dviroel|out is now known as dviroel | 11:26 | |
| sshnaidm | jm1, yeah, I think so.. this method exists up to stein, right? | 11:37 |
| sshnaidm | in case of keeping compatibility we can generate original_names, then regular to_dict, and then merge them - so it will include both old and new names | 11:38 |
| sshnaidm | but not sure it worth the effort | 11:38 |
| *** ysandeep is now known as ysandeep|dinner | 15:15 | |
| *** gmann is now known as gmann_afk | 15:59 | |
| *** ysandeep|dinner is now known as ysandeep | 16:12 | |
| *** gmann_afk is now known as gmann | 16:17 | |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Run jobs on stable branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/829638 | 18:12 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: DNM test jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/830263 | 18:12 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: DNM test branch jobs for collection https://review.opendev.org/c/openstack/ansible-collections-openstack/+/829668 | 18:13 |
| *** ysandeep is now known as ysandeep|out | 18:20 | |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Run jobs on stable branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/829638 | 20:44 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Run jobs on stable branch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/829638 | 21:07 |
| *** dviroel is now known as dviroel|out | 21:18 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!