| *** dviroel|biab is now known as dviroel|out | 00:20 | |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates volume for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/853749 | 01:50 |
|---|---|---|
| *** ysandeep|out is now known as ysandeep | 02:48 | |
| *** ysandeep is now known as ysandeep|afk | 03:32 | |
| *** ysandeep|afk is now known as ysandeep | 06:01 | |
| *** frenzyfriday is now known as frenzyfriday|sick | 07:50 | |
| *** ysandeep is now known as ysandeep|lunch | 08:19 | |
| *** ysandeep|lunch is now known as ysandeep | 09:46 | |
| rpittau | rcastillo: hi! do you maybe have an ETA for the release of ansible-collections-openstack 2.x.x and inclusion in Ansible 6 ? | 10:01 |
| jm1 | rpittau: hello :) we still have to port several modules but we are targeting end of the year for aoc 2.0.0 | 10:10 |
| rpittau | jm1 hey thanks for the quick reply :) | 10:11 |
| rpittau | I'm asking because with the zuul migration to Ansible 6 we unfortunately experience a breakage in our CI with the openstack.cloud module due to incompatibility with latest openstacksdk | 10:11 |
| rpittau | we're forced to pin Ansible version to 5 but not sure for how long we can do that | 10:12 |
| jm1 | rpittau: can you install aoc from git (master branch)? | 10:13 |
| jm1 | rpittau: which modules are causing issues? | 10:13 |
| rpittau | jm1: the issue is with openstack.cloud, we receive the error message "To utilize this module, the installed version of the openstacksdk library MUST be <=0.98.999." | 10:15 |
| *** dviroel|out is now known as dviroel | 11:06 | |
| jm1 | rpittau: yeah, we implemented this check to warn users about incompatibilities. the best solution depends on your use case. do you use any specific modules from aoc or just its module_utils argument spec functions? | 11:10 |
| *** ysandeep is now known as ysandeep|afk | 11:42 | |
| rpittau | jm1: we import and use openstack_cloud_from_module in our project openstack/metalsmith | 12:09 |
| *** ysandeep|afk is now known as ysandeep | 12:16 | |
| jm1 | rpittau: you are only using it here? https://opendev.org/openstack/metalsmith/src/branch/master/metalsmith_ansible/ansible_plugins/modules/metalsmith_instances.py | 12:19 |
| rpittau | jm1: correct | 12:21 |
| jm1 | rpittau: let me post a workaround.. | 12:24 |
| rpittau | jm1: great, thanks! | 12:24 |
| jm1 | rpittau: can you somehow test this? https://review.opendev.org/c/openstack/metalsmith/+/860943 | 12:41 |
| rpittau | jm1: let me see, I think we can use the revert of the ansible pin to test that | 12:43 |
| rpittau | jm1: https://review.opendev.org/c/openstack/metalsmith/+/860886 | 12:44 |
| jm1 | rpittau: can i edit your patch to test that? | 12:45 |
| rpittau | jm1: absolutely | 12:45 |
| jm1 | rpittau: ack, lets see if that works | 12:46 |
| rpittau | jm1: mmm I don't think you need to add the depends-on, it was already rebased on top of yours :) | 12:47 |
| jm1 | rpittau: omg did not see that | 12:47 |
| rpittau | jm1: no worries! And thanks a lot for your help! | 12:47 |
| jm1 | rpittau: a cleaner solution would be to implement that in aoc stable branch, but we still have old modules there using this code. once we have backported those modules (eta ca. 100 years from next year on) we could drop those hacks | 12:49 |
| jm1 | rpittau: another thing: please make sure that you really really use no other modules from ansible openstack collection when using this metalsmith module | 12:51 |
| jm1 | rcastillo, gtema: ^ we will not be able to remove those openstack_* functions from module utils. there are a looot of modules depending on this functionality. metalsmith is one, tripleo is another. the latter has dozens of modules using the openstack_* functions :/ | 13:10 |
| gtema | tl;dr - which functions is is about? | 13:10 |
| jm1 | gtema, rcastillo: openstack_* functions here https://opendev.org/openstack/ansible-collections-openstack/src/commit/41299b9666b6ab6904d5bed4823508c87df2fd8c/plugins/module_utils/openstack.py#L161 | 13:11 |
| jm1 | gtema, rcastillo: openstack_cloud_from_module | 13:12 |
| jm1 | gtema, rcastillo: openstack_module_kwargs openstack_full_argument_spec openstack_argument_spec | 13:12 |
| jm1 | gtema, rcastillo: once we ported all baremetal modules to OpenStackModule we dont use those functions anymore but we cannot drop them because else we will break others | 13:13 |
| gtema | okay, maybe at least add deprecation decorator? | 13:13 |
| jm1 | gtema: any specific decorator in mind? | 13:15 |
| gtema | smth like https://pypi.org/project/Deprecated/ | 13:16 |
| rpittau | jm1: I'll be sure to remember to not using other modules until we have version 2 of aoc at least | 13:18 |
| jm1 | gtema: looks good, will add it to my todoinalifetime list | 13:26 |
| gtema | great, list is too long to be named list that I guess | 13:27 |
| rpittau | jm1: the workaround works just fine, thanks again! | 14:34 |
| *** ysandeep is now known as ysandeep|dinner | 14:37 | |
| *** ysandeep|dinner is now known as ysandeep | 15:06 | |
| *** dviroel is now known as dviroel|lunch | 15:11 | |
| *** ysandeep is now known as ysandeep|out | 16:10 | |
| *** dviroel|lunch is now known as dviroel | 16:24 | |
| jm1 | rpittau: cool :) | 19:13 |
| *** dviroel is now known as dviroel|biab | 19:19 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!