| noonedeadpunk | gtema: hey, I was wondering about your opinion on that part of modules: https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/module_utils/openstack.py#L195-L203 To be more specific - if that is intended, that module defaults do override what's defined in clouds.yaml? | 13:59 |
|---|---|---|
| noonedeadpunk | specifically, interface part | 13:59 |
| noonedeadpunk | As I was slightly o_O when realized that interface in clouds.yaml does not have effect on behaviour of ansible modules as module defaults does silently shadow clouds.yaml | 14:00 |
| noonedeadpunk | At the same time I don't really see straightforward workaround for that | 14:03 |
| noonedeadpunk | like there's no good way to know if interface is part of the clouds.yaml in module | 14:04 |
| noonedeadpunk | except just remove default in module and have a default in SDK instead | 14:07 |
| gtema | nooedeadpunk - module doesn't really override the clouds.yaml, unless you specify those params - what means you explicitly WANT to override this | 14:46 |
| gtema | noonedeadpunk: ^^ (key stucks) | 15:11 |
| noonedeadpunk | I'm pretty sure it does... https://paste.openstack.org/show/b3u99kw9Y4Pal6kG9UCW/ | 15:15 |
| noonedeadpunk | https://paste.openstack.org/show/bcM0tPoEkADPCA7pBE42/ | 15:16 |
| noonedeadpunk | gtema: ^ | 15:16 |
| gtema | the interface default is public | 15:16 |
| noonedeadpunk | yep, and it doesn't care if you have smth else in clouds.yaml | 15:16 |
| gtema | aaah, in this sense you are right | 15:17 |
| noonedeadpunk | And your statement is true for _everything_ except interface | 15:17 |
| gtema | basic idea is that with ansible module you have possibility to override what is in clouds.yaml. Of course any sort of default here is breaking things | 15:17 |
| noonedeadpunk | But does SDK have some default for interface as well? | 15:18 |
| noonedeadpunk | As I was wondering how reasonable to keep default in collection as well? | 15:18 |
| gtema | I was having challenges to understand precisely your point, sorry | 15:18 |
| gtema | I think SDK does this is little bit more smart | 15:19 |
| gtema | trying to find the place now | 15:20 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/loader.py#L1173 is one of the places if I remember correctly | 15:21 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/defaults.json#L7 - is the default itself, which is working differently to how ansible would treat that | 15:22 |
| noonedeadpunk | But should ansible care at all about that? | 15:22 |
| gtema | I think it should be safe to drop the default for interface from ansible | 15:22 |
| noonedeadpunk | yeah, I was kinda thinking the same. Let me propose patch then and see how CI will fail dramatically :D | 15:23 |
| gtema | no, ansible should not take care, but it should give possibility to override (for the cases when config is passed and not the clouds.yaml is used) | 15:23 |
| gtema | override = set | 15:23 |
| noonedeadpunk | yes, totally, I do understand override part | 15:23 |
| noonedeadpunk | as whatever set should have prescedence over config | 15:24 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ansible-collections-openstack master: Remove default value for interface https://review.opendev.org/c/openstack/ansible-collections-openstack/+/889729 | 15:40 |
| noonedeadpunk | gtema: ^ | 15:40 |
| gtema | yupp, noticed. Thanks | 15:40 |
| noonedeadpunk | there're actually several more patches I've pushed lately, but see close to nobody around who could review them... | 15:41 |
| noonedeadpunk | like https://review.opendev.org/c/openstack/ansible-collections-openstack/+/889388 is preetty much annoying | 15:41 |
| gtema | yupp, RH pulled away so pretty much nobody left | 15:41 |
| noonedeadpunk | did they promise to return one day or just decided they're not interested anymore at all? | 15:42 |
| gtema | second afaik | 15:42 |
| noonedeadpunk | doh | 15:43 |
| gtema | and I am deep in the codegeneration experiment, which should resolve this issue, but is clearly not the simpliest thing | 15:43 |
| noonedeadpunk | annoying part, is that a rhel personal account is used to publish collection as well as openstack namespace | 15:45 |
| noonedeadpunk | in galaxy | 15:45 |
| gtema | oh, never noticed that | 15:45 |
| noonedeadpunk | so generating code is part of the problem | 15:45 |
| noonedeadpunk | *a personal account of a folk from redhat | 15:46 |
| gtema | where do you see personal account is used? | 15:46 |
| noonedeadpunk | I just know as we had couple of discussion when I wanted to publish some OSA things to galaxy | 15:46 |
| gtema | https://galaxy.ansible.com/openstack - this is not personal account | 15:47 |
| noonedeadpunk | and we ended up that if person is gone infra-root technically can decrypt secret and move somewhere | 15:47 |
| noonedeadpunk | it's created by sshnaidem | 15:48 |
| noonedeadpunk | to be specific | 15:48 |
| noonedeadpunk | and linked to his github account | 15:48 |
| gtema | I don't know how to see this from the UI | 15:49 |
| gtema | but anyway, I think in the mid term we will have here anyway a big change in everything | 15:50 |
| * noonedeadpunk hates big changes | 16:41 | |
| * noonedeadpunk finally wants some stability | 16:41 | |
| * noonedeadpunk and eat a burek with some rakija | 16:42 | |
| noonedeadpunk | btw the role I was talking during the summit: https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/889707 | 16:43 |
| gtema | big changes are necessary when code basis is big and no people left to maintain it | 16:43 |
| noonedeadpunk | * https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/878794 | 16:44 |
| noonedeadpunk | let's find ppl?:) | 16:44 |
| gtema | ok | 16:44 |
| noonedeadpunk | I can imagine kolla userbase would be interested in keeping collection alive along with osa | 16:45 |
| noonedeadpunk | the trickest thing in whole ansible stuff is the license | 16:45 |
| noonedeadpunk | as it's not apache2, but GPL iirc | 16:46 |
| noonedeadpunk | so there is also legal part to consider, if we talk about generating the code | 16:46 |
| noonedeadpunk | as you kinda switching licensing in between | 16:47 |
| gtema | Don't think there is issue with that | 16:48 |
| noonedeadpunk | there were discussion when this sig was created | 16:48 |
| noonedeadpunk | and why it's a sig and not a project | 16:48 |
| noonedeadpunk | with ptl and all governance on top | 16:49 |
| gtema | This is more or less a "replace" with new code | 16:49 |
| gtema | Not partly, but whole modules | 16:49 |
| gtema | Anyway, it is still far | 16:49 |
| * noonedeadpunk is not a lawyer | 16:50 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade at 21:00 utc, approximately an hour from now | 20:02 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade, but should return shortly | 21:00 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!