*** markvoelker has quit IRC | 00:18 | |
*** hwoarang has quit IRC | 00:39 | |
*** hwoarang has joined #openstack-ansible | 00:39 | |
*** kplant has joined #openstack-ansible | 00:44 | |
*** kplant has quit IRC | 00:49 | |
*** hwoarang has quit IRC | 00:50 | |
*** hwoarang has joined #openstack-ansible | 00:50 | |
*** sreejithp has joined #openstack-ansible | 00:56 | |
*** hwoarang has quit IRC | 01:01 | |
*** hwoarang has joined #openstack-ansible | 01:01 | |
*** CeeMac has quit IRC | 01:02 | |
*** hwoarang has quit IRC | 01:19 | |
*** hwoarang has joined #openstack-ansible | 01:25 | |
*** sreejithp has quit IRC | 01:39 | |
*** kplant has joined #openstack-ansible | 01:40 | |
*** hwoarang has quit IRC | 02:03 | |
*** hwoarang has joined #openstack-ansible | 02:03 | |
*** sreejithp has joined #openstack-ansible | 02:14 | |
*** markvoelker has joined #openstack-ansible | 02:15 | |
*** sreejithp has quit IRC | 02:22 | |
*** hwoarang has quit IRC | 02:24 | |
*** hwoarang has joined #openstack-ansible | 02:24 | |
*** dave-mccowan has joined #openstack-ansible | 02:32 | |
*** dave-mccowan has quit IRC | 02:36 | |
*** kplant has quit IRC | 02:38 | |
*** markvoelker has quit IRC | 02:49 | |
*** sreejithp has joined #openstack-ansible | 02:57 | |
*** kplant has joined #openstack-ansible | 03:06 | |
*** kplant has quit IRC | 03:11 | |
*** BjoernT has joined #openstack-ansible | 03:23 | |
*** BjoernT has quit IRC | 03:27 | |
*** BjoernT has joined #openstack-ansible | 03:29 | |
*** Talion has joined #openstack-ansible | 03:57 | |
*** hwoarang has quit IRC | 03:57 | |
*** hwoarang has joined #openstack-ansible | 03:58 | |
*** BjoernT has quit IRC | 04:01 | |
*** sreejithp has quit IRC | 04:06 | |
*** hwoarang has quit IRC | 04:08 | |
*** hwoarang has joined #openstack-ansible | 04:09 | |
*** radeks has joined #openstack-ansible | 04:16 | |
*** radeks has quit IRC | 04:17 | |
*** radeks_ has joined #openstack-ansible | 04:17 | |
*** hwoarang has quit IRC | 04:33 | |
*** hwoarang has joined #openstack-ansible | 04:33 | |
*** markvoelker has joined #openstack-ansible | 04:46 | |
*** radeks_ has quit IRC | 05:02 | |
*** markvoelker has quit IRC | 05:19 | |
*** Talion has quit IRC | 05:44 | |
*** Talion has joined #openstack-ansible | 05:44 | |
*** Talion has quit IRC | 05:46 | |
*** Talion has joined #openstack-ansible | 05:46 | |
*** hwoarang has quit IRC | 05:48 | |
*** hwoarang has joined #openstack-ansible | 05:48 | |
*** hwoarang has quit IRC | 05:53 | |
*** hwoarang has joined #openstack-ansible | 05:54 | |
*** altlogbot_0 has quit IRC | 06:29 | |
*** altlogbot_3 has joined #openstack-ansible | 06:29 | |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible-os_keystone master: Execute the keystone db setup earlier in the process https://review.opendev.org/659676 | 06:43 |
---|---|---|
*** hwoarang has quit IRC | 07:09 | |
*** hwoarang has joined #openstack-ansible | 07:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/openstack-ansible master: Imported Translations from Zanata https://review.opendev.org/658731 | 07:10 |
*** kplant has joined #openstack-ansible | 07:12 | |
*** markvoelker has joined #openstack-ansible | 07:16 | |
*** kplant has quit IRC | 07:16 | |
*** hwoarang has quit IRC | 07:19 | |
*** hwoarang has joined #openstack-ansible | 07:19 | |
*** hwoarang has quit IRC | 07:25 | |
*** hwoarang has joined #openstack-ansible | 07:25 | |
*** markvoelker has quit IRC | 07:49 | |
*** radeks_ has joined #openstack-ansible | 07:51 | |
*** sreejithp has joined #openstack-ansible | 08:02 | |
*** sreejithp has quit IRC | 08:06 | |
*** markvoelker has joined #openstack-ansible | 08:46 | |
*** markvoelker has quit IRC | 09:19 | |
*** hamzaachi has joined #openstack-ansible | 09:20 | |
*** hwoarang has quit IRC | 09:32 | |
*** hwoarang has joined #openstack-ansible | 09:32 | |
*** Talion has quit IRC | 09:47 | |
*** hwoarang has quit IRC | 10:32 | |
*** hwoarang has joined #openstack-ansible | 10:33 | |
*** markvoelker has joined #openstack-ansible | 11:15 | |
*** hwoarang has quit IRC | 11:16 | |
*** hwoarang has joined #openstack-ansible | 11:16 | |
*** hwoarang has quit IRC | 11:25 | |
*** hwoarang has joined #openstack-ansible | 11:25 | |
*** markvoelker has quit IRC | 11:50 | |
*** dave-mccowan has joined #openstack-ansible | 11:52 | |
*** hwoarang has quit IRC | 11:55 | |
*** hwoarang has joined #openstack-ansible | 11:56 | |
*** dave-mccowan has quit IRC | 12:13 | |
*** kplant has joined #openstack-ansible | 12:20 | |
*** tosky has joined #openstack-ansible | 13:05 | |
*** markvoelker has joined #openstack-ansible | 13:46 | |
*** markvoelker has quit IRC | 14:20 | |
*** adrianreza has quit IRC | 14:33 | |
*** hwoarang has quit IRC | 14:42 | |
*** hwoarang has joined #openstack-ansible | 14:43 | |
*** hwoarang has quit IRC | 14:52 | |
*** hwoarang has joined #openstack-ansible | 14:52 | |
*** Talion has joined #openstack-ansible | 15:12 | |
*** markvoelker has joined #openstack-ansible | 15:16 | |
*** hwoarang has quit IRC | 15:22 | |
*** hwoarang has joined #openstack-ansible | 15:23 | |
*** hwoarang has quit IRC | 15:42 | |
*** hwoarang has joined #openstack-ansible | 15:42 | |
*** markvoelker has quit IRC | 15:50 | |
*** sreejithp has joined #openstack-ansible | 16:03 | |
*** sreejithp has quit IRC | 16:07 | |
*** hwoarang has quit IRC | 16:33 | |
*** hwoarang has joined #openstack-ansible | 16:33 | |
*** hamzaachi has quit IRC | 16:42 | |
*** markvoelker has joined #openstack-ansible | 16:47 | |
*** hwoarang has quit IRC | 16:52 | |
*** hwoarang has joined #openstack-ansible | 16:52 | |
*** markvoelker has quit IRC | 17:20 | |
openstackgerrit | Jonathan Rosser proposed openstack/openstack-ansible master: Update to ceph-ansible 4.0.0 https://review.opendev.org/656503 | 17:47 |
*** tosky has quit IRC | 17:48 | |
*** tosky has joined #openstack-ansible | 17:49 | |
*** noonedeadpunk has joined #openstack-ansible | 18:02 | |
noonedeadpunk | folks, can you knidly vote on translations patch https://review.opendev.org/#/c/658731/ to get it merged, until futher potential bugs hasn't landed:) | 18:03 |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible master: Fix OS requirments https://review.opendev.org/661496 | 18:22 |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible master: Fix OS requirments https://review.opendev.org/661496 | 18:24 |
openstackgerrit | Merged openstack/openstack-ansible master: Imported Translations from Zanata https://review.opendev.org/658731 | 18:32 |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible master: Fix OS requirments https://review.opendev.org/661496 | 18:54 |
*** markvoelker has joined #openstack-ansible | 19:16 | |
*** pnull has joined #openstack-ansible | 19:25 | |
*** markvoelker has quit IRC | 19:50 | |
*** tosky has quit IRC | 20:18 | |
*** tosky has joined #openstack-ansible | 20:26 | |
guilhermesp | noonedeadpunk: nice, looking | 20:27 |
guilhermesp | btw, are you around noonedeadpunk ? | 20:28 |
noonedeadpunk | kinda) | 20:28 |
noonedeadpunk | although it's 11.30 pm) | 20:29 |
guilhermesp | hahaha well it is just something about your comments here https://review.opendev.org/#/c/657036/ | 20:30 |
guilhermesp | before I move on with other patches on the topic | 20:30 |
guilhermesp | I'd like to discuss quickly about your suggestions ( no worrie, it is sunday so if you prefer we can talk tomorrow ) | 20:30 |
guilhermesp | ops, actually wrong patch | 20:31 |
guilhermesp | is that one https://review.opendev.org/#/c/657029/ | 20:31 |
noonedeadpunk | it's ok) sure, we can discuss now | 20:31 |
guilhermesp | all right so | 20:31 |
guilhermesp | you suggest changing the second condition and add run_once | 20:32 |
guilhermesp | I suppose run_once would replace that second condition? | 20:32 |
guilhermesp | so we make the code simpler? | 20:32 |
noonedeadpunk | yep, sure | 20:32 |
guilhermesp | nice, I was thinking correctly then. I will test it locally and make the changes :) | 20:33 |
guilhermesp | that's is noonedeadpunk | 20:33 |
guilhermesp | that's it* | 20:33 |
noonedeadpunk | I was just referencing to ceilometer job at once, but this role has service list, that's where comment regarding intersect came from:) | 20:33 |
guilhermesp | neat | 20:33 |
guilhermesp | thx for the clarification! | 20:33 |
noonedeadpunk | btw, seems, that we have some tempest problem with octavia for a while.... was trying to locate what's wrong, but probably I should continue tomorrow... | 20:35 |
guilhermesp | yeah, I need to take a look at the integration of placement in openstack-ansible-tests to be able to unblock https://review.opendev.org/#/c/654942/ | 20:36 |
guilhermesp | that's an initial idea https://review.opendev.org/#/c/661179/1 | 20:36 |
noonedeadpunk | oh, yep, I see | 20:38 |
noonedeadpunk | I think that dependency on https://review.opendev.org/#/c/661179/1 may not work, due to the way we clone it | 20:42 |
guilhermesp | yeah, I need to figure out the best way to do it. Maybe merge that patch and then recheck tempest patch. But I need to be sure all files are modified as expected in that patch. I still have a feeling that something is missing | 20:46 |
guilhermesp | btw noonedeadpunk I saw that the other patches mnaser did he added the run_once in the main task https://review.opendev.org/#/c/657036/7/tasks/main.yml | 20:47 |
guilhermesp | for that reason I will change only glance patch to behave the same way | 20:47 |
noonedeadpunk | run_once in main task won't work afaik | 20:47 |
noonedeadpunk | but it's smth worth checking one more time | 20:48 |
guilhermesp | actually only keystone patch has run_once in main | 20:48 |
noonedeadpunk | I think that merging patch to ansible-tests in by far the only way all-in-all | 20:48 |
guilhermesp | would I expect like, running the tests locally, the first time I will see changed status and the second run, skip | 20:49 |
guilhermesp | I can do it now with keystone patch btw and see how it goes, if works, replicate to the other patches | 20:49 |
*** radeks_ has quit IRC | 20:50 | |
noonedeadpunk | I'm wondering if serial run somehow affects run_once... | 20:52 |
guilhermesp | does serial runs by default? | 20:53 |
guilhermesp | that's something I'm a bit confusing now... here we have conditions https://review.opendev.org/#/c/657038/7/tasks/main.yml, and here we just have run_once https://review.opendev.org/#/c/657036/7/tasks/main.yml | 20:53 |
guilhermesp | I'd expect a reason for that. But if we don't have a reason, we need to apply a pattern | 20:54 |
guilhermesp | to make things consistent | 20:54 |
noonedeadpunk | guilhermesp: I think it is, at least for keystone... | 20:54 |
noonedeadpunk | I'd vote for run_once, as this condition is smth not really easy to read and unerstand, while run_once is more readable and do exactly required thing (at least supposed to) | 20:56 |
guilhermesp | I'm running tests locally here. As I told ya, I'd expect this first time to be changed status and the second run, to be skip. If so, we have our answer :) | 20:56 |
noonedeadpunk | When I've checked for ceilometer - run_once didn't work for me for include - I had to place it for block and it was ok then | 20:57 |
guilhermesp | I see a run_once in mq_setup tho https://github.com/openstack/openstack-ansible-os_ceilometer/blob/bc0a2619e4065460357d42797fe54e0f1346685f/tasks/main.yml#L96 | 20:58 |
guilhermesp | maybe works because we change from include to import_tasks? | 20:59 |
noonedeadpunk | Yeah, this might be the case:) Or I just missed smth - who knows now:) | 21:00 |
guilhermesp | maybe I'd have answers soon :) | 21:00 |
logan- | The difference is run_once will run multiple times if serial is used | 21:02 |
logan- | (It will run once per serial batch) | 21:02 |
noonedeadpunk | logan-: but I think it won't if run_once is set for block.... | 21:02 |
noonedeadpunk | inside import... | 21:03 |
noonedeadpunk | Yeah, let's just wait for results:) | 21:03 |
logan- | The gate results won’t show you anything because there is only one serial batch | 21:04 |
guilhermesp | would I expect a different behavior running local with run_tests logan- ? | 21:04 |
noonedeadpunk | with run_tests - not likely, unless you've got multi node aio configured | 21:05 |
logan- | If you execute the tasks in a playbook with multiple serial batches then yes you will see a difference between those conditionals and a run_once | 21:05 |
logan- | I can build a poc playbook to show you later | 21:05 |
guilhermesp | that would be nice logan- thanks in advance | 21:05 |
guilhermesp | i'm still just wondering why some roles uses two conditionals instead of run_once like keystone | 21:06 |
guilhermesp | for both db_setup and mq_setup | 21:06 |
logan- | keystone playbook isn’t serialized right? | 21:07 |
jrosser | on the subject of serial, this has to be a bug? https://github.com/openstack/openstack-ansible/blob/master/playbooks/os-cinder-install.yml#L28 | 21:07 |
jrosser | i would expect some [ ] there | 21:07 |
logan- | Because the role itself handles serialized orchestration on certain tasks | 21:07 |
logan- | jrosser: yep I agree | 21:08 |
guilhermesp | I can't see something explicit about serial in keystone | 21:08 |
logan- | guilhermesp: yeah the playbook is not serialized so run_once is effectively the same as the conditional in that situation | 21:09 |
guilhermesp | all right by consequence the others that uses when are serialized, I just can't see this explicitly btw | 21:10 |
openstackgerrit | Jonathan Rosser proposed openstack/openstack-ansible master: Correct os-cinder-install task serialisation https://review.opendev.org/661502 | 21:14 |
Pilou | guilhermesp: besides serial, there is one difference between two conditionals and run_once: tasks could be executed on different servers | 21:14 |
guilhermesp | hum Pilou If I understood correctly, if I have tree nodes in my lb cool, run_once will take any of them, with these conditionals https://review.opendev.org/#/c/657038/7/tasks/main.yml I will pick one specific server to run the task | 21:15 |
noonedeadpunk | yep, that's true, but in this case we're delegating task, so we shouldn;t care about htis | 21:15 |
guilhermesp | lb pool* ( lb is cool anyways ) :P | 21:16 |
*** tosky has quit IRC | 21:17 | |
jrosser | "When used together with “serial”, tasks marked as “run_once” will be run on one host in each serial batch. If it’s crucial that the task is run only once regardless of “serial” mode, use when: inventory_hostname == ansible_play_hosts[0] construct." | 21:20 |
guilhermesp | that clarifies a lot jrosser thanks. But I'm just trying to point out where we identify if role X is serialized and Y is not ( e.g os_glance and os_keystone respectively ) | 21:22 |
noonedeadpunk | But once we allow deployer to override serial we probably shoudnt rely on run_once then:( | 21:25 |
jrosser | Yes there are a bunch of overrides for serial | 21:25 |
guilhermesp | that's a good point noonedeadpunk | 21:25 |
jrosser | I’m not sure if they are important for upgrades | 21:26 |
jrosser | Similarly for any reordering of tasks for db setup, I have distant memeories of comments that things are ordered as they are to handle both greenfield and upgrades OK | 21:27 |
jrosser | But I’ve not really thought about it enough to know what is right | 21:27 |
guilhermesp | to conclude my thoughts about run_once. I think executing db or mq stuff could be ok to perform in any of the nodes of the cluster. If you agree with that, I'd vote to convert the other tasks to run_once. noonedeadpunk point of allowing deployers makes run_once preferable tho | 21:32 |
*** markvoelker has joined #openstack-ansible | 21:47 | |
logan- | guilhermesp: regarding your question about what’s serialized and what’s not.. serialization is always controlled in the playbook, never in roles or tasks. In general, for these mq/db tasks, we should not use run_once since it is less efficient in many of our playbooks | 21:55 |
guilhermesp | ok logan- so, with that said then, would be better to replace run_once in keystone task to make things consistence ( noonedeadpunk just read it wrong, you said the opposite, we shoudn't use run_once since we allow override serial ) | 21:58 |
logan- | yeah if you are planning to use the same task file everywhere i would not use run_once | 22:03 |
logan- | in something like keystone where it is not serialized both of these will behave identically, in something like nova/neutron/cinder/etc, the conditional will behave more like we want than run_once | 22:04 |
guilhermesp | as I result of the discussion logan- yeah, I'd prefer to keep it consistent across all roles, since conditional will offer us more then run_once :) | 22:04 |
guilhermesp | I will change the keystone role to conditionals and see how it goes locally | 22:04 |
guilhermesp | anyways, thanks Pilou noonedeadpunk jrosser and logan- enjoy the rest of your weekend! | 22:05 |
*** noonedeadpunk has quit IRC | 22:13 | |
*** markvoelker has quit IRC | 22:20 | |
*** hwoarang has quit IRC | 22:57 | |
*** hwoarang has joined #openstack-ansible | 22:57 | |
*** hwoarang has quit IRC | 23:04 | |
*** hwoarang has joined #openstack-ansible | 23:04 | |
djhankb | If I wanted to deploy a third party driver along with my Cinder-Volume container - is there a built-in mechanism for doing so? (I am specifically wanting to use this: https://github.com/iXsystems/cinder) | 23:17 |
djhankb | I can configure a cinder-backend in the "openstack_user_config.yml" file which works perfectly if I let it fail the first time, copy the driver into the containers and then run it again. I've found that you guys have built other stuff into the system (Like Horizom custom Theme installation) and was curious if Cinder Drivers is one of them. | 23:18 |
guilhermesp | djhankb: I think that might be your case https://docs.openstack.org/openstack-ansible-os_cinder/latest/configure-cinder.html#configuring-cinder-to-use-dell-equallogic I used this one to add dell equallogic to serve as backend for the deployment. | 23:20 |
djhankb | guilhermesp: Thank you - in that case the driver is already built in to the venv: /openstack/venvs/cinder-19.0.0.0rc2/lib/python2.7/site-packages/cinder/volume/drivers/dell_emc/ps.py | 23:22 |
djhankb | what I am asking, is if there is a mechanism to copy a third party driver *into* the venv upon creation, so I don't have to manually copy the driver into the /openstack/venvs/cinder-19.0.0.0rc2/lib/python2.7/site-packages/cinder/volume/drivers/ folder manually, after the container is created. | 23:23 |
*** hwoarang has quit IRC | 23:29 | |
*** hwoarang has joined #openstack-ansible | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!