opendevreview | Jonathan Rosser proposed openstack/openstack-ansible master: Revert "set non-voting for broken tox-doc test" https://review.opendev.org/c/openstack/openstack-ansible/+/803832 | 07:51 |
---|---|---|
*** rpittau|afk is now known as rpittau | 07:52 | |
jrosser | ebbex: are you around to take a look at this? https://review.opendev.org/c/openstack/openstack-ansible/+/803041 | 09:35 |
ebbex | As luck would have it I am :) | 09:39 |
jrosser | cool - thanks.... looks like quite a blacklog of stuff to fix/merge right now | 09:42 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/victoria: Fast fix ceph-ansible bootstrap issue https://review.opendev.org/c/openstack/openstack-ansible/+/803844 | 09:47 |
opendevreview | likui proposed openstack/openstack-ansible-os_zun master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/803903 | 11:46 |
opendevreview | Merged openstack/openstack-ansible master: haproxy: decrease check interval for letsencrypt back ends https://review.opendev.org/c/openstack/openstack-ansible/+/802716 | 11:51 |
opendevreview | likui proposed openstack/openstack-ansible-os_mistral master: Replace deprecated UPPER_CONSTRAINTS_FILE variable https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/803904 | 11:51 |
opendevreview | Merged openstack/openstack-ansible master: Do not use https for metadata service with calico networking https://review.opendev.org/c/openstack/openstack-ansible/+/803041 | 11:54 |
jrosser | ebbex: another one to unblock victoria https://review.opendev.org/c/openstack/openstack-ansible/+/803844 | 12:09 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/victoria: Bump OpenStack-Ansible Victoria https://review.opendev.org/c/openstack/openstack-ansible/+/803098 | 12:30 |
opendevreview | Marcus Klein proposed openstack/openstack-ansible stable/ussuri: Backported fixes for healthcheck playbooks https://review.opendev.org/c/openstack/openstack-ansible/+/803926 | 13:44 |
opendevreview | Marcus Klein proposed openstack/openstack-ansible stable/ussuri: Backported fixes for healthcheck playbooks https://review.opendev.org/c/openstack/openstack-ansible/+/803926 | 13:45 |
kleini_ | https://review.opendev.org/c/openstack/openstack-ansible/+/803926 <- here are some backports of fixes for the healthcheck playbooks for U release. with these fixes I am able to use all healtchecks | 13:50 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-tests stable/train: Pin virtualenv version to before 16.7.11 https://review.opendev.org/c/openstack/openstack-ansible-tests/+/803930 | 13:52 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/train: Remove Debian Stable testing https://review.opendev.org/c/openstack/openstack-ansible/+/803405 | 13:53 |
*** kleini_ is now known as kleini | 14:00 | |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Set ovn hostname using nodename facts https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802134 | 14:15 |
spatel | jrosser mgariepy can we get some review and vote here? https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803798 | 14:18 |
jrosser | spatel: i did have a question about what we do for wallaby | 14:19 |
spatel | sure! | 14:20 |
jrosser | also there are lots of patches :) see the conflicts on the right hand of that page - which are real / still needed? | 14:20 |
jrosser | or are they now all squashed into 803798.... | 14:20 |
spatel | I was about to ask you how to handle them because some of duplicate because of dependency so i think i can clean up them and put reference patch | 14:21 |
spatel | let me do little clean up and then let me know how it looks | 14:21 |
spatel | I am going to remove - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802402 | 14:22 |
spatel | I believe we don't need centos-8 anymore | 14:22 |
jrosser | right - but wallaby.... it's released with centos-8 support | 14:22 |
spatel | but centos-8 will be dead in 5 month so do you think people will continue their production on non-supported OS | 14:23 |
mgariepy | what's the latest release that support centos7 ? | 14:24 |
spatel | if you think we should support for next few months then i am good, anyway we are not removing centos-8 yet but just not actively fixing stuff (too much changes going on in centos-8 and hard to keep up) | 14:24 |
spatel | centos 7.9 will be continue until 2024 | 14:25 |
jrosser | we need to decide what we do for W | 14:25 |
mgariepy | can you deploy Victoria with centos 7? | 14:25 |
spatel | no no... | 14:25 |
jrosser | are we going to backport any OVN support for any kind of centos | 14:25 |
spatel | only train release supported for centos7.x | 14:26 |
jrosser | or do we say that X is the first release that you can OVN + centos stream | 14:26 |
spatel | it will be hard to backport OVN because it need latest OS and packages which might be not available for centos7 | 14:27 |
jrosser | no i mean wallaby | 14:27 |
spatel | W would be perfect release for OVN (we have fully working code for OVN) | 14:27 |
spatel | centos-8-stream and ubuntu both working fine with OVN with OSA | 14:28 |
spatel | my goal is to run OVN in next cloud deployment so try my best to keep it up with | 14:28 |
spatel | I think we are pretty much ready to announce OVN support for OSA in next 23.1.0 (W release), let me know if anything missing | 14:30 |
spatel | OVN SSL support which i am working on so hope we can introduce in next tag because its little complicated | 14:31 |
jrosser | i have a meeting | 14:33 |
jrosser | but SSL things should generally be easier with W due to the new PKI role | 14:33 |
jrosser | but we should not be backporting features | 14:34 |
spatel | This is about SSL channel between OVN central and OVN agent (running on compute nodes) | 14:34 |
jrosser | yes, so you need certs/keys? | 14:34 |
spatel | end to end encryption for OVN | 14:34 |
spatel | Yes we have to sign every single compute node with OVN central CA to trust them | 14:35 |
jrosser | hrrm we should look carefully at that | 14:35 |
jrosser | becasue we just introduces a cluster wide CA in W | 14:35 |
jrosser | so having another in OVN is not good | 14:36 |
opendevreview | Merged openstack/openstack-ansible stable/victoria: Fast fix ceph-ansible bootstrap issue https://review.opendev.org/c/openstack/openstack-ansible/+/803844 | 14:36 |
spatel | Let me write up whole process of OVN SSL workflow and then we can see how we can tie up with existing OSA (that is why i said its little complicated, but will see) | 14:37 |
spatel | if your patch https://review.opendev.org/c/openstack/openstack-ansible/+/803041 has been merged in master then can i remove it from my Dependent-On: ? | 14:40 |
jrosser | you don't need to? | 14:41 |
spatel | hmm | 14:41 |
mgariepy | jrosser, https://review.opendev.org/c/openstack/openstack-ansible/+/803635 | 14:41 |
mgariepy | shall we merge this one instead of disabling the tests completely ? than re-add the -W when the other patch get a proper fix (https://review.opendev.org/c/openstack/openstackdocstheme/+/802758) | 14:43 |
anskiy | spatel: hey! I've checked your patch for OVN, it works, thank you. | 15:12 |
spatel | anskiy sounds good! | 15:12 |
spatel | anskiy please report any bug if you encounter anywhere.. :) | 15:47 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-lxc_hosts master: Add yum vars for centos-8-stream lxc containers https://review.opendev.org/c/openstack/openstack-ansible-lxc_hosts/+/803630 | 16:15 |
opendevreview | Merged openstack/openstack-ansible stable/stein: Remove Debian Stable testing https://review.opendev.org/c/openstack/openstack-ansible/+/803404 | 16:15 |
jrosser | ebbex: mgariepy can you look at this please https://review.opendev.org/c/openstack/openstack-ansible-tests/+/803930 | 16:18 |
*** rpittau is now known as rpittau|afk | 16:26 | |
spatel | jrosser does these merge conflict holding this patch to get merge right? https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802701 | 16:29 |
mgariepy | lgtm. | 16:30 |
jrosser | spatel: merge conficts show you which patches won't merge, if you merge the one youre looking at | 16:36 |
spatel | jrosser thinking i should merge small 1 liner patches in this mega patch and remove others - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803798 | 16:38 |
spatel | to avoid conflicts | 16:38 |
spatel | majority of them are os-neutron and related to OVN/OVS | 16:38 |
jrosser | each patch should fix one thing really | 16:38 |
jrosser | and the commit message should be really clear about what is broken / what we change / how this fixes it | 16:39 |
jrosser | otherwise it's totally difficult to look back at the history and understand whats happened | 16:39 |
jrosser | if you stack the patches up properly in os_neutron they will all be tested together | 16:39 |
jrosser | so you were going to abandon this? https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802402 | 16:40 |
spatel | I am thinking to because we already set centos-8 job for non-voting and plan to remove them | 16:41 |
jrosser | and we should abandon this https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/803368 | 16:42 |
spatel | if you think its useful then i can keep it. what do you thinking? | 16:42 |
jrosser | i kind of don't know | 16:42 |
jrosser | there are too many patches all conflicting and i don't understand which are important | 16:42 |
spatel | Lets abandon then, no point to beating dead horse | 16:43 |
spatel | going to abandon c8 job | 16:44 |
spatel | done! | 16:46 |
spatel | James isn't around but he should remove/delete this patch, we don't need this one - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/793009 | 16:47 |
spatel | jrosser any idea why its failing on calico even it has that patch part of Depends-On: (i check logs and its failing on same nova-metedata https issue, so depends-On: should be working here) | 17:00 |
spatel | https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803060 | 17:00 |
jrosser | spatel: i can't see why that is failing really | 17:30 |
jrosser | it fails inside the tempest test | 17:35 |
jrosser | spatel: also this is the thing to keep an eye on for Wallaby - this is all quite unhappy https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/798881 | 17:39 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/wallaby: haproxy: decrease check interval for letsencrypt back ends https://review.opendev.org/c/openstack/openstack-ansible/+/803955 | 17:44 |
opendevreview | Merged openstack/openstack-ansible-tests stable/train: Pin virtualenv version to before 16.7.11 https://review.opendev.org/c/openstack/openstack-ansible-tests/+/803930 | 17:44 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/victoria: haproxy: decrease check interval for letsencrypt back ends https://review.opendev.org/c/openstack/openstack-ansible/+/803956 | 17:44 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/wallaby: Do not use https for metadata service with calico networking https://review.opendev.org/c/openstack/openstack-ansible/+/803957 | 17:45 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/victoria: Do not use https for metadata service with calico networking https://review.opendev.org/c/openstack/openstack-ansible/+/803958 | 17:45 |
spatel | 80% neutron failures are because we moved all LB vips to https or broken centos-8.x stuff | 18:04 |
spatel | If we merge this patch which has that fix -https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803798 | 18:06 |
spatel | If we merge this patch which has that fix - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803798 | 18:07 |
spatel | jrosser ^^ | 18:08 |
jrosser | ok, well i guess we need to try that patch also on wallaby | 18:08 |
jrosser | so whats going on with the rest of these conflicts | 18:09 |
jrosser | like this https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802134 | 18:09 |
spatel | jrosser i don't know why its thinking its conflict may be because they are editing same file? that patch is clean and ready to merge | 18:10 |
spatel | In that conflict list, no idea what is this patch for may be just delete it - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/780579 | 18:11 |
spatel | lets delete this one also - https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/793009 | 18:11 |
jrosser | i think it's becaseu you make different edits to the zuul project file | 18:11 |
jrosser | i keep saying to stack the patches up - is that making any sense? | 18:11 |
jrosser | currently all these patches are individually against the tip of master in os_neutron | 18:12 |
spatel | what do you mean by stacking ? | 18:12 |
spatel | Like depend-On: ? | 18:12 |
jrosser | if you put them in order (rebase them on top of each other) then they will all get tested in context of each other | 18:13 |
jrosser | depends-on is to express a dependancy between two different repos | 18:13 |
jrosser | putting patches consecutively one after the other in the *same* repo means that they get tested together, in parallel | 18:13 |
jrosser | and can also merge in parallel | 18:13 |
jrosser | you won't be able to do this without resolving the merge conflicts | 18:14 |
jrosser | and if we don't do it, it's going to take a whole lot longer to merge tis | 18:14 |
jrosser | this | 18:14 |
spatel | never used rebase so that concept is little foggy for me | 18:15 |
jrosser | it's not really about rebase | 18:16 |
jrosser | it's about having patches in the same repo (os_neutron) going HEAD->patch1->patch2->patch3.... | 18:16 |
jrosser | rather than HEAD->patch1 HEAD->patch2 HEAD->patch3 | 18:16 |
jrosser | we have the second of those where all these patches are landing on HEAD | 18:17 |
jrosser | rather than on each other, and becasue several of them make conflicting changes to things like zuul.d/project.yml they cannot all merge | 18:17 |
spatel | i got your point.. | 18:17 |
jrosser | "rebase" is a git tool to change the parent of a patch | 18:18 |
jrosser | you will get a conflict that needs fixing | 18:18 |
spatel | what do you suggest to resolve this https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803798 | 18:18 |
jrosser | you can also use cherry-pick to do the same thing | 18:18 |
jrosser | i have no idea | 18:19 |
jrosser | so many depends-on | 18:19 |
jrosser | some pointing to abandoned patches | 18:19 |
jrosser | i can't understand it | 18:19 |
spatel | I am going to remove abandoned patch | 18:20 |
spatel | Reason i did abandoned because they were part of other patch that is why it looks ugly!! | 18:23 |
spatel | I am thinking to remove all these patch and create clean on... | 18:24 |
jrosser | sure - ideally as small and specific as possible | 18:24 |
jrosser | and if possible the first ones in the queue should fix the CI | 18:24 |
jrosser | make sure to put clear explanations in the commit messages | 18:25 |
spatel | +1 so lets start with this one - lets keep this one which will fix CI ( remove old centos and replace with stream + i am adding OVN job for centos-8-stream) | 18:27 |
jrosser | in your local repo make the patches one on top of each other, do it all locally | 18:27 |
spatel | I am removing all other patches.. | 18:27 |
jrosser | the submit them together | 18:27 |
jrosser | it's late here i need to go :) | 18:27 |
spatel | Thank you! lets start over again... clean way.. | 18:28 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Adding centos-8-stream job for ovs https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/802701 | 19:38 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Add support of OVN for CentOS-8-Stream https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803987 | 20:42 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Set ovn hostname using nodename facts https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803988 | 20:42 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Fix OVN metadata protocol to point https https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803989 | 20:42 |
opendevreview | Satish Patel proposed openstack/openstack-ansible-os_neutron master: Use list of cluster member for ovn ml2 agent to directly connect https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/803990 | 20:42 |
admin1 | just checking if you guys know .. ( no one answered in the keystone channel ) .. do you know of a way to restric domain admins to only users and projects and not give them access to networks, flavors etc | 20:42 |
spatel | jrosser i figured out how to stack patches together, I wasn't aware of it until you point out. I am going to abandon all other individual patches | 20:44 |
spatel | admin1 may be possible with policy.yml | 20:53 |
opendevreview | Jonathan Rosser proposed openstack/openstack-ansible stable/train: Remove Debian Stable testing https://review.opendev.org/c/openstack/openstack-ansible/+/803405 | 22:02 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_murano stable/train: Remove Debian jobs https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/803995 | 22:55 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_murano stable/ussuri: Remove Debian jobs https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/803996 | 22:57 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_murano stable/victoria: Remove Debian jobs https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/803997 | 22:58 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_murano stable/wallaby: Remove Debian jobs https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/803998 | 22:58 |
opendevreview | Ian Wienand proposed openstack/openstack-ansible-os_murano master: Remove Debian jobs https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/803999 | 22:59 |
admin1 | is it possible to add a custom endpoint /backend to haproxy role ? | 23:06 |
admin1 | found it | 23:12 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!