*** odyssey4me is now known as Guest104 | 00:45 | |
*** odyssey4me is now known as Guest105 | 00:52 | |
*** odyssey4me is now known as Guest124 | 04:02 | |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Drop hosts file distribution tasks https://review.opendev.org/c/openstack/openstack-ansible/+/809521 | 04:56 |
---|---|---|
*** arxcruz|pto is now known as arxcruz | 07:40 | |
*** odyssey4me is now known as Guest139 | 08:03 | |
*** odyssey4me is now known as Guest140 | 08:27 | |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_glance master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_glance/+/809635 | 11:39 |
noonedeadpunk | jrosser: does this makes any sense to you? ^ | 11:40 |
noonedeadpunk | decided to ask before spawning same thing across roles | 11:40 |
noonedeadpunk | damn, I wonder what we can do with this https://paste.opendev.org/show/809405/ | 13:18 |
noonedeadpunk | this is caused when you try to override requirements SHA | 13:18 |
noonedeadpunk | I'd say we should put there openstack_release instead of the requirements_git_install_branch https://opendev.org/openstack/openstack-ansible-repo_server/src/branch/master/tasks/repo_install_constraints.yml#L26 | 13:19 |
jrosser | noonedeadpunk: i think i put a thing in where you could locally host the requirements file in the deploy host for this | 13:23 |
noonedeadpunk | yeah but for this you would need to change requirements_git_repo | 13:25 |
noonedeadpunk | but the thing is that it is soooo not obious, that if you overriden requirements_git_install_branch you must run repo_server | 13:25 |
noonedeadpunk | otherwise things will fail | 13:26 |
jrosser | oh yes, thats totally not obvious :/ | 13:26 |
noonedeadpunk | well, another idea is to add smth like block/rescue around https://opendev.org/openstack/ansible-role-python_venv_build/src/branch/master/tasks/python_venv_wheel_build.yml#L106-L125 and for example include or just copy/paste code from repo_server | 13:27 |
noonedeadpunk | that would be a bit weird though | 13:27 |
jrosser | i think i was considering what you'd need to do for OSA W release with master Magnum, for example | 13:28 |
noonedeadpunk | or at least add some extra step when venv_rebuild=true | 13:28 |
jrosser | then you could pre-stage the master SHA of requirements on the deploy host | 13:29 |
noonedeadpunk | yeah that is neat actually | 13:29 |
jrosser | but this is really un-obvious and you have to kind of know what to do up front | 13:29 |
noonedeadpunk | also you don't need to contact opendev for each venv that is built | 13:30 |
noonedeadpunk | which improves performance for sure | 13:30 |
jrosser | yeah, so this also was to fix CI failures too | 13:30 |
jrosser | but also needs to make some kind of sense outside CI | 13:30 |
noonedeadpunk | well, we can stage requirements conditionally as well ofc | 13:31 |
noonedeadpunk | not sure what's best thing to do here tbh. But I kind of like idea that requirements is cached, so I'm more thinking about the way to update file if it's missing on repo server | 13:34 |
noonedeadpunk | but the way this can be done are kind of weird with regards to python_venv_build role which thinks that file is always there | 13:35 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_aodh master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_aodh/+/809704 | 13:54 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_aodh master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_aodh/+/809704 | 13:57 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_glance master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_glance/+/809635 | 13:58 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_barbican master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/809706 | 14:00 |
spatel | noonedeadpunk what is the validity if these new PKI certs? 10 years? | 14:19 |
noonedeadpunk | yep | 14:20 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_blazar master: Refactor galera_use_ssl behaviour https://review.opendev.org/c/openstack/openstack-ansible-os_blazar/+/809746 | 14:24 |
spatel | thanks | 14:41 |
jrosser | noonedeadpunk: i think that python_venv_build only assumes that the requirements file is always there because thats the var we pass to it | 14:55 |
jrosser | but yeah, this is a kind of higher level problem than any one of the roles | 14:56 |
jrosser | as the needed functions are spread around in different places | 14:56 |
noonedeadpunk | yeah... | 15:12 |
noonedeadpunk | so maybe solution with var that can be adjusted is good idea after all | 15:12 |
noonedeadpunk | at least ppl will be aware of consequences if they decide to use it | 15:12 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!