| *** odyssey4me is now known as Guest822 | 00:38 | |
| *** frenzy_friday is now known as frenzyfriday|ruck | 04:36 | |
| *** anbanerj is now known as frenzyfriday|ruck | 07:00 | |
| *** odyssey4me is now known as Guest925 | 09:22 | |
| *** dviroel|afk is now known as dviroel | 11:25 | |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-plugins master: Add ssh_keypairs role https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/825113 | 14:09 |
|---|---|---|
| opendevreview | James Denton proposed openstack/openstack-ansible-ops master: Update MNAIO for Focal https://review.opendev.org/c/openstack/openstack-ansible-ops/+/824486 | 14:32 |
| noonedeadpunk | #startmeeting openstack_ansible_meeting | 15:00 |
| opendevmeet | Meeting started Tue Jan 18 15:00:23 2022 UTC and is due to finish in 60 minutes. The chair is noonedeadpunk. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'openstack_ansible_meeting' | 15:00 |
| noonedeadpunk | #topic rollcall | 15:00 |
| noonedeadpunk | o/ | 15:00 |
| mgariepy | hey | 15:02 |
| damiandabrowski[m] | hey! | 15:02 |
| jrosser | hello | 15:02 |
| noonedeadpunk | #topic office hours | 15:02 |
| noonedeadpunk | We did pretty good job on moving things to plugs! | 15:03 |
| noonedeadpunk | *plugins | 15:03 |
| noonedeadpunk | The thing we miss now is proper CI testing of what we have there | 15:03 |
| jrosser | there must be something "simple" we can use there in place of the tests repo | 15:03 |
| jrosser | does anyone have experience with molecule? | 15:04 |
| noonedeadpunk | While leveraging some standart ansible bootstraping | 15:04 |
| noonedeadpunk | to ensure versions are same and all stuff is in place | 15:04 |
| noonedeadpunk | not really. very basic only | 15:04 |
| noonedeadpunk | I actually was thinking about even more simple things:) like a playbook/role inside tests that will do just functional testing | 15:05 |
| noonedeadpunk | like we do for config_template. | 15:05 |
| noonedeadpunk | But maybe molecule is indeed better | 15:05 |
| noonedeadpunk | but I guess we still need the way to start jobs and make it in single place | 15:08 |
| jrosser | i'm concerned with things like the PKI role that we have no test coverage and they are critical | 15:09 |
| jrosser | well, we test it in an AIO, but thats not checking all the things in ansible-role-pki are not broken | 15:09 |
| noonedeadpunk | yes, I agree we need some kind of "functional" testing anyway | 15:10 |
| noonedeadpunk | I wonder if we can just limit things to tox considering we still run integrated pre-step (which does all bootstrapping) | 15:11 |
| jrosser | yes - i mentioned before making some sort of exit point in the existing stuff | 15:12 |
| jrosser | then perhaps call {{ role_name }}/tests/main.yml | 15:13 |
| noonedeadpunk | yeah | 15:13 |
| noonedeadpunk | I agree here | 15:13 |
| noonedeadpunk | Sounds good for me. | 15:13 |
| noonedeadpunk | I can't promise I will have time during this week to look into that though | 15:13 |
| jrosser | though i remember that including tasks / playbooks based on a var name is kind of hard | 15:13 |
| jrosser | ^ playbook | 15:14 |
| noonedeadpunk | but we have project name in zuul vars? | 15:14 |
| noonedeadpunk | but yeah, we run shell script actually (gate-check-commit) | 15:14 |
| noonedeadpunk | But I think it's smth solvable tbh | 15:15 |
| jrosser | ok | 15:15 |
| noonedeadpunk | A had a quick look at https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/825113 and it looks good. | 15:17 |
| jrosser | there are some things i need to add but yes the guts of it is there | 15:18 |
| jrosser | and i've had it working here in a POC way, now i need to rework os_nova in my AIO to use it for real | 15:18 |
| noonedeadpunk | I guess we need to draw some line to which extent we push things to plugins repo. Do we consider it as sandbox? | 15:19 |
| jrosser | i think it is a great place as a sandbox, and somewhere to get POC code like this tested in zuul with zero effort | 15:19 |
| jrosser | we can in parallel decide if we need a new repo / top level role | 15:20 |
| jrosser | perhaps this role is similar enough to PKI role that it should be external | 15:20 |
| jrosser | but for sure the mq/db setup stuff should stay in plugins, so there is a line to draw somewhere | 15:20 |
| jrosser | perhaps based on re-usability | 15:21 |
| damiandabrowski[m] | it's also not so clear for me, when something should be placed in -ops repo, and when in -plugins | 15:22 |
| damiandabrowski[m] | for ex. we're going to put journald-remote in '-plugins' but repos like grafana or elk are placed in '-ops' | 15:23 |
| jrosser | for ops repo we don't really provide any warranty that stuff works | 15:23 |
| jrosser | it's best effort, or example code | 15:23 |
| noonedeadpunk | Actually that's good question I was thinking about. | 15:23 |
| noonedeadpunk | Tbh I think that journald code should probably be located also in -ops | 15:23 |
| noonedeadpunk | but to make it re-usable we need to do huge work on ops repo to make it collection as well | 15:24 |
| noonedeadpunk | which probably would be great thing to do | 15:24 |
| jrosser | maybe the ops repo is also kind of an incubator | 15:25 |
| jrosser | and there is an argument that ELK and MNAIO are mature enough to factor out | 15:25 |
| damiandabrowski[m] | so maybe we should define what warranty we want to provide for sandbox/POC things in plugins repo :D | 15:27 |
| damiandabrowski[m] | but I don't have any vision how should it work :/ | 15:27 |
| jrosser | i think it is down to expectations | 15:28 |
| jrosser | we have an ELK stack in our prod environment deployed from the ops repo | 15:28 |
| jrosser | but i know we have to maintain/fix that ourselves to keep it being useful | 15:28 |
| jrosser | thats different to OSA, where the expectation is that you can raise a LP bug and someone will triage/fix stuff thats broken | 15:29 |
| noonedeadpunk | Tbh I see ops as incubator more but we need to tranform it to smth re-usable (collection) to make it usable that way | 15:30 |
| jrosser | we should talk about the qdrouterd role | 15:33 |
| jrosser | it still blocks the stable branch centos-8 removal and i have no time to look at it currently | 15:33 |
| jrosser | a possibility is that we remove the depends-on and when the centos-8 removal happens, infra would probably force-push the patches to address zuul job errors | 15:34 |
| noonedeadpunk | hm, yes | 15:36 |
| noonedeadpunk | IIRC there was an issue with functional jobs in general... | 15:40 |
| jrosser | right | 15:40 |
| noonedeadpunk | I will try to look into there this week. If not, let's just disable test for it... | 15:40 |
| jrosser | something was odd with the glance-nfs ones and i decided to backport the integrated test rather than sink more time into the functional ones | 15:40 |
| jrosser | maybe a good time to make a reminder that contributors are always welcome :) | 15:41 |
| noonedeadpunk | oh, btw, about that. | 15:43 |
| noonedeadpunk | I pushed a patch to drop sub-osa groups which were made per-roles https://review.opendev.org/c/openstack/project-config/+/824230 | 15:43 |
| noonedeadpunk | They actually had some ppl I never knew, but also permissions for johnsom for os_octavia and some more repo.... | 15:45 |
| johnsom | That was courtesy access as I was the Octavia PTL. | 15:46 |
| johnsom | I am not really active there anymore, so it's not a problem if you remove it. | 15:47 |
| noonedeadpunk | it's anyway great that you're always around and ready to help) | 15:47 |
| johnsom | I try. grin | 15:47 |
| noonedeadpunk | so I'm more about that we add ppl we know/trust as osa cores if they want to rather then maintain per-role ACLs | 15:48 |
| johnsom | Definitely would be easier to audit/keep on top of | 15:49 |
| noonedeadpunk | jrosser: wdyt? | 15:50 |
| jrosser | i'm happy to add people | 15:51 |
| jrosser | and also reducing the complexity in the ACL is good otherwise it will rot | 15:51 |
| noonedeadpunk | ofc worth writing emails to the effected ppl.... | 15:51 |
| jrosser | like it had done | 15:51 |
| noonedeadpunk | it did... | 15:51 |
| noonedeadpunk | ok, awesome then | 15:52 |
| noonedeadpunk | I kind of doubt it will add active contributors though :( | 15:52 |
| noonedeadpunk | Also Release-Candidate label is placed on top of that change as I was sooo lazy to add it to every role ACL which I wanted to drop... | 15:56 |
| noonedeadpunk | *Backport-Candidate | 15:57 |
| jrosser | speaking of release, we are probably due a point release | 15:57 |
| noonedeadpunk | yes, I was just checking what we have on stable branches to run bumps | 15:57 |
| jrosser | i think that the nova ssh config is the only major problem we had in the X release | 15:57 |
| noonedeadpunk | would be nice to have though https://review.opendev.org/q/topic:%22cherrypick-combine-filter-recursion-b4njjwtez2%22+(status:open) | 16:00 |
| noonedeadpunk | but yeah rest seems to be centos-8 drop so can be ignored | 16:01 |
| noonedeadpunk | I think the only question for X - should we do bugfix (24.0.1) or minor (24.1.0) release? I'd say this bugfix and next can be minor... | 16:02 |
| damiandabrowski[m] | bugfix is fine for me but I don't have a strong opinion here | 16:03 |
| noonedeadpunk | the question here is that we ususally say that first point release is when it's known to be safe for upgrades | 16:04 |
| noonedeadpunk | with current stable/xena I'd say it is. But still I'd way for another 2 weeks before doing point release | 16:05 |
| noonedeadpunk | s/point/minor/ | 16:05 |
| noonedeadpunk | oh, and we're out of time :) | 16:05 |
| noonedeadpunk | #endmeeting | 16:05 |
| opendevmeet | Meeting ended Tue Jan 18 16:05:41 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:05 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-18-15.00.html | 16:05 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-18-15.00.txt | 16:05 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/openstack_ansible_meeting/2022/openstack_ansible_meeting.2022-01-18-15.00.log.html | 16:05 |
| jrosser | current stable/xena breaks cold migration though | 16:09 |
| jamesdenton | hi all | 16:18 |
| jrosser | o/ hello | 16:20 |
| *** dviroel is now known as dviroel|lunch | 16:21 | |
| damiandabrowski[m] | hey! | 16:21 |
| jamesdenton | *wave* | 16:22 |
| *** dviroel|lunch is now known as dviroel | 17:19 | |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Implement variable: tempest_endpoint_type https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825156 | 18:13 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Do not redefine variables with their default values in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825157 | 18:21 |
| damiandabrowski[m] | do You know how can I avoid merge conflict in these changes? :/ | 18:23 |
| opendevreview | Merged openstack/openstack-ansible-os_zun stable/xena: Enable recursion in combine() filter https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/824416 | 18:36 |
| jrosser | damiandabrowski[m]: it's becasue i think you submit them both relative to the head of master | 18:41 |
| jrosser | and they change very similar parts of the code | 18:41 |
| jrosser | so if you arrange the patches in your local tree to be HEAD -> patch1 -> pactch2 and then run git-review, they will appear stacked one on top of the other (direct dependancy chain) in gerrit | 18:42 |
| damiandabrowski[m] | it's true, i have ~10 tempest changes to upload, they do not depend on each other, but most of them change some parts of tempest.conf.j2 | 18:44 |
| damiandabrowski[m] | ahh, so git-review will create separate change for each commit? that's clever | 18:45 |
| damiandabrowski[m] | so should I abandon these changes now and start the process from scratch, according to Your suggestions? | 18:45 |
| jrosser | you can just rebase one of the on top of the other locally | 18:46 |
| opendevreview | Merged openstack/openstack-ansible stable/ussuri: Remove CI jobs for centos-8 https://review.opendev.org/c/openstack/openstack-ansible/+/824572 | 18:46 |
| jrosser | (or cherry-pick) and fix up whatever merge conflicts you get | 18:46 |
| jrosser | then re-run git review | 18:46 |
| jrosser | becasue the change-id in the commit message will stay the same everything will be ok from gerrit POV | 18:46 |
| jrosser | it only cares about the change id | 18:46 |
| damiandabrowski[m] | i can't rebase them because of the merge conflict(at least not from gerrit UI) | 18:48 |
| damiandabrowski[m] | but I'll try cherry-picking them locally | 18:48 |
| damiandabrowski[m] | thanks! | 18:48 |
| opendevreview | Merged openstack/openstack-ansible stable/ussuri: Remove periodic jobs for extended-maintainance ussuri branch https://review.opendev.org/c/openstack/openstack-ansible/+/824573 | 18:52 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Do not redefine variables with their default values in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825157 | 18:55 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Implement variable: tempest_endpoint_type https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825156 | 18:55 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Deprecate unnecessary variables https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825159 | 18:55 |
| damiandabrowski[m] | i still see merge conflict there, but 'relation chain' has appeared | 18:58 |
| damiandabrowski[m] | is it ok now or I messed something up? | 18:58 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Rename [orchestration] section to [heat_plugin] in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825163 | 19:36 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: do not include [*-feature-enabled] sections in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825164 | 19:36 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible master: Remove test_volumes_backup tests https://review.opendev.org/c/openstack/openstack-ansible/+/825165 | 19:43 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible master: Remove tempest.api.volume.admin.test_multi_backend test https://review.opendev.org/c/openstack/openstack-ansible/+/825166 | 19:43 |
| *** dviroel is now known as dviroel|out | 21:26 | |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Deprecate unnecessary variables https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825159 | 22:55 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Do not redefine variables with their default values in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825157 | 23:10 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Implement variable: tempest_endpoint_type https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825156 | 23:12 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: Rename [orchestration] section to [heat_plugin] in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825163 | 23:12 |
| opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-os_tempest master: do not include [*-feature-enabled] sections in tempest.conf https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/825164 | 23:12 |
| damiandabrowski[m] | sorry for the spam, i added a second patchset to the first change in relation chain because tests were failing, so then i had to rebase all other changes in this chain | 23:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!