Monday, 2022-08-01

*** ysandeep|out is now known as ysandeep02:08
*** ysandeep is now known as ysandeep|afk03:40
*** ysandeep|afk is now known as ysandeep05:20
*** frickler_pto is now known as frickler05:35
*** akahat_ is now known as akahat05:39
*** ysandeep is now known as ysandeep|afk06:51
*** ysandeep|afk is now known as ysandeep07:18
jrosser_morning07:49
*** ysandeep is now known as ysandeep|lunch07:50
noonedeadpunkhey o/07:55
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Remove neutron agents from ironic env.d file  https://review.opendev.org/c/openstack/openstack-ansible/+/85169907:57
noonedeadpunkI think we need to merge xena stuff and merge bump to unblock yoga https://review.opendev.org/q/parentproject:openstack/openstack-ansible+branch:%255Estable/xena+status:open08:37
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_manila stable/xena: Create backends when running against manila_share  https://review.opendev.org/c/openstack/openstack-ansible-os_manila/+/84799309:02
*** ysandeep|lunch is now known as ysandeep09:40
opendevreviewMerged openstack/openstack-ansible stable/xena: Set minimum and maximum microversions for manila api  https://review.opendev.org/c/openstack/openstack-ansible/+/85047811:18
*** dviroel_ is now known as dviroel11:45
*** ysandeep is now known as ysandeep|afk12:23
*** anskiy1 is now known as anskiy12:23
* jrosser_ stares hard at ironic role, kind of big mess here12:57
mrfHi! Can i use other node diferent than a controller for deploy openstack with ansible?13:28
mrflike a deployment node?13:28
jrosser_mrf: absolutely yes13:28
jrosser_i would recommend this too for a production deployment13:29
noonedeadpunkjrosser_: btw, do you recall stuff we did to pass requiest-id from haproxy and leave it the same to be able to track down request?13:29
noonedeadpunkI just hardly recall that part13:29
jrosser_hmm13:29
mrfthanks @jrosser_13:29
jrosser_i can't remember doing that for haproxy - definatley in the ELK stack stuff though13:29
noonedeadpunkI either dreamed about it or clean forgot...13:30
noonedeadpunkAs trying to map requests betweeen incoming to haproxy and to uwsgi13:30
jrosser_mrf: the only thing you need for the deploy host is to be able to ssh to the targets, you can have a bastion or WAN link or whatever else in the way, and you also don't have to use br-mgmt for it, you can have a separate deplyoment/OOB network if you want13:31
jrosser_noonedeadpunk: theres some stuff here about logging headers https://www.haproxy.com/blog/haproxy-log-customization/13:33
jrosser_i don't recall seeing anything like that in standard OSA13:33
*** ysandeep|afk is now known as ysandeep13:33
noonedeadpunkhuh, where I have taken this from....13:39
noonedeadpunkmaybe some PR we never merged...13:39
mrfnote: when you use a controller as deployment node the etc/hosts file got redundant entries (doubled) 13:44
noonedeadpunkwell, then basically you should set `openstack_host_manage_deploy_hosts_file: false`... But we likely can be smarter there13:45
mrfanyway im going to move the deployment to a dedicated host to prevent that , just info for you that duplicated entries happens13:46
jrosser_noonedeadpunk: can you try something like `ansible -m debug -a var=group_names utility_all` for me? i'm surprised at what what prints in my lab env14:04
jrosser_like this for one of them https://paste.opendev.org/show/brjquwupiONwR7GKnonJ/14:04
noonedeadpunksure, sec14:04
jrosser_it's like it's printed the groups to do with everything on the LXC host, rather than just the `utility_all` grou14:06
noonedeadpunkhuh, that's interesting indeed14:09
jrosser_we have conditionals on group_names all over the place14:09
noonedeadpunkso I have that indeed https://paste.openstack.org/show/buQHhZoqOsUn82aiEKOz/14:09
noonedeadpunkactually, I had spotted such weird behaviour when mentioning belongs_to several times on container_skel level14:10
noonedeadpunklike here https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/env.d/utility.yml#L25-L2614:11
noonedeadpunkso basically, utility is added to all shared-infra_containers14:11
noonedeadpunkeventually, we kind of asked for this?14:11
jrosser_taking the example of `operator_containers`, it looks like there are conflicting views from14:15
jrosser_`ansible-inventory -i inventory/dynamic_inventory.py --list` and `ansible-inventory -i inventory/dynamic_inventory.py`14:15
jrosser_^ `--graph`14:15
jrosser_--list shows something like i expect, --graph shows something that looks more like `group_names`14:15
noonedeadpunkI wonder if --list just do not iterate over groups where another groups are mentioned as children14:16
noonedeadpunkeventually I'm messing with inventory quite a bit to get AZs working and there was even idea to re-think how are we doing things, and isntead of using "dynamic inventory" just generate static one (as yaml?) and pass it instead...14:18
jrosser_reason i started looking at this is i am messing with ironic14:18
jrosser_and all of the 3 different types of ironic container are members of all the grous14:18
jrosser_so the conditional logic in the role is just completely hopeless14:18
jrosser_and then i was very surprised to see how many things were actually in group_names14:19
jrosser_of course the ironic env.d could be just wrong, but then i looked at utility to sanity check14:19
noonedeadpunkwell, it's highly likely that utility also wrong...14:23
noonedeadpunkOr we did some mistake in patching dynamic_inventory, or it was jsut like that for quite some time14:23
opendevreviewMerged openstack/openstack-ansible stable/xena: Let git choose the branch when cloning a repo  https://review.opendev.org/c/openstack/openstack-ansible/+/85155214:26
jrosser_well, dynamic inventory scripts are basically deprecated now14:43
jrosser_i might investigate turning ours into a plugin14:44
*** frenzyfriday|rover is now known as frenzyfriday|rover|lunch15:01
*** melwitt_ is now known as melwitt15:11
jrosser_from openstack_inventory.json this doesnt look right https://paste.opendev.org/show/b37rvrjn3An3UTlEz2rx/15:23
noonedeadpunkbasically, we just need inventory-manage.py, that would generate changes to openstack_inventory. And if we can switch json to yml....15:29
noonedeadpunkbut worth discussion indeed15:30
noonedeadpunkmaybe jsut turn to the plugin15:30
jrosser_yeah i am seeing super wierd things here in an AIO15:30
jrosser_i deleted compute-infra_containers { ..... } section from openstack_inventory.json completely15:31
jrosser_then re-ran the dynamic inventory script, and it is put back like this https://paste.opendev.org/show/bPKfAZuGZSvsBNlE7HFZ/15:32
jrosser_with children: being empty rather than `aio1-host_containers`15:32
noonedeadpunkwhaaaat15:34
noonedeadpunkbrrrr15:34
jrosser_i know :(15:34
noonedeadpunktbh this is last thing I wanted to touch, but it seems indeed we need to do smth with it15:39
jrosser_it is wierd - some of these things come back with children: populated15:43
jrosser_this is quite a good debugging angle i think, remove these sections and see why generate.py wants to put them back15:44
noonedeadpunkWell, for me it indeed was belongs_to  in container_skel. So when I placed there more general group, hosts were added to all subgroups of this groups as well15:45
noonedeadpunk(or smth like that)15:45
noonedeadpunkand I ended up on having az1_cinder_volume as a part of whole az1 hosts plus their subgroups (like az1_nova_compute, az1_neutron_l3_agent, etc)15:47
noonedeadpunk(this doesn't make sense when I write it this way)15:47
*** frenzyfriday|rover|lunch is now known as frenzyfriday|rover15:51
*** dviroel is now known as dviroel|lunch16:22
*** ysandeep is now known as ysandeep|out16:26
jrosser_this looks suspicious https://github.com/openstack/openstack-ansible/blob/master/osa_toolkit/generate.py#L217-L21916:45
jrosser_and perhaps duplicate of https://github.com/openstack/openstack-ansible/blob/master/osa_toolkit/generate.py#L397-L39916:48
jrosser_well not duplicate, just wrong16:48
*** dviroel|lunch is now known as dviroel17:24
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Do not create {hostname}-host_containers group as child of other containers  https://review.opendev.org/c/openstack/openstack-ansible/+/85176417:41
jrosser_noonedeadpunk: maybe something like that ^ ...... i don't see a good case for that code to be there17:42
opendevreviewJonathan Rosser proposed openstack/openstack-ansible master: Do not create {hostname}-host_containers group as child of other groups  https://review.opendev.org/c/openstack/openstack-ansible/+/85176417:43
noonedeadpunkjrosser_:  won't it drop possibility to limit actions only against containers on provided controller?17:45
jrosser_there is also a top level group aio1-host_containers17:45
jrosser_which is pretty unclear atm how that is created in the inventory17:45
jrosser_well thats not what i mean17:47
jrosser_it's created here https://github.com/openstack/openstack-ansible/blob/master/osa_toolkit/generate.py#L397-L39917:47
jrosser_but how it is populated is less clear17:47
jrosser_actually thats wrong - ignore me :(17:47
jrosser_you could be right - the patch will show. It's hard doing this in an AIO because some things only happen kind of one-shot17:48
jrosser_it looks OK tbh18:00
noonedeadpunkhuh, interesting. I would likely need to try and see what's there. Btw another interesting thing, is that I inventory-manage doesn't really show all groups18:28
noonedeadpunkI occured on super strange things that were not shown there but debug play was doing what's expected... But I messed up with env.d there so wasn't really raising any disturbance18:29
noonedeadpunkfeel quite sick today tbh... So really can hardly think...18:31
noonedeadpunkwhat I'm super concerned about is how these one-time things happen18:32
noonedeadpunkfwiw, all lxc jobs are red for 85176418:32
noonedeadpunkhttps://zuul.opendev.org/t/openstack/build/053da6fd3614472c96a87086bc125651/log/job-output.txt#927318:33
noonedeadpunkseems we use host_containers for ssh plugin18:33
noonedeadpunkbut don't see such direct reference in connection plugin...18:35
jrosser_yeah i see how thats broken18:46
jrosser_it's because all_containers references a list of things like `identity_hosts`18:47
jrosser_oops 18:48
jrosser_it's because all_containers references a list of things like `identity_containers`18:48
jrosser_before my change `identity_containers` has hosts: [] and children: [ "aio1-host_containers" ]18:50
jrosser_so this all feels really messed up18:50
jrosser_by cleaning up the stuff to do with child groups a bit, it seems to show that groups like identity_containers don't actually contain any hosts18:51
jrosser_anyway it's late here and i'll look some more tomorrow18:51
jrosser_those lxc jobs are failing because this returns no hosts https://opendev.org/openstack/openstack-ansible/src/branch/master/playbooks/containers-lxc-create.yml#L1718:52
*** dviroel is now known as dviroel|out21:26
*** anskiy1 is now known as anskiy21:45

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!