| opendevreview | Merged openstack/openstack-ansible master: Bump OpenStack-Ansible for Zed release https://review.opendev.org/c/openstack/openstack-ansible/+/867618 | 01:24 |
|---|---|---|
| opendevreview | James Denton proposed openstack/openstack-ansible master: Set keepalived branch to master https://review.opendev.org/c/openstack/openstack-ansible/+/867757 | 05:07 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Set keepalived branch to master https://review.opendev.org/c/openstack/openstack-ansible/+/867757 | 08:00 |
| *** dviroel|out is now known as dviroel|rover | 11:12 | |
| kleini | noonedeadpunk, https://opendev.org/openstack/openstack-ansible-ceph_client/src/branch/master/tasks/ceph_auth_extra_compute.yml#L94 <- can that 0 index be problematic, if I have multiple entries in ceph_extra_confs and only the second one applies to both previous tasks as it only has secret_uuid defined? | 11:38 |
| kleini | https://paste.opendev.org/show/bYoHFHNwqeLym8VdTxE8/ | 11:38 |
| noonedeadpunk | sry, quite in rush with internal stuff now, cant' really dig in | 11:39 |
| noonedeadpunk | but yes, it will check only first element indeed | 11:40 |
| noonedeadpunk | But I'm not sure how to fix it now. As somehow getting current loop index is needed | 11:41 |
| jrosser | kleini: i am also totally busy with $dayjob so not really completely understanding the problem | 12:10 |
| jrosser | but if you need to iterate over two lists at the same time there is this https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_loops.html#with-together | 12:10 |
| kleini | Was just a general question. Have already an idea how to fix that. | 12:26 |
| opendevreview | Merged openstack/openstack-ansible master: Set keepalived branch to master https://review.opendev.org/c/openstack/openstack-ansible/+/867757 | 12:55 |
| jamesdenton | ^^ ++ thanks | 13:28 |
| noonedeadpunk | sure, thanks for fixing it:) | 13:50 |
| noonedeadpunk | I thought that 7.0.0 is latest one | 13:50 |
| jamesdenton | :) | 13:53 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-os_ironic master: Update ironic documentation https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/867547 | 14:43 |
| *** frenzy_friday is now known as frenzy_friday|food | 14:45 | |
| opendevreview | Marcus Klein proposed openstack/openstack-ansible-ceph_client master: Use correct index of previous task results https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/867809 | 15:08 |
| noonedeadpunk | kleini: I wonder if it would be better understandable / readable if replace with loop: https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_loops.html#with-indexed-items | 15:20 |
| noonedeadpunk | but yeah, maybe it's good as is! | 15:20 |
| kleini | noonedeadpunk: I was not able to get the when conditionals working with loop. The task was not executed at all any more. No skip, just nothing. Task title and that was all. | 15:23 |
| noonedeadpunk | huh | 15:24 |
| kleini | Is Ansible different in 2.10 vs what the documentation states as latest? Is something with loop behavior changed in Ansible within OpenStack-Ansible? | 15:26 |
| noonedeadpunk | um, not sure. We haven't changed anything for sure in addition | 15:32 |
| kleini | noonedeadpunk: https://paste.opendev.org/show/bGRY7LI7sTBcgetrCQTk/ <- can you tell me what is wrong with that? when running that only the title "debug" appears and nothing else. | 15:32 |
| *** frenzy_friday|food is now known as frenzy_friday | 15:33 | |
| noonedeadpunk | mmm... let me play a bit with that example | 15:34 |
| noonedeadpunk | kleini: switch when to `"'lala' in item"` | 15:37 |
| noonedeadpunk | or well | 15:37 |
| kleini | https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_conditionals.html#using-conditionals-in-loops <- the first example from this chapter works as expected | 15:37 |
| noonedeadpunk | this loop does a bit different thing | 15:37 |
| kleini | try to skip one entry of the loop and the other not. this is what we need within ceph_auth_extra_compute.yml. I was not able to find a working solution. I am sorry! | 15:38 |
| noonedeadpunk | kleini: Um, does it work? | 15:39 |
| noonedeadpunk | https://paste.openstack.org/show/bYlRRbgW3bSEMvbM4ycl/ | 15:39 |
| kleini | that looks good | 15:41 |
| noonedeadpunk | Just you raise KeyError when having item.lala is defined | 15:41 |
| noonedeadpunk | instead you should check for key in dict | 15:41 |
| noonedeadpunk | So I switched to `"'lala' in item"` | 15:41 |
| noonedeadpunk | and that's it | 15:41 |
| kleini | can you paste it please? | 15:42 |
| kleini | I still don't get it... | 15:42 |
| noonedeadpunk | https://paste.openstack.org/show/bHL05CZNBE7IPXR9pj2l/ | 15:42 |
| kleini | hmm too easy | 15:43 |
| noonedeadpunk | But you can leave this as is at the end of the day if you like current patch more | 15:43 |
| noonedeadpunk | Sorry I dissapointed you :D | 15:43 |
| kleini | Ansible documentation tells me to use loop. So I will do it that way and change my review. | 15:43 |
| kleini | I am not dissapointed. I am very thankful, you found a working solution! | 15:44 |
| noonedeadpunk | well. We I guess we would need to have a huge re-work of our stuff as we rarely use loops | 15:45 |
| noonedeadpunk | So this one doesn't matter after all | 15:45 |
| kleini | Will test the change tomorrow and then change the review. It is too late for me today. | 15:45 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-os_ironic master: Update ironic documentation https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/867547 | 17:33 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-os_ironic master: Update ironic documentation https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/867547 | 17:57 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-os_ironic master: Update ironic documentation https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/867547 | 18:10 |
| opendevreview | Jonathan Rosser proposed openstack/openstack-ansible-os_ironic master: Update ironic documentation https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/867547 | 18:22 |
| *** rgunasekaran_ is now known as rgunasekaran | 18:32 | |
| jrosser | \o/ | 18:49 |
| jrosser | oh | 18:50 |
| jrosser | sooo many attempts to make that pass | 18:50 |
| *** dviroel|rover is now known as dviroel|rover|afk | 21:16 | |
| *** cloudnull1 is now known as cloudnull | 22:29 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!