jrosser | good morning | 06:59 |
---|---|---|
noonedeadpunk | o/ | 07:34 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/880038 | 07:56 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_murano master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/879974 | 07:56 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_magnum master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/879970 | 07:57 |
noonedeadpunk | I think I should start looking at nova role now.... I feel like I'm gonna regret that | 08:53 |
opendevreview | Merged openstack/openstack-ansible master: Change the order of horizon-back map entry https://review.opendev.org/c/openstack/openstack-ansible/+/880089 | 09:26 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Delegate compute wait tasks to service_setup_host https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/880139 | 09:32 |
noonedeadpunk | i kinda wonder what sense does this condtion make https://opendev.org/openstack/openstack-ansible-os_nova/src/branch/master/tasks/main.yml#L286 | 09:39 |
jrosser | would be nice to include a step to cleanup all these openrc files from places they are not supposed to be | 09:39 |
noonedeadpunk | and what was the intention behind it | 09:39 |
noonedeadpunk | jrosser: I'm not sure it was ever executed | 09:39 |
noonedeadpunk | unless you have disabled auto-discovery | 09:39 |
noonedeadpunk | but then I think it will just fail, as cell discovery runs _after_ this task | 09:39 |
noonedeadpunk | in CI it's always skipped | 09:40 |
noonedeadpunk | But also, computes do report back on their startup | 09:40 |
noonedeadpunk | I probably need to ask nova folks if there's any need in such thing at all.... | 09:41 |
noonedeadpunk | ok, we have things right. Yeah, maybe I should clean up openrcs there as well, but it might be tricky. Like on bare metal it will drop openrc that should be there... | 09:54 |
damiandabrowski | noonedeadpunk: regarding your comment "can we add also length verification, so that empty/null wasn't treated as True here?" | 10:56 |
damiandabrowski | do you know any wise way to ensure that variable is not null and not empty string using only one filter? | 10:56 |
damiandabrowski | (because you can't use length filter on null value) | 10:56 |
noonedeadpunk | `is truthy`? | 10:56 |
noonedeadpunk | but it's test, not filter | 10:57 |
damiandabrowski | works like a charm, thanks ;) | 10:57 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 | 11:43 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible master: Serve security.txt directly from haproxy https://review.opendev.org/c/openstack/openstack-ansible/+/880110 | 11:44 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Move online_data_migrations to post-setup https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/880147 | 11:50 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 | 11:51 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 | 12:18 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible master: Serve security.txt directly from haproxy https://review.opendev.org/c/openstack/openstack-ansible/+/880110 | 12:18 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Stop gathering local software_versions for services https://review.opendev.org/c/openstack/openstack-ansible/+/880150 | 12:19 |
noonedeadpunk | I wonder how dramatically this will fail ^ | 12:23 |
damiandabrowski | https://review.opendev.org/c/openstack/openstack-ansible/+/880091 | 12:31 |
damiandabrowski | i have no idea why tempest fails for upgrade jobs there :/ | 12:31 |
damiandabrowski | it doesn't look related to the reason why original patch was implemented | 12:31 |
noonedeadpunk | yeah, it indeed doesn't look like related | 12:37 |
noonedeadpunk | both failed on tempest after upgrade | 12:37 |
opendevreview | Merged openstack/openstack-ansible master: Swith to tracking stable/2023.1 for upstream services https://review.opendev.org/c/openstack/openstack-ansible/+/878235 | 12:45 |
damiandabrowski | noonedeadpunk: I'm a bit confused, do you know why at the beginning of upgrade job we do: `export UPGRADE_SOURCE_BRANCH=stable/yoga` | 13:01 |
damiandabrowski | but then, during run_upgrade.sh i see: "Running Upgrade from Zed to 2023.1" | 13:01 |
noonedeadpunk | I know | 13:04 |
noonedeadpunk | https://review.opendev.org/c/openstack/openstack-ansible/+/879884/6/scripts/gate-check-commit.sh | 13:05 |
noonedeadpunk | Probably I could do that as standalone patch... But there's some logic to fix upgrade scripts that's not so easy to de-couple | 13:07 |
noonedeadpunk | so right now we're testing upgrades from Y | 13:07 |
damiandabrowski | ah ok, I'll try to perform Y->master upgrade locally to find out what's going on with https://review.opendev.org/c/openstack/openstack-ansible/+/880091 | 13:11 |
noonedeadpunk | recent patches are passing it just in case | 13:11 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible master: Revert "Skip haproxy with setup-infrastructure for upgrades" https://review.opendev.org/c/openstack/openstack-ansible/+/880091 | 14:48 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Move online_data_migrations to post-setup https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/880147 | 16:22 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_cinder master: Move online data migrations to post-restart step https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/880210 | 17:06 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_cinder master: Move online data migrations to post-restart step https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/880210 | 17:09 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible master: Stop gathering local software_versions for services https://review.opendev.org/c/openstack/openstack-ansible/+/880150 | 17:12 |
noonedeadpunk | can we land this? https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/879856 | 17:18 |
noonedeadpunk | also another vote needed for https://review.opendev.org/c/openstack/openstack-ansible-os_adjutant/+/879859 - it's not merged on master so can't self-vote | 17:19 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_magnum master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/879970 | 17:23 |
damiandabrowski | done | 17:25 |
damiandabrowski | ehh, i was able to perform Y->master upgrade locally without any issues :| | 17:25 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Update api-paste to enable healthcheck https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/864422 | 17:27 |
opendevreview | Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/880038 | 17:27 |
noonedeadpunk | https://review.opendev.org/c/openstack/openstack-ansible/+/880150 is soooo freaking scary.... | 18:16 |
noonedeadpunk | But I actually don't see why we might need any of these dropped steps... | 18:18 |
noonedeadpunk | The only confusing thing, is that we have ANSIBLE_FORCE_HANDLERS=True https://opendev.org/openstack/openstack-ansible/src/branch/master/scripts/openstack-ansible.rc#L57 | 18:19 |
noonedeadpunk | So in case if upgrade check will fail - all handlers will execute and restart service while it should not be restarted | 18:20 |
noonedeadpunk | But that worth a follow-up patch | 18:20 |
noonedeadpunk | damiandabrowski: https://review.opendev.org/c/openstack/openstack-ansible/+/871189 seems to be in conflict merge now | 18:30 |
noonedeadpunk | seems like this is the last bit for separated config? | 18:31 |
damiandabrowski | yeah, but I'm waiting to merge security.txt changes because it will be another merge conflict | 18:31 |
damiandabrowski | yup :D | 18:31 |
noonedeadpunk | ++ | 18:31 |
noonedeadpunk | they're blocked by https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 from what I see | 18:32 |
opendevreview | Damian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 | 18:38 |
opendevreview | Merged openstack/openstack-ansible-os_adjutant stable/yoga: Switch back to use constrained Django version https://review.opendev.org/c/openstack/openstack-ansible-os_adjutant/+/879859 | 19:04 |
opendevreview | Merged openstack/openstack-ansible-os_designate master: Adopt project_info fetch to collection 2.0 https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/879986 | 19:53 |
opendevreview | Merged openstack/openstack-ansible-os_trove master: Adopt project_info fetch to collection 2.0 https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/879987 | 19:54 |
opendevreview | Merged openstack/openstack-ansible-os_designate master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/879960 | 19:58 |
BobZAnnapolis | Hopefully a simple newbie issue. . . on machine1, when standing up an aio, openstack-ansible setup-hosts picks up the dynamic inventory json file in /etc/openstack_deploy just fine for localhost; for some reason, on machine2 (the deployment machine), for a multinode deployment, running setup-hosts still thinks it is installing just to localhost, almost feels like there is a step missing, or we missed, in the se | 20:40 |
jrosser | BobZAnnapolis: for a multnode deployment you need to create your own /etc/openstack_deploy/openstack_user_config.yml, which would be something like the examples here https://github.com/openstack/openstack-ansible/tree/master/etc/openstack_deploy | 20:43 |
jrosser | and you would not use scripts/bootstrap-aio.sh at all | 20:44 |
jrosser | there is also a tool, scripts/inventory-manage.py which you can use to inspect or manipulate the inventory | 20:45 |
opendevreview | Merged openstack/openstack-ansible-os_trove master: Ensure service is restarted on unit file changes https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/880042 | 21:50 |
opendevreview | Merged openstack/ansible-role-systemd_mount stable/yoga: Ensure systemd-udev is installed for gluster https://review.opendev.org/c/openstack/ansible-role-systemd_mount/+/879174 | 22:04 |
opendevreview | Merged openstack/openstack-ansible-rabbitmq_server stable/xena: Switch rabbitmq repo back to packagecloud https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/879856 | 23:08 |
opendevreview | Merged openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 | 23:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!