Wednesday, 2023-04-12

jrossergood morning06:59
noonedeadpunko/07:34
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/88003807:56
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_murano master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_murano/+/87997407:56
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_magnum master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/87997007:57
noonedeadpunkI think I should start looking at nova role now.... I feel like I'm gonna regret that08:53
opendevreviewMerged openstack/openstack-ansible master: Change the order of horizon-back map entry  https://review.opendev.org/c/openstack/openstack-ansible/+/88008909:26
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Delegate compute wait tasks to service_setup_host  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/88013909:32
noonedeadpunki kinda wonder what sense does this condtion make https://opendev.org/openstack/openstack-ansible-os_nova/src/branch/master/tasks/main.yml#L28609:39
jrosserwould be nice to include a step to cleanup all these openrc files from places they are not supposed to be09:39
noonedeadpunkand what was the intention behind it09:39
noonedeadpunkjrosser: I'm not sure it was ever executed09:39
noonedeadpunkunless you have disabled auto-discovery09:39
noonedeadpunkbut then I think it will just fail, as cell discovery runs _after_ this task09:39
noonedeadpunkin CI it's always skipped09:40
noonedeadpunkBut also, computes do report back on their startup09:40
noonedeadpunkI probably need to ask nova folks if there's any need in such thing at all....09:41
noonedeadpunkok, we have things right. Yeah, maybe I should clean up openrcs there as well, but it might be tricky. Like on bare metal it will drop openrc that should be there...09:54
damiandabrowskinoonedeadpunk: regarding your comment "can we add also length verification, so that empty/null wasn't treated as True here?"10:56
damiandabrowskido you know any wise way to ensure that variable is not null and not empty string using only one filter?10:56
damiandabrowski(because you can't use length filter on null value)10:56
noonedeadpunk`is truthy`?10:56
noonedeadpunkbut it's test, not filter10:57
damiandabrowskiworks like a charm, thanks ;)10:57
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/88008811:43
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible master: Serve security.txt directly from haproxy  https://review.opendev.org/c/openstack/openstack-ansible/+/88011011:44
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Move online_data_migrations to post-setup  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/88014711:50
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/88008811:51
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/88008812:18
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible master: Serve security.txt directly from haproxy  https://review.opendev.org/c/openstack/openstack-ansible/+/88011012:18
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: Stop gathering local software_versions for services  https://review.opendev.org/c/openstack/openstack-ansible/+/88015012:19
noonedeadpunkI wonder how dramatically this will fail ^12:23
damiandabrowskihttps://review.opendev.org/c/openstack/openstack-ansible/+/88009112:31
damiandabrowskii have no idea why tempest fails for upgrade jobs there :/12:31
damiandabrowskiit doesn't look related to the reason why original patch was implemented12:31
noonedeadpunkyeah, it indeed doesn't look like related12:37
noonedeadpunkboth failed on tempest after upgrade12:37
opendevreviewMerged openstack/openstack-ansible master: Swith to tracking stable/2023.1 for upstream services  https://review.opendev.org/c/openstack/openstack-ansible/+/87823512:45
damiandabrowskinoonedeadpunk: I'm a bit confused, do you know why at the beginning of upgrade job we do: `export UPGRADE_SOURCE_BRANCH=stable/yoga`13:01
damiandabrowskibut then, during run_upgrade.sh i see: "Running Upgrade from Zed to 2023.1"13:01
noonedeadpunkI know13:04
noonedeadpunkhttps://review.opendev.org/c/openstack/openstack-ansible/+/879884/6/scripts/gate-check-commit.sh13:05
noonedeadpunkProbably I could do that as standalone patch... But there's some logic to fix upgrade scripts that's not so easy to de-couple13:07
noonedeadpunkso right now we're testing upgrades from Y13:07
damiandabrowskiah ok, I'll try to perform Y->master upgrade locally to find out what's going on with https://review.opendev.org/c/openstack/openstack-ansible/+/88009113:11
noonedeadpunkrecent patches are passing it just in case13:11
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible master: Revert "Skip haproxy with setup-infrastructure for upgrades"  https://review.opendev.org/c/openstack/openstack-ansible/+/88009114:48
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Move online_data_migrations to post-setup  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/88014716:22
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_cinder master: Move online data migrations to post-restart step  https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/88021017:06
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_cinder master: Move online data migrations to post-restart step  https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/88021017:09
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible master: Stop gathering local software_versions for services  https://review.opendev.org/c/openstack/openstack-ansible/+/88015017:12
noonedeadpunkcan we land this? https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/87985617:18
noonedeadpunkalso another vote needed for https://review.opendev.org/c/openstack/openstack-ansible-os_adjutant/+/879859 - it's not merged on master so can't self-vote17:19
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_magnum master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/87997017:23
damiandabrowskidone17:25
damiandabrowskiehh, i was able to perform Y->master upgrade locally without any issues :|17:25
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Update api-paste to enable healthcheck  https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/86442217:27
opendevreviewDmitriy Rabotyagov proposed openstack/openstack-ansible-os_sahara master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_sahara/+/88003817:27
noonedeadpunkhttps://review.opendev.org/c/openstack/openstack-ansible/+/880150 is soooo freaking scary....18:16
noonedeadpunkBut I actually don't see why we might need any of these dropped steps...18:18
noonedeadpunkThe only confusing thing, is that we have ANSIBLE_FORCE_HANDLERS=True https://opendev.org/openstack/openstack-ansible/src/branch/master/scripts/openstack-ansible.rc#L5718:19
noonedeadpunkSo in case if upgrade check will fail - all handlers will execute and restart service while it should not be restarted18:20
noonedeadpunkBut that worth a follow-up patch18:20
noonedeadpunkdamiandabrowski: https://review.opendev.org/c/openstack/openstack-ansible/+/871189 seems to be in conflict merge now18:30
noonedeadpunkseems like this is the last bit for separated config?18:31
damiandabrowskiyeah, but I'm waiting to merge security.txt changes because it will be another merge conflict18:31
damiandabrowskiyup :D 18:31
noonedeadpunk++18:31
noonedeadpunkthey're blocked by https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/880088 from what I see18:32
opendevreviewDamian Dąbrowski proposed openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/88008818:38
opendevreviewMerged openstack/openstack-ansible-os_adjutant stable/yoga: Switch back to use constrained Django version  https://review.opendev.org/c/openstack/openstack-ansible-os_adjutant/+/87985919:04
opendevreviewMerged openstack/openstack-ansible-os_designate master: Adopt project_info fetch to collection 2.0  https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/87998619:53
opendevreviewMerged openstack/openstack-ansible-os_trove master: Adopt project_info fetch to collection 2.0  https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/87998719:54
opendevreviewMerged openstack/openstack-ansible-os_designate master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/87996019:58
BobZAnnapolisHopefully a simple newbie issue. . . on machine1, when standing up an aio, openstack-ansible setup-hosts picks up the dynamic inventory json file in /etc/openstack_deploy just fine for localhost; for some reason, on machine2 (the deployment machine), for a multinode deployment, running setup-hosts still thinks it is installing just to localhost, almost feels like there is a step missing, or we missed, in the se20:40
jrosserBobZAnnapolis: for a multnode deployment you need to create your own /etc/openstack_deploy/openstack_user_config.yml, which would be something like the examples here https://github.com/openstack/openstack-ansible/tree/master/etc/openstack_deploy20:43
jrosserand you would not use scripts/bootstrap-aio.sh at all20:44
jrosserthere is also a tool, scripts/inventory-manage.py which you can use to inspect or manipulate the inventory20:45
opendevreviewMerged openstack/openstack-ansible-os_trove master: Ensure service is restarted on unit file changes  https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/88004221:50
opendevreviewMerged openstack/ansible-role-systemd_mount stable/yoga: Ensure systemd-udev is installed for gluster  https://review.opendev.org/c/openstack/ansible-role-systemd_mount/+/87917422:04
opendevreviewMerged openstack/openstack-ansible-rabbitmq_server stable/xena: Switch rabbitmq repo back to packagecloud  https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/87985623:08
opendevreviewMerged openstack/openstack-ansible-haproxy_server master: Allow haproxy role to create security.txt file  https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/88008823:11

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!