Friday, 2024-09-20

gokhangood morning noonedeadpunk 07:44
noonedeadpunko/07:48
gokhanwe are deploying osa 29.0.2, on skyline it is doing yarn rebuild on repo hosts. it seems it needs to install yarn and dependencies and make package on skyline container. because it can't find the /openstack/src/skyline-console when installing python venv packages 07:48
gokhanhttps://opendev.org/openstack/openstack-ansible-os_skyline/src/branch/master/defaults/main.yml#L138-L14307:49
noonedeadpunkso there's option to build or not build yarn07:50
noonedeadpunkhttps://opendev.org/openstack/openstack-ansible-os_skyline/src/branch/master/defaults/main.yml#L38-L4107:51
noonedeadpunkso if you are to use `skyline_console_git_install_branch` being set to a specific tag rather then SHA - it will just install from pypi07:51
jrosseris there a bug there with the skyline install (i.e works in AIO but not multinode)?07:53
jrossergokhan: it's always good to link to a paste of the actual error you get07:53
noonedeadpunk++07:54
noonedeadpunkI've installed skyline on 29.0.0 only on multinode and it worked nicely07:54
jrosserah ok07:55
noonedeadpunkbut can imagine that sha bump could switch skyline from tag to sha07:55
jrosserit just sounded like there was something getting being shared between repo and skyline container through /openstack07:55
noonedeadpunknot really: https://opendev.org/openstack/openstack-ansible/src/tag/29.0.2/inventory/group_vars/skyline_all/source_git.yml#L2407:55
jrosserwhich would not be good for multinode07:55
noonedeadpunkoh, well, I didn't try that on metal07:56
noonedeadpunkon multinode07:56
noonedeadpunkbut the thing is that it should not be building yarn when version is set to a tag07:57
gokhanI rerun again and share logs 07:57
gokhanjrosser, https://paste.openstack.org/show/bsN0MDnZysRQveCDyhPz/08:06
gokhanit seems we need make shared /openstack/src/skyline-console on repo containers 08:06
gokhanskyline_console_yarn_build is true 08:16
kleini_regarding ANSIBLE_INJECT_FACT_VARS=True: I doubt, this can be fixed as "ansible_architecture" is used in prometheus collection: https://github.com/prometheus-community/ansible/blob/main/roles/node_exporter/vars/main.yml#L908:26
gokhannoonedeadpunk, jrosser for quick workaround I changed skyline_console_yarn_setup_host to inventory_host and it worked 08:35
noonedeadpunkkleini: yeah, true... then you're right about ANSIBLE_INJECT_FACT_VARS :(08:39
noonedeadpunkeventually if you're running fresh enough osa - you can have /etc/openstack_deploy/user.env file and set `export ANSIBLE_INJECT_FACT_VARS=True` there08:40
noonedeadpunkto store all in-tree08:40
kleiniokay, trying to make reviews for openstack-ansible-ops documentation08:40
noonedeadpunkgokhan: oh, ok, that can be a valid bug for sure08:59
noonedeadpunkgokhan: is it the same if you don't supply `-e skyline_console_yarn_build=yes`?09:08
noonedeadpunkbut yeah, I kinda see that logic does not add up in some cases09:09
noonedeadpunkit really looks like I haven't thought through the case with repo_host and wheels build enabled09:10
noonedeadpunkcould be the reason why `skyline_console_yarn_build` is expected to be False by default09:11
noonedeadpunkgokhan: but actually it's interesting, as in your case you do skip wheels build, but with that code goes through path if wheels build is reuqired09:15
noonedeadpunkas you really fully skip wheels despite `-e venv_wheels_rebuild=yes`09:16
noonedeadpunkI will try to check on that, but smth looks off in the deployment09:43
noonedeadpunkas ofc if no wheels are avalable but role expects for them to be present - it will fail09:43
gokhannoonedeadpunk, skyline git install branch is master and it makes  skyline_console_yarn_build=yes, we do not need to run with skyline_console_yarn_build=yes. I will make it to be installed with shared repo. 11:14
noonedeadpunkgokhan: but why are wheels build are actually skipped ?11:34
noonedeadpunkI also wonder how exact same flow does pass in our CI: https://zuul.opendev.org/t/openstack/build/637d3f28a5f5416eae1a44effc183e6c/log/job-output.txt#17641-1769211:37
noonedeadpunkthough, we also do skip building wheels there11:37
noonedeadpunkwhat actually breaks behaviour potenitally - is `-e venv_wheels_rebuild=yes` where there're actually no wheels11:38
gokhanhow https://zuul.opendev.org/t/openstack/build/637d3f28a5f5416eae1a44effc183e6c/log/job-output.txt#17688 worked ? how skyline console buildable dir is reched on skyline container, it is on repo container 11:42
gokhannoonedeadpunk, wheels built is not skipped if we run with -e venv_wheels_rebuild=yes. ı think it is working as expected  11:54
gokhanalso it is very slow to write anything on /var/ww/repo/. I am trying to make buildable skyline console package under /var/ww/repo/11:55
noonedeadpunk`Including python_venv_wheel_build tasks` is skipped in your paste11:58
noonedeadpunkand paste was with `-e venv_wheels_rebuild=yes`11:59
noonedeadpunkwhich meens no wheels are built11:59
gokhanoh yes you are right, it is skipped 12:02
gokhaniwhy hypervisor name is registered as computename.openstack.local ? For masakari if hostname is not same, host failure is not working 15:32
gokhanido we need any specific config on nova side? 15:33
gokhaniin /etc/hosts file  hosts are added like 10.x.x.x test-compute3.openstack.local test-compute315:34
noonedeadpunkgokhani: I think you're using old masakari though16:11
noonedeadpunkas I think I did patch for that couple of years ago16:11
noonedeadpunktoday masakari should be jsut using compute service list name16:12
noonedeadpunkbut answering your question - hypervisor name is coming from libvirt16:12
noonedeadpunkand compute service is coming from python's socket.gethostname()16:12
noonedeadpunkso basically, what you'd need to do to align these two, is to make `python3 -c "import socket; print(socket.gethostname())" to be same as `python3 -c "import socket; print(socket.getfqdn()"16:14
gokhanithanks noonedeadpunk, I am trying on caracal, I made a test and host failure is not triggered. ok compute service list is same which is in /etc/masakari/masakarimonitors.conf. ı recalled wrong that hypervisor list name must be same in masakari config file 16:19
noonedeadpunkso I think that would boil down to how it's named in corosync cluster16:20
noonedeadpunkand how you added it to masakari api16:20
noonedeadpunkif you do everywhere as in compute service list - that should work16:20
gokhaniI will recheck but it is the same 16:24
noonedeadpunkSo unless this was reverted - it should work... https://review.opendev.org/c/openstack/masakari/+/72862916:27
noonedeadpunk(and not caring about hypervisors)16:29
gokhaninoonedeadpunk: do we need to enable oslo messaging notifications on nova and masakari? 17:10
gokhanimasakari host monitor send notification https://paste.openstack.org/show/bEfQqYNv45dzGmlta4GN/ but masakari engine ignores this notification 17:12

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!