andrewbonney | noonedeadpunk: I'm seeing a few recurring things with regex slashes and 'null' swapping for nothing in the linter patches | 08:25 |
---|---|---|
andrewbonney | I'm marking them for now, but if they turn out to be valid let me know and I'll change reviews | 08:25 |
noonedeadpunk | andrewbonney: so these were auto-fixed by ansible-lint | 09:00 |
noonedeadpunk | I guess in case of null - that's pretty much should not matter, as nothing is the same null | 09:00 |
noonedeadpunk | as for regex stuff... it's a bit more risky, though if we're to align used quotes - might be valid replacement... | 09:01 |
noonedeadpunk | so I tried to pretty much leave auto-fixing, except cases when it was dropping comments or new lines after defining empty list/mapping in defaults | 09:02 |
andrewbonney | Ok, I'll go back over the nulls. It's possible the regexes are fine too, I'm just not certain | 09:03 |
noonedeadpunk | yeah, I'm not 100% sure about regexp either to be frank | 09:26 |
opendevreview | Merged openstack/openstack-ansible-os_rally master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_rally/+/941400 | 09:42 |
opendevreview | Merged openstack/openstack-ansible-os_swift master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_swift/+/941410 | 09:48 |
opendevreview | Merged openstack/ansible-role-pki master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-pki/+/941897 | 09:51 |
opendevreview | Merged openstack/openstack-ansible-os_placement master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_placement/+/941397 | 09:59 |
opendevreview | Merged openstack/ansible-role-systemd_mount master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-systemd_mount/+/941514 | 10:04 |
opendevreview | Merged openstack/openstack-ansible-os_tacker master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_tacker/+/941418 | 10:05 |
opendevreview | Merged openstack/openstack-ansible-os_ironic master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_ironic/+/941359 | 10:05 |
opendevreview | Merged openstack/openstack-ansible-os_magnum master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_magnum/+/941366 | 10:06 |
opendevreview | Merged openstack/openstack-ansible-os_zun master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_zun/+/941438 | 10:14 |
opendevreview | Merged openstack/openstack-ansible-os_mistral master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_mistral/+/941370 | 10:16 |
opendevreview | Merged openstack/openstack-ansible-os_tempest master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/941425 | 10:25 |
opendevreview | Merged openstack/openstack-ansible-os_masakari master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/941368 | 10:36 |
opendevreview | Merged openstack/openstack-ansible-memcached_server master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-memcached_server/+/941503 | 10:45 |
opendevreview | Merged openstack/openstack-ansible-lxc_container_create master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-lxc_container_create/+/941532 | 10:51 |
opendevreview | Merged openstack/openstack-ansible-ceph_client master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/941537 | 11:36 |
birbilakos | hi team, I'm scheduling for a lab move of the current openstack-ansible deployment and as such a full shutdown of openstack will be needed. What are the appropriate steps to take in order to avoid data corruption? | 12:39 |
noonedeadpunk | birbilakos: the same question was asked just yesterday btw | 12:52 |
mnasiadka | noonedeadpunk: do you guys have any automation for documenting variables for roles - or is that all manual effort? Thinking how to streamline that in Kolla-Ansible | 18:14 |
jrosser | mnasiadka: you mean for the openstack docs site? | 18:16 |
mnasiadka | Yup | 18:40 |
mnasiadka | Like a guidance for users which variables can they set for a role | 18:41 |
jrosser | mnasiadka: so we do have some kind of automation for this | 18:45 |
jrosser | "ish" :) | 18:45 |
jrosser | like this https://raw.githubusercontent.com/openstack/openstack-ansible-os_glance/refs/heads/master/doc/source/index.rst | 18:46 |
jrosser | we put some effort into making sure that defaults/main.yml is nicely formatted and hopefully contains useful info as well as just what the default values are | 18:47 |
jrosser | this might be examples of var usage in some cases | 18:47 |
jrosser | so for every one of our roles you end up with an autogenerated page like this https://docs.openstack.org/openstack-ansible-os_glance/latest/ | 18:48 |
jrosser | and then extra docs can be added alongside that as needed manually | 18:48 |
opendevreview | Merged openstack/openstack-ansible-os_designate master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_designate/+/941333 | 18:52 |
opendevreview | Merged openstack/openstack-ansible-os_barbican master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_barbican/+/941321 | 18:58 |
birbilakos | hello again:) | 19:01 |
mnasiadka | jrosser: that’s something, thanks | 19:02 |
opendevreview | Merged openstack/openstack-ansible-os_cloudkitty master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_cloudkitty/+/941331 | 19:02 |
birbilakos | i know this has probably been discussed already but I'm looking for some doc on properly shutting down the whole openstack OSA deployment (pending lab move), as well as how to bring it up back appropriately, minimizing the risks | 19:02 |
opendevreview | Merged openstack/openstack-ansible-os_ceilometer master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_ceilometer/+/941329 | 19:05 |
opendevreview | Merged openstack/openstack-ansible-os_aodh master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_aodh/+/941319 | 19:10 |
opendevreview | Merged openstack/ansible-role-systemd_service master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/941512 | 19:11 |
opendevreview | Merged openstack/openstack-ansible-os_nova master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/941382 | 19:12 |
opendevreview | Merged openstack/openstack-ansible-os_gnocchi master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_gnocchi/+/941337 | 19:14 |
noonedeadpunk | mnasiadka: I was planning to look at argument specs soonish and as they're machine-readable - it could be better way of documentation | 19:24 |
noonedeadpunk | though I really not sure about effort/profit for this | 19:24 |
mnasiadka | We currently have sort of nothing, so I want to start somewhere - if there’s a better option that makes sense - we could think of working together on this… | 19:31 |
opendevreview | Merged openstack/openstack-ansible-os_cinder master: Auto-fix yaml[truthy] rules https://review.opendev.org/c/openstack/openstack-ansible-os_cinder/+/941285 | 19:52 |
noonedeadpunk | it's pretty much the format used for verification and documentation of modules. and recently I've learned, that it can be used for roles as well | 19:57 |
noonedeadpunk | though start using it and veifying/describing each and every variable is likely will be very time consuming... | 19:58 |
noonedeadpunk | but I haven't tried yet :) | 19:58 |
opendevreview | Merged openstack/openstack-ansible-os_trove master: Auto-fix yaml rules https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/941433 | 21:55 |
opendevreview | Merged openstack/ansible-role-uwsgi master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-uwsgi/+/941891 | 22:07 |
opendevreview | Merged openstack/ansible-role-systemd_networkd master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-systemd_networkd/+/941518 | 22:17 |
opendevreview | Merged openstack/ansible-role-python_venv_build master: Auto-fix yaml rules https://review.opendev.org/c/openstack/ansible-role-python_venv_build/+/941521 | 23:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!