*** notmyname has quit IRC | 00:27 | |
*** notmyname has joined #openstack-api | 00:28 | |
*** gmann has joined #openstack-api | 01:12 | |
*** gmann has quit IRC | 01:26 | |
*** gmann has joined #openstack-api | 01:35 | |
*** ig0r__ has joined #openstack-api | 05:52 | |
*** ig0r_ has quit IRC | 05:55 | |
*** jxstanford has quit IRC | 06:14 | |
*** jxstanford has joined #openstack-api | 06:22 | |
*** jxstanford has quit IRC | 06:24 | |
*** jxstanford has joined #openstack-api | 06:29 | |
*** jxstanford has quit IRC | 06:36 | |
*** fzdarsky has joined #openstack-api | 07:23 | |
*** lucasagomes has joined #openstack-api | 08:11 | |
*** subscope has joined #openstack-api | 08:17 | |
*** subscope has quit IRC | 09:14 | |
*** subscope has joined #openstack-api | 09:15 | |
*** park__heijlong has quit IRC | 10:07 | |
*** park__heijlong has joined #openstack-api | 10:20 | |
*** park_heijlong has joined #openstack-api | 10:37 | |
*** park__heijlong has quit IRC | 10:41 | |
*** cdent has joined #openstack-api | 10:44 | |
*** subscope has quit IRC | 11:12 | |
*** e0ne has joined #openstack-api | 11:17 | |
*** subscope has joined #openstack-api | 11:36 | |
*** e0ne has quit IRC | 11:45 | |
*** e0ne has joined #openstack-api | 11:56 | |
*** etoews has joined #openstack-api | 11:58 | |
*** lucasagomes is now known as lucas-hungry | 12:11 | |
*** e0ne is now known as e0ne_ | 12:57 | |
openstackgerrit | wuhao proposed openstack/api-wg: Add description of pagination parameters https://review.openstack.org/198707 | 12:58 |
---|---|---|
*** ameade_vacation is now known as ameade | 13:08 | |
*** lucas-hungry is now known as lucasagomes | 13:10 | |
*** etoews has quit IRC | 13:17 | |
*** terrylhowe has joined #openstack-api | 13:22 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:24 | |
*** e0ne_ is now known as e0ne | 13:24 | |
*** etoews has joined #openstack-api | 13:43 | |
*** woodster_ has joined #openstack-api | 14:21 | |
*** ameade has quit IRC | 15:22 | |
*** ameade_vacation has joined #openstack-api | 15:22 | |
*** ameade_vacation is now known as ameade | 15:23 | |
openstackgerrit | Everett Toews proposed openstack/api-wg: Use Code-Review to Freeze instead of Workflow https://review.openstack.org/198775 | 15:32 |
etoews | elmiko: ^ after trying to put together a api-wg dashboard, i changed my mind on how to freeze guidelines. let's go with what you were doing before. | 15:33 |
elmiko | etoews: hehe, cool. works for me =) | 15:34 |
ryansb | Seems legit | 15:37 |
*** annegentle has joined #openstack-api | 15:37 | |
etoews | elmiko: can i get a review/merge here? https://review.openstack.org/#/c/193366/1 | 15:43 |
elmiko | etoews: sure thing | 15:43 |
ryansb | would if I could ;) | 15:44 |
sigmavirus24 | etoews: so, stupid question | 15:48 |
sigmavirus24 | We have some process. I wonder if we want something like the TC-Rollcall lalbel | 15:48 |
sigmavirus24 | *label | 15:48 |
sigmavirus24 | CPLs are in a separate group that can +1 the TC-Rollcall label and then we know that they've seen it | 15:49 |
sigmavirus24 | Gives us an easier way than checking if the CPLs +1'd it normally | 15:49 |
sigmavirus24 | Idk if we want that extra process, but that might be better? idk | 15:49 |
etoews | i haven't used labels like that in gerrit before. is it common? | 15:50 |
elmiko | interesting idea | 15:50 |
etoews | considering lazy consensus is part of the process, a +1 at all isn't required of the CPLs so such a label wouldn't be definitive. | 15:51 |
etoews | but i bet in practice it could be useful | 15:51 |
sigmavirus24 | etoews: looks to be kind of common with our openstack-specs and tc stuff | 15:52 |
sigmavirus24 | I don't know if we want that much process/ceremony | 15:52 |
sigmavirus24 | But it seems like we're introducing process anyway so I thought I'd point it out as a possibility | 15:52 |
etoews | sigmavirus24: can you link me to a review that's using it right now? | 15:54 |
sigmavirus24 | sure one sec | 15:54 |
sigmavirus24 | etoews: https://review.openstack.org/#/c/188014/ | 15:55 |
sigmavirus24 | etoews: also https://review.openstack.org/#/c/197672/ | 15:56 |
etoews | i take the TC-Rollcall is a gerrit group? | 15:56 |
sigmavirus24 | https://review.openstack.org/#/admin/groups/uuid-c88faeb0c52f35ee530be8defcc9627ea87b28df | 15:56 |
sigmavirus24 | From https://review.openstack.org/#/admin/projects/openstack/governance,access | 15:56 |
etoews | do you need gerrit admin rights to create a group and add/remove members? | 15:58 |
etoews | we talked about creating a CPL gerrit group instead of doing this https://review.openstack.org/#/c/193753/ at the last meeting but felt gerrit admin of the group would be too much of a barrier. | 15:59 |
etoews | if you know differently, a gerrit group could simplify things. | 16:00 |
ryansb | etoews: I'm pretty sure you need admin powers | 16:02 |
etoews | i'd really rather not have to pester admins every time we change a CPL, which could be a relatively common thing to do. | 16:04 |
openstackgerrit | Merged openstack/api-wg: Change template to match our historic usage https://review.openstack.org/186546 | 16:06 |
openstackgerrit | Merged openstack/api-wg: Minor fixes to the process https://review.openstack.org/193366 | 16:07 |
sigmavirus24 | I'm not certain | 16:07 |
sigmavirus24 | I know for one that as a core I can add other cores to gropus | 16:07 |
sigmavirus24 | *to the core group | 16:07 |
sigmavirus24 | If the API-WG cores can be CPL members | 16:07 |
sigmavirus24 | then they can also add/remove other CPLs | 16:07 |
etoews | that doesn't feel quite right to me. seems like an abuse of the cores group. i'd prefer a separate group or not at all. | 16:10 |
etoews | elmiko: can i get a merge here? https://review.openstack.org/#/c/198775/ | 16:22 |
*** jxstanford has joined #openstack-api | 16:22 | |
elmiko | etoews: done | 16:22 |
etoews | thx | 16:22 |
*** jxstanford has quit IRC | 16:39 | |
*** jxstanford has joined #openstack-api | 16:42 | |
openstackgerrit | Merged openstack/api-wg: Use Code-Review to Freeze instead of Workflow https://review.openstack.org/198775 | 16:47 |
*** e0ne has quit IRC | 16:47 | |
*** fzdarsky has quit IRC | 16:50 | |
*** annegentle has quit IRC | 16:50 | |
*** jxstanford has quit IRC | 16:50 | |
*** annegentle has joined #openstack-api | 16:54 | |
etoews | ryansb: what do you think about recommending prefixing all OpenStack APIs that use a custom header with "OpenStack-"? https://review.openstack.org/#/c/186526/4/guidelines/headers.rst | 16:57 |
etoews | (when you have a minute) | 16:57 |
elmiko | etoews: +1, good idea | 16:58 |
*** lucasagomes is now known as lucas-dinner | 16:58 | |
openstackgerrit | Everett Toews proposed openstack/api-wg: Add reviewers to an API WG review https://review.openstack.org/193753 | 17:08 |
*** fzdarsky has joined #openstack-api | 17:18 | |
ryansb | etoews: that wouldn't be bad | 17:23 |
ryansb | another option might be "OS-<project>" | 17:23 |
ryansb | e.g. OS-Compute-FooBar, OS-BareMetal-Baz | 17:23 |
ryansb | (I'll put that in the review. | 17:23 |
ryansb | ) | 17:23 |
elmiko | the real question is, if we advise to use OS-Compute-*, are we opening the can of worms that is project name vs service name? | 17:24 |
ryansb | ...yeah, we would be | 17:25 |
etoews | imo, it's not a can of worms. it should be service name. i think there's a guideline for that out there already. | 17:28 |
elmiko | oh, did it finally get settled then? (i might have missed that) | 17:28 |
etoews | https://review.openstack.org/#/c/196918/ | 17:28 |
etoews | getting closer | 17:29 |
elmiko | ok, thanks | 17:29 |
*** fzdarsky_ has joined #openstack-api | 17:29 | |
ryansb | oh, lol. Just realized I was the one who proposed that spec. Almost +1'd myself | 17:30 |
* ryansb needs sleep, apparently | 17:30 | |
ryansb | or hasn't fully re-engaged from July 4th weekend | 17:31 |
elmiko | ryansb: i hear that... | 17:31 |
elmiko | ;) | 17:31 |
ryansb | etoews: you mean service as in "compute" right? | 17:31 |
etoews | yep | 17:31 |
ryansb | ah, I see the last comment now. | 17:31 |
ryansb | Thank | 17:31 |
ryansb | *Thanks | 17:32 |
*** fzdarsky has quit IRC | 17:33 | |
*** amit213 has quit IRC | 17:39 | |
*** amit213 has joined #openstack-api | 17:39 | |
*** amit213 has quit IRC | 17:40 | |
*** amit213 has joined #openstack-api | 17:40 | |
*** amit213 has quit IRC | 17:41 | |
*** amit213 has joined #openstack-api | 17:42 | |
*** amit213 has quit IRC | 17:42 | |
*** amit213 has joined #openstack-api | 17:42 | |
etoews | let me know what you think of this dashboard. fixes/improvements/whatever https://review.openstack.org/#/c/198826/ | 17:50 |
etoews | git clone https://github.com/stackforge/gerrit-dash-creator.git | 17:50 |
etoews | git review -d 198826 | 17:50 |
etoews | ./gerrit-dash-creator dashboards/api-wg.dash | 17:50 |
etoews | there's a "cd gerrit-dash-creator/" in there somewhere too | 17:50 |
ryansb | URL is too short, under 1KB | 17:51 |
ryansb | ;) | 17:51 |
elmiko | lol | 17:52 |
elmiko | that is an impressive url though | 17:52 |
elmiko | etoews: looks nice +1 | 17:53 |
ryansb | you should probably change the "You are a reviewer" section to exclude changes you own | 17:53 |
ryansb | just add "NOT owner:self" to the very last line | 17:54 |
*** e0ne has joined #openstack-api | 17:54 | |
elmiko | agreed | 17:55 |
ryansb | also add "NOT label:Code-Review=-2" to the "all open reviews" query | 17:56 |
ryansb | since those are frozen guidelines, so I don't think they're really "open" | 17:56 |
ryansb | per se | 17:56 |
ryansb | k, that's all the feedback I have | 17:57 |
*** e0ne is now known as e0ne_ | 18:04 | |
etoews | ryansb: thx. i implemented your first suggestion. i actually already considered doing your second suggestion. i held off because that would also sweep up "Frozen but needs feedback" and it seems like we'd have to take care not to include all of the above sections. it's more complexity than i want to deal with. i'd prefer to just cast a really wide net for | 18:06 |
etoews | "All open reviews" | 18:06 |
ryansb | ok, fair enough | 18:08 |
*** e0ne_ is now known as e0ne | 18:24 | |
*** e0ne has quit IRC | 19:06 | |
*** e0ne has joined #openstack-api | 19:26 | |
*** cdent has quit IRC | 19:29 | |
*** e0ne has quit IRC | 19:47 | |
*** annegentle has quit IRC | 20:27 | |
*** fzdarsky_ has quit IRC | 21:05 | |
*** annegentle has joined #openstack-api | 21:05 | |
*** annegentle has quit IRC | 22:40 | |
*** annegentle has joined #openstack-api | 22:44 | |
*** lucas-dinner has quit IRC | 22:45 | |
*** annegentle has quit IRC | 23:02 | |
*** annegentle has joined #openstack-api | 23:18 | |
*** annegentle has quit IRC | 23:20 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg: Add generic name of each project for terms https://review.openstack.org/196918 | 23:36 |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!