| oomichi | jaypipes: hi | 00:29 |
|---|---|---|
| oomichi | jaypipes: I'm glad if you take a look at https://review.openstack.org/#/c/221163/ | 00:30 |
| *** apoorvad has quit IRC | 00:33 | |
| jaypipes | oomichi: nice one. +1 from me. | 00:51 |
| oomichi | jaypipes: thanks so much :-) | 00:51 |
| *** yunpengli has joined #openstack-api | 02:09 | |
| *** yunpengli has quit IRC | 02:09 | |
| *** etoews has quit IRC | 03:18 | |
| *** alex_klimov has joined #openstack-api | 07:59 | |
| *** fzdarsky has joined #openstack-api | 08:07 | |
| *** alex_klimov has quit IRC | 08:09 | |
| *** lucasagomes has joined #openstack-api | 08:17 | |
| *** pballand has quit IRC | 08:26 | |
| *** fzdarsky has quit IRC | 08:53 | |
| *** cdent has joined #openstack-api | 08:59 | |
| *** pballand has joined #openstack-api | 09:03 | |
| *** e0ne has joined #openstack-api | 09:26 | |
| *** pballand has quit IRC | 10:24 | |
| *** alex_klimov has joined #openstack-api | 10:34 | |
| *** pballand has joined #openstack-api | 10:53 | |
| oomichi | cdent: hi, thanks for your review on https://review.openstack.org/#/c/221163 | 11:19 |
| oomichi | cdent: I'd like to know your comment about the commit message | 11:19 |
| cdent | Hi oomichi: I mean that the commit message currently makes it sound like http400 is being suggested for _all_ resource not found situations, which is not at all the case | 11:20 |
| cdent | so it would be good if it was clarified | 11:20 |
| oomichi | cdent: I see. "Add http400 for a reference to a nonexistent resource" is nice? | 11:24 |
| cdent | I think that change, plus an additional paragraph would be best, but that change by itself is enough | 11:24 |
| oomichi | cdent: thanks:) the patch content of api-wg shows the meaning and the commit message would be duplicated in most cases. | 11:26 |
| oomichi | cdent: and easy to forget updating the commit message if writting it. that is a reason why avoiding writting the commit message | 11:27 |
| cdent | I understand where you're coming from, but I still think it is useful for the commit message to have meaningful information in it. In the context of things like these guidelines it is a bit different than code: that's why I didn't -1. If it were code and the commit message was that short I would have -1. | 11:28 |
| oomichi | cdent: yeah, I never posted a code patch without paragraph actually. | 11:31 |
| oomichi | cdent: I am searching fitting paragraph for this now.. | 11:32 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg: Add http400 for reference to nonexistent resource https://review.openstack.org/221163 | 11:44 |
| oomichi | cdent: ^^^ glad if you see it again | 11:44 |
| * cdent looks | 11:44 | |
| cdent | yeah, that's better, thanks | 11:45 |
| oomichi | cdent: thanks but cannot get your +1 yet | 11:58 |
| *** e0ne has quit IRC | 12:06 | |
| *** oomichi has quit IRC | 12:18 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:58 | |
| *** annegentle has joined #openstack-api | 14:06 | |
| *** pballand has quit IRC | 14:34 | |
| *** annegentle has quit IRC | 14:34 | |
| *** e0ne has joined #openstack-api | 15:25 | |
| *** openstackgerrit has quit IRC | 15:31 | |
| *** openstackgerrit has joined #openstack-api | 15:32 | |
| *** apoorvad has joined #openstack-api | 16:11 | |
| *** pballand has joined #openstack-api | 16:14 | |
| *** lucasagomes has quit IRC | 16:16 | |
| *** alex_klimov has quit IRC | 16:27 | |
| *** e0ne has quit IRC | 16:30 | |
| *** annegentle has joined #openstack-api | 16:35 | |
| *** fzdarsky has joined #openstack-api | 16:41 | |
| *** annegentle has quit IRC | 16:45 | |
| *** fzdarsky has quit IRC | 16:46 | |
| *** fzdarsky has joined #openstack-api | 17:02 | |
| *** fzdarsky has quit IRC | 17:11 | |
| *** bitblt has joined #openstack-api | 17:13 | |
| *** cdent has quit IRC | 17:22 | |
| *** fzdarsky has joined #openstack-api | 17:34 | |
| *** cdent has joined #openstack-api | 17:43 | |
| *** fzdarsky has quit IRC | 17:43 | |
| *** salv-orlando has joined #openstack-api | 17:47 | |
| *** lucasagomes__ has joined #openstack-api | 17:48 | |
| *** pballand has quit IRC | 18:01 | |
| *** pballand has joined #openstack-api | 18:03 | |
| *** pballand has quit IRC | 18:08 | |
| *** e0ne has joined #openstack-api | 18:09 | |
| *** lucasagomes has joined #openstack-api | 18:15 | |
| *** lucasagomes is now known as lucas-afk | 18:16 | |
| *** bitblt has quit IRC | 18:16 | |
| *** lucas-afk has quit IRC | 18:20 | |
| *** cdent has quit IRC | 18:23 | |
| *** lucasagomes has joined #openstack-api | 18:28 | |
| *** lucasagomes__ has quit IRC | 18:28 | |
| *** lucasagomes is now known as lucas-afk | 18:28 | |
| *** woodster_ has joined #openstack-api | 18:43 | |
| *** subscope has joined #openstack-api | 18:56 | |
| *** e0ne has quit IRC | 19:25 | |
| *** salv-orlando has quit IRC | 19:32 | |
| *** etoews has joined #openstack-api | 19:32 | |
| *** alex_klimov has joined #openstack-api | 19:34 | |
| *** pballand has joined #openstack-api | 19:42 | |
| *** apoorvad has quit IRC | 19:51 | |
| *** salv-orlando has joined #openstack-api | 20:02 | |
| *** subscope has quit IRC | 20:25 | |
| *** apoorvad has joined #openstack-api | 20:26 | |
| *** lifeless has quit IRC | 20:34 | |
| *** pballand has quit IRC | 20:57 | |
| *** pballand has joined #openstack-api | 20:59 | |
| *** lucas-afk has quit IRC | 21:14 | |
| *** pballand has quit IRC | 21:59 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:08 | |
| *** pballand has joined #openstack-api | 22:32 | |
| *** pballand has quit IRC | 23:09 | |
| *** salv-orl_ has joined #openstack-api | 23:15 | |
| *** salv-orlando has quit IRC | 23:18 | |
| *** etoews_ has joined #openstack-api | 23:27 | |
| *** nikhil_k has joined #openstack-api | 23:27 | |
| *** miguelgrinberg has quit IRC | 23:31 | |
| *** miguelgrinberg has joined #openstack-api | 23:31 | |
| *** etoews has quit IRC | 23:32 | |
| *** nikhil has quit IRC | 23:32 | |
| *** etoews_ is now known as etoews | 23:32 | |
| *** dstanek has quit IRC | 23:54 | |
| *** johnthetubaguy has quit IRC | 23:54 | |
| *** nikhil_k has quit IRC | 23:54 | |
| *** etoews has quit IRC | 23:54 | |
| *** alex_klimov has quit IRC | 23:54 | |
| *** vishwanathj has quit IRC | 23:54 | |
| *** krotscheck has quit IRC | 23:54 | |
| *** sigmavirus24_awa has quit IRC | 23:54 | |
| *** dtroyer has quit IRC | 23:54 | |
| *** briancurtin has quit IRC | 23:54 | |
| *** ameade has quit IRC | 23:54 | |
| *** stevelle has quit IRC | 23:54 | |
| *** russellb has quit IRC | 23:55 | |
| *** tristanC has quit IRC | 23:55 | |
| *** apoorvad has quit IRC | 23:55 | |
| *** jaypipes has quit IRC | 23:55 | |
| *** openstackgerrit has quit IRC | 23:55 | |
| *** amit213 has quit IRC | 23:55 | |
| *** dhellmann has quit IRC | 23:55 | |
| *** notmyname has quit IRC | 23:55 | |
| *** HenryG has quit IRC | 23:55 | |
| *** d0ugal has quit IRC | 23:55 | |
| *** peterstac has quit IRC | 23:55 | |
| *** alex_xu has quit IRC | 23:55 | |
| *** miguelgrinberg has quit IRC | 23:55 | |
| *** woodster_ has quit IRC | 23:55 | |
| *** ryansb has quit IRC | 23:55 | |
| *** flaper87 has quit IRC | 23:55 | |
| *** kragniz has quit IRC | 23:55 | |
| *** sc68cal has quit IRC | 23:55 | |
| *** gmann has quit IRC | 23:55 | |
| *** salv-orl_ has quit IRC | 23:55 | |
| *** elmiko has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!