| *** kebray has quit IRC | 00:01 | |
| kfox1111 | :/ | 00:33 |
|---|---|---|
| kfox1111 | its too big to review. | 00:33 |
| docaedo | basically since it's a full reformat of assets.yaml (though all the same assets, same data, same order, just indented two fewer lines), not sure how else to do it. | 00:34 |
| kfox1111 | its also munging some of the formatting in an ugly way.... | 00:34 |
| kfox1111 | > to " with \ line wrapping. :/ | 00:35 |
| docaedo | yeah I saw that for a few of them though not all - it did that if description contained a single-quote | 00:36 |
| kfox1111 | can you put the extra formatting back in? add a --- and indent it two more? | 00:36 |
| docaedo | possibly, but leaving --- out is syntactically correct (arguably) since we only have "assets" now. That additional indentation was needed from before we combined into a single asset type. Should have probably dropped it at that point. | 00:37 |
| kfox1111 | yeah. its not a syntactically correctness issue. its an issue of changing every line in the file. :/ | 00:38 |
| kfox1111 | and not having an easy way to verify it didn't munge something in the conversion. :/ | 00:39 |
| docaedo | yeah it's more than just that though, like instead of | 00:41 |
| docaedo | - | 00:41 |
| docaedo | name: Debian | 00:41 |
| docaedo | it's | 00:42 |
| docaedo | - name: Debian | 00:42 |
| docaedo | what I did to feel better about it was grepping for things (like - name:/ name:) and diffing the output to make sure the values match | 00:43 |
| kfox1111 | in theory I think git is more tolerent of pure white space changes like that. its more the changing the quoting, line lengths, etc that is tripping it up. | 00:43 |
| docaedo | but I can appreciate the concern here, this is not an easy one since we're going from a human-formatted one with inconsistent line lengths and stuff, to something formatted by a machine | 00:43 |
| kfox1111 | most of it I can live with. I really dislike the string formatting. :/ | 00:44 |
| kfox1111 | so... what about this... | 00:45 |
| kfox1111 | we have two files, the human writable, the machine writable both in git. the machine one just has resource: with hash and active. we always sort that and merge it in tools/yaml2json.py | 00:46 |
| kfox1111 | its still in git, so it works the way you would like with reviews. | 00:46 |
| kfox1111 | for people that don't want to have to care, they just edit assets.yaml as normal, and it doesn't change at all. | 00:46 |
| docaedo | I still don't like having two that get magically merged - much of openstack has combined machine-edited and human edited yamls, and it works nicely. We just have get past this one point where we have the sloppy human-version then it'll be clean from there on out | 00:54 |
| docaedo | I have to take off, we can debate some more tomorrow :) | 00:54 |
| kfox1111 | like where? | 00:54 |
| kfox1111 | the machine version is much sloppier in some ways though. :/ | 00:55 |
| docaedo | project-normalizer for one, I'll find some links tomorrow | 00:55 |
| kfox1111 | k. | 00:55 |
| kfox1111 | with forcing the machine formatting through, anyone that submits a new resource that doesn't has the same formatting, will get it aproved, and then it will have to update it all over again. this is an ongoing maintenence thing I really don't like. | 00:57 |
| kfox1111 | either our schema formatter should validate the identical formatting going through, or we shouldn't do this. | 00:58 |
| kfox1111 | my objection is, to do it this way, is we have to add an aweful lot of code to make it work nicely, and its hard to get right. really, this is a short term thing to get us to v2 in a few months. so the two file solution isn't terrible, and its like 10 lines of code, instead of over a hundred and an unreviewable patch. :/ | 00:59 |
| *** dfflanders has joined #openstack-app-catalog | 03:25 | |
| *** dfflanders has quit IRC | 04:37 | |
| *** ddovbii_home has joined #openstack-app-catalog | 06:28 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 06:34 | |
| *** kzaitsev_mb has quit IRC | 07:41 | |
| *** ddovbii_home has quit IRC | 08:20 | |
| *** ddovbii_home has joined #openstack-app-catalog | 08:26 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 09:01 | |
| *** ddovbii_home has quit IRC | 10:02 | |
| *** kebray has joined #openstack-app-catalog | 15:07 | |
| *** kebray has quit IRC | 15:10 | |
| *** kebray has joined #openstack-app-catalog | 15:15 | |
| *** kebray has quit IRC | 16:40 | |
| *** kzaitsev_mb has quit IRC | 17:35 | |
| *** kebray has joined #openstack-app-catalog | 17:36 | |
| *** kebray has quit IRC | 17:47 | |
| *** kebray has joined #openstack-app-catalog | 17:57 | |
| *** kebray has quit IRC | 18:15 | |
| *** kebray has joined #openstack-app-catalog | 18:17 | |
| openstackgerrit | Kevin Fox proposed openstack/app-catalog: WIP - Derive asset last modified date/time from git logs https://review.openstack.org/267087 | 18:43 |
| *** ig0r_ has joined #openstack-app-catalog | 18:43 | |
| *** kebray has quit IRC | 18:52 | |
| *** kebray has joined #openstack-app-catalog | 20:21 | |
| *** ig0r_ has quit IRC | 21:14 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 21:23 | |
| *** ig0r_ has joined #openstack-app-catalog | 21:23 | |
| *** kebray has quit IRC | 21:30 | |
| *** ig0r_ has quit IRC | 21:31 | |
| *** ig0r_ has joined #openstack-app-catalog | 21:44 | |
| *** ig0r_ has quit IRC | 21:45 | |
| *** kebray has joined #openstack-app-catalog | 22:51 | |
| *** kebray has quit IRC | 23:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!