| *** openstack has joined #openstack-barbican | 21:08 | |
| openstackgerrit | Ade Lee proposed a change to openstack/barbican: code to retrieve transport key on metadata request https://review.openstack.org/107110 | 21:09 |
|---|---|---|
| rellerreller | alee thanks! | 21:10 |
| alee | rellerreller, woodster - awesome - thanks! | 21:10 |
| woodster | one down, two to go.... | 21:10 |
| alee | jvrbanac, how about a +2 and +1 workflow ? | 21:11 |
| woodster | well, ok, not counting merges! | 21:11 |
| rellerreller | alee have a good day. I"m headed out now | 21:11 |
| alee | yeah -- I'm getting used to merges :) | 21:11 |
| alee | rellerreller, thanks you too! | 21:11 |
| *** rellerreller has quit IRC | 21:11 | |
| jvrbanac | alee, done | 21:13 |
| alee | jvrbanac, thank you sir! gentlemen and scholars all round. | 21:14 |
| *** Kevin_Bishop has quit IRC | 21:14 | |
| *** paul_glass has joined #openstack-barbican | 21:16 | |
| alee | woodster, I'll merge and get the others posted tonight. Am out tommorow but I'll watch for a new cert/symantec patch from you and chellygel . | 21:17 |
| woodster | alee: sounds good, have a good weekend | 21:17 |
| *** paul_glass has quit IRC | 21:18 | |
| alee | you too | 21:18 |
| *** paul_glass1 has quit IRC | 21:19 | |
| rm_work | alright, got the tempest tests running in my devstack… | 21:21 |
| woodster | rm_work: drats, we are running out of hoops to have you jump through :\ jk.... | 21:27 |
| rm_work | >_< | 21:27 |
| rm_work | it does seem like it sometimes :P | 21:27 |
| atiwari | woodster, for https://review.openstack.org/#/c/87405/ where you are seeing the container validation ? | 21:31 |
| woodster | atiwari: I think it was a rebase artifact I saw in there. It is hard to tell the new stuff from rebased deltas with gerrit, apologies. I do think that this change should be in a different CR though: https://review.openstack.org/#/c/87405/16/barbican/plugin/resources.py,cm | 21:33 |
| *** edewata has quit IRC | 21:33 | |
| *** Kevin_Bishop has joined #openstack-barbican | 21:34 | |
| atiwari | woodster, np. I think need to understand more on your concern but this https://review.openstack.org/#/c/87405/ is only for order type | 21:35 |
| atiwari | it wd be helpful if you add comments in the cr | 21:36 |
| atiwari | I know it is little big but dedicated to only one BP/Spec | 21:36 |
| woodster | atiwari: so the code at line 131 of plugin/resources.py 'generate_asymmetric_secret()' is coming from another merged CR then? | 21:37 |
| *** alee_ has quit IRC | 21:37 | |
| *** alee has quit IRC | 21:37 | |
| atiwari | woodster, no that is my cr which is not merged yet | 21:39 |
| woodster | atiwari: so I'm saying code like that would be better to have in a dependent or separate CR...that doesn't deal directly with the order type/meta additions like other code changes in that CR | 21:40 |
| atiwari | woodster, then how do we support Asymmetric order type, which need this piece of code | 21:42 |
| atiwari | you want it to land before order type ? | 21:42 |
| redrobot | atiwari, I think the point that woodster is trying to make is that you've added way too much functionailty in a single CR, which is why it's taking us so long to review | 21:43 |
| redrobot | atiwari asymmetric order generation is a new feature, and as such, it would be better to split up into its own CR | 21:44 |
| redrobot | it also doesn't help that Gerrit is not very smart about showing deltas between two patches in the same CR | 21:45 |
| atiwari | redrobot, woodster can you tell me how should I split it? Initially I made the changes in crypto plugin and this one is REST part. | 21:46 |
| atiwari | redrobot, IMO the changes in this cr are atomic to only one spec | 21:48 |
| *** lisaclark1 has quit IRC | 21:49 | |
| atiwari | it wd be good it it land together. To make it review simple I did not removed the old code | 21:49 |
| atiwari | thoughts? | 21:49 |
| woodster | atiwari: I think the order type/meta work is good to me, including the api/controller work, and the queue/tasks changes. I realize we will remove the old order schema support at some point soon. Anything else in there though is somethign best in another CR I'd think | 21:53 |
| woodster | atiwari: by having the order type/meta in there, we can unblock the certificate workflow generation stuff for example, again as a follow on CR to this one though. You could submit a CR for the async stuff as well. | 21:53 |
| openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican-specs: Remove leftover references to Nova https://review.openstack.org/111096 | 21:54 |
| *** SheenaG11 has quit IRC | 21:55 | |
| atiwari | woodster, let me see how I can split it, but if you are concerned about https://review.openstack.org/#/c/87405/16/barbican/plugin/resources.py change . THis is done because of your change for code restructuring. | 21:56 |
| rm_work | so, there's a bug in the way the Tempest rest_client handles the DELETE method >_< | 21:57 |
| rm_work | reaperhulk: do the tests have to be … COMPLETE? :P | 21:59 |
| *** alee has joined #openstack-barbican | 22:00 | |
| atiwari | woodster, I will ping you tomorrow after looking in to it. | 22:05 |
| *** nkinder_away has quit IRC | 22:10 | |
| *** nkinder_away has joined #openstack-barbican | 22:11 | |
| *** ayoung has quit IRC | 22:13 | |
| *** alee has quit IRC | 22:15 | |
| *** Kevin_Bishop has quit IRC | 22:19 | |
| *** juantwo has joined #openstack-barbican | 22:20 | |
| *** juantwo has quit IRC | 22:20 | |
| *** juantwo has joined #openstack-barbican | 22:20 | |
| openstackgerrit | A change was merged to openstack/barbican: code to retrieve transport key on metadata request https://review.openstack.org/107110 | 22:22 |
| *** akoneru has quit IRC | 22:34 | |
| *** uberj_ is now known as uberj | 22:37 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Add support to Barbican for consumer registration https://review.openstack.org/107845 | 22:38 |
| openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican-specs: Add Containers to python-barbicanclient https://review.openstack.org/110056 | 22:38 |
| rm_work | got it | 22:38 |
| rm_work | whew | 22:38 |
| *** SheenaG1 has joined #openstack-barbican | 22:47 | |
| reaperhulk | rm_work: I care only about smoketest equivalents. As long as you test register/unregister I'm happy :) | 22:51 |
| reaperhulk | looks like your tests do create/delete/create again, that's fine | 22:52 |
| reaperhulk | assuming they pass ;) | 22:52 |
| *** mdorman has quit IRC | 22:56 | |
| *** hockeynut has joined #openstack-barbican | 23:04 | |
| *** alee has joined #openstack-barbican | 23:25 | |
| openstackgerrit | Adam Harwell proposed a change to openstack/barbican: Add support to Barbican for consumer registration https://review.openstack.org/107845 | 23:40 |
| *** gyee has quit IRC | 23:48 | |
| *** jamielennox|away is now known as jamielennox | 23:53 | |
| *** atiwari has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!