*** juantwo_ has quit IRC | 00:24 | |
*** juantwo has joined #openstack-barbican | 00:25 | |
*** nkinder has joined #openstack-barbican | 02:32 | |
*** nkinder has quit IRC | 02:59 | |
*** bdpayne has joined #openstack-barbican | 03:13 | |
*** bdpayne has quit IRC | 03:33 | |
*** juantwo has quit IRC | 04:33 | |
openstackgerrit | Jamie Lennox proposed a change to openstack/kite: Explicitly import _ translation function https://review.openstack.org/119692 | 04:44 |
---|---|---|
openstackgerrit | Jamie Lennox proposed a change to openstack/kite: Update requirements from global https://review.openstack.org/119693 | 04:44 |
openstackgerrit | Jamie Lennox proposed a change to openstack/kite: Update requirements from global https://review.openstack.org/119693 | 04:54 |
openstackgerrit | Jamie Lennox proposed a change to openstack/kite: Explicitly import _ translation function https://review.openstack.org/119692 | 04:54 |
*** jenkins-keep has quit IRC | 05:10 | |
*** jenkins-keep has joined #openstack-barbican | 05:11 | |
openstackgerrit | Jamie Lennox proposed a change to openstack/kite: Update requirements from global https://review.openstack.org/119693 | 05:18 |
jenkins-keep | Project openstack-barbican-cloudcafe build #23: ABORTED in 50 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/23/ | 05:57 |
jenkins-keep | Project openstack-barbican-cloudcafe build #24: STILL FAILING in 11 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/24/ | 06:09 |
*** Nirupama has joined #openstack-barbican | 06:13 | |
*** jaosorior has joined #openstack-barbican | 07:09 | |
*** rm_work has quit IRC | 10:15 | |
*** rm_work|away has joined #openstack-barbican | 10:22 | |
*** rm_work|away is now known as rm_work | 10:22 | |
*** rm_work has joined #openstack-barbican | 10:22 | |
*** Guest22704 has quit IRC | 11:12 | |
*** juantwo has joined #openstack-barbican | 12:00 | |
*** juantwo has quit IRC | 12:01 | |
*** juantwo has joined #openstack-barbican | 12:02 | |
*** ayoung has joined #openstack-barbican | 12:40 | |
openstackgerrit | Tim Kelsey proposed a change to openstack/barbican: Adding a plugin to interact with HP Atalla ESKM https://review.openstack.org/116878 | 12:44 |
*** Nirupama has quit IRC | 12:51 | |
*** alee_out is now known as alee | 13:48 | |
*** nkinder has joined #openstack-barbican | 14:00 | |
*** woodster_ has joined #openstack-barbican | 14:19 | |
*** atiwari has joined #openstack-barbican | 14:25 | |
openstackgerrit | A change was merged to openstack/python-barbicanclient: Work toward Python 3.4 support and testing https://review.openstack.org/118798 | 14:27 |
openstackgerrit | A change was merged to openstack/python-kiteclient: Work toward Python 3.4 support and testing https://review.openstack.org/118803 | 14:31 |
*** paul_glass has joined #openstack-barbican | 14:33 | |
*** Guest22704 has joined #openstack-barbican | 14:35 | |
openstackgerrit | A change was merged to openstack/barbican: Move to oslotest https://review.openstack.org/116700 | 14:36 |
*** paul_glass has quit IRC | 14:36 | |
*** paul_glass has joined #openstack-barbican | 14:37 | |
*** paul_glass1 has joined #openstack-barbican | 15:06 | |
*** paul_glass has quit IRC | 15:09 | |
rm_work | redrobot: https://review.openstack.org/#/c/113393/ ;P | 15:10 |
*** SheenaG1 has joined #openstack-barbican | 15:11 | |
*** jorge_munoz has joined #openstack-barbican | 15:13 | |
*** lisaclark has joined #openstack-barbican | 15:29 | |
*** mikedillion has joined #openstack-barbican | 15:40 | |
*** jaosorior has quit IRC | 15:52 | |
*** bdpayne has joined #openstack-barbican | 15:57 | |
*** mikedillion has quit IRC | 16:04 | |
*** mikedillion has joined #openstack-barbican | 16:09 | |
*** bdpayne has quit IRC | 16:11 | |
*** bdpayne has joined #openstack-barbican | 16:11 | |
*** bdpayne has quit IRC | 16:16 | |
*** lisaclark has quit IRC | 16:21 | |
*** lisaclark has joined #openstack-barbican | 16:25 | |
*** kebray has joined #openstack-barbican | 16:26 | |
*** mikedillion has quit IRC | 16:28 | |
*** mikedillion has joined #openstack-barbican | 16:30 | |
*** lisaclark has quit IRC | 16:49 | |
*** lisaclark has joined #openstack-barbican | 16:56 | |
*** atiwari has quit IRC | 17:00 | |
*** Guest22704 has quit IRC | 17:04 | |
*** jaosorior has joined #openstack-barbican | 17:18 | |
*** Guest22704 has joined #openstack-barbican | 17:18 | |
*** atiwari has joined #openstack-barbican | 17:19 | |
*** kebray has quit IRC | 17:20 | |
*** kebray has joined #openstack-barbican | 17:21 | |
*** bdpayne has joined #openstack-barbican | 17:23 | |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Add asymmtric order validator https://review.openstack.org/118697 | 17:28 |
atiwari | hockeynut, yt? | 17:28 |
*** akoneru has joined #openstack-barbican | 17:39 | |
*** ayoung has quit IRC | 17:41 | |
*** Guest22704 has quit IRC | 17:49 | |
*** bdpayne has quit IRC | 17:50 | |
*** bdpayne has joined #openstack-barbican | 17:51 | |
*** ayoung has joined #openstack-barbican | 17:52 | |
*** kebray has joined #openstack-barbican | 18:06 | |
*** bdpayne has quit IRC | 18:10 | |
*** bdpayne has joined #openstack-barbican | 18:11 | |
*** Guest22704 has joined #openstack-barbican | 18:13 | |
*** Guest22704 has quit IRC | 18:18 | |
*** lisaclark has quit IRC | 18:18 | |
*** lisaclark has joined #openstack-barbican | 18:19 | |
*** Guest22704 has joined #openstack-barbican | 18:34 | |
*** akoneru is now known as akoneru_lunch | 18:43 | |
*** mikedillion has quit IRC | 18:49 | |
*** openstackgerrit has quit IRC | 18:51 | |
*** jorge_munoz has quit IRC | 18:55 | |
*** jorge_munoz has joined #openstack-barbican | 18:56 | |
*** mikedillion has joined #openstack-barbican | 19:04 | |
*** Guest22704 has quit IRC | 19:06 | |
*** openstackgerrit has joined #openstack-barbican | 19:07 | |
*** lisaclark has quit IRC | 19:14 | |
openstackgerrit | Arun Kant proposed a change to openstack/barbican: Adding keystone notification listener support https://review.openstack.org/110817 | 19:14 |
*** lisaclark has joined #openstack-barbican | 19:22 | |
hockeynut | atiwari I am now | 19:32 |
atiwari | thanks hockeynut, I did not get you second comment in https://review.openstack.org/#/c/118697/6/barbican/plugin/interface/secret_store.py | 19:32 |
hockeynut | oh - alg.lower() is called both on lines 205 and 207 | 19:33 |
hockeynut | better to just set a variable once and use it in both places | 19:33 |
atiwari | ok | 19:34 |
atiwari | let me fix that | 19:34 |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Add asymmtric order validator https://review.openstack.org/118697 | 19:38 |
atiwari | hockeynut, ^ | 19:39 |
hockeynut | <click> | 19:39 |
rm_work | hockeynut / jvrbanac / reaperhulk: https://review.openstack.org/#/c/113393/ :P | 19:40 |
rm_work | uhh BTW how do I multi-line "from barbicanclient.barbican_cli.containers import CertificateContainerFormatter" | 19:42 |
*** lisaclark has quit IRC | 19:42 | |
*** lisaclark1 has joined #openstack-barbican | 19:43 | |
rm_work | jaosorior: hey | 19:44 |
*** rellerreller has joined #openstack-barbican | 19:44 | |
jaosorior | Yo | 19:45 |
rm_work | see my comment like two lines up, or else on that __str__ CR | 19:45 |
rm_work | the reason I did the imports in ( ) format was because one of them NEEDS IT anyway | 19:45 |
rm_work | so I thought I may as well just combine them while I was at it | 19:45 |
rm_work | Also, I think that is actually valid hacking/pep8 | 19:45 |
hockeynut | redrobot I may not be in mtg this afternoon - working from orthodontist office and they may call me in to empty my wallet :-) | 19:46 |
*** Guest22704 has joined #openstack-barbican | 19:48 | |
*** lisaclark1 has quit IRC | 19:48 | |
*** Guest22704 has quit IRC | 19:51 | |
rm_work | jaosorior: i wouldn't have grouped the imports that way otherwise | 19:52 |
reaperhulk | from barbicanclient.barbican_cli.containers import (\n\tCertificateContainerFormatter\n) basically rm_work | 19:57 |
redrobot | weekly meeting starts in 2 minutes in #openstack-meeting-alt | 19:58 |
jaosorior | rm_work: I'll check it out | 19:58 |
jaosorior | Environment to run hacking and check what's up, not so easy on my phone :P | 19:59 |
rm_work | reaperhulk: right, but at that point why not just do what I did and combine all three imports since it's going to be in parens anyway <_< | 19:59 |
rm_work | jaosorior: heh well I mean, you can tell it is fine for hacking since jenkins +1'd it :)\ | 19:59 |
rm_work | reaperhulk: https://review.openstack.org/#/c/118494/3/barbicanclient/containers.py | 20:00 |
rm_work | (could use more reviews there too :P) | 20:00 |
redrobot | rm_work not hacking compliant | 20:00 |
redrobot | rm_work hacking says to import modules, not classes | 20:00 |
jaosorior | Still gotta search for some openstack python style guide that I saw a while ago | 20:00 |
rm_work | redrobot: then why does it pass hacking tox tests? >_> | 20:00 |
redrobot | rm_work because hacking sucks | 20:00 |
rm_work | I guess hacking just doesn't test it? lol | 20:00 |
reaperhulk | rm_work: I think that's just because hacking is stupid. | 20:01 |
rm_work | heh | 20:01 |
reaperhulk | oh I see others have beaten me to the punch there | 20:01 |
*** akoneru_lunch is now known as akoneru | 20:01 | |
rm_work | alright so, I'm not allowed to import classes... ok | 20:01 |
jaosorior | redrobot: rm_work I remember reading that somewhere, but couldn't recall which wiki page | 20:01 |
redrobot | rm_work http://docs.openstack.org/developer/hacking/#imports H302 | 20:01 |
reaperhulk | hacking doesn't actually look at the AST much, so it's pretty stupid about certain things | 20:01 |
rm_work | so I just have to import from barbicanclient.barbican_cli.containers | 20:01 |
rm_work | and then use containers.ContainerFormatter | 20:01 |
rm_work | ? | 20:01 |
jaosorior | Yup | 20:01 |
rm_work | fine by me | 20:02 |
rm_work | import barbicanclient.barbican_cli.containers as cli_containers | 20:02 |
rm_work | seem ok? | 20:02 |
*** Guest22704 has joined #openstack-barbican | 20:02 | |
jaosorior | Fine by me | 20:02 |
rm_work | kk | 20:03 |
rm_work | fixing the same issue in the other classes and submitting a patch | 20:03 |
*** gyee has joined #openstack-barbican | 20:03 | |
*** bubbva has joined #openstack-barbican | 20:04 | |
*** kebray has quit IRC | 20:04 | |
openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Change object __str__() to use pretty formatting https://review.openstack.org/118494 | 20:08 |
*** arunkant has quit IRC | 20:17 | |
*** arunkant has joined #openstack-barbican | 20:18 | |
*** bdpayne_ has joined #openstack-barbican | 20:33 | |
*** bdpayne has quit IRC | 20:36 | |
redrobot | atiwari ping | 21:01 |
woodster_ | atiwari: this etherpad was an attempt to identify Juno work items: https://etherpad.openstack.org/p/barbican-juno-final-roadmap | 21:01 |
redrobot | atiwari is this what you're looking for? https://launchpad.net/barbican/+milestone/juno-rc1 | 21:01 |
woodster_ | folks, please put you name in the right if you make mods to that etherpad | 21:01 |
atiwari | redrobot, do you have list of CR/bug fix items for RC1 | 21:01 |
atiwari | redrobot, yes | 21:02 |
atiwari | redrobot, thanks | 21:02 |
*** kaitlin-farr has joined #openstack-barbican | 21:03 | |
redrobot | atiwari you're welcome | 21:03 |
arunkant | woodster_ : Can this be reviewed as well https://review.openstack.org/#/c/110817/ ..have been going through review for quite some time. | 21:04 |
atiwari | redrobot, woodster_ https://review.openstack.org/#/c/118697/8 is also waiting for more blessing :) | 21:04 |
*** SheenaG1 has quit IRC | 21:05 | |
atiwari | redrobot, we need some direction on https://review.openstack.org/#/c/117032/ too. this is regarding tempest test coverage . | 21:08 |
*** juantwo has quit IRC | 21:11 | |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: Updated dev guide to include feedback from previous tech review https://review.openstack.org/117889 | 21:13 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: removing cq-devguide.wadl which was added by mistake https://review.openstack.org/119931 | 21:13 |
redrobot | atiwari sorry, I'm not so familiar with Tempest. IIRC tempest tests should live in the barbican repo? At least that's where our current tempest tests are | 21:15 |
openstackgerrit | Constanze Kratel proposed a change to openstack/barbican: removed image files as they referred to internal architecure https://review.openstack.org/119932 | 21:16 |
*** Guest22704 has quit IRC | 21:16 | |
atiwari | redrobot, can some body add note on that CR, that will be helpful | 21:16 |
redrobot | atiwari what is the CR for? It's almost 900 LOC, so I'd have to spend some time to read it | 21:21 |
rm_work | yeah, right now our tempest tests live in the functionaltests directory inside barbican | 21:26 |
atiwari | redrobot, no rush, our QA has added barbican tests for tempest suite and blocked for now. This CR has enough context. | 21:26 |
atiwari | rm_work, is that mean https://review.openstack.org/#/c/117032/ has to go under barbican review? | 21:27 |
rm_work | atiwari: yes I believe so | 21:28 |
rm_work | though from what they are saying, we may need to change to having our tempest tests live *in tempest*?? | 21:29 |
rm_work | which I guess is how other projects do it? | 21:29 |
atiwari | yes | 21:30 |
redrobot | where's Chad when you need him? | 21:30 |
redrobot | as far as I know we tried to add tests to Tempest | 21:30 |
redrobot | but they told us that we should keep them in our own repo | 21:30 |
rm_work | yeah, so in our current model, that would be a Barbican review and the tests would live in barbican/functionaltests/api/v1 | 21:30 |
rm_work | but that's not actually valid long-term | 21:30 |
rm_work | redrobot: which Chad? | 21:31 |
redrobot | rm_work Chad Lung... no longer a Racker, he was the one who set up our tempest/devstack stuff | 21:31 |
atiwari | redrobot, I think we eventually have to move to tempest if we want to go for Graduation to integrated | 21:31 |
atiwari | redrobot, https://github.com/openstack/governance/blob/master/reference/incubation-integration-requirements.rst | 21:31 |
atiwari | redrobot, btw what is the plan around Graduation to integrated? | 21:32 |
redrobot | atiwari we were up for review a couple of weeks ago for the TC meeting | 21:32 |
redrobot | atiwari TC decided we were not ready to graduate for this cycle | 21:33 |
atiwari | :( | 21:33 |
redrobot | they want to see us integrate with at least one project next cycle | 21:33 |
redrobot | as far as Tempest is concerned, we need to talk to their team further. My understanding is that hosting your own tempest tests was a new feature of Tempest, and so the test we have currently in the barbican source meet the requirement of having tempest tests. | 21:35 |
*** kebray has joined #openstack-barbican | 21:35 | |
redrobot | why is Meera trying to add them to Tempest? | 21:35 |
*** bdpayne_ has quit IRC | 21:35 | |
*** bdpayne has joined #openstack-barbican | 21:37 | |
rm_work | redrobot: well, LBaaS will be integrating with YOU, does that count? | 21:37 |
rm_work | :P | 21:37 |
redrobot | rm_work possibly, but since that code hadn't landed when we went up for Graduation review, it didn't count | 21:37 |
rm_work | right | 21:37 |
redrobot | Swift is talking about integrating with us for encrypted-swift :) | 21:38 |
rm_work | nice :) | 21:38 |
atiwari | redrobot, we thought tempest is the place for all tempest tests. | 21:38 |
atiwari | I will check with her and ask to add them in barbican. | 21:39 |
redrobot | atiwari thanks! | 21:39 |
atiwari | redrobot, rm_work sounds OK? | 21:39 |
*** SheenaG1 has joined #openstack-barbican | 21:39 | |
rm_work | atiwari: i'd wait for us to get some clarification... | 21:39 |
rm_work | since apparently there are two different messages circulating | 21:39 |
redrobot | yeah, we definitely need to get some clarification from the Tempest team | 21:40 |
atiwari | rm_work, redrobot than we will wait for a signal from you guys :) | 21:40 |
redrobot | atiwari you're more than welcome to engage the Tempes team yourself | 21:41 |
atiwari | redrobot, as per Matthew's comment in CR, he is looking something from barbican team | 21:42 |
redrobot | atiwari where do you see that? | 21:44 |
redrobot | atiwari I'm reading both of Matthew's comments | 21:44 |
redrobot | his points are that | 21:44 |
atiwari | redrobot, "So I'm -2 here because we need to have a devstack gate job added that actually runs these tests before it can land." | 21:44 |
atiwari | So the requirement for tempest tests is a graduation requirement. If barbican plans to become an integrated project it needs to have tempest tests before it can do that | 21:45 |
atiwari | I am not sure who is going to add tempest | 21:45 |
atiwari | tests | 21:45 |
*** mikedillion has quit IRC | 21:46 | |
atiwari | https://review.openstack.org/#/c/117032/ cr is an attempt to add it | 21:46 |
redrobot | ok, it sounds to me like you're confused, so let me see if I can clear up the confusion | 21:48 |
redrobot | Meera wrote tests for the Tempest tree that test barbican | 21:48 |
redrobot | Matthew rejected the patch because Tempest does not have a dsvm gate for Barbican | 21:48 |
redrobot | Meera did not understand Matthew's rejection, and told Matthew that we already have a gate in Barbican that runs Tempest tests from our own repo | 21:49 |
redrobot | Matthew apparently does not know that projects are running tempests tests out of their own repos. | 21:50 |
redrobot | Matthew apparently thinks that having Tempest tests in the project's repo would not work. He's wrong, since our devstack gate does run the Tempest tests | 21:50 |
redrobot | does that seem like an accuarate summary of what's happening? | 21:51 |
redrobot | the integration requirement does specify that we need some Tempest tets, but it does not say whether they need to be in Tempest proper, or be part of Barbican as they are now | 21:52 |
redrobot | IF the TC does indeed mean that they have to be in Tempest proper, then someone (anyone) could add the extra gate they want to unblock the patch. | 21:52 |
redrobot | this sounds like something either you atiwari or Meera can do | 21:52 |
atiwari | redrobot, thanks. let me see it one more time | 21:56 |
redrobot | atiwari Matthew says that he does not think that Tempest tests can be run from our own repo, but he's clearly wrong because we're doing exactly that. https://github.com/openstack/barbican/blob/master/functionaltests/pre_test_hook.sh | 21:57 |
*** SheenaG1 has quit IRC | 21:57 | |
atiwari | redrobot, ok | 21:57 |
redrobot | now that I think about it, I think the best course of action is to just have Meera send a patch with all those tests to the Barbican repo | 21:58 |
redrobot | once we start talking about Graduation again next cycle we can ask the TC if those tests need to be moved to Tempes proper. | 21:59 |
atiwari | redrobot, make sense | 21:59 |
atiwari | I will ask her to do so | 21:59 |
atiwari | thanks for your time on this | 21:59 |
*** rellerreller has quit IRC | 22:00 | |
*** juantwo has joined #openstack-barbican | 22:01 | |
rm_work | yep that makes sense | 22:06 |
rm_work | also, woodster_ / redrobot: http://i.imgur.com/zVq3Iut.png | 22:06 |
rm_work | That is our proposed workflow | 22:06 |
redrobot | rm_work what happened to the shadow-copy? | 22:07 |
redrobot | rm_work and step 5 better include that consumer registration, or I'm going to shank somebody | 22:07 |
rm_work | redrobot: shadow copy happens after the "driver for processing" | 22:08 |
rm_work | the continuation is: 7. Driver sends data to the LoadBalancer Appliance that was chosen by the system (in our case, Octavia); 8. Octavia receives the data and stores the certificate info in Barbican using the Octavia Service-Account | 22:09 |
rm_work | but anything after step #6 is up to the specific implementation, for instance F5 won't store the cert in Barbican, it'll store it internally on the F5 Hardware | 22:09 |
*** jorge_munoz has quit IRC | 22:24 | |
rm_work | redrobot: so basically, the result of that meeting is that I should not worry about getting reviews on the client CRs I have up for the next week or two? >_> | 22:30 |
rm_work | redrobot: I guess that's fine, but it does mess with my sprint a ton, wish I'd known that a little earlier :P | 22:31 |
*** paul_glass1 has quit IRC | 22:32 | |
redrobot | rm_work my bad... I | 22:43 |
redrobot | rm_work I'll start reviewing that stuff at home today | 22:43 |
redrobot | basically gonna do a bunch of after-hours work just for you. :) | 22:43 |
woodster_ | well, I'd like to land the Containers one ASAP, since that refactors other things in there too, and folks trying to use the client now will not be happy campers :( | 22:44 |
woodster_ | ...at is is just a workflow+1 away | 22:44 |
*** kebray has quit IRC | 22:48 | |
*** kebray has joined #openstack-barbican | 22:48 | |
*** jaosorior has quit IRC | 22:52 | |
rm_work | redrobot: you'd do that? for me?! <3 | 22:54 |
redrobot | rm_work I wouldn't say I'm doing it FOR you.... more like doing it so you'll stop pestering me. :-P | 22:55 |
rm_work | eh, tomato tomato (that expression doesn't work well in text chat...) | 22:59 |
redrobot | tomato tomáto? | 23:00 |
*** atiwari has quit IRC | 23:05 | |
rm_work | :P | 23:06 |
*** nkinder has quit IRC | 23:42 | |
*** bdpayne has quit IRC | 23:44 | |
*** bdpayne has joined #openstack-barbican | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!