Wednesday, 2014-09-24

*** dimtruck is now known as zz_dimtruck00:09
*** woodster_ has joined #openstack-barbican00:34
*** gyee has quit IRC00:41
*** Aurelie92 has joined #openstack-barbican00:48
openstackgerritA change was merged to openstack/barbican: Pin Pecan to 0.6.0 to fix binary secret decrypts  https://review.openstack.org/12349801:00
ryanpetrellohttp://logs.openstack.org/92/123592/1/check/gate-pecan-tox-barbican-tip/1b003b9/console.html01:11
ryanpetrelloany of you have a clue what this is about?01:11
ryanpetrelloor does this seem familiar?01:11
ryanpetrello(I hate testr with *such* a passion)01:11
reaperhulkryanpetrello: you and me both01:21
reaperhulksigh, failure during test discovery...not sure why that would be happening in py2701:23
jenkins-keepProject openstack-barbican-cloudcafe build #37: STILL FAILING in 15 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/37/01:23
jenkins-keepJohn Wood: Pin Pecan to 0.6.0 to fix binary secret decrypts01:23
ryanpetrelloI've figured it out01:23
ryanpetrelloit's legitimate01:23
ryanpetrelloreally frustrating that testr doesn't, e.g., actually print the import traceback01:23
ryanpetrelloand that I actually have to recreate this and go digging01:23
reaperhulkIs the bug in barbican?01:24
*** zz_dimtruck is now known as dimtruck01:25
*** Aurelie92 has quit IRC01:25
aleereaperhulk, please take a look at https://review.openstack.org/#/c/117845/01:28
reaperhulkalee: will do01:28
aleereaperhulk, it needed some changes but is mostly the same as what you saw before.01:28
aleethanks!01:28
reaperhulkI assume we want to get this landed before RC101:28
*** kebray has quit IRC01:28
dstufftreaperhulk: fwiw the reason I like pragma: nocover is it encodes as part of the code which lines are uncoverable instead of having to remember/rediscover it everytime the test fails, plus it should feel bad to do it because it should be a last resort01:34
dstufft'"yea this really isn't coverable"01:34
dstufftplus tests that fail sometimes and humans have to decide when to ignore it is ripe for it becoming noise that is almost always ignored01:34
reaperhulkare there any tools that expose lines marked as uncoverable?01:35
dstufftwhat do you mean by expose01:37
reaperhulkLike, report them in some fashion01:37
reaperhulkI don't have any particular reason to need this, just curious01:37
reaperhulksince a pragma nocover is a scoped ignore it'd be interesting to get a list of ignored lines01:37
dstufftcoverage.py's html output greys them out01:38
dstufftother than that I'm not aware of anything that does that, but it shouldn't bee too dificult to do it using coverage.py itself01:39
reaperhulkalee: reviewed. Other than one last change and a question I'm okay with the CR now01:39
reaperhulkDid I see someone (you?) talk about proposals to pull coverage.py into python core?01:40
dstufftthat was Alex01:40
dstufftI'm pretty sure he wasn't serious01:40
dstufftbut coverage.py is pretty terrible so it'd fit right in with the stdlib01:40
dstufftthe code that is01:40
reaperhulkHeh01:40
*** Amaya66 has joined #openstack-barbican01:50
*** Amaya66 has quit IRC02:38
rm_youreaperhulk: you know, there's a nice CR just sitting there, awaiting your stamp of approval :)02:40
rm_youreaperhulk: https://review.openstack.org/#/c/113393/02:41
reaperhulkInstead of that I am dealing with OpenSSL functions.02:41
reaperhulkSo, really I should have reviewed that02:41
rm_youheh02:41
reaperhulkbut instead I get to figure out why PEM_write_bio_PKCS8PrivateKey writes to a BIO but thinks it's okay to not tell you how many bytes it has written02:41
*** Annamae_Cremin has joined #openstack-barbican02:46
rm_youO_o02:58
rm_you"doesn't tell you" or "lies"02:58
reaperhulkdoesn't tell you.03:00
reaperhulkthere are some other ways to cheat to learn what's inside the BIO, but it sorta ruins the BIO abstraction03:01
*** jvrbanac has quit IRC03:05
*** dimtruck has quit IRC03:06
*** chellygel has quit IRC03:07
*** insequent has quit IRC03:07
*** insequent has joined #openstack-barbican03:22
*** Annamae_Cremin has quit IRC03:39
*** Ayden26 has joined #openstack-barbican03:44
*** Ayden26 has quit IRC04:18
*** chellygel has joined #openstack-barbican04:21
*** zz_dimtruck has joined #openstack-barbican04:21
*** jvrbanac has joined #openstack-barbican04:21
*** zz_dimtruck is now known as dimtruck04:21
*** chellygel has quit IRC04:33
*** dimtruck has quit IRC04:34
*** jvrbanac has quit IRC04:34
*** chellygel has joined #openstack-barbican04:38
*** zz_dimtruck has joined #openstack-barbican04:38
*** jvrbanac has joined #openstack-barbican04:38
*** zz_dimtruck is now known as dimtruck04:38
*** jvrbanac has quit IRC04:44
*** dimtruck has quit IRC04:44
*** chellygel has quit IRC04:45
*** woodster_ has quit IRC04:55
*** juantwo_ has quit IRC04:56
*** jvrbanac has joined #openstack-barbican05:17
*** zz_dimtruck has joined #openstack-barbican05:18
*** chellygel has joined #openstack-barbican05:18
*** zz_dimtruck is now known as dimtruck05:18
*** rm_you| has joined #openstack-barbican05:56
*** rm_you has quit IRC06:00
*** ayoung has quit IRC06:19
*** ayoung has joined #openstack-barbican06:40
*** usimba has joined #openstack-barbican06:58
*** openstack has joined #openstack-barbican09:23
*** SheenaG1 has joined #openstack-barbican11:32
*** SheenaG11 has joined #openstack-barbican11:37
*** SheenaG1 has quit IRC11:40
*** dmakogon_ is now known as denis_makogon11:56
*** akoneru has joined #openstack-barbican12:05
*** juantwo has joined #openstack-barbican12:10
*** akoneru has quit IRC12:30
*** ayoung has quit IRC12:57
*** woodster_ has joined #openstack-barbican13:57
woodster_ryanpetrello: thanks for the fix!13:57
ryanpetrellonp, working on getting it merged :)13:57
woodster_ryanpetrello: nice! So are you getting more request than usual in the run up to Juno RC1?13:59
ryanpetrellonot particularly :)13:59
aleewoodster_, morning14:00
aleewoodster_, jvrbanac : can you look at https://review.openstack.org/#/c/117845 ? other than a couple of minor comments so far, it looks like its ready to go.  would like to address all remaining concerns in the next iteration.14:02
*** rellerreller has joined #openstack-barbican14:07
aleewoodster_, akso sent you email about further progress on cert issuance.14:19
aleerellerreller, please look at https://review.openstack.org/#/c/117845 -- other than a couple of minor changes, it looks like its good to go.14:20
aleewould be nice to address the remainder in next iteration14:20
rellerrellerI am reviewing it now14:21
aleerellerreller, awesome - you rock.14:21
rellerrelleralee I saw reaperhulk gave -114:22
reaperhulkyep, just a small fix needed and I'm good with it though :)14:22
rellerrelleralee let me know when a new version is pushed out that addresses his concerns.14:23
aleerellerreller, yeah - the points he made are valid and will be addressed in next iteration.  just want to make sure there aren't any others.14:23
rellerrellerI added a comment about public keys v certificates. It looks like generate_asymmetric_keys is expected to generate a certificate.14:24
rellerrelleralee this can be addressed during summit, so I have no blocking points.14:25
rellerrellerBut I do think it is an issue that needs to be resolved14:25
aleerellerreller, ok - its not a certifcate that it returns by the way -- its a public key in pem format.14:29
aleerellerreller, looks like ----PUBLIC KEY ----- ...... --- END PUBLIC KEY ----14:29
rellerrelleralee cool, I must have misread that14:30
aleerellerreller, but I agree we should discuss further at summit14:30
*** paul_glass has joined #openstack-barbican14:31
aleerellerreller, going to forward you an email chain I've been having with woodster_ and reaperhulk regarding some db issues I'm encountering with cert issuance -- you might have some ideas on how to proceed ..14:32
aleereaperhulk, you have any idea>14:32
alee?14:32
reaperhulkalee: I saw the email thread but I'm unfamiliar with that section of the code so I don't have any ideas off the top of my head :(14:33
aleeyeah - the failures are db related so a little out of my expertise ..14:34
*** akoneru has joined #openstack-barbican14:46
*** jorge_munoz has joined #openstack-barbican14:47
*** bubbva_ has quit IRC14:58
*** bubbva_ has joined #openstack-barbican14:59
*** paul_glass has quit IRC15:02
*** kebray has joined #openstack-barbican15:06
*** akoneru has quit IRC15:10
openstackgerritPaul Kehrer proposed a change to openstack/barbican-specs: Add kilo section to barbican-specs so kilo blueprints can be submitted  https://review.openstack.org/12375715:11
rm_workredrobot: >_>15:15
rm_workredrobot: secret_refs can't be a dict15:16
rm_workredrobot: see comments15:16
rm_worktrust me, I'd love if it could be15:16
*** akoneru has joined #openstack-barbican15:16
rm_workFixing the other stuff now though (mostly just the docstrings I forgot to update)15:18
redrobotrm_work I wonder if we can just tighten that restriction in the API.  To prevent duplicate names in the same container.15:18
redrobotrm_work and yes, I really do want to remove secret_refs from the subclasses15:19
rm_workk15:19
rm_workredrobot: yeah I asked about doing that15:19
rm_workand people were like "ehhhhh...."15:19
rm_workkinda too late to do it now tho15:19
rm_work… feature freeze15:19
redrobotNot a new feature... just bugfixing the fact that you can have duplicate names now. :)15:20
rm_workI believe we discussed it at the barbican mid-cycle meet15:20
rm_worki brought it up a couple of times15:20
redrobotI can't remember that...15:20
* redrobot hates old age15:20
redrobotI really don't see the benefit of a container with all secret names set to the same thing...15:21
rm_workme either, but15:21
rm_workpeople were dubious of making that change15:21
rm_workit might have been a "we can't now" thing or something15:22
rm_workdon't remember the specific objections either15:22
redrobotwell, hopefully nobody else remembers, and we can get it fixed now ;)15:22
redrobotrm_work actually, that's already the case15:25
rm_workheh15:25
redrobotcreating a container with duplicate names fails with a 40015:25
redrobot"description": "Provided object does not match schema 'Container': Duplicate reference names are not allowed",15:25
*** paul_glass has joined #openstack-barbican15:25
rm_workerrr15:25
rm_workwhen was that fixed15:25
rm_workbecause I asked about this like15:25
rm_workthree weeks ago again15:25
rm_worklet me see if i can find the patchset where someone complained15:26
rm_workhmmm, *I* Mention that in a comment here: https://review.openstack.org/#/c/113393/5/barbicanclient/containers.py15:29
rm_workstill looking for where someone else complained15:29
*** ayoung has joined #openstack-barbican15:30
rm_workfff it must not have been a comment on the patchset...15:32
rm_workI hope I am not imagining things15:32
rm_workredrobot: so you're POSITIVE this isn't possible?15:33
redrobotI just curled an instance of Barbican running HEAD15:33
redrobotthat's where I copy/pasted the error description above15:33
rm_worklooks like jaosorior snuck this on on July 8 without me noticing :P15:38
rm_workI wasn't paying much attention to reviews at that point15:38
rm_workhttps://github.com/openstack/barbican/commit/e19393a0f0ce439caea52cf0b5410e30de2c7dab15:38
rm_workoh, or later, that's the commit date, need to find the CR15:38
rm_workhttps://review.openstack.org/#/c/105490/15:39
rm_workyeah, July 815:39
rm_workWOW, *one* patchset15:39
redrobotrm_work like a BOSS15:40
rm_worksneaky Juan15:40
rm_workrefactor change, changes functionality <_<15:40
openstackgerritAbhishek Koneru proposed a change to openstack/barbican: Add asymmetric key generation in dogtag plugin  https://review.openstack.org/11784515:41
rm_workoh, nm he really did just move it around T_T15:41
rm_workmy bad15:42
rm_workalright, that's been in for a long time -- then I have no idea what the deal was with everyone discussing it at the mid-cycle like it was a problem T_T15:42
rm_workI'll go change it to a straight dict :P15:42
rm_workwoot15:43
redrobotwoooooooot!15:43
*** denis_makogon has quit IRC15:47
*** juantwo_ has joined #openstack-barbican15:52
*** juantwo has quit IRC15:54
aleewoodster_, ?15:55
*** juantwo_ has quit IRC15:56
*** juantwo has joined #openstack-barbican15:57
woodster_alee: hey there16:00
aleewoodster_, hey :)16:01
aleewoodster_, interesting stuff in cert issuance land16:01
woodster_alee: not sure why you are seeing the dup session error, but looking now16:01
aleewoodster_, cool16:01
aleewoodster_, by the way, are the cert plugins supposed to be __init__ each time they are called?16:02
woodster_alee: you mentioned your changes were in a patch of a CR?16:02
openstackgerritArun Kant proposed a change to openstack/barbican: Adding keystone notification listener support  https://review.openstack.org/11081716:02
aleewoodster_, not yet - I can send you a patch -- better yet , I'll put up a CR16:02
woodster_I believe so...the cert stuff went in about the time that reaperhulk moved his HSM plugin over to a singleton16:03
woodster_alee: yeah, wip CR would be good16:03
aleewoodster_, ok will do right now.  In the meantime, you could review https://review.openstack.org/117845 :)16:04
woodster_jvrbanac: odd about the devstack failure and recheck no bug fixing it :\16:04
woodster_alee: ok :)16:04
arunkantwoodster_, jvrbanac : Can this CR be reviewed https://review.openstack.org/#/c/110817/ . Just now resolved another merge conflict as its is in review for over 7 weeks.16:11
aleewoodster_, ah phooey - my patch is on top of an earlier version of akoneru patch.  I'll send you a patch by email to start with ..16:12
openstackgerritA change was merged to openstack/barbican: Remove restrictive hard-coded orders validation  https://review.openstack.org/12254716:14
aleereaperhulk, rellerreller -- https://review.openstack.org/117845 is ready for you :)16:18
aleewoodster_, I'll put up an actual  wip cr once akoneru patch is +2'e and workflowed.  in the meantime , I sent you a patch.16:20
rellerrelleralee done and done16:20
reaperhulklgtm as well16:20
aleesweet - thanks all :)16:21
akonerurellerreller, reaperhulk , woodster_ ,alee - Thanks!16:23
woodster_arunkant: added a comment to your CR. jvrbanac, reaperhulk, redrobot: please also take a look.16:27
*** paul_glass has quit IRC16:30
*** openstackgerrit has quit IRC16:35
jenkins-keepProject openstack-barbican-cloudcafe build #38: STILL FAILING in 17 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/38/16:40
jenkins-keepJohn Wood: Remove restrictive hard-coded orders validation16:40
*** paul_glass has joined #openstack-barbican16:43
*** jamielenz has joined #openstack-barbican16:53
*** jamielenz is now known as jamielennox16:53
arunkantwoodster_ : I also prefer my original approach. Changed it to address earlier review concern. If consensus is too have that style, I can change it back. I just want to avoid this CR to miss merge opportunity because of this change.16:53
*** juantwo has quit IRC17:01
*** dimtruck is now known as zz_dimtruck17:04
*** juantwo has joined #openstack-barbican17:04
*** juantwo has quit IRC17:04
*** juantwo has joined #openstack-barbican17:05
*** zz_dimtruck is now known as dimtruck17:16
*** openstackgerrit has joined #openstack-barbican17:24
*** ayoung has quit IRC17:26
jenkins-keepProject openstack-barbican-cloudcafe build #39: STILL FAILING in 17 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/39/17:41
jenkins-keepakoneru: Add asymmetric key generation in dogtag plugin17:41
*** ayoung has joined #openstack-barbican17:41
*** paul_glass has quit IRC17:48
*** atiwari has joined #openstack-barbican17:48
*** openstackgerrit has quit IRC17:51
*** openstackgerrit has joined #openstack-barbican17:52
*** akoneru is now known as akoneru_lunch18:09
*** bdpayne has joined #openstack-barbican18:27
*** paul_glass has joined #openstack-barbican18:33
jvrbanacwoodster_, https://review.openstack.org/#/c/12015618:35
rm_workredrobot: could you look at the discussion here: https://review.openstack.org/#/c/117889/17/docs/src/docbkx/ck-devguide.xml ?18:40
rm_workI am maybe being pedantic...18:41
rm_works/maybe/probably/18:41
rm_workwoodster_: ^^18:46
*** rellerreller has quit IRC19:04
*** SheenaG11 has quit IRC19:09
*** SheenaG1 has joined #openstack-barbican19:13
*** akoneru_lunch is now known as akoneru19:16
*** dimtruck is now known as zz_dimtruck19:21
*** SheenaG1 has quit IRC19:22
*** SheenaG1 has joined #openstack-barbican19:24
*** gyee has joined #openstack-barbican19:34
*** atiwari has quit IRC19:45
*** openstackgerrit has quit IRC19:46
*** openstackgerrit has joined #openstack-barbican19:47
*** atiwari has joined #openstack-barbican19:56
*** atiwari has quit IRC20:05
*** usimba has quit IRC20:06
*** usimba has joined #openstack-barbican20:06
*** zz_dimtruck is now known as dimtruck20:06
*** usimba has quit IRC20:16
*** usimba has joined #openstack-barbican20:19
*** atiwari has joined #openstack-barbican20:24
*** paul_glass has quit IRC20:28
*** usimba has quit IRC20:28
*** usimba has joined #openstack-barbican20:31
*** usimba has quit IRC20:36
*** juantwo has quit IRC20:48
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Add asymmtric order validator  https://review.openstack.org/11869720:58
openstackgerritA change was merged to openstack/barbican-specs: Add kilo section to barbican-specs so kilo blueprints can be submitted  https://review.openstack.org/12375721:10
openstackgerritArvind Tiwari proposed a change to openstack/barbican: Code clean-up due to type order enhancement  https://review.openstack.org/12126921:13
rm_workI hate py26 compatibility so much21:27
rm_workwhen can we drop this BS :(21:27
openstackgerritA change was merged to openstack/barbican: Update Getting Started Guide to include tech review feedback  https://review.openstack.org/12015621:28
openstackgerritA change was merged to openstack/barbican: removed whitespace from pom.xml  https://review.openstack.org/12016121:28
openstackgerritA change was merged to openstack/barbican: removed tenant id from code samples  https://review.openstack.org/12016321:28
*** juantwo has joined #openstack-barbican21:35
openstackgerritJoe Gordon proposed a change to openstack/barbican: Deduplicate HACKING.rst with docs.openstack.org/developer/hacking/  https://review.openstack.org/12385921:35
openstackgerritAdam Harwell proposed a change to openstack/python-barbicanclient: Add Containers to python-barbicanclient  https://review.openstack.org/11339321:38
rm_workredrobot: BOOM. ^^21:38
rm_workwoodster_ / redrobot: gogogo21:38
rm_workafk for 20 while you review :P21:38
redrobotSTOP THE PRESS!!!  rm_work has a new patch!21:38
rm_work:P:P21:38
* chellygel gets a chair and hot cocoa out for him to come sit next to redrobot's desk21:39
jenkins-keepProject openstack-barbican-cloudcafe build #40: STILL FAILING in 16 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/40/21:54
jenkins-keep* constanze.kratel: Update Getting Started Guide to include tech review feedback21:54
jenkins-keep* constanze.kratel: removed whitespace from pom.xml21:54
jenkins-keep* constanze.kratel: removed tenant id from code samples21:54
redrobotthanks for the update jenkins-keep21:55
*** juantwo_ has joined #openstack-barbican21:57
-openstackstatus- NOTICE: The openstack-infra/config repo will be frozen for project-configuration changes starting at 00:01 UTC. If you have a pending configuration change that has not merged or is not in the queue, please see us in #openstack-infra.21:57
*** juantwo has quit IRC22:00
woodster_https://github.com/JAORMX22:06
woodster_Great photo, wonder what he is up to there!22:06
rm_workchellygel: ooo, cocoa :P22:26
rm_workI mean, I don't *always* stand behind redrobot like a taskmaster while he reviews my changes...22:27
rm_workJust *most* of the time22:27
*** juantwo_ has quit IRC22:27
*** juantwo has joined #openstack-barbican22:28
rm_workthough I am just about to walk over there because I have become impatient again (patience is not my best virtue, nor possibly a virtue I am gifted with in any capacity)22:37
redrobotrm_work won't do you no good... got my hour long PyTexas board meeting today.22:37
rm_workah, crap22:37
*** juantwo_ has joined #openstack-barbican22:41
*** juantwo_ has quit IRC22:41
*** juantwo_ has joined #openstack-barbican22:41
*** juantwo has quit IRC22:42
*** openstackgerrit has quit IRC22:47
*** openstackgerrit_ has joined #openstack-barbican22:48
*** openstackgerrit_ is now known as openstackgerrit22:48
*** atiwari has quit IRC22:59
rm_workwoodster_: can you look at the discussion in https://review.openstack.org/#/c/117889/17/docs/src/docbkx/ck-devguide.xml and tell me if I am just being super pedantic?22:59
rm_workI mean, I am pretty sure I am being really pedantic, but is it at least a valid point?22:59
woodster_rm_work: I'm not too torqued about it...I'm also not a fan of having only the first word capitalized in titles, but if that is the style in use, I'm fine with it. As long as the doc content is accurate, I'm easily pleased beyond that23:03
rm_workk, I just don't know if I got the point across correctly23:04
rm_workstill wasn't a -1 tho, so whatever23:05
openstackgerritA change was merged to openstack/barbican: Bringing translation.py coverage up to 100%  https://review.openstack.org/12256423:23
*** kebray has quit IRC23:28
*** arunkant has quit IRC23:33
woodster_rm_work: I see your point but concede to the writers' experience23:37
*** gyee has quit IRC23:45
*** openstackstatus has quit IRC23:55
*** openstack has joined #openstack-barbican23:55
*** openstackstatus has joined #openstack-barbican23:55
*** ChanServ sets mode: +v openstackstatus23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!