*** openstack has joined #openstack-barbican | 12:40 | |
*** ayoung has joined #openstack-barbican | 12:50 | |
*** nkinder has quit IRC | 13:12 | |
*** joesavak has joined #openstack-barbican | 13:53 | |
*** nkinder has joined #openstack-barbican | 14:00 | |
*** lbragstad has joined #openstack-barbican | 14:06 | |
*** atiwari has joined #openstack-barbican | 14:20 | |
*** akoneru has joined #openstack-barbican | 14:21 | |
*** zz_dimtruck is now known as dimtruck | 14:23 | |
*** dstanek has joined #openstack-barbican | 14:26 | |
*** SheenaG1 has joined #openstack-barbican | 14:52 | |
*** paul_glass has joined #openstack-barbican | 15:05 | |
*** jvrbanac has joined #openstack-barbican | 15:13 | |
*** chellygel has joined #openstack-barbican | 15:14 | |
rm_work | chellygel: is doug in the office? | 15:15 |
---|---|---|
chellygel | not yet rm_work | 15:15 |
rm_work | jaosorior: yeah, just a rebase on the str patch, but I want to double-check to make sure it all looks good still. :) | 15:15 |
rm_work | some of the rebases required some pretty big conflict handling | 15:16 |
rm_work | *should* be fine | 15:16 |
jaosorior | Alright, let me know | 15:16 |
jaosorior | I'm gonna buy some good beers and review songs code at home | 15:16 |
rm_work | but yeah, pretty much have to run through all of the cases by hand, because it's all a visual inspection sort of thing | 15:16 |
jaosorior | We should automate this some how... | 15:19 |
jaosorior | Anyway, are you going to Paris? | 15:19 |
jaosorior | * review some | 15:20 |
jaosorior | Damn autocorrect | 15:20 |
rm_work | jaosorior: well, i have a plane ticket and a hotel reservation…. but no | 15:23 |
jaosorior | Whaaaa | 15:23 |
jaosorior | How come? | 15:23 |
rm_work | got cut because of some budget bullshit | 15:23 |
jaosorior | :( | 15:23 |
rm_work | so now RS gets to pay for like 1k in cancellation fees and NOT send me <_< | 15:23 |
rm_work | i don't even | 15:23 |
jaosorior | That doesn't sound smart | 15:23 |
rm_work | it does not | 15:23 |
jaosorior | Well, what a bummer dude | 15:24 |
rm_work | but that's the way the cookie crumbles | 15:24 |
rm_work | eh, i don't actually like Paris anyway, so meh :P | 15:24 |
rm_work | and that's 26h of flying I don't have to do | 15:24 |
rm_work | but was hoping to be able to hang out, and had a brownbag talk i wanted to give :( | 15:25 |
jaosorior | To hell with cookies, eat tacos instead :P | 15:25 |
chellygel | ^ this | 15:25 |
jaosorior | Sorry, I'm hungry | 15:25 |
rm_work | heh | 15:25 |
rm_work | well, chellygel and I can hang out and watch the streams and eat tacos | 15:25 |
rm_work | since I think she's basically the only one not going from the barbican team? | 15:26 |
rm_work | :( | 15:26 |
jaosorior | Well, you can't get proper tacos in Europe | 15:26 |
rm_work | Paris had pretty good crepes | 15:27 |
rm_work | and also a great steak frittes place like down the road from where the conference is | 15:27 |
jaosorior | Awesomeness | 15:27 |
rm_work | I was there like a year ago <_< | 15:28 |
jaosorior | Never been to Paris | 15:28 |
rm_work | not missing too much IMO | 15:28 |
rm_work | but I am a heathen that doesn't enjoy the arts | 15:28 |
jaosorior | I tend to travel to stranger and smaller cities in my free time | 15:28 |
rm_work | the Louvre was like, my personal hell | 15:28 |
rm_work | well, I like some art, just not the kind the Louvre has | 15:29 |
jaosorior | I like funky societal aspects more than art, that's what I prefer to see when I travel | 15:30 |
rm_work | all I got from my trip to Paris was that native parisians were mostly assholes to us, and there are a ton of gypsies that are super aggressive in the touristy areas | 15:30 |
jaosorior | Damn | 15:31 |
jaosorior | Yeah, I've heard that before | 15:31 |
jaosorior | Even from a friend that is a native parisian himself | 15:31 |
rm_work | versus Germany (Berlin, and especially Frankfurt) where everyone is super friendly and helpful | 15:31 |
rm_work | and really laid-back | 15:32 |
jaosorior | Dude, Poland | 15:32 |
jaosorior | Friendliest pace I've ever been to | 15:32 |
rm_work | never been | 15:32 |
jaosorior | Needless to say, cheap as heeeell | 15:32 |
rm_work | :P | 15:32 |
jaosorior | Got myself a litre of beer for about 3 dollars in a pub | 15:33 |
rm_work | heh | 15:33 |
jaosorior | And the food was obscenely good | 15:33 |
jaosorior | I miss Poland so much :( | 15:33 |
rm_work | yeah, I miss the food (mostly the turkish food, honestly) from germany germany/holland/denmark | 15:34 |
rm_work | err, i guess germany is good enough to list twice :P | 15:34 |
jaosorior | Denmark is pricey, but you can get really good food | 15:34 |
jaosorior | Lol | 15:34 |
rm_work | yeah, a burger combo at burger king was like $17 IIRC | 15:35 |
rm_work | not that that's good food, but as a price index :P | 15:35 |
rm_work | i lost a lot of weight in just a week in denmark <_< | 15:35 |
jaosorior | Uh... | 15:35 |
jaosorior | Burger king is not an index I'm acquainted to | 15:36 |
rm_work | heh | 15:36 |
rm_work | i mean, like mcdonalds | 15:36 |
rm_work | but i didn't see a mcdonalds | 15:36 |
rm_work | we went to burger king because we were hoping it'd be cheaper… it was not | 15:36 |
*** jorge_munoz has joined #openstack-barbican | 15:37 | |
jaosorior | Anyway | 15:37 |
jaosorior | Turkish kebab places FTW | 15:37 |
rm_work | lulz yes | 15:37 |
rm_work | the food in france was meh compared to the rest of europe (italy, spain, germany, etc) IMO | 15:38 |
*** Guest68643 is now known as redrobot | 15:38 | |
rm_work | ah there's reaperhulk | 15:39 |
rm_work | err | 15:39 |
rm_work | redrobot: | 15:39 |
rm_work | redrobot: thanks for merging my change! here's a CR to review as thanks: https://review.openstack.org/#/c/118494/ | 15:39 |
*** hockeynut has quit IRC | 15:39 | |
*** hockeynut has joined #openstack-barbican | 15:40 | |
jaosorior | Which CR was merged? | 15:42 |
*** gyee has joined #openstack-barbican | 15:44 | |
*** ayoung is now known as ayong | 15:50 | |
rm_work | jaosorior: the main one for client-containers | 16:01 |
jaosorior | daaaaamn | 16:02 |
jaosorior | awesome! | 16:02 |
rm_work | so, two CRs to go | 16:02 |
rm_work | the __str__ fix, and one followup to fix Secrets/Orders to follow the finally agreed upon model for those classes | 16:03 |
jaosorior | awesome | 16:03 |
rm_work | (and to clean up some attributes/functions that should have been be private to begin with) | 16:03 |
redrobot | awesome indeed | 16:03 |
jaosorior | to be honest I still don't dig the generic_data/columns approach... but I couldn't think of anything else when I tried giving it a thought | 16:03 |
rm_work | redrobot: ah, you are there | 16:03 |
rm_work | jaosorior: yeah, it's a quandry | 16:03 |
redrobot | rm_work indeed I am, but Barbican proper is priority right now so we can cut RC1. Might not get to review your str patch until later. | 16:04 |
*** ayong is now known as ayoung | 16:04 | |
rm_work | I'm not nearly as tied to this model as I was to some of the other stuff redrobot killed, but I do think that code is a *fairly* elegant way to handle what is otherwise kind of a mess | 16:04 |
rm_work | redrobot: alright, I guess that's fine… though it is much smaller | 16:04 |
rm_work | redrobot: and I'd like to get the client in a consistent state | 16:05 |
jaosorior | rm_work: re-reviewing it just now | 16:05 |
rm_work | jaosorior: yeah, shouldn't be anything besides rebases in there since your last reviews | 16:05 |
rm_work | but worth double-checking | 16:05 |
redrobot | rm_work I concurr... I've been spending a lot of time looking into Keystone sessions so we can clean up all the auth crud in the client. | 16:05 |
rm_work | really, if you can pull it down and test, that's the most helpful thing | 16:05 |
redrobot | does that __str__ still do the nested ascii tables? 'cause that was FUGLY | 16:06 |
rm_work | redrobot: no | 16:06 |
jaosorior | redrobot: what about keystone sessions? | 16:06 |
rm_work | redrobot: ah I am going to have to make a BP for kilo for Barbican to pull in some more keystone middleware stuff, but that can wait a bit | 16:07 |
rm_work | just a heads up | 16:07 |
redrobot | jaosorior barbicanclient currently has its own concept of auth. We've got façades for Keystone objects and all kinds of crap I want to get rid of | 16:07 |
rm_work | need support for this in Barbican: https://review.openstack.org/#/c/108384/ | 16:08 |
redrobot | jaosorior basically standardize on Keystone Auth plugins + Sessions, and get rid of barbicanclient's concept of auth, so users don't have to learn two auth strategies. | 16:08 |
rm_work | not sure actually if that requires an update but i didn't see any of that code in barbican's middleware layer | 16:08 |
jaosorior | rm_work: damn, that CR 108384 seems promising | 16:09 |
jaosorior | and would save me a lot of the work that I'm doing at the office at the moment | 16:09 |
rm_work | yeah, it solves my problem fairly neatly | 16:11 |
jaosorior | redrobot: anyway, that sounds like useful stuff | 16:12 |
jaosorior | gonna talk about that in the summit? | 16:12 |
redrobot | jaosorior about the auth stuff? I can probably add it to today's weekly meeting. I would like to get that stuff in as the last breaking change so we can do a major version bump of the client. | 16:13 |
redrobot | and still have it out for use with Juno final. | 16:13 |
jaosorior | oooh | 16:13 |
jaosorior | planning it for Juno? | 16:13 |
jaosorior | that sounds tight | 16:13 |
redrobot | I know. But I'd hate to release a 3.x just to release a 4.x shortly after. | 16:14 |
* redrobot is going to be hella busy before Paris. | 16:14 | |
jaosorior | I'm not particularly keen on rushing features | 16:14 |
*** rm_work is now known as rm_work|away | 16:14 | |
jaosorior | well, no-one is, I guess | 16:15 |
jaosorior | but still | 16:15 |
redrobot | It's a good think we've got some stellar code reviewers on the client side ;) | 16:15 |
jaosorior | Good thing I bought a bunch of good beers | 16:15 |
jaosorior | anyway | 16:16 |
jaosorior | they are getting cold | 16:16 |
jaosorior | bring on the CRs! :P | 16:16 |
*** rm_work|away is now known as rm_work | 16:20 | |
rm_work | heh, i'll be working on the last of mine when I get in the office, which will be soon as i'm leaving for the office now | 16:21 |
*** hockeynut has quit IRC | 16:22 | |
*** hockeynut has joined #openstack-barbican | 16:23 | |
arunkant | woodster_ : What needs to be done to get https://review.openstack.org/#/c/110817/ merged? It has been in review for quite a while. | 16:24 |
jaosorior | rm_work: in the 118494 | 16:26 |
jaosorior | only thing I would argue against is how things are being tested using the string representation | 16:26 |
jaosorior | not that it's completely wrong | 16:26 |
jaosorior | but maybe some testing using the direct parameters would be a good diea | 16:27 |
jaosorior | *idea | 16:27 |
woodster_ | arunkant: please add this to the IRC meeting agenda today. | 16:38 |
*** akoneru has quit IRC | 17:10 | |
jaosorior | By the way, I would like to get rid of the instances of tenant in barbican and replace them for project... or vice versa, but at least I would like some consistency | 17:27 |
jaosorior | Although, tenant appears to be 580 times in the code base, while project only 103 | 17:27 |
*** atiwari has quit IRC | 17:47 | |
openstackgerrit | A change was merged to openstack/barbican: Add asymmtric order validator https://review.openstack.org/118697 | 17:48 |
openstackgerrit | A change was merged to openstack/barbican: Adding support for allowing binary data as-is as part of PUT https://review.openstack.org/120618 | 17:51 |
*** bdpayne has joined #openstack-barbican | 17:54 | |
*** ametts has joined #openstack-barbican | 17:59 | |
*** akoneru has joined #openstack-barbican | 18:01 | |
*** akoneru_ has joined #openstack-barbican | 18:03 | |
rm_work | wtf, all my secrets disappeared, but not my containers <_< | 18:05 |
*** akoneru has quit IRC | 18:06 | |
*** kebray has joined #openstack-barbican | 18:06 | |
rm_work | uhh weird, is tenant_id supposed to be a column on the `secrets` table, I assume? | 18:06 |
rm_work | ah no, i see, tenant_secrets | 18:07 |
rm_work | ffff they all expired T_T | 18:09 |
jenkins-keep | Project openstack-barbican-cloudcafe build #46: STILL FAILING in 16 min: http://jenkins.cloudkeep.io/job/openstack-barbican-cloudcafe/46/ | 18:10 |
jenkins-keep | * arun.kant: Adding support for allowing binary data as-is as part of PUT | 18:10 |
jenkins-keep | * arvind.tiwari: Add asymmtric order validator | 18:10 |
*** SheenaG1 has quit IRC | 18:10 | |
*** SheenaG1 has joined #openstack-barbican | 18:11 | |
rm_work | so, is the expected response for an expired secret really a 404? >_> | 18:17 |
rm_work | seems weird that I have a container with some secrets in it, I fetch the container, I fetch the secrets, and I get 404s on the secrets instead of anything that actually tells me "this is what the secret's metadata was, but it's expired now" | 18:18 |
*** vdreamarkitex has joined #openstack-barbican | 18:26 | |
rm_work | jaosorior: asleep yet? :P | 18:34 |
woodster_ | rm_work: when a secret expires, it is considered to be non-existent, at least that was the original business purpose | 18:36 |
rm_work | woodster_: yeah it's just a little odd that they "disappear" | 18:36 |
rm_work | had to dig into the DB to figure out wtf | 18:37 |
jaosorior | rm_work: no, just doing laundry and drinking a beer | 18:39 |
jaosorior | whattup? | 18:39 |
rm_work | http://pastebin.com/raw.php?i=JJm9z2aH | 18:49 |
rm_work | jaosorior: for generics | 18:49 |
rm_work | versus... | 18:49 |
rm_work | http://pastebin.com/raw.php?i=ctvtQbZq | 18:50 |
rm_work | I could maybe try messing with the Field list... | 18:50 |
jaosorior | well, I gotta say it does look fine | 18:52 |
rm_work | the generic one looks fine? with the name==ref format? | 18:54 |
rm_work | err, name=ref | 18:54 |
jaosorior | well, I would have actually ignored the name | 18:55 |
jaosorior | since the href is the actual important field here | 18:55 |
rm_work | yeah, but... it IS named | 18:56 |
rm_work | like, "in the container" named, not the name of the secret | 18:56 |
jaosorior | uh.... dude, I suck at usability things | 18:56 |
jaosorior | for me it kinda makes sense | 18:57 |
rm_work | k well | 18:57 |
rm_work | you'd +1 that? | 18:57 |
jaosorior | maybe it's something to ask for an opinion in the meeting? | 18:57 |
jaosorior | I would, actually | 18:57 |
rm_work | when is the meeting again? | 18:58 |
rm_work | is it Mondays? | 18:58 |
jaosorior | yes | 18:58 |
jaosorior | so, today | 18:58 |
rm_work | kk | 18:58 |
rm_work | yeah | 18:58 |
jaosorior | you can bring it up | 18:59 |
jaosorior | maybe someone has an opinion about it | 18:59 |
rm_work | kk | 19:00 |
rm_work | pushing this as-is though for now | 19:00 |
rm_work | there WAS a bug remaining from part of the rebase :) | 19:00 |
jaosorior | whaaaat | 19:00 |
rm_work | since something inside the container code changed | 19:00 |
rm_work | the __str__ stuff needed to be updated | 19:01 |
rm_work | for generic containers | 19:01 |
jaosorior | well, good thing the other stuff is merged already | 19:01 |
rm_work | yeah | 19:01 |
openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Change object __str__() to use pretty formatting https://review.openstack.org/118494 | 19:01 |
*** kebray has quit IRC | 19:04 | |
jaosorior | oho | 19:06 |
jaosorior | by the way | 19:06 |
jaosorior | there are tests for CertificateContainers missing | 19:06 |
jaosorior | oh, uhm... I see the test now | 19:10 |
jaosorior | that's strange | 19:10 |
jaosorior | coverage says otherwise | 19:10 |
jaosorior | can you recheck on your machine? if coverage says that the _get_formatted_data function is being covered? | 19:11 |
redrobot | jaosorior I agree ont he Project vs Tenant thing. We should use Project moving forward. That's what Keystone v3 uses. | 19:13 |
jaosorior | redrobot | 19:13 |
jaosorior | If I want to do a change like that, do I need to submit a blueprint? | 19:13 |
jaosorior | And, should I push it for Juno? or do I leave it for Kilo? | 19:14 |
redrobot | I think it's way too late for Juno. The concern is really the DB schma. Since Juno will be called blah_tenant_blah, we'll need to migrate the schema to change them to blah_project_blah | 19:15 |
jaosorior | yeah | 19:15 |
jaosorior | but I guess the sooner the earlier | 19:15 |
jaosorior | *the better | 19:15 |
jaosorior | that way people have less hassle migrating | 19:15 |
redrobot | yeah, as far as the BP, not sure... I'm inclined to say yes, since it does affect the db schema | 19:16 |
jaosorior | well | 19:16 |
jaosorior | I'll write a BP | 19:16 |
jaosorior | its only a good thing, since I should be pushing the guys approving these stuff in my company to work more efficiently | 19:16 |
redrobot | kk, I think someone already started a kilo/ directory in barbican-specs | 19:16 |
jaosorior | And maybe with a BP I can get my PO to approve me more time to work in OpenStack, hohohohooo | 19:17 |
redrobot | we can start merging work after we cut Juno-RC1 | 19:17 |
redrobot | haha, that'd be awesome... it's been quiet here while you've been busy on other stuff. :-P | 19:17 |
jaosorior | http://iusedtohavehair.files.wordpress.com/2009/10/mr-burns-evil-laugh.png | 19:17 |
redrobot | EXCELLENT! | 19:18 |
jaosorior | Dude, trust me, I've been quite eager to get started again with OpenStack stuff | 19:18 |
jaosorior | but my backlog is full of other stuff :( | 19:19 |
redrobot | womp womp :( ... well at least you get to go to Paris | 19:19 |
jaosorior | are you going+ | 19:19 |
jaosorior | ? | 19:19 |
redrobot | yep, the new PTL has to be there :D | 19:20 |
jaosorior | hohoooo | 19:20 |
jaosorior | congrats dude! | 19:20 |
redrobot | thanks! | 19:20 |
redrobot | I won the election by a landslide! | 19:20 |
redrobot | also, nobody else ran against me, but that's just a minor detail. | 19:21 |
rm_work | awww did i miss the voting? | 19:21 |
rm_work | when was the voting!? | 19:21 |
redrobot | jaosorior if you have a few minutes right now, would you mind adding +1 votes to the top 3 things you'd like to talk about at the summit: https://etherpad.openstack.org/p/barbican-kilo-design-sessions | 19:21 |
redrobot | rm_work the only contested spots are Cinder, Heat and Horizon. | 19:22 |
jaosorior | sure thing | 19:22 |
rm_work | right, but was there still not a vote? >_> | 19:22 |
redrobot | rm_work vote is ongoing, ends October 3. If you got code merged into any of those 3 projects you should have gotten a ballot. | 19:23 |
rm_work | hmm | 19:23 |
rm_work | yeah but | 19:23 |
rm_work | was there not a vote for Barbican? | 19:23 |
rm_work | usually there is still a vote even with one candidate >_> | 19:23 |
redrobot | rm_work nope, there's only a need for a vote if you have more than one choice. | 19:23 |
redrobot | seems like a lot of wasted energy for a vote that only has one candidate | 19:24 |
rm_work | the other choice is assumed to be "no confidence" :P | 19:24 |
redrobot | much like the North Korean elections. | 19:24 |
jaosorior | How many should I vote for? | 19:24 |
redrobot | jaosorior 3 please. We're voting on what needs to go on the actual schedule | 19:24 |
redrobot | jaosorior the other topics will be covered at the Barbican table. | 19:24 |
redrobot | jaosorior so discussions that need community-wide input should be listed on the schedule. Anything that we can sort out within Barbican can stay as just a table discussion. | 19:25 |
jaosorior | my votes have been casted | 19:28 |
jaosorior | and stuff | 19:34 |
jaosorior | at what time is the meeting today? | 19:35 |
openstackgerrit | John Wood proposed a change to openstack/barbican: Fix error in two-step secret PUT with base64 https://review.openstack.org/124274 | 19:37 |
redrobot | jaosorior in 20 min. | 19:39 |
jaosorior | cool | 19:39 |
*** juantwo has quit IRC | 19:42 | |
*** juantwo has joined #openstack-barbican | 19:42 | |
*** atiwari has joined #openstack-barbican | 19:52 | |
rm_work | redrobot: about to push that fixup CR to review | 19:54 |
redrobot | Wekly meeting starts in 5 min on #openstack-meeting-alt | 19:55 |
jaosorior | cool | 19:58 |
*** juantwo has quit IRC | 20:00 | |
*** juantwo has joined #openstack-barbican | 20:00 | |
redrobot | Barbican Weekly Meeting starts now in #openstack-meeting-alt | 20:00 |
*** juantwo has quit IRC | 20:03 | |
*** juantwo has joined #openstack-barbican | 20:03 | |
*** dimtruck is now known as zz_dimtruck | 20:05 | |
*** kaitlin-farr has joined #openstack-barbican | 20:06 | |
*** zz_dimtruck is now known as dimtruck | 20:06 | |
*** ayoung is now known as ayoung-afk | 20:11 | |
jaosorior | By the way, in CR: https://review.openstack.org/#/c/121272 should there still be the copyright notice? as far as I remember that shouldn't be there | 20:22 |
jaosorior | jvrbanac, hockeynut: ^ | 20:23 |
jvrbanac | jaosorior, copyright notice where? | 20:23 |
jaosorior | Copyright 2014 Rackspace | 20:23 |
jaosorior | at the top of the newly added files | 20:23 |
jvrbanac | just following the pattern of the other files | 20:24 |
jaosorior | yeah... If I remember correctly those shouldn't be there either | 20:24 |
jaosorior | Whatever, I'll investigate about it | 20:25 |
*** juantwo has quit IRC | 20:25 | |
jaosorior | and if needed I'll remove it | 20:25 |
jvrbanac | jaosorior, awesome ok. Yeah, I thought the community was still debating on what to do with that stuf | 20:26 |
jaosorior | there was a wiki about it...somewhere... gotta investigate about it first | 20:26 |
openstackgerrit | Arvind Tiwari proposed a change to openstack/barbican: Code clean-up due to type order enhancement https://review.openstack.org/121269 | 20:37 |
*** ayoung-afk is now known as ayoung | 20:45 | |
*** rellerreller has joined #openstack-barbican | 20:48 | |
*** akoneru_ has quit IRC | 20:49 | |
openstackgerrit | Adam Harwell proposed a change to openstack/python-barbicanclient: Fix consistency between Order/Secret/Container https://review.openstack.org/124889 | 21:16 |
rm_work | redrobot: ^^ cleaning up the namespaces, and updating Order/Secret classes to match Container (and some other consistency changes to bring everything in-line) | 21:17 |
redrobot | rm_work nice! ... now can you help review some barbican stuff so I can get to your CR? :) | 21:17 |
rm_work | sure | 21:17 |
rm_work | though, warning, I am going to be pulled off Barbican next week pretty much, as far as "officially" having time allocated | 21:18 |
rm_work | I will try to keep doing stuff but we're reprioritizing internally :/ | 21:18 |
redrobot | T_T | 21:18 |
rm_work | so I can't just sit here Barbican-ing all day :( | 21:18 |
rm_work | doesn't mean I can't do reviews here and there though :) | 21:19 |
rm_work | which ones are currently blockers? | 21:19 |
redrobot | rm_work https://review.openstack.org/#/c/110817 | 21:20 |
rm_work | ah yeah, saw that | 21:20 |
rm_work | looked like it was already well on its way (JW +2) | 21:20 |
*** joesavak has quit IRC | 21:21 | |
redrobot | yeah... I suppose I really need jvrbanac or reaperhulk or dstufft to look at it | 21:21 |
rm_work | well, it's got some hacking issues | 21:22 |
rm_work | but i assume we won't touch on that yet :P | 21:22 |
rm_work | will just need to be another round of hacking update fixes... | 21:22 |
rm_work | honestly, not sure why we didn't just wrap that up and update the req to the new hacking already | 21:22 |
rm_work | we had 95% of the project fixed | 21:22 |
kaitlin-farr | rm_work redrobot, how do you check for hacking violations? I thought tox already checked that? | 21:37 |
rm_work | I check with my brain-parser | 21:37 |
rm_work | I did a lot of work bringing barbican up to speed with the new hacking stuff, which we don't use yet | 21:38 |
*** reaperhulk has quit IRC | 21:38 | |
redrobot | kaitlin-farr there's a new version of hacking that adds more stuff. Won't get checked until we update our requirements.txt | 21:38 |
kaitlin-farr | redrobot, Ooooh, got it. | 21:38 |
rm_work | yeah barbican is on hacking>=0.8.0,<0.9 | 21:39 |
rm_work | >0.9 adds some... things | 21:39 |
kaitlin-farr | Ohkay, good to know. I'll be sure to check my future patches | 21:39 |
rm_work | it's a bit more pedantic, especially around docstrings and split-line stuff | 21:39 |
kaitlin-farr | Are we planning on adding >0.9 for this release? | 21:40 |
rm_work | no more \ | 21:40 |
rm_work | kaitlin-farr: probably not <_< | 21:40 |
rm_work | I wish we would though | 21:40 |
rm_work | would be nice to get it out of the way | 21:40 |
redrobot | umm... maybe? I think we need to sync with global-reqs for RC1 | 21:40 |
*** reaperhulk has joined #openstack-barbican | 21:41 | |
rm_work | jaosorior: I think maybe earlier you were looking for http://docs.openstack.org/developer/hacking/#openstack-licensing ? | 21:42 |
redrobot | nice find guys | 21:45 |
rm_work | jaosorior: how come you didn't give woodster_ a hard time on https://review.openstack.org/#/c/124274/ eh? :P | 21:49 |
rm_work | You made me spell out every single word and make my functions like 30 characters long :P | 21:50 |
rm_work | (not that I disagree) | 21:50 |
*** kaitlin-farr has quit IRC | 21:55 | |
*** rellerreller has quit IRC | 21:58 | |
*** juantwo has joined #openstack-barbican | 21:59 | |
*** juantwo has quit IRC | 21:59 | |
*** juantwo has joined #openstack-barbican | 22:00 | |
*** paul_glass has quit IRC | 22:07 | |
*** mikedillion has joined #openstack-barbican | 22:10 | |
*** nkinder has quit IRC | 22:13 | |
*** ayoung is now known as ayoung-afk | 22:14 | |
*** mikedillion has quit IRC | 22:23 | |
*** SheenaG1 has quit IRC | 22:25 | |
*** mikedillion has joined #openstack-barbican | 22:30 | |
*** dimtruck is now known as zz_dimtruck | 22:43 | |
*** kebray has joined #openstack-barbican | 22:52 | |
*** jaosorior has quit IRC | 23:03 | |
*** nkinder has joined #openstack-barbican | 23:10 | |
*** bubbva has quit IRC | 23:11 | |
*** bubbva has joined #openstack-barbican | 23:11 | |
*** kebray has quit IRC | 23:24 | |
*** mikedillion has quit IRC | 23:25 | |
*** atiwari has quit IRC | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!