*** nkinder has joined #openstack-barbican | 00:09 | |
*** dstanek has quit IRC | 00:31 | |
*** dstanek has joined #openstack-barbican | 00:35 | |
*** ryanpetrello has joined #openstack-barbican | 00:59 | |
*** jaosorior has quit IRC | 01:03 | |
*** ryanpetrello has quit IRC | 01:50 | |
*** bdpayne has quit IRC | 01:54 | |
*** tiger_to1s has joined #openstack-barbican | 01:55 | |
*** rm_you| has joined #openstack-barbican | 01:56 | |
*** tiger_toes has quit IRC | 01:56 | |
*** rm_you has quit IRC | 01:56 | |
*** dougwig has quit IRC | 01:57 | |
*** dougwig has joined #openstack-barbican | 01:59 | |
*** gyee has quit IRC | 02:14 | |
*** dave-mccowan has quit IRC | 02:43 | |
*** zz_dimtruck is now known as dimtruck | 02:48 | |
*** jaosorior has joined #openstack-barbican | 08:07 | |
*** tiger_to1s is now known as tiger_toes | 11:00 | |
*** dave-mccowan has joined #openstack-barbican | 11:41 | |
*** dimtruck is now known as zz_dimtruck | 12:32 | |
*** liam_ has joined #openstack-barbican | 12:41 | |
*** liam_ is now known as Guest26825 | 12:41 | |
*** Guest26825 has quit IRC | 13:07 | |
*** alee has quit IRC | 13:07 | |
*** ryanpetrello has joined #openstack-barbican | 13:15 | |
*** rellerreller has joined #openstack-barbican | 13:49 | |
*** ayoung-dadmode has quit IRC | 13:59 | |
openstackgerrit | Tim Kelsey proposed a change to openstack/barbican: Fix communication of secret_type info https://review.openstack.org/133695 | 14:01 |
---|---|---|
*** rellerreller has quit IRC | 14:06 | |
*** rsyed_away is now known as rsyed | 14:15 | |
*** nkinder has quit IRC | 14:16 | |
*** joesavak has joined #openstack-barbican | 14:34 | |
*** zz_dimtruck is now known as dimtruck | 14:40 | |
*** paul_glass has joined #openstack-barbican | 14:47 | |
*** ayoung has joined #openstack-barbican | 14:49 | |
openstackgerrit | John Vrbanac proposed a change to openstack/barbican: Fixing remaining hacking violations https://review.openstack.org/133356 | 14:50 |
jvrbanac | jaosorior, I made the changes you suggested. We need to get this merged quickly, because this CR will continue to get bigger as I have to continue to rebase and fix more violations as other people's code gets merged. | 14:53 |
*** openstackgerrit has quit IRC | 14:55 | |
jaosorior | jvrbanac: will +2 when it passes CI | 14:59 |
jvrbanac | jaosorior, awesome thanks! | 15:00 |
*** nkinder has joined #openstack-barbican | 15:00 | |
*** alee has joined #openstack-barbican | 15:01 | |
reaperhulk | hooray jaosorior core :D | 15:02 |
jaosorior | yay :D | 15:03 |
*** akoneru has joined #openstack-barbican | 15:05 | |
jvrbanac | There you go jaosorior, CI just gave it a +1 | 15:16 |
jvrbanac | reaperhulk, redrobot, hockeynut, alee, rellerreller, could use a +2 and workflow: https://review.openstack.org/#/c/133356/ | 15:19 |
hockeynut | looking now. | 15:21 |
jvrbanac | hockeynut, it's just fixing all of the hacking violations and turning on the latest versions of hacking they get caught in the gate | 15:22 |
hockeynut | yup - I see that. | 15:23 |
hockeynut | many files, few lines :-) | 15:23 |
jvrbanac | hockeynut, you might notice a couple tests removed as well. I noticed they were duplicates of other tests, so instead of fixing the duplicated tests, I just removed them. | 15:23 |
hockeynut | awesome! | 15:24 |
hockeynut | so periods on docstrings but not on commit msgs. Consistency :-) | 15:25 |
jvrbanac | hockeynut, only on the one line summary | 15:26 |
hockeynut | right | 15:27 |
hockeynut | my first +2 | 15:27 |
hockeynut | wiping the tears from my eyes as I type... | 15:28 |
jvrbanac | lol | 15:28 |
*** rtom has joined #openstack-barbican | 15:31 | |
*** tdink has joined #openstack-barbican | 15:31 | |
*** tdink has quit IRC | 15:43 | |
*** ryanpetrello has quit IRC | 15:48 | |
jvrbanac | jfyi to all, As the our test requirements has been updated to include a newer version of hacking, you'll want to rebuild your tox pep8 env | 15:50 |
reaperhulk | test-requirements is updated so we gate on it now? | 15:51 |
reaperhulk | I see it is. Excellent | 15:51 |
jvrbanac | reaperhulk, yep | 15:57 |
jvrbanac | reaperhulk, finally! | 15:57 |
*** tdink has joined #openstack-barbican | 16:00 | |
*** paul_glass has quit IRC | 16:01 | |
*** dimtruck is now known as zz_dimtruck | 16:04 | |
jaosorior | jvrbanac: just a back to check your commit (was in the bus) ... and damn that was quick O_O | 16:06 |
jvrbanac | jaosorior, lol yeah. More core reviews, in theory, means that more people can look at something and merge it. In theory, that really should of had 3 core people on it, but oh well. | 16:11 |
reaperhulk | jvrbanac are you down at castle | 16:11 |
jvrbanac | reaperhulk, no. I'm only working a half day today | 16:12 |
reaperhulk | I'm on PTO entirely but I think I'm going to go to the office after I get a haircut. | 16:12 |
reaperhulk | Gonna play with rust | 16:12 |
reaperhulk | Come hang out in the office and play with rust with me ;) | 16:13 |
jvrbanac | reaperhulk, oooo tempting... | 16:13 |
reaperhulk | I might also get that blood work done so I can get some free monies | 16:13 |
reaperhulk | (they are on site in austin today) | 16:13 |
reaperhulk | anyway, going to get haircut now. I'll be in the office by noon if you decide you want to remedial rust with me | 16:14 |
reaperhulk | fn main() { println!("Hello World!"); } <-- we are now rust experts | 16:14 |
jvrbanac | reaperhulk, lol | 16:15 |
*** tdink has quit IRC | 16:31 | |
*** tdink has joined #openstack-barbican | 16:32 | |
hockeynut | (updating resume now) | 16:34 |
hockeynut | reaperhulk I read that as "f*cking main". Is it too late for rust to change? :-) | 16:35 |
*** rellerreller has joined #openstack-barbican | 16:36 | |
*** rm_you| is now known as rm_you | 16:47 | |
*** zz_dimtruck is now known as dimtruck | 17:06 | |
*** rellerreller has quit IRC | 17:09 | |
*** rellerreller has joined #openstack-barbican | 17:18 | |
*** tdink has quit IRC | 17:28 | |
*** gyee has joined #openstack-barbican | 17:28 | |
*** tdink has joined #openstack-barbican | 17:31 | |
*** tdink has quit IRC | 17:33 | |
*** tdink has joined #openstack-barbican | 17:33 | |
*** openstackgerrit has joined #openstack-barbican | 17:48 | |
rm_work | for a certificate signing interface, what would you expect the "Validity Period" to be called, and what units would be passed? | 18:09 |
rm_work | Would it be "validity_period=<years>" or "validity_period=<seconds>" or "validity=<date>" or "expiration=<date>" or what? | 18:10 |
rm_work | in pyOpenSSL it appears to be done with cert.set_notAfter(<date>) | 18:12 |
rm_work | so I guess that? | 18:12 |
rm_work | "not_after=<date>" | 18:12 |
rm_work | <_< | 18:12 |
rm_work | maybe "expiration=<date>" | 18:13 |
dstufft | rm_work: theoretically you can set both a start and an end date | 18:15 |
rm_work | yeah... | 18:16 |
rm_work | I don't know if I need to bother exposing that | 18:16 |
rm_work | now I'm leaning towards | 18:16 |
rm_work | "expiration=<seconds>" | 18:16 |
rm_work | to avoid needing a weird date format | 18:16 |
rm_work | or rather, a specific date format | 18:16 |
alee | rm_work, usually expiration is specified in days | 18:16 |
rm_work | yeah, though we have use-cases in seconds | 18:17 |
rm_work | ... admittedly entirely for testing | 18:17 |
rm_work | I guess 0 days might work for that | 18:17 |
alee | rm_work, whats this for? | 18:17 |
rm_work | I wonder if pyOpenSSL will let me sign a certificate that is already expired :) | 18:18 |
rm_work | alee: negative testing | 18:18 |
rm_work | testing what happens when a cert is expired | 18:18 |
rm_work | oh | 18:18 |
rm_work | the thing in general>? | 18:18 |
rm_work | https://review.openstack.org/#/c/131889/8/octavia/certificates/generator/cert_gen.py | 18:18 |
alee | rm_work, this is testing code? | 18:19 |
rm_work | no | 18:19 |
rm_work | this is production code, i thought you were asking why we'd need that kind of test :) | 18:19 |
rm_work | or rather, this WILL be production code | 18:19 |
*** bdpayne has joined #openstack-barbican | 18:19 | |
rm_work | pyOpenSSL implementation: https://review.openstack.org/#/c/132578/7/octavia/certificates/generator/local.py | 18:20 |
alee | rm_work, just trying to understand -- I thought the idea was to call into barbican to get a cert? | 18:20 |
rm_work | alee: yes but we need a dev impl | 18:20 |
rm_work | since Barbican doesn't support this yet | 18:20 |
rm_work | there is also a barbican impl... | 18:20 |
alee | gotcha | 18:20 |
rm_work | https://review.openstack.org/#/c/132580/5/octavia/certificates/generator/barbican.py | 18:20 |
rm_work | just not super useful yet :/ | 18:21 |
alee | rm_work, ok makes sense -- well for your dev plugin -- do a expiration time in seconds | 18:22 |
alee | or something like that | 18:23 |
rm_work | alee: I want it to be consistent -- I will be specifying the parameter at the interface level | 18:23 |
alee | whatever pyOpenSSL will allow | 18:23 |
rm_work | so, that would mean all of them would have to assume seconds | 18:23 |
rm_work | pyOpenSSL takes a "date" string | 18:23 |
rm_work | so I'll have to get current time, add <seconds>, generate string, pass to pyOpenSSL | 18:23 |
rm_work | so it doesn't matter much, I'll convert from whatever I need to | 18:23 |
rm_work | I could do "valid_seconds=<seconds>" | 18:24 |
rm_work | to be explicit :P | 18:24 |
rm_work | defining interfaces is tricky >_> | 18:24 |
alee | yeah | 18:25 |
rm_work | I guess I'll call it "validity" and make a good docstring | 18:28 |
*** rellerreller has quit IRC | 18:29 | |
*** alee is now known as alee_lunch | 18:35 | |
*** tdink has quit IRC | 19:02 | |
*** tdink has joined #openstack-barbican | 19:09 | |
*** gyee has quit IRC | 19:13 | |
*** alee_lunch is now known as alee | 19:13 | |
rm_work | redrobot: so, this: https://www.youtube.com/watch?v=jf_YOzW7I3s is the thing I was talking about | 19:25 |
redrobot | rm_work yeah, that's not Kite | 19:31 |
rm_work | yeah | 19:34 |
rm_work | err, who knows a lot about certificates that I could quiz really quick | 19:34 |
rm_work | I am super bad at TLS stuff | 19:34 |
redrobot | rm_work chellygel is my go-to cert person, but she's still out | 19:40 |
rm_work | hmm k | 19:40 |
redrobot | rm_work also, there's a really good TLS Deep Dive class avaiable in Rack U | 19:41 |
rm_work | hmm | 19:41 |
*** darrenmoffat has quit IRC | 19:47 | |
*** darrenmoffat has joined #openstack-barbican | 19:48 | |
rm_work | I wonder if reaperhulk ended up going to his office... | 19:48 |
*** ametts has quit IRC | 19:53 | |
*** paul_glass has joined #openstack-barbican | 19:54 | |
*** paul_glass has quit IRC | 20:07 | |
*** tdink has quit IRC | 20:21 | |
*** gyee has joined #openstack-barbican | 20:41 | |
*** rellerreller has joined #openstack-barbican | 20:47 | |
*** bubbva has quit IRC | 21:03 | |
*** bubbva has joined #openstack-barbican | 21:04 | |
*** alee has quit IRC | 21:07 | |
*** alee has joined #openstack-barbican | 21:30 | |
*** paul_glass has joined #openstack-barbican | 21:32 | |
*** paul_glass1 has joined #openstack-barbican | 21:34 | |
*** ryanpetrello has joined #openstack-barbican | 21:36 | |
*** paul_glass has quit IRC | 21:37 | |
*** rsyed is now known as rsyed_away | 21:37 | |
*** rtom has quit IRC | 22:02 | |
*** ryanpetrello has quit IRC | 22:07 | |
*** paul_glass1 is now known as paul_glass | 22:20 | |
*** paul_glass has quit IRC | 22:31 | |
*** joesavak has quit IRC | 22:34 | |
*** rellerreller has quit IRC | 22:51 | |
*** dave-mccowan_ has joined #openstack-barbican | 22:51 | |
*** dave-mccowan has quit IRC | 22:53 | |
*** dave-mccowan_ is now known as dave-mccowan | 22:53 | |
*** dave-mccowan_ has joined #openstack-barbican | 22:59 | |
*** dave-mccowan has quit IRC | 23:00 | |
*** dave-mccowan_ is now known as dave-mccowan | 23:00 | |
*** jaosorior has quit IRC | 23:13 | |
*** dimtruck is now known as zz_dimtruck | 23:16 | |
*** akoneru has quit IRC | 23:16 | |
*** rsyed_away is now known as rsyed | 23:20 | |
openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican: Use "key-manager" for service type https://review.openstack.org/127313 | 23:24 |
reaperhulk | rm_work: I did go to the office. | 23:37 |
*** ayoung has quit IRC | 23:41 | |
openstackgerrit | Douglas Mendizábal proposed a change to openstack/barbican: Remove version from endpoints in catalog https://review.openstack.org/127865 | 23:44 |
*** nkinder has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!