| *** miqui_ has joined #openstack-barbican | 00:12 | |
| *** kgriffs is now known as kgriffs|afk | 00:21 | |
| *** david-lyle has joined #openstack-barbican | 00:25 | |
| *** ayoung has quit IRC | 00:37 | |
| *** kebray_ has quit IRC | 00:47 | |
| *** david-lyle has quit IRC | 01:08 | |
| *** gyee has joined #openstack-barbican | 01:17 | |
| *** ryanpetrello has joined #openstack-barbican | 01:22 | |
| *** gyee has quit IRC | 01:25 | |
| *** david-lyle has joined #openstack-barbican | 01:26 | |
| *** zz_dimtruck is now known as dimtruck | 01:27 | |
| *** openstack has joined #openstack-barbican | 01:34 | |
| *** ryanpetrello has quit IRC | 01:35 | |
| *** ayoung has joined #openstack-barbican | 01:41 | |
| *** gyee has joined #openstack-barbican | 02:00 | |
| *** david-lyle has quit IRC | 02:01 | |
| *** gyee has quit IRC | 02:07 | |
| *** dimtruck is now known as zz_dimtruck | 02:38 | |
| *** david-lyle has joined #openstack-barbican | 02:42 | |
| *** david-lyle has quit IRC | 02:42 | |
| *** zz_dimtruck is now known as dimtruck | 03:07 | |
| *** ryanpetrello has joined #openstack-barbican | 05:13 | |
| *** ryanpetrello has quit IRC | 05:24 | |
| *** dimtruck is now known as zz_dimtruck | 06:05 | |
| *** woodster_ has quit IRC | 06:10 | |
| *** chlong has quit IRC | 07:20 | |
| *** jamielennox is now known as jamielennox|away | 07:42 | |
| *** morganfainberg has quit IRC | 08:21 | |
| *** morganfainberg has joined #openstack-barbican | 08:21 | |
| *** jaosorior has joined #openstack-barbican | 09:07 | |
| *** Guest49876 is now known as d0ugal | 09:36 | |
| *** d0ugal has quit IRC | 09:36 | |
| *** d0ugal has joined #openstack-barbican | 09:36 | |
| *** david-lyle has joined #openstack-barbican | 09:46 | |
| *** tkelsey has joined #openstack-barbican | 09:54 | |
| *** david-lyle has quit IRC | 10:08 | |
| jaosorior | tkelsey: ping | 10:40 |
|---|---|---|
| tkelsey | hello | 10:48 |
| tkelsey | jaosorior: ^ | 10:48 |
| jaosorior | Hey man | 10:53 |
| jaosorior | what's your timezone? | 10:54 |
| tkelsey | UK | 10:54 |
| jaosorior | öhö | 10:54 |
| jaosorior | so we're not that far | 10:54 |
| tkelsey | ah awesome :) handy | 10:54 |
| jaosorior | Anyway, was just thinking why you would be online so "early" | 10:55 |
| jaosorior | but I thought it was US time | 10:55 |
| tkelsey | haha yeah, not so early here :) | 10:55 |
| jaosorior | I'm in Finland, actually | 10:55 |
| jaosorior | yeah | 10:55 |
| jaosorior | anyway | 10:55 |
| jaosorior | was checking out your CR | 10:55 |
| jaosorior | https://review.openstack.org/#/c/146906/ | 10:55 |
| jaosorior | seems that people have agreed to get it merged | 10:55 |
| jaosorior | but... nobody actually discussed anything :/ | 10:56 |
| tkelsey | yeah, I was expecting more conversation over that | 10:56 |
| jaosorior | do you have any insights? | 10:56 |
| jaosorior | are you OK with that getting merged? | 10:56 |
| tkelsey | no, it merged while I was away | 10:56 |
| jaosorior | I was thinking you could try pushing the exception | 10:56 |
| jaosorior | no, actually, it didn't get merged | 10:56 |
| tkelsey | well I am happy with some kind of checking, but I would have preferred exceptions | 10:56 |
| jaosorior | it stumbled upon the JSONDecoderError | 10:56 |
| tkelsey | ah right ok | 10:56 |
| tkelsey | recheck needed? | 10:57 |
| jaosorior | which I will try to debug in the next days | 10:57 |
| jaosorior | yeah | 10:57 |
| jaosorior | but | 10:57 |
| jaosorior | I was gonna ask you | 10:57 |
| jaosorior | would you like to try pushing the exception raising? | 10:57 |
| jaosorior | so instead of doing a re-check | 10:57 |
| jaosorior | pushing another CR | 10:57 |
| jaosorior | which would actually reset the scoring | 10:57 |
| tkelsey | I would, yeah thats a good idea | 10:57 |
| jaosorior | but from my side | 10:57 |
| tkelsey | let this one land and then bump to exceptions in another | 10:57 |
| jaosorior | the exception raising would be a +2 | 10:57 |
| tkelsey | awesome thanks jaosorior | 10:58 |
| jaosorior | alright, that could also work | 10:58 |
| jaosorior | lemme trigger the re-check | 10:58 |
| tkelsey | ok cool, I'll push another patch with the exception logic back | 10:58 |
| jaosorior | recheck triggered | 10:59 |
| tkelsey | cool thanks jaosorior | 11:00 |
| *** david-lyle has joined #openstack-barbican | 11:17 | |
| jaosorior | tkelsey: do you happen to know when and where the OSSG mid-cycle will take place? | 11:26 |
| tkelsey | i do, let me dig out the info :) | 11:27 |
| jaosorior | https://wiki.openstack.org/wiki/Sprints | 11:27 |
| jaosorior | there it says SF | 11:27 |
| jaosorior | but I'm not sure if it was going to be switched to Austin to be along Barbican also | 11:27 |
| tkelsey | it is in SF | 11:28 |
| tkelsey | #link https://etherpad.openstack.org/p/ossg-kilo-meetup | 11:28 |
| jaosorior | ooh, ok | 11:30 |
| jaosorior | thought they would switch to Austin, but alright | 11:30 |
| tkelsey | jaosorior: yeah I think the venue won out in the end | 11:48 |
| openstackgerrit | Merged openstack/barbican: Checking the certificate file has reasonable permissions https://review.openstack.org/146906 | 12:19 |
| *** ayoung has quit IRC | 13:04 | |
| *** david-lyle has quit IRC | 13:11 | |
| *** woodster_ has joined #openstack-barbican | 13:18 | |
| *** darrenmoffat has quit IRC | 13:28 | |
| jaosorior | hockeynut: ping | 13:28 |
| *** darrenmoffat has joined #openstack-barbican | 13:29 | |
| *** ayoung has joined #openstack-barbican | 13:31 | |
| *** zz_dimtruck is now known as dimtruck | 13:36 | |
| jaosorior | woodster_: Anything going on with this one? https://review.openstack.org/#/c/125798 Haven't heard much about it in a while. | 13:41 |
| woodster_ | jaosorior: yeah I'd added a comment for alee but we haven't followed up....alee can you revisit ^^^? | 13:46 |
| woodster_ | alee: ^^^^ | 14:15 |
| jaosorior | O_O | 14:16 |
| openstackgerrit | Tim Kelsey proposed openstack/barbican: Re-adding excpetions raised on bad certificate key file permissions https://review.openstack.org/147862 | 14:27 |
| tkelsey | jaosorior: https://review.openstack.org/147862 | 14:28 |
| *** ryanpetrello has joined #openstack-barbican | 14:29 | |
| hockeynut | jaosorior good morning sir. | 14:32 |
| hockeynut | jaosorior I'm bouncing around a lot this morning so I may not be terribly responsive until post-lunch | 14:37 |
| *** dimtruck is now known as zz_dimtruck | 14:42 | |
| alee | woodster_, done | 14:49 |
| *** ametts has joined #openstack-barbican | 14:52 | |
| *** lisaclark1 has joined #openstack-barbican | 15:09 | |
| *** SheenaG1 has joined #openstack-barbican | 15:13 | |
| jvrbanac | n case people forgot, you only have a couple more hours to vote in the OpenStack election. Voting ends at 11am CST / 1700UTC | 15:29 |
| jvrbanac | ^in | 15:29 |
| *** paul_glass has joined #openstack-barbican | 15:38 | |
| *** jorge_munoz has joined #openstack-barbican | 15:40 | |
| *** kgriffs|afk is now known as kgriffs | 15:42 | |
| *** kebray has joined #openstack-barbican | 15:48 | |
| *** kebray has quit IRC | 15:49 | |
| *** kebray has joined #openstack-barbican | 15:49 | |
| *** zz_dimtruck is now known as dimtruck | 15:53 | |
| openstackgerrit | Tim Kelsey proposed openstack/barbican: Adding excpetions on bad certificate key file permissions https://review.openstack.org/147862 | 16:06 |
| openstackgerrit | Tim Kelsey proposed openstack/barbican: Adding excpetions on bad key file permissions https://review.openstack.org/147862 | 16:07 |
| *** lisaclark1 has quit IRC | 16:09 | |
| jaosorior | hockeynut: have you been able to get info with the print statement that you added to debug the JSONDecoderError? I tried checking it out. But didn't actually see it get printed | 16:12 |
| jaosorior | tkelsey: one more comment on your CR | 16:12 |
| *** lisaclark1 has joined #openstack-barbican | 16:19 | |
| tkelsey | jaosorior: cool, will do | 16:21 |
| jaosorior | tkelsey: thanks dude | 16:22 |
| openstackgerrit | Tim Kelsey proposed openstack/barbican: Adding excpetions on bad key file permissions https://review.openstack.org/147862 | 16:24 |
| tkelsey | jaosorior: hows that? | 16:25 |
| jaosorior | Cool. Reviewed | 16:28 |
| tkelsey | :) good stuff | 16:28 |
| *** Guest29310 is now known as redrobot | 16:41 | |
| *** jkf has joined #openstack-barbican | 16:57 | |
| hockeynut | jaosorior not yet - I'm bringing up a devstack gate-like VM to have more control over the logging | 17:04 |
| *** gyee has joined #openstack-barbican | 17:06 | |
| jaosorior | Niiiice | 17:31 |
| *** bdpayne has joined #openstack-barbican | 17:44 | |
| *** tkelsey has quit IRC | 18:03 | |
| *** gerchardon has joined #openstack-barbican | 18:46 | |
| *** gerchardon has left #openstack-barbican | 18:46 | |
| *** SheenaG11 has joined #openstack-barbican | 19:02 | |
| *** SheenaG1 has quit IRC | 19:02 | |
| *** paul_glass has quit IRC | 19:50 | |
| *** ametts has quit IRC | 19:58 | |
| *** SheenaG11 has quit IRC | 20:01 | |
| *** kebray has quit IRC | 20:08 | |
| openstackgerrit | Ade Lee proposed openstack/barbican: Added new repository classes and controller classes for CAs https://review.openstack.org/147981 | 20:34 |
| alee | jaosorior, rm_work , woodster_ ping | 20:35 |
| rm_work | sup | 20:36 |
| alee | jaosorior, rm_work , woodster_ hey -- I'm trying to figure out why some unit tests are failing -- perhaps you can take a look at the cr above ? | 20:36 |
| rm_work | sure | 20:36 |
| alee | rm_work, the tests are saying that no CertificateAuthority entities are found .. | 20:37 |
| rm_work | pulling it down | 20:38 |
| rm_work | this machine is slow, tox could take a bit <_< | 20:38 |
| rm_work | just py27 is good, right? | 20:38 |
| jaosorior | alee: sure man, I'll check out out tomorrow. Friday night, 11pm and at a bar :P | 20:46 |
| rm_work | heh | 20:46 |
| alee | rm_work, yup | 20:47 |
| rm_work | i feel like jaosorior is at a bar like 75% of the time I talk to him | 20:47 |
| rm_work | ^_^ | 20:47 |
| alee | jaosorior, thanks! | 20:47 |
| alee | rm_work, indeed :) | 20:47 |
| redrobot | jaosorior gotta shoot for 100% | 20:47 |
| rm_work | alee: ok, getting those errors | 20:47 |
| jaosorior | rm_work: you....are not wrong... | 20:47 |
| *** lisaclark1 has quit IRC | 20:48 | |
| jaosorior | I actually do work in bars sometimes. Its surprisingly productive. But not tonight :P | 20:48 |
| jaosorior | Anyway. Have a good Friday guys :D | 20:49 |
| alee | jaosorior, you too! | 20:49 |
| woodster_ | jaosorior, take care. alee, rm_work, can you paste up the stack trace? | 20:50 |
| alee | woodster_, sure | 20:51 |
| alee | woodster_, http://www.fpaste.org/170703/42144157/ | 20:52 |
| alee | woodster_, basically if you look at the test, I create a CA model object -- and I think that it gets persisted with session.commit() | 20:53 |
| alee | but when I query for it, its not there | 20:54 |
| rm_work | debugging really quick | 20:55 |
| woodster_ | Off topic, but I've been curious why tox reports three of the same stack trace for errors...it seems like it's running the same test three times. Does anyone know for sure? | 20:55 |
| alee | woodster_, are you talking about the stack trace I posted? | 20:57 |
| woodster_ | alee, yeah...I've been noticing that too, just curious about it | 20:58 |
| alee | woodster_, its because I'm running three tests :) | 20:58 |
| alee | and all three are failing in the same way | 20:58 |
| woodster_ | you are failing in only one method: WhenTestingCertificateAuthorityRepo.test_get_by_create_date | 21:00 |
| *** lisaclark1 has joined #openstack-barbican | 21:00 | |
| *** lisaclark2 has joined #openstack-barbican | 21:04 | |
| *** lisaclark1 has quit IRC | 21:05 | |
| alee | woodster_, well there are a couple of others that are very similar .. | 21:05 |
| alee | def test_get_by_create_date_with_plugin_name_filter(self): | 21:06 |
| alee | def test_get_by_create_date_with_plugin_ca_id_filter(self): | 21:06 |
| alee | all call the same setup functions - and so fail in the same way | 21:06 |
| woodster_ | alee, rm_work, this might be an issue with the mapped collection setting process inside the initializer of CertificateAuthority. You might try to comment that out and see if you get further. All other places in Barbican we are saving the key/value info outside of the parent entity, with individual save() calls. What you are doing should work though, but just | 21:13 |
| woodster_ | something to try | 21:13 |
| *** samueldmq has quit IRC | 21:15 | |
| alee | woodster_, so - comment out the line -- ca_meta = orm.relationship( | 21:17 |
| alee | 'CertificateAuthorityMetadatum', | 21:17 |
| alee | collection_class=col.attribute_mapped_collection('key'), | 21:17 |
| alee | lazy=False) ? | 21:17 |
| woodster_ | alee, I mean the one in the __init__() method that sets the key/value info...just to see if the entity saves and can be retrieved at least | 21:18 |
| alee | did not seem to make a difference | 21:21 |
| alee | woodster_, ^^ | 21:21 |
| alee | woodster_, does the unit test run agaianst an actual db? | 21:22 |
| alee | woodster_, does it matter if I have no migration scripts yet? | 21:22 |
| woodster_ | alee, it runs against an in-mem sqlite db, so migration scripts are not used. | 21:23 |
| alee | woodster_, yeah - thats what I figured .. | 21:24 |
| woodster_ | alee, yeah if the .save() method is called on entities, that should stage them for updates in the database (that repo create() call should do that), and the commit should flush it out to the db. Not sure why that isn't happening | 21:25 |
| *** samueldmq has joined #openstack-barbican | 21:28 | |
| alee | woodster_, am I missing a method I need to implement to store the entity? | 21:29 |
| alee | woodster_, any way I can log the db commands to the internal db -- and their results? | 21:29 |
| *** lisaclark2 has quit IRC | 21:31 | |
| woodster_ | alee, I think there is a way to turn on more debug logging...change line #42 of the database_utils.py to True from False | 21:32 |
| *** lisaclark1 has joined #openstack-barbican | 21:32 | |
| woodster_ | The BaseRepo class is what provides the create_from() impl...and it has an entity.save() calls inside of it :\ | 21:33 |
| alee | woodster_, seems to take quite a bit longer with debug on .. | 21:37 |
| woodster_ | alee, I'm stepping thru it now... | 21:37 |
| rm_work | me too, i keep getting pulled away but i am looking now | 21:40 |
| woodster_ | oh, I see the created date is in utc, and the expiration is in local time...so the expiration date will filter out the get's | 21:41 |
| rm_work | lol | 21:41 |
| woodster_ | alee, rm_work, sorry gotta get my kiddo now...but I'll have IRC on my phone, just slower response | 21:42 |
| alee | woodster_, thanks ! | 21:43 |
| *** dimtruck is now known as zz_dimtruck | 21:43 | |
| alee | woodster_, good catch -- trying to fix | 21:43 |
| *** nkinder_away has quit IRC | 21:44 | |
| *** jorge_munoz has quit IRC | 21:46 | |
| *** nkinder_away has joined #openstack-barbican | 21:47 | |
| *** bdpayne has quit IRC | 21:48 | |
| alee | woodster_, rm_work yeah - that gets me further - thanks1 | 21:49 |
| alee | thanks! | 21:49 |
| *** samueldmq has quit IRC | 21:49 | |
| *** ametts has joined #openstack-barbican | 21:50 | |
| rm_work | alee: did that fix it? | 21:52 |
| rm_work | or just one hurdle? | 21:52 |
| alee | rm_work, that fixed that problem -- there are a couple of other small things wrong with the tests | 21:53 |
| alee | fixing those now. | 21:53 |
| rm_work | alright | 21:53 |
| alee | but I understand those problems .. | 21:53 |
| rm_work | yeah I was definitely focused on things that weren't the timezones :P | 21:53 |
| rm_work | good catch woodster_ | 21:53 |
| alee | this also explains why some other tests I was trying did not work :) | 21:54 |
| alee | thanks guys -- good catch woodster | 21:54 |
| rm_work | freaking timezones | 21:55 |
| rm_work | actually something similar happened to me before when my secrets expired and i was like WTF why won't my containers load properly | 21:55 |
| alee | :/ | 21:56 |
| *** jorge_munoz has joined #openstack-barbican | 21:58 | |
| *** jorge_munoz has quit IRC | 22:00 | |
| *** samueldmq has joined #openstack-barbican | 22:00 | |
| rm_work | oh hey PyCharm is on version 4.0.4 | 22:03 |
| rm_work | that makes me happier than it should | 22:03 |
| *** tkelsey has joined #openstack-barbican | 22:03 | |
| *** jorge_munoz has joined #openstack-barbican | 22:04 | |
| woodster_ | alee: glad that worked | 22:05 |
| *** tkelsey has quit IRC | 22:07 | |
| *** SheenaG1 has joined #openstack-barbican | 22:22 | |
| *** SheenaG1 has quit IRC | 22:41 | |
| *** lisaclark1 has quit IRC | 22:42 | |
| *** ayoung has quit IRC | 22:42 | |
| *** ametts has quit IRC | 22:47 | |
| *** bdpayne has joined #openstack-barbican | 22:50 | |
| *** SheenaG1 has joined #openstack-barbican | 22:52 | |
| *** ryanpetrello has quit IRC | 22:59 | |
| *** ryanpetrello has joined #openstack-barbican | 23:03 | |
| *** jaosorior has quit IRC | 23:03 | |
| *** openstackgerrit has quit IRC | 23:19 | |
| *** openstackgerrit has joined #openstack-barbican | 23:19 | |
| *** SheenaG1 has quit IRC | 23:24 | |
| *** jorge_munoz has quit IRC | 23:50 | |
| *** ryanpetrello has quit IRC | 23:55 | |
| *** ryanpetrello has joined #openstack-barbican | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!