| *** tkelsey has joined #openstack-barbican | 00:28 | |
| *** tkelsey has quit IRC | 00:32 | |
| *** alee has joined #openstack-barbican | 00:46 | |
| *** SheenaG has joined #openstack-barbican | 01:12 | |
| *** SheenaG has quit IRC | 01:49 | |
| *** woodster_ has quit IRC | 02:00 | |
| *** alee_afk has quit IRC | 02:13 | |
| *** jamielennox is now known as jamielennox|lunc | 02:32 | |
| *** jamielennox|lunc is now known as jamielennox|food | 02:32 | |
| *** woodster_ has joined #openstack-barbican | 02:39 | |
| *** alee_afk has joined #openstack-barbican | 02:53 | |
| *** greghaynes has quit IRC | 02:58 | |
| *** jamielennox|food is now known as jamielennox | 03:01 | |
| *** greghaynes has joined #openstack-barbican | 03:06 | |
| openstackgerrit | Ade Lee proposed openstack/barbican: Add functional tests for certificate orders https://review.openstack.org/166089 | 03:33 |
|---|---|---|
| alee | redrobot, woodster_ dave-mccowan, jvrbanac ^^ | 03:35 |
| dave-mccowan | alee sweet. i'll download and give them a try. | 03:38 |
| alee | dave-mccowan, they all don't work right now :/ | 03:38 |
| alee | dave-mccowan, but I'm working on a quick patch right now to get at least some of them woring | 03:38 |
| alee | ie. the exception ferom validator based ones | 03:39 |
| alee | for those I think just adding a client message and status code to the exceptions will resolve the issue. | 03:39 |
| alee | others will need woodster_ 's patches for status to land | 03:40 |
| *** gyee has quit IRC | 03:41 | |
| dave-mccowan | by the way, a bunch of kmip related unit tests stopped working for me. did something change in the environment related to that? | 03:49 |
| dave-mccowan | alee ^ | 03:49 |
| alee | dave-mccowan, yeah - recreate your tox environment | 03:49 |
| alee | tox -r | 03:49 |
| dave-mccowan | alee i think i've already tried that, but i'll give it another try | 03:51 |
| alee | dave-mccowan, did you actually get the exceptions to show up with the correct values by adding the %(x)s ? | 04:18 |
| dave-mccowan | alee i tested two of them manually and saw the value | 04:19 |
| alee | dave-mccowan, weird - I'm still seeing %(reason) | 04:20 |
| dave-mccowan | for the %(ca_id)s one? that came in a second patch. maybe just git pull? | 04:21 |
| alee | dave-mccowan, oh wait .. its ok for the internal (log) reason) but not for the external (client_messsage) | 04:21 |
| alee | hmm | 04:21 |
| *** alee is now known as alee_sleep | 04:30 | |
| *** tkelsey has joined #openstack-barbican | 04:36 | |
| *** tkelsey has quit IRC | 04:41 | |
| *** dave-mcc_ has joined #openstack-barbican | 04:57 | |
| *** dave-mccowan has quit IRC | 04:57 | |
| *** chlong has quit IRC | 05:02 | |
| openstackgerrit | Jamie Lennox proposed openstack/python-barbicanclient: Use the ksc Adapter instead of custom HTTPClient https://review.openstack.org/148450 | 05:09 |
| *** chlong has joined #openstack-barbican | 05:19 | |
| openstackgerrit | Merged openstack/barbican: Fixing errors and warnings on the sphinx docs https://review.openstack.org/165556 | 05:30 |
| *** dave-mcc_ has quit IRC | 05:30 | |
| *** chlong has quit IRC | 06:01 | |
| *** chlong has joined #openstack-barbican | 06:13 | |
| *** gitorres has joined #openstack-barbican | 06:35 | |
| *** jamielennox is now known as jamielennox|away | 06:35 | |
| *** gitorres has left #openstack-barbican | 06:35 | |
| *** chlong has quit IRC | 07:45 | |
| *** SheenaG has joined #openstack-barbican | 08:01 | |
| *** SheenaG has quit IRC | 08:11 | |
| *** openstackgerrit has quit IRC | 08:22 | |
| *** jaosorior has joined #openstack-barbican | 08:22 | |
| *** openstackgerrit has joined #openstack-barbican | 08:22 | |
| *** jamielennox|away is now known as jamielennox | 09:14 | |
| *** tkelsey has joined #openstack-barbican | 09:19 | |
| *** tkelsey has quit IRC | 09:24 | |
| *** tkelsey has joined #openstack-barbican | 09:24 | |
| *** nickrmc83 has quit IRC | 09:24 | |
| *** nickrmc83 has joined #openstack-barbican | 09:25 | |
| *** tkelsey has quit IRC | 10:56 | |
| *** tkelsey has joined #openstack-barbican | 10:56 | |
| *** gitorres has joined #openstack-barbican | 11:42 | |
| *** gitorres has quit IRC | 12:05 | |
| *** gitorres has joined #openstack-barbican | 12:06 | |
| *** gitorres has quit IRC | 12:28 | |
| *** gitorres has joined #openstack-barbican | 12:31 | |
| *** gitorres has left #openstack-barbican | 12:43 | |
| *** zz_dimtruck is now known as dimtruck | 13:25 | |
| *** alee_sleep is now known as alee | 13:36 | |
| *** jamielennox is now known as jamielennox|away | 13:36 | |
| *** alee has quit IRC | 13:37 | |
| *** alee_afk is now known as alee | 13:37 | |
| alee | jaosorior, ping | 13:37 |
| jaosorior | alee: pong | 13:38 |
| alee | jaosorior, hey -- got a question about the exceptions | 13:38 |
| alee | specificially BarbicanHTTPException | 13:38 |
| alee | you refactored that, right? | 13:39 |
| jaosorior | Yup | 13:39 |
| alee | so - BarbicanHTTPException allows you to specify a client_message and return_code | 13:39 |
| jaosorior | Wazzup? | 13:39 |
| jaosorior | Yes | 13:39 |
| alee | but the client_message does not interpolate the args being passed in | 13:40 |
| jaosorior | It doesn't? | 13:40 |
| alee | so how can we fix it so that it does? | 13:40 |
| alee | jaosorior, no -- look at BarbicanException | 13:41 |
| jaosorior | I'll fix that as soon as I get top my computer | 13:41 |
| jaosorior | * to | 13:41 |
| alee | you can see how the message arg is constructed from the kwargs passed in | 13:41 |
| alee | I think you need to do something similar | 13:41 |
| jaosorior | I probably do. Bummer, sorry for that | 13:42 |
| alee | jaosorior, thanks. If you put up a CR, I'll review it right away | 13:42 |
| alee | (as I need it for the cert functional tests) | 13:42 |
| jaosorior | Won't take to long. It's just that I'm at the gym at the moment | 13:42 |
| jaosorior | * too | 13:42 |
| alee | jaosorior, yup - figured that | 13:42 |
| *** SheenaG has joined #openstack-barbican | 13:43 | |
| *** SheenaG has left #openstack-barbican | 13:43 | |
| alee | redrobot, jvrbanac , hockeynut ping | 13:48 |
| *** tkelsey has quit IRC | 13:51 | |
| *** xaeth_afk is now known as xaeth | 14:40 | |
| *** dave-mccowan has joined #openstack-barbican | 14:41 | |
| alee | redrobot, jvrbanac , hockeynut, woodster_ ? | 14:56 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/barbican: BarbicanHTTPException can take arguments for client_message https://review.openstack.org/166257 | 14:59 |
| alee | jaosorior, so this allows you to set the client message and message as well right? | 15:01 |
| jaosorior | yup | 15:01 |
| alee | jaosorior, trying it out right now .. | 15:02 |
| jaosorior | just the same as it works for the standard barbican exceptions | 15:02 |
| alee | jaosorior, cool - it works | 15:05 |
| alee | any other cores around today? | 15:05 |
| alee | jaosorior, what do you think is going on here? http://logs.openstack.org/89/166089/1/check/gate-barbican-devstack-dsvm/24c23f4/console.html | 15:06 |
| jaosorior | uhm | 15:06 |
| jaosorior | wait up | 15:06 |
| alee | why? | 15:08 |
| alee | woodster_, jvrbanac , redrobot ? | 15:08 |
| *** rellerreller has joined #openstack-barbican | 15:14 | |
| *** kebray has joined #openstack-barbican | 15:20 | |
| *** openstackgerrit has quit IRC | 15:21 | |
| *** openstackgerrit has joined #openstack-barbican | 15:22 | |
| jaosorior | alee: sorry about that, I'm checking out the VISA stuff for Canada | 15:23 |
| alee | jaosorior, ah ok -- I thought you were concerned about your patch | 15:24 |
| jaosorior | aaah, no, the patch makes sense | 15:24 |
| alee | jaosorior, any idea on my error? | 15:25 |
| jaosorior | what CR is it? | 15:25 |
| alee | http://logs.openstack.org/89/166089/1/check/gate-barbican-devstack-dsvm/24c23f4/console.html | 15:25 |
| jaosorior | yeah, but what's the related CR? | 15:25 |
| jaosorior | or the link to it | 15:25 |
| alee | https://review.openstack.org/#/c/166089/ | 15:25 |
| alee | jaosorior, you might as well review it too :) | 15:26 |
| jaosorior | alee: weird O_O | 15:28 |
| alee | jaosorior, yeah -- I dont know where to go from there | 15:29 |
| alee | jaosorior, works when I run it locally just fine | 15:29 |
| *** kebray has quit IRC | 15:31 | |
| *** kebray has joined #openstack-barbican | 15:39 | |
| alee | rellerreller, ping | 15:42 |
| rellerreller | alee pong | 15:42 |
| alee | rellerreller, couple of things .. | 15:42 |
| alee | 1. I had comment/question on https://review.openstack.org/#/c/163989/9/barbican/plugin/kmip_secret_store.py,cm | 15:42 |
| alee | 2. can you +2 https://review.openstack.org/166257 | 15:43 |
| alee | 3. any idea what could be going on in the gate for .. https://review.openstack.org/#/c/166089/ ? | 15:43 |
| alee | any rackers around today? | 15:43 |
| rellerreller | alee 1. I responded to your comment about 20 minutes ago. We plan to implement that in the near future, so it sounded like you were ok with that code then? | 15:44 |
| alee | rellerreller, yeah - if thats so fine. I'll +2 it | 15:45 |
| rellerreller | alee I can look at 2 and 3 in about 5-10 minutes | 15:45 |
| alee | rellerreller, thanks | 15:45 |
| dave-mccowan | CRITICAL barbican [-] OperationalError: (OperationalError) index ix_certificate_authority_metadata_ca_id already exists u'CREATE INDEX ix_certificate_authority_metadata_ca_id ON certificate_authority_metadata (ca_id)' () | 15:58 |
| alee | dave-mccowan, ? | 15:59 |
| dave-mccowan | has anyone seen this error before? ^^ my pyenv seteup on my mac was working great until recently. now bin/barbican.sh install gets stuck in this loop. i've tried recreating my env from scratch, with same result. | 15:59 |
| alee | dave-mccowan, thats one of my commits | 16:00 |
| dave-mccowan | OOPS ! failed loading app in worker 1 (pid 83922) :( trying again... | 16:00 |
| alee | dave-mccowan, try removing your db | 16:00 |
| alee | dave-mccowan, usually under /var/lib/barbican | 16:01 |
| rm_work | redrobot: do you know if we have any plans to move to the "Externally Hosted Plugin" method of devstack http://docs.openstack.org/developer/devstack/plugins.html | 16:02 |
| rm_work | redrobot: would be a lot simpler for installation/config than the old extras.d hooks | 16:02 |
| rm_work | jvrbanac / hockeynut / jaosorior ^^ | 16:02 |
| rm_work | not sure who was doing the devstack work | 16:02 |
| dave-mccowan | alee thanks! | 16:03 |
| alee | dave-mccowan, you'll notice in the functional tests, there are a few tests that depend on your current cr | 16:04 |
| jaosorior | rm_work: wazzup? | 16:04 |
| rm_work | http://docs.openstack.org/developer/devstack/plugins.html | 16:05 |
| rm_work | looks like a better method for devstack setup has come along | 16:05 |
| rm_work | wondering if we had considered switching to that | 16:05 |
| rm_work | not sure how much work it would be | 16:05 |
| rm_work | an example: https://github.com/openstack/neutron-lbaas/tree/master/devstack | 16:05 |
| rm_work | possibly VERY simple | 16:06 |
| jaosorior | Niiiiice | 16:06 |
| rm_work | then installing it in devstack is just | 16:08 |
| rm_work | enable_plugin barbican https://review.openstack.org/openstack/barbican | 16:09 |
| rm_work | in the localrc | 16:09 |
| rm_work | no more clone/copy | 16:09 |
| dave-mccowan | alee do you mean using certutils? cool! i was hoping they'd be useful. or do you mean blocked waiting on my validator? | 16:13 |
| rm_work | dave-mccowan: certutils? | 16:15 |
| *** igueths has joined #openstack-barbican | 16:16 | |
| rellerreller | alee I reviewed https://review.openstack.org/166257 | 16:16 |
| alee | dave-mccowan, blocked waiting your validator | 16:17 |
| alee | (look for "dave") | 16:17 |
| rellerreller | alee I looked at the gate for https://review.openstack.org/#/c/166089/ . I don't know what is happening there. I have not seen anything like that before. | 16:17 |
| alee | and yeah - I did use them | 16:17 |
| rm_work | dave-mccowan: what certutils? linky? | 16:17 |
| dave-mccowan | rm_work tests/certificate_utils.py does some neat stuff like create_good_csr() and create_bad_csr() to write test cases | 16:17 |
| rm_work | ah | 16:18 |
| rm_work | was thinking someone actually went ahead and added certutils (for certificate X509 related convenience functions) to somewhere | 16:18 |
| rm_work | ala: | 16:18 |
| alee | rellerreller, jaosorior - https://review.openstack.org/166257 seems pretty simple -- any objections to workflowing it , seeing as noone else is around? | 16:19 |
| rm_work | https://github.com/openstack/neutron-lbaas/tree/master/neutron_lbaas/common/tls_utils | 16:19 |
| alee | (and its blocking me sending up further updates) | 16:19 |
| dave-mccowan | alee having the tests help me. i'll get them unblocked. | 16:20 |
| alee | cool | 16:20 |
| alee | rellerreller, jaosorior - ya'll have one minute to object .. | 16:21 |
| rellerreller | alee object to what? the workflow? | 16:22 |
| alee | yup | 16:22 |
| rellerreller | alee I don't know what can and cannot get merged with the freeze. | 16:22 |
| rellerreller | alee I don't mind if someone else workflows it, but I probably will not unless I hear from redrobot. | 16:23 |
| alee | rellerreller, we'll find out :) but I would assume that a freeze does not stop development | 16:23 |
| alee | ie. it means some kind of branch | 16:23 |
| alee | anyways - I'll workflow and see what happens | 16:24 |
| rellerreller | alee I just saw from Thierry on openstack-announce that it kind of does stop devleopment. | 16:24 |
| rellerreller | Only those features that have ffe or are bugs can be merged. | 16:24 |
| alee | rellerreller, right - but thats a policy thing -- not something that prevents stuff from being checked in (I think) | 16:26 |
| alee | anyways we'll see | 16:26 |
| *** igueths has quit IRC | 16:30 | |
| *** kebray has quit IRC | 16:33 | |
| *** kebray has joined #openstack-barbican | 16:33 | |
| *** SheenaG has joined #openstack-barbican | 16:37 | |
| arunkant | jaosorior, replied to your comments on https://review.openstack.org/#/c/164334/ . Can you please check. | 16:45 |
| arunkant | alee, can you check https://review.openstack.org/#/c/164334/ as well. | 16:46 |
| alee | arunkant, yup - I have not forgotten .. just trying to get the cert stuff in. | 16:47 |
| alee | arunkant, right now that needs a little work. | 16:47 |
| arunkant | alee, okay. Just want to check to see if there is need to make db model changes as per jaosorior comments or not? | 16:52 |
| jaosorior | arunkant: replied in the cr | 16:53 |
| arunkant | jaosorior, thanks | 16:54 |
| *** jkf has joined #openstack-barbican | 16:57 | |
| *** jkf has quit IRC | 16:58 | |
| openstackgerrit | Ade Lee proposed openstack/barbican: Add functional tests for certificate orders https://review.openstack.org/166089 | 17:01 |
| openstackgerrit | Ade Lee proposed openstack/barbican: Fix CA related exceptions, and unskip relevant tests https://review.openstack.org/166316 | 17:02 |
| alee | dave-mccowan, ^^ | 17:02 |
| alee | dave-mccowan, you'll need Oz fix too -- https://review.openstack.org/#/c/166257/1 | 17:03 |
| *** jkf has joined #openstack-barbican | 17:07 | |
| *** darrenmoffat has quit IRC | 17:07 | |
| *** kebray has quit IRC | 17:08 | |
| *** darrenmoffat has joined #openstack-barbican | 17:08 | |
| *** SheenaG has quit IRC | 17:15 | |
| *** openstackgerrit has quit IRC | 17:21 | |
| *** openstackgerrit has joined #openstack-barbican | 17:22 | |
| *** gyee has joined #openstack-barbican | 17:27 | |
| openstackgerrit | Merged openstack/barbican: Moving containers tests to separate module https://review.openstack.org/162504 | 17:37 |
| *** jkf has quit IRC | 17:57 | |
| *** jkf has joined #openstack-barbican | 18:05 | |
| *** tkelsey has joined #openstack-barbican | 18:21 | |
| openstackgerrit | Thomas Dinkjian proposed openstack/python-barbicanclient: Second set of negative secrets tests. https://review.openstack.org/163556 | 18:24 |
| alee | anyone know if there is a way to attach a debugger to a process in pycharm 3? | 18:30 |
| dave-mccowan | alee https://wiki.openstack.org/wiki/Barbican/Barbican-IDE-Debugging | 18:32 |
| alee | dave-mccowan, yeah - I saw that -- I may try out pycharm 4 though | 18:33 |
| alee | looks like they have a brand new "attach to process" feature | 18:34 |
| dave-mccowan | alee i think you need the professional edition. i use pycharm 4 PE. | 18:34 |
| alee | well we have an openstack license for the pycharm 3 PE I think | 18:34 |
| alee | so maybe it will work for 4? | 18:35 |
| *** crc32 has joined #openstack-barbican | 18:35 | |
| *** lisaclark has quit IRC | 18:39 | |
| *** dougwig has quit IRC | 18:39 | |
| *** erw has quit IRC | 18:39 | |
| *** Sheena_ has quit IRC | 18:39 | |
| alee | woodster_, ? | 18:55 |
| alee | bueller? | 18:56 |
| woodster_ | alee: lots of meetings today, one starting up shortly | 19:01 |
| redrobot | alee rellerreller just catching up on IRC. I'm at a one-day security conference. | 19:01 |
| alee | woodster_, yeah - I noticed no one was around | 19:01 |
| redrobot | rellerreller what workflow were you asking about? | 19:02 |
| alee | redrobot, I workflowed this one -- not sure when/if it will merge | 19:02 |
| redrobot | alee ok, cool | 19:02 |
| alee | https://review.openstack.org/166257 ? | 19:02 |
| alee | its an easy one but one needed to make my tests work | 19:03 |
| *** tkelsey has quit IRC | 19:03 | |
| alee | woodster_, I have a question about some plugins .. trying to figure out why they are not working | 19:03 |
| alee | woodster_, we're going to need to work closely over the beginning of next week to try to get the ca stuff done | 19:04 |
| alee | woodster_, its not working partly because the status stuff is not being set correctly | 19:05 |
| alee | and partly because the plugins are not firing | 19:05 |
| redrobot | alee docstring doesn't match the implementation in that CR... not a big deal if it merges, I can patch it up. | 19:05 |
| woodster_ | alee: for sure | 19:05 |
| alee | redrobot, woodster_ please review https://review.openstack.org/#/c/166089/ and https://review.openstack.org/#/c/166316/1 when you get a chance | 19:07 |
| alee | woodster_, redrobot although I have no idea why the gate job failed for that | 19:07 |
| alee | and will need help troubleshooting that | 19:07 |
| alee | http://logs.openstack.org/89/166089/1/check/gate-barbican-devstack-dsvm/24c23f4/console.html -- no idea whats going on here. | 19:08 |
| redrobot | alee weird... maybe tdink or hockeynut have seen this before? ^^ | 19:10 |
| tdink | redrobot: i have not seen this before =/ | 19:11 |
| *** dimtruck is now known as zz_dimtruck | 19:14 | |
| openstackgerrit | Merged openstack/barbican: BarbicanHTTPException can take arguments for client_message https://review.openstack.org/166257 | 19:15 |
| *** xaeth is now known as xaeth_afk | 19:15 | |
| redrobot | rellerreller Feature Freeze means we're not merging any code for new Blueprints. The only blueprint-related patches we should land are for blueprints that have Feature Freeze Exceptions (the ones listed here: https://launchpad.net/barbican/+milestone/kilo-rc1) | 19:18 |
| redrobot | rellerreller bugfixes and test code is fine for review/merging | 19:18 |
| redrobot | rellerreller once RC1 is tagged, the L cycle begins and we can start landing new blueprints again. | 19:18 |
| rellerreller | redrobot OK, that is good to know. Thanks for clarifying that. | 19:18 |
| alee | redrobot, is there some kind of check that is made on the commit message for either a blueprint or bug number? | 19:21 |
| alee | or is it done via inspection? | 19:21 |
| redrobot | alee it's purely policy. There's no automatic gating of it or anything. | 19:22 |
| alee | redrobot, ok great | 19:22 |
| redrobot | alee the idea is that we use the time to polish the code base for the final release for the Cycle | 19:22 |
| alee | redrobot, or get it to actually work :) | 19:22 |
| alee | yeah | 19:23 |
| redrobot | lol, yeah... that would qualify as "polish" :D | 19:23 |
| *** zz_dimtruck is now known as dimtruck | 19:33 | |
| *** SheenaG has joined #openstack-barbican | 19:41 | |
| *** dimtruck is now known as zz_dimtruck | 19:43 | |
| *** xaeth_afk is now known as xaeth | 19:46 | |
| woodster_ | alee, I'm back. Not sure if you are still trying to remote debug, but check this out if so: https://github.com/cloudkeep/barbican/wiki/Barbican---debugging-with-IDE | 19:52 |
| alee | woodster_, right now - I'm trying to debug my setup --- I have a barbican server which I started using barbican.sh install | 19:58 |
| alee | woodster_, and I see the folllowing error .. | 19:58 |
| alee | AttributeError: 'module' object has no attribute 'certificate' | 19:58 |
| openstackgerrit | Merged openstack/barbican: Starting to rework docs around the secret resource https://review.openstack.org/165659 | 19:58 |
| alee | woodster_, in the init for the CertPluginManager | 19:59 |
| alee | woodster_, http://www.fpaste.org/200714/68816181/ | 20:00 |
| alee | woodster_, its like it cannot read the config file correctly | 20:01 |
| alee | my barbican-api.conf has the section .. | 20:02 |
| alee | [certificate] | 20:02 |
| alee | namespace = barbican.certificate.plugin | 20:02 |
| alee | enabled_certificate_plugins = simple_certificate | 20:02 |
| woodster_ | alee, can you paste the top of the file (that does the config foo up there), or is it the same as what is in the code base now? | 20:07 |
| alee | woodster_, its the same as whats in the code base now | 20:08 |
| woodster_ | alee, don't see anything obvioius...you might need to send up a CR and workflow -2 it | 20:11 |
| alee | eh? | 20:12 |
| woodster_ | alee, is this running in the stand alone (out of the box) mode locally? | 20:12 |
| alee | woodster_, its running on my local box | 20:13 |
| woodster_ | alee, send up your changes and then I can try to run locally on my box | 20:13 |
| alee | woodster_, ah -- well I have a couple of crs .. | 20:13 |
| *** dougwig has joined #openstack-barbican | 20:13 | |
| alee | woodster_, https://review.openstack.org/#/c/166089/ | 20:13 |
| woodster_ | too many secrets, too many CRs! | 20:13 |
| alee | woodster_, https://review.openstack.org/#/c/166316/1 | 20:14 |
| woodster_ | oh you're troubleshooting the broken gate then? | 20:14 |
| alee | no not yet | 20:14 |
| *** erw has joined #openstack-barbican | 20:14 | |
| alee | I'm trying to figure out why in my local install , my cert manager plugins are not being instantiated | 20:15 |
| woodster_ | so this is the one you are futzing with then?: https://review.openstack.org/#/c/166316/1 | 20:15 |
| alee | woodster_, yeah -- so download the first one and the second one | 20:15 |
| alee | they lie on top of each other | 20:16 |
| alee | then -- I tried doing this .. | 20:17 |
| alee | set up keystone and run barbican server locally | 20:17 |
| alee | and run functional tests | 20:17 |
| alee | woodster_, for some reason, the secret_store config works but the cert store config does not | 20:20 |
| alee | cert_manager | 20:21 |
| *** kebray has joined #openstack-barbican | 20:21 | |
| alee | woodster_, so the real question is -- when you run a functional test -- say you remove the skip on test_create_simple_cmc_order() for example | 20:26 |
| alee | do you see the same error in loading the cert_manager plugin? | 20:26 |
| alee | and the cert_manager_event_plugin? | 20:26 |
| woodster_ | alee, just visually looking at the code now. I haven't crossed the bridge of spinning up Keystone server in a long time...dreading doing that, but need to :\ | 20:27 |
| *** gitorres has joined #openstack-barbican | 20:30 | |
| woodster_ | alee, on line 82/83 of certificate_resources.py....remove that 'repos' from the CertificatePluginManager() constructor call...it is shadowing the 'conf' attribute and causing your issue I bet | 20:30 |
| *** gitorres has quit IRC | 20:31 | |
| alee | aha | 20:32 |
| *** lisaclark has joined #openstack-barbican | 20:33 | |
| *** zz_dimtruck is now known as dimtruck | 20:34 | |
| alee | woodster_, ok much better :) | 20:35 |
| alee | woodster_, good catch | 20:35 |
| woodster_ | alee, ha, I'm kicking that Keystone can down the road a little longer ;) | 20:35 |
| alee | woodster_, anyways feel free to review the functional tests | 20:36 |
| alee | woodster_, if all goes well - I think if we get the functional tests working - we can say "cert api is complete" | 20:36 |
| alee | ish .. | 20:36 |
| *** Sheena_ has joined #openstack-barbican | 20:40 | |
| *** dimtruck is now known as zz_dimtruck | 20:44 | |
| *** jaosorior has quit IRC | 20:52 | |
| *** tkelsey has joined #openstack-barbican | 21:00 | |
| *** tkelsey has quit IRC | 21:04 | |
| *** zz_dimtruck is now known as dimtruck | 21:10 | |
| dave-mccowan | alee i've got some cert api validator code working, and have it raising exceptions on some of your functional tests, but i'm still getting 500 responded. i have patched oz's commit to exception.py. is there something else i'm missing (or need to write). | 21:11 |
| alee | dave-mccowan, I found a couple of things that need to be fixed , but they are later on in the stack I think | 21:12 |
| alee | dave-mccowan, this is in validator code , right? | 21:12 |
| dave-mccowan | yes | 21:13 |
| alee | or in code executed post validator? | 21:13 |
| alee | which functions? | 21:13 |
| alee | and which tests? | 21:13 |
| dave-mccowan | validate_certificate_container() is what i've called it. if i find a bad container id for example, i raise exception.InvalidContainer(reason=reason) | 21:15 |
| *** jkf has quit IRC | 21:15 | |
| openstackgerrit | Arun Kant proposed openstack/barbican: For per secret ACL support, adding db layer changes (Part 1) https://review.openstack.org/164334 | 21:16 |
| *** rellerreller has quit IRC | 21:16 | |
| alee | dave-mccowan, called by _validate_stored_key_request() ? | 21:16 |
| *** jkf has joined #openstack-barbican | 21:17 | |
| dave-mccowan | alee yes | 21:17 |
| alee | dave-mccowan, which functional test are you running? | 21:17 |
| alee | test_create_stored_key_order_with_invalid_container_ref() ? | 21:18 |
| dave-mccowan | test_create_stored_key_order_with_invalid_container_ref() is one. i see my code raising exception, but 500 is still returned. | 21:18 |
| *** SheenaG has quit IRC | 21:18 | |
| alee | dave-mccowan, thats puzzling | 21:19 |
| alee | dave-mccowan, the code I have in exception.py has this exception throwing 400 | 21:20 |
| alee | class InvalidContainer(BarbicanHTTPException): | 21:20 |
| alee | message = u._("Invalid container: %(reason)s") | 21:20 |
| alee | client_message = message | 21:20 |
| alee | status_code = 400 | 21:20 |
| alee | so - not sure what is happening .. do you see the correct message in the 500 response? | 21:21 |
| dave-mccowan | alee ah. that's the code i'm missing. has it been merged? | 21:21 |
| alee | dave-mccowan, no - that was in my second patch .. | 21:21 |
| dave-mccowan | alee cool. that's it then. i'll check my git branching. thanks! | 21:22 |
| alee | dave-mccowan, https://review.openstack.org/#/c/166316/ | 21:22 |
| alee | you need https://review.openstack.org/#/c/166089/2, then oz fix (which has merged I think), and then https://review.openstack.org/#/c/166316/ | 21:23 |
| alee | dave-mccowan, cool - looking forward to seeing the patch | 21:24 |
| alee | ok - gotta go get kids - have a good weekend, all. | 21:24 |
| *** alee is now known as alee_out | 21:24 | |
| *** SheenaG has joined #openstack-barbican | 21:38 | |
| openstackgerrit | Arun Kant proposed openstack/barbican: Adding Secret ACL controller layer changes (Part 2) https://review.openstack.org/164335 | 21:43 |
| openstackgerrit | Arun Kant proposed openstack/barbican: Adding Container ACL controller layer changes (Part 3) https://review.openstack.org/165205 | 21:44 |
| openstackgerrit | Arun Kant proposed openstack/barbican: Adding policy layer changes for ACL support (Part 4) https://review.openstack.org/165207 | 21:44 |
| openstackgerrit | John Wood proposed openstack/barbican: Add sub-status logic to worker/task processing https://review.openstack.org/157565 | 21:47 |
| *** jkf has quit IRC | 21:48 | |
| *** jamielennox|away is now known as jamielennox | 21:49 | |
| openstackgerrit | John Wood proposed openstack/barbican: Add retry periodic task and worker-client logic https://review.openstack.org/164947 | 21:51 |
| *** xaeth is now known as xaeth_afk | 22:02 | |
| *** jamielennox is now known as jamielennox|away | 22:05 | |
| *** kebray has quit IRC | 22:42 | |
| *** SheenaG has quit IRC | 22:50 | |
| *** dimtruck is now known as zz_dimtruck | 22:59 | |
| openstackgerrit | John Wood proposed openstack/barbican: Allow business logic and plugins to retry tasks https://review.openstack.org/165594 | 23:13 |
| *** dave-mccowan has quit IRC | 23:20 | |
| *** tkelsey has joined #openstack-barbican | 23:31 | |
| *** tkelsey has quit IRC | 23:35 | |
| *** dave-mccowan has joined #openstack-barbican | 23:38 | |
| *** gyee has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!