| elmiko | redrobot: no prob, glad to help =) | 00:00 |
|---|---|---|
| *** nkinder has joined #openstack-barbican | 00:09 | |
| *** SheenaG has quit IRC | 00:10 | |
| jamielennox | hi, what's the status of https://review.openstack.org/#/c/169481/2 ? | 00:32 |
| jamielennox | does that mean there is another review replacing it or it's no longer required..? | 00:33 |
| *** SheenaG has joined #openstack-barbican | 01:36 | |
| openstackgerrit | John Vrbanac proposed openstack/barbican: Adding simple log.info's to the SecretController https://review.openstack.org/168774 | 01:45 |
| *** SheenaG has quit IRC | 01:53 | |
| woodster_ | jamielennox: we just talked about that one today, I don't think it's being replaced if that's what you mean? | 01:54 |
| jamielennox | woodster_: i was just looking at https://review.openstack.org/#/c/148450/ | 01:55 |
| jamielennox | woodster_: and the last comment refers to it - but it's been -1ed after a +2, i was just wondering what was going on | 01:55 |
| woodster_ | jamielennox: it looks like that last gate is borking and Thomas' CR might fix that. After that your CR should be all green? | 02:00 |
| jamielennox | woodster_: not sure - i was just reading the comment | 02:00 |
| woodster_ | jamielennox: my read is that it could fix that broken gate. The issue is that the API is returning new fields now (for order sub-status) that broke the client. | 02:02 |
| jamielennox | woodster_: that's ok, i was just circling back to it, i can leave it for another few days i was just wondering if it was worth rebasing onto an existing fix or something | 02:05 |
| woodster_ | jamielennox: we'll be trying to put some heat behind these CRs over the next couple of days, but if you are in a hurry you could certainly add those changes to your CR (and the one Steve mentions at the end of this CR: https://review.openstack.org/#/c/169481/2/barbicanclient/barbican_cli/orders.py,cm) | 02:16 |
| woodster_ | jamielennox: fwiw, we talked about making the client less sensitive to new optional fields added to responses from the API so that these new fields don't break the client everytie | 02:19 |
| woodster_ | everytime | 02:19 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Refactor Stored Key Certificate Order Validator Code https://review.openstack.org/171023 | 02:19 |
| jamielennox | woodster_: would make sense, client shouldn't be tied to only working with certain server versions | 02:20 |
| woodster_ | jamielennox: yeah we had a big discussion about that this afternoon. If feels 'dirty' adding a **kwargs at the end of the Order __init__() though...or plucking values out of the kwargs dict directly. :) | 02:21 |
| jamielennox | having done the kwargs thing i'd hold off as long as possible | 02:22 |
| woodster_ | jamielennox: the action items was to see what other projects do to handle this one, or the API workig group | 02:22 |
| woodster_ | jamielennox: I was in the **kwargs camp if the alternative to is to release more versions of the client though the API URI version isn't changing. | 02:23 |
| jamielennox | woodster_: why is the client checking the server side info at all? | 02:24 |
| jamielennox | you can add this stuff to get() and list() etc | 02:24 |
| jamielennox | or if you are talking about creating the object, i don't know about reconstructing from kwargs, we normally pass the response from the response as a dict and you should only provide accessors to things that the client knows about | 02:25 |
| woodster_ | jamielennox: the response is coming back as a dict that is then passed to the Order model which has specific keyword args with no ending **kwargs to 'soak up' the remaining 'new' dict items that might be in the response. | 02:26 |
| jamielennox | woodster_: hmm, ok - not sure which way you want to go, just showing how we deal with it | 02:28 |
| jamielennox | and the client should be able to handle these new options | 02:29 |
| woodster_ | jamielennox: so you mean the dict is passed in to the __init__ and then the constructor does '.get('my_value')' sort of calls to it to set its 'self' attributes, correct? | 02:29 |
| jamielennox | woodster_: more or less, they tried to standardize this a while ago, i'll find it | 02:30 |
| jamielennox | woodster_: https://github.com/openstack/oslo-incubator/blob/master/openstack/common/apiclient/base.py#L440 | 02:31 |
| woodster_ | jamielennox: which project are you referring to? The API WG? | 02:31 |
| jamielennox | woodster_: that was an older one, the way we tried to do it in sdk you still pass the dictionary, __getitem__ gives you access to the whole resource response so that if you need new values before the client you can get them | 02:32 |
| woodster_ | jamielennox: Nice! | 02:32 |
| jamielennox | and attributes are provided for objects that the client knows about | 02:33 |
| jamielennox | that oslo-incubator module is deprecated, but there are plenty of clients that are using more or less that | 02:34 |
| jamielennox | this is a way better way but it's a big file https://github.com/stackforge/python-openstacksdk/blob/master/openstack/resource.py | 02:35 |
| woodster_ | jamielennox: this looks good. I need to spin up on what it takes to get barbican into the openstack sdk. I think we'll be discussing that more in liberty. | 02:41 |
| dave-mccowan | woodster_ https://review.openstack.org/171023 this is the code moving the validator function out of orders.py, per your code review comment. what do you think? | 02:42 |
| briancurtin | woodster_: there's already some minimal support for it, just need to rename it from keystore to whatever you moved to (can't remember) | 02:42 |
| jamielennox | woodster_: yea, that's long term a good idea, but the clients will stick around for a while yet anyway | 02:42 |
| *** chlong has quit IRC | 02:42 | |
| woodster_ | dave-mccowan: nice, I'll take a look | 02:42 |
| jamielennox | briancurtin: that resource file is so much bigger than i remember, i need to get back in there | 02:43 |
| *** chlong has joined #openstack-barbican | 02:44 | |
| woodster_ | briancurtin: ha, I was thinking work wouldn't start until after the Liberty summit. So maybe we just fret over the current client we have until Kilo final release and then replace it? | 02:45 |
| briancurtin | woodster_: i dont work on barbican so i have no input there, but once we in SDK wrap up some current things, we could have full support of the REST API of pretty much any service very quickly. we did a small amount of a bunch of services just to see how things look, and will push more for completeness probably starting in a few weeks | 02:46 |
| woodster_ | jamielennox: frameworks can be that way I figure :) | 02:46 |
| woodster_ | briancurtin: nice, so meeting up in Liberty will be good timing then it sounds like | 02:47 |
| briancurtin | i believe so | 02:47 |
| openstackgerrit | John Vrbanac proposed openstack/barbican: Updating hacking version for py3pep8 tox job https://review.openstack.org/171027 | 03:14 |
| openstackgerrit | John Vrbanac proposed openstack/barbican: Fixing python 3 imcompatiblity in common.utils https://review.openstack.org/171031 | 03:20 |
| *** jamielennox is now known as jamielennox|away | 03:47 | |
| *** gyee has quit IRC | 03:50 | |
| *** kebray has joined #openstack-barbican | 04:00 | |
| *** dave-mccowan has quit IRC | 04:08 | |
| *** kebray has quit IRC | 04:44 | |
| *** kebray has joined #openstack-barbican | 04:51 | |
| rm_work | woodster_: ah i hope you had good luck tonight -- got disconnected, so may have missed if you did ping me | 05:46 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Imported Translations from Transifex https://review.openstack.org/171055 | 06:11 |
| *** woodster_ has quit IRC | 06:50 | |
| *** everjeje has joined #openstack-barbican | 06:57 | |
| *** tkelsey has joined #openstack-barbican | 07:28 | |
| *** tkelsey has quit IRC | 07:30 | |
| *** chlong has quit IRC | 07:34 | |
| *** kebray has quit IRC | 07:46 | |
| openstackgerrit | Thomas Herve proposed openstack/python-barbicanclient: Fix order listing on the command line. https://review.openstack.org/169481 | 07:56 |
| *** jaosorior has joined #openstack-barbican | 08:05 | |
| *** gitorres1 has joined #openstack-barbican | 09:55 | |
| *** gitorres has quit IRC | 09:55 | |
| *** chlong has joined #openstack-barbican | 10:07 | |
| *** darrenmoffat has quit IRC | 10:20 | |
| *** darrenmoffat has joined #openstack-barbican | 10:21 | |
| jaosorior | anybody knows what version of openssl is being used in the gate? | 11:39 |
| *** chlong has quit IRC | 11:49 | |
| *** chlong has joined #openstack-barbican | 11:51 | |
| *** woodster_ has joined #openstack-barbican | 12:10 | |
| *** dave-mccowan has joined #openstack-barbican | 12:21 | |
| *** alee has quit IRC | 12:26 | |
| *** rellerreller has joined #openstack-barbican | 12:41 | |
| openstackgerrit | Merged openstack/barbican: Updating hacking version for py3pep8 tox job https://review.openstack.org/171027 | 12:55 |
| openstackgerrit | John Wood proposed openstack/barbican: Add retry server and functional tests to DevStack https://review.openstack.org/170896 | 12:58 |
| openstackgerrit | Dave McCowan proposed openstack/barbican: Refactor Stored Key Certificate Order Validator Code https://review.openstack.org/171023 | 13:02 |
| *** openstackgerrit has quit IRC | 13:07 | |
| *** SheenaG has joined #openstack-barbican | 13:07 | |
| *** openstackgerrit has joined #openstack-barbican | 13:07 | |
| rellerreller | woodster_ redrobot Are people discussing content type issues today? When I logged off yesterday there was talk of a Google hangout. | 13:13 |
| woodster_ | rellerreller I think the idea was to meet in IRC after the weekly meeting, but I think you had to cut out shortly thereafter. A google hangouts today would work for me though. What time works for you? | 13:20 |
| rellerreller | woodster_ All times in CT, I am busy from 9:00-9:30 and after 12:00. Basically anytime before noon except 9:00-9:30 is good with me. | 13:24 |
| woodster_ | so effectively now thru the next 2 and 1/2 hours? | 13:25 |
| woodster_ | rellerreller, sorry ^^^ | 13:26 |
| woodster_ | redrobot, are you there? | 13:26 |
| woodster_ | rellerreller, I don't see alee either. Maybe give them another hour | 13:27 |
| *** alee has joined #openstack-barbican | 13:40 | |
| dave-mccowan | woodster_, rellerreller, yesterday redrobot said he was going to spend today sorting out and documenting all the flows and formats, then find a slot on Wednesday for a hangout. | 13:44 |
| *** SheenaG has quit IRC | 13:45 | |
| *** chlong has quit IRC | 13:51 | |
| alee | jaosorior, I would guess its 0.9.8 something , based on the failures I saw before. | 13:58 |
| jaosorior | alee: I didn't post an update on that question. But from what I saw it seems it's 1.0.1f | 13:59 |
| alee | jaosorior, ok | 14:00 |
| jaosorior | alee: 1.0.1f-1ubuntu2.11 to be specific | 14:00 |
| jaosorior | I'm getting errors on some tests from the snakeoil CA | 14:00 |
| jaosorior | and I'm trying to understand what's going on | 14:01 |
| *** kfarr has joined #openstack-barbican | 14:01 | |
| *** zz_dimtruck is now known as dimtruck | 14:03 | |
| alee | jaosorior, ok | 14:03 |
| *** paul_glass has joined #openstack-barbican | 14:04 | |
| *** paul_glass has quit IRC | 14:14 | |
| *** paul_glass has joined #openstack-barbican | 14:15 | |
| *** igueths has joined #openstack-barbican | 14:23 | |
| igueths | Hi all. | 14:23 |
| woodster_ | igueths, morning | 14:25 |
| igueths | Morning woodster_. | 14:28 |
| *** SheenaG has joined #openstack-barbican | 14:32 | |
| *** kebray has joined #openstack-barbican | 14:49 | |
| *** atiwari has joined #openstack-barbican | 14:56 | |
| *** kfarr has quit IRC | 15:02 | |
| *** SheenaG has quit IRC | 15:04 | |
| *** xaeth_afk is now known as xaeth | 15:08 | |
| redrobot | ohai | 15:42 |
| *** SheenaG has joined #openstack-barbican | 15:43 | |
| jvrbanac | jaosorior, yo! | 15:43 |
| jvrbanac | jaosorior, sooo I went and looked at Nova and Keystone and it looks like LOG.infos are used very sparingly, but they are used in the same fashion for what I did in that CR. They only use LOG.infos to report discrete positive units of work within the controller call directly. I'm inclined to follow that pattern for now. | 15:52 |
| *** gyee has joined #openstack-barbican | 15:54 | |
| jaosorior | jvrbanac: alright. What's the link to the CR? | 16:07 |
| jvrbanac | jaosorior, https://review.openstack.org/#/c/168774/ | 16:15 |
| jvrbanac | jaosorior, I think this is a good sidebar discussion for us to have over Liberty, but currently, we have zero logging that is acceptable for production cases, so I would like to atleast get our minimum unit-of-work messages in and then iterate. | 16:17 |
| *** SheenaG1 has joined #openstack-barbican | 16:21 | |
| *** SheenaG has quit IRC | 16:22 | |
| openstackgerrit | Merged openstack/barbican: Fixing python 3 imcompatiblity in common.utils https://review.openstack.org/171031 | 16:26 |
| elmiko | jvrbanac: i've been watching that review (168774), would it be worthwhile to add similar logging to the containers controller? | 16:41 |
| *** alee is now known as alee_lunch | 16:49 | |
| *** tkelsey has joined #openstack-barbican | 16:49 | |
| *** dave-mccowan has quit IRC | 16:58 | |
| *** rellerreller has quit IRC | 16:58 | |
| *** dave-mccowan has joined #openstack-barbican | 17:26 | |
| jaosorior | jvrbanac: I agree. And we can refactor it later if we find another solution that we prefer | 17:46 |
| jaosorior | jvrbanac: I agree. And we can refactor it later if we find another solution that we prefer | 17:48 |
| *** alee_lunch is now known as alee | 17:49 | |
| *** tkelsey has quit IRC | 18:00 | |
| *** jamielennox|away is now known as jamielennox | 18:01 | |
| jvrbanac | jaosorior, thx | 18:19 |
| *** atiwari has quit IRC | 18:19 | |
| jvrbanac | elmiko, yeah I agree. I didn't want to start adding logging to other things until we had agreed on a solution for the time being. | 18:20 |
| elmiko | jvrbanac: yea same, sounds like i could make a patch for it? | 18:22 |
| jvrbanac | elmiko, I believe so. Btw, here is the Openstack logging guideline if you didn't already have it: http://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html | 18:24 |
| elmiko | jvrbanac: awesome, thanks! | 18:24 |
| openstackgerrit | Ade Lee proposed openstack/barbican: Changes to get remaining cert functional tests working https://review.openstack.org/169600 | 18:53 |
| alee | woodster_, redrobot , dave-mccowan ^^ | 18:54 |
| alee | rellerreller, kfarr ^^ | 18:54 |
| alee | woodster_, redrobot , dave-mccowan - this gets all the cert order functional tests working and gets things working as the current code is envisioned to work. | 18:55 |
| redrobot | alee sounds good | 18:55 |
| redrobot | alee will hopefully get to it sometime soon | 18:55 |
| alee | woodster_, redrobot , dave-mccowan - if we decide we want to change how things work, we can do that in a separate cr. | 18:56 |
| alee | but this will at least give us a framework and tests for what needs to work in case we change anything | 18:56 |
| alee | redrobot, yes - I think this will be instructive for you as you research how we manage content type. | 18:57 |
| alee | its in all the code you need to examine. | 18:57 |
| alee | jvrbanac, jaosorior ^^ please take a look as well. | 18:58 |
| alee | dave-mccowan, going to try out your tests now to see if they pass .. | 18:58 |
| dave-mccowan | alee awesome. looking at your CR now. | 18:59 |
| alee | reaperhulk, we're probably going to need some input from you too. | 19:00 |
| alee | dave-mccowan, I don't think your test cases are valid -- I'll comment on the CR. | 19:10 |
| *** bpoulos has joined #openstack-barbican | 19:13 | |
| dave-mccowan | alee quite possible that they need to be debugged now there is working code underneath. | 19:15 |
| alee | dave-mccowan, yup | 19:15 |
| alee | dave-mccowan, I'd wait till redrobot figures out what we want to do and we have the google hangout tomorrow. | 19:16 |
| alee | redrobot, have you scheduled the hangout yet? | 19:16 |
| dave-mccowan | alee, i hacked them a couple different ways trying to work around the underlying code; i don't remember which state I left them in. :-) but please, comment on CR. | 19:17 |
| redrobot | alee not yet | 19:17 |
| alee | dave-mccowan, I'll put in some pointers on the CR and maybe you can try them .. | 19:17 |
| redrobot | trying to figure out if we even need one | 19:17 |
| redrobot | I think the only thing I don't like currently is that there is no content type for a public key | 19:18 |
| redrobot | so we're using application/octet-stream for a public key | 19:19 |
| alee | redrobot, I think what we are currently doing is pretty complicated. | 19:21 |
| redrobot | alee I've been mostly looking at it from an API user pov | 19:22 |
| alee | redrobot, so its worth reviewing. check out my cr to see what needs to be done to get things working | 19:22 |
| alee | redrobot, sure - lets start from there. | 19:22 |
| *** openstackgerrit has quit IRC | 19:22 | |
| *** openstackgerrit has joined #openstack-barbican | 19:23 | |
| openstackgerrit | Merged openstack/barbican: Imported Translations from Transifex https://review.openstack.org/171055 | 19:24 |
| *** bpoulos has left #openstack-barbican | 19:29 | |
| *** tkelsey has joined #openstack-barbican | 19:46 | |
| *** tkelsey has quit IRC | 19:50 | |
| *** SheenaG has joined #openstack-barbican | 20:12 | |
| *** SheenaG1 has quit IRC | 20:16 | |
| *** SheenaG1 has joined #openstack-barbican | 20:17 | |
| *** SheenaG has quit IRC | 20:19 | |
| alee | dave-mccowan, can you run the functional tests and see if the stored_key_test still fails? | 20:33 |
| alee | woodster_, ^^ | 20:33 |
| alee | it still seems to be failing in the gate for some reason | 20:34 |
| dave-mccowan | alee ok | 20:39 |
| dave-mccowan | alee FAILED (SKIP=10, errors=3, failures=8) | 20:45 |
| alee | dave-mccowan, phooey | 20:45 |
| alee | dave-mccowan, which ones failed? | 20:45 |
| dave-mccowan | alee, functional.test_certificate_orders. | 20:46 |
| alee | dave-mccowan, thats a lot of failures -- more even than in the gate | 20:47 |
| alee | dave-mccowan, can you post the results? | 20:48 |
| alee | dave-mccowan, just confirming that you applied the patch ok and to a clean tree, because on the gate only one test fails | 20:50 |
| dave-mccowan | alee, git log looks ok, but i usually hose my repo whenever i try to cherry-pick. so, i wouldn't rule that out. | 20:52 |
| alee | dave-mccowan, ok -- so just to confirm, lets do this .. | 20:53 |
| alee | git checkout master; git pull | 20:53 |
| dave-mccowan | alee, my output http://ur1.ca/k4koe | 20:53 |
| alee | git checkout -b alee_test; git fetch ssh://alee@review.openstack.org:29418/openstack/barbican refs/changes/00/169600/3 && git cherry-pick FETCH_HEAD | 20:55 |
| alee | then reinstall your barbican server -- not sure how you do it -- I use barbican.sh install | 20:55 |
| alee | dave-mccowan, and run tests | 20:56 |
| alee | dave-mccowan, if that doesn't work, you might try blowing away the db | 20:56 |
| dave-mccowan | alee, my bad. i forgot to restart my server. standby for new results. | 20:58 |
| alee | :) | 20:58 |
| dave-mccowan | alee, trying to listen to a conference call at the same time. I got OK (SKIP=10) this time. | 20:59 |
| alee | dave-mccowan, yay | 20:59 |
| alee | dave-mccowan, can you confirm that the stored_key case was run? | 20:59 |
| dave-mccowan | Ran 5 tests, OK (SKIP=1) | 21:02 |
| dave-mccowan | alee nosetests functionaltests/api/v1/functional/test_certificate_orders.py:CertificatesTestCase.test_create_stored_key_order ran OK | 21:08 |
| alee | dave-mccowan, great thanks | 21:08 |
| openstackgerrit | John Wood proposed openstack/barbican: Add retry server and functional tests to DevStack https://review.openstack.org/170896 | 21:20 |
| *** chlong has joined #openstack-barbican | 21:26 | |
| *** alee has quit IRC | 21:31 | |
| *** openstackgerrit has quit IRC | 21:37 | |
| *** openstackgerrit has joined #openstack-barbican | 21:37 | |
| redrobot | anyone ever notice this content-type on Barbican responses: ? | 21:42 |
| redrobot | Content-Type: application/octet-stream; charset=UTF-8 | 21:42 |
| redrobot | it doesn't seem correct that application/octet-stream would have a charset | 21:43 |
| rm_work | hah | 21:43 |
| *** tkelsey has joined #openstack-barbican | 21:47 | |
| *** tkelsey has quit IRC | 21:51 | |
| openstackgerrit | John Wood proposed openstack/barbican: Add retry server and functional tests to DevStack https://review.openstack.org/170896 | 21:53 |
| *** xaeth is now known as xaeth_afk | 22:08 | |
| *** gyee has quit IRC | 22:11 | |
| *** gyee has joined #openstack-barbican | 22:14 | |
| openstackgerrit | John Wood proposed openstack/barbican: Add retry server and functional tests to DevStack https://review.openstack.org/170896 | 22:21 |
| *** paul_glass has quit IRC | 22:30 | |
| *** alee has joined #openstack-barbican | 22:32 | |
| *** jaosorior has quit IRC | 22:52 | |
| *** dimtruck is now known as zz_dimtruck | 22:56 | |
| *** dave-mccowan has quit IRC | 23:04 | |
| *** igueths has quit IRC | 23:06 | |
| openstackgerrit | Merged openstack/barbican: Adding simple log.info's to the SecretController https://review.openstack.org/168774 | 23:33 |
| *** alee has quit IRC | 23:37 | |
| *** alee has joined #openstack-barbican | 23:50 | |
| *** kebray has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!