*** SheenaG has quit IRC | 00:07 | |
*** edtubill has joined #openstack-barbican | 00:15 | |
*** lisaclark1 has joined #openstack-barbican | 00:22 | |
*** dave-mcc_ has joined #openstack-barbican | 00:24 | |
*** dave-mccowan has quit IRC | 00:27 | |
*** vivek-ebay has quit IRC | 00:35 | |
*** edtubill has quit IRC | 00:38 | |
*** lisaclark1 has quit IRC | 01:17 | |
*** vivek-ebay has joined #openstack-barbican | 01:29 | |
*** vivek-eb_ has joined #openstack-barbican | 01:47 | |
*** vivek-ebay has quit IRC | 01:48 | |
*** lisaclark1 has joined #openstack-barbican | 02:08 | |
rm_work | ok, looks like the best way to test this is to do it as an experimental gate temporarily -- https://review.openstack.org/217458 | 02:08 |
---|---|---|
rm_work | redrobot: if you have a sec to +1 that :P | 02:08 |
rm_work | or anyone who happens to be around, take a look | 02:08 |
pksingh | rm_work : Hi, I have a query can you please help me with it | 02:10 |
openstackgerrit | Dave McCowan proposed openstack/barbican: Ensure Project and ProjectQuotas Tables are in sync https://review.openstack.org/216253 | 02:10 |
rm_work | what's up? | 02:10 |
pksingh | rm_work: how to setup snake_oil plugin for CA | 02:11 |
rm_work | aaah | 02:11 |
rm_work | I am not sure I can help with that | 02:11 |
rm_work | I was looking into it (and helping define it) a long time ago but I never actually got it working | 02:11 |
rm_work | and someone else actually handled the majority of the patch :( | 02:11 |
pksingh | rm_work: OK | 02:12 |
rm_work | if you are somewhat far along and just need help with an error or something i can maybe help | 02:13 |
pksingh | i was just trying to setup snake_oil plugin fir CA | 02:14 |
pksingh | i changed config file and restarted the services but get api for CAS shows empty list | 02:14 |
rm_work | hmm | 02:15 |
rm_work | is there anything in the logs or in the barbican console output for when it tries to load up that plugin? | 02:16 |
pksingh | i am running barbican.sh start after modifying the conf file , and there is nothing unusual on the terminal | 02:18 |
dave-mcc_ | pksingh which config file did you change? depending how you installed and started barbican, there maybe two config files? "barbican.sh install" makes a copy of the config file. | 02:19 |
pksingh | dave-mcc_: i changed barbican.conf as in http://docs.openstack.org/developer/barbican/setup/certificate.html | 02:19 |
dave-mcc_ | in which directory? | 02:20 |
pksingh | file is at /etc/barbican/barbican.conf | 02:20 |
dave-mcc_ | "barbican.sh install" will copy ./etc/barbican/barbican.conf to /etc/barbican/barbican.conf (perhaps overwriting your change). did that happen? | 02:22 |
pksingh | i did not executed "barbican.sh install" | 02:23 |
pksingh | i installed through devstack | 02:23 |
*** lisaclark1 has quit IRC | 02:29 | |
*** vivek-eb_ has quit IRC | 02:32 | |
rm_work | pksingh: so there should still be logs somewhere | 02:39 |
rm_work | that shows what happens when barbican starts up | 02:39 |
rm_work | and it SHOULD spit out *something* about the plugins it loads | 02:40 |
rm_work | I am pretty sure | 02:40 |
pksingh | i was checking at /opt/stack/logs/barbican.log and found nothing related to CA | 02:45 |
rm_work | hmm | 02:45 |
openstackgerrit | Dave McCowan proposed openstack/barbican: Add get_count() method to project resource repositories https://review.openstack.org/212876 | 02:51 |
*** dave-mcc_ has quit IRC | 02:54 | |
*** yuanying_ has joined #openstack-barbican | 03:06 | |
*** yuanying_ has quit IRC | 03:07 | |
*** yuanying has quit IRC | 03:10 | |
*** vivek-ebay has joined #openstack-barbican | 03:13 | |
*** yuanying has joined #openstack-barbican | 04:01 | |
*** jamielennox is now known as jamielennox|away | 04:04 | |
*** jamielennox|away is now known as jamielennox | 04:05 | |
*** xaeth_afk is now known as xaeth | 04:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican: Updated from global requirements https://review.openstack.org/217476 | 04:13 |
*** xaeth is now known as xaeth_afk | 04:23 | |
*** yuanying has quit IRC | 04:32 | |
*** vivek-ebay has quit IRC | 04:33 | |
*** yuanying has joined #openstack-barbican | 04:37 | |
*** kebray has joined #openstack-barbican | 04:59 | |
*** elarson has quit IRC | 05:00 | |
*** elarson has joined #openstack-barbican | 05:01 | |
*** openstackgerrit has quit IRC | 05:16 | |
*** openstackgerrit has joined #openstack-barbican | 05:17 | |
openstackgerrit | Arun Kant proposed openstack/barbican: Barbican audit using audit middleware for pycadf events https://review.openstack.org/217523 | 05:33 |
*** Nirupama has joined #openstack-barbican | 05:49 | |
*** yuanying has quit IRC | 05:58 | |
*** xaeth_afk is now known as xaeth | 06:22 | |
*** DTadrzak has quit IRC | 06:35 | |
*** DTadrzak has joined #openstack-barbican | 06:49 | |
*** xaeth is now known as xaeth_afk | 07:05 | |
*** insequent has quit IRC | 07:14 | |
*** insequent has joined #openstack-barbican | 07:27 | |
*** DTadrzak has quit IRC | 07:38 | |
*** DTadrzak has joined #openstack-barbican | 07:39 | |
*** kebray has quit IRC | 07:45 | |
*** shohel has joined #openstack-barbican | 07:59 | |
*** jaosorior has joined #openstack-barbican | 08:02 | |
*** yuanying has joined #openstack-barbican | 08:03 | |
openstackgerrit | Merged openstack/barbican: Migrate to using gate_hook.sh pre-devstack-update https://review.openstack.org/217343 | 08:39 |
*** shohel has quit IRC | 09:40 | |
*** shohel has joined #openstack-barbican | 09:45 | |
*** shohel has quit IRC | 09:49 | |
*** shohel has joined #openstack-barbican | 09:59 | |
*** mmdurrant has quit IRC | 10:09 | |
*** shohel has quit IRC | 10:12 | |
*** shohel has joined #openstack-barbican | 10:13 | |
*** Kevin_Zheng_ is now known as Kevin_Zheng | 10:49 | |
*** insequent has quit IRC | 10:49 | |
*** insequent has joined #openstack-barbican | 11:02 | |
*** dave-mccowan has joined #openstack-barbican | 11:30 | |
*** mmdurrant has joined #openstack-barbican | 11:58 | |
*** alee has quit IRC | 12:21 | |
*** openstackgerrit has quit IRC | 12:31 | |
*** openstackgerrit has joined #openstack-barbican | 12:32 | |
*** Nirupama has quit IRC | 12:36 | |
*** zz_dimtruck is now known as dimtruck | 12:55 | |
*** dimtruck is now known as zz_dimtruck | 12:58 | |
*** alee has joined #openstack-barbican | 13:24 | |
*** kfarr has joined #openstack-barbican | 13:46 | |
*** rellerreller has joined #openstack-barbican | 13:46 | |
*** shohel has quit IRC | 13:48 | |
*** shohel has joined #openstack-barbican | 13:48 | |
*** spotz_zzz is now known as spotz | 14:05 | |
dave-mccowan | rellerreller ping | 14:07 |
*** pglass has joined #openstack-barbican | 14:09 | |
rellerreller | dave-mccowan pong | 14:11 |
dave-mccowan | rellerreller: were you asking about running only certain tests based on a tag recently? | 14:11 |
rellerreller | dave-mccowan I was | 14:12 |
rellerreller | dave-mccowan I actually found the source of the bug yesterday afternoon. I was quite excited. | 14:12 |
dave-mccowan | rellerreller did you find a solution? i found one, but we're not sure if it's the best one. https://review.openstack.org/216715 | 14:13 |
*** jlhinson has joined #openstack-barbican | 14:13 | |
rellerreller | dave-mccowan here's the issue with testing. We are using testtools for unit tests and nosetest for functional tests. | 14:14 |
rellerreller | dave-mccowan so for testtools the attributes that are applied to functions are lost if they are a parameterized test. The utils package that builds the functions has a bug that I need to fix. | 14:15 |
rellerreller | dave-mccowan I have not found the source of the bug for nosetest attributes, but I believe the issue to be the same. | 14:16 |
dave-mccowan | rellerreller cool. with my CR I got nosetest attributes to be recognized by the nosetest CLI. but, the nosetest CLI did not recognize the testtools attributes. i guess that could be as-designed, or it could be due to the bug you found. | 14:17 |
rellerreller | dave-mccowan I just looked at source for nose, and I think it is the same issue. | 14:17 |
rellerreller | dave-mccowan no, the two frameworks do not handle each others attributes. | 14:18 |
openstackgerrit | Merged openstack/barbican: Updated from global requirements https://review.openstack.org/217476 | 14:18 |
rellerreller | dave-mccowan what happens is that the attribute decorators assign attributes to the functions. | 14:19 |
rellerreller | dave-mccowan then the filtering capability is applied by looking at the attributes. | 14:19 |
dave-mccowan | rellerreller what about the "testr" CLI? do you know which attributes it can read, if any? | 14:20 |
rellerreller | dave-mccowan our utils parameterized_test_case class decorator looks for all functions that have our "build_data" attribute assigned to them. | 14:20 |
rellerreller | dave-mccowan but our utils for building the new function does not transfer other attributes to the new functions. Hence nosetest and testtools cannot find them. | 14:21 |
rellerreller | dave-mccowan I think testr sits above testtools and nosetests. I don't think it knows anything about attributes, but I could be wrong. I'm still learning why testr is used. | 14:22 |
dave-mccowan | rellerreller: nice find. i got lucky with my tags, since they were not parameterized_test_cases | 14:22 |
rellerreller | dave-mccowan like I said only parameterized tests with attributes have this problem. That was the tricky part for me. | 14:23 |
*** lisaclark1 has joined #openstack-barbican | 14:23 | |
dave-mccowan | rellerreller i think using each tool in different places has contributed to some mysterious gate failures in the past. | 14:23 |
dave-mccowan | rellerreller, so once you fix that bug, how do specify that you want to run a set of tests with a certain tag? | 14:25 |
rellerreller | dave-mccowan so for the functional tests that use nose I believe you should be able to pass a '-a' flag to the tox job. | 14:26 |
rellerreller | dave-mccowan I do not yet know how to do it for the unit tests. Unfortunately testtools does not have a flag like that. | 14:27 |
rellerreller | dave-mccowan It seems like testtools wants you to list all tests by doing `testtools.run --list barbican.tests` and then filter on the results. | 14:27 |
rellerreller | dave-mccowan The list operation returns a newline delimited list of test methods. Tests that have an attribute are named "barbican.tests.SomeClass.test_foo[some_attrib]". | 14:29 |
*** lisaclark1 has quit IRC | 14:29 | |
*** lisaclark1 has joined #openstack-barbican | 14:30 | |
dave-mccowan | reller Oh cool... so you can regex on [some_attrib]. I know that testr support regex. | 14:30 |
rellerreller | dave-mccowan then if you only want to run tests that have an attribute of some_attrib then delete all lines that do not have the regex "\[.*some_attrib.*\]". | 14:30 |
rellerreller | dave-mccowan That is good to know because I was disappointed by the implementation. | 14:30 |
dave-mccowan | rellerreller... this sounds like nose and testr can read each other's attributes. | 14:31 |
rellerreller | dave-mccowan I thought it was weird to have a developer do grep commands to some temporary file and then feed that back to testtools.run. | 14:31 |
rellerreller | dave_mccowan which part makes you think that? | 14:31 |
dave-mccowan | rellerreller here's an example of using regex to filter by class name. https://github.com/openstack/barbican/blob/master/functionaltests/run_tests.sh#L38 | 14:33 |
rellerreller | dave-mccowan thanks! That is helping me figure out the last pieces of the puzzle here. | 14:34 |
dave-mccowan | rellerreller currently in the barbican code testtools.testcase.attr() is used in functional tests. and "tox -e functional" uses nose. if the -a flag works for functional tests, then nose must read testtools attributes. | 14:35 |
rellerreller | dave-mccowan I wonder if we should convert the functional tests to testtools. By that I think that just means changing the attributes to testtool attributes and using testtools to run instead of nose. | 14:35 |
rellerreller | dave-mccowan the -a flag does not work. | 14:35 |
dave-mccowan | rellerreller where do you see nose attributes in functional tests? | 14:36 |
rellerreller | dave-mccowan Sorry, I forgot that I added a new test class with nose attributes for testing. | 14:36 |
rellerreller | dave-mccowan That was my first step in tracking down this problem. | 14:37 |
dave-mccowan | rellerreller ah... ok. me too in the CR i linked above. | 14:37 |
dave-mccowan | rellerreller... so Barbican should either go nose all the way or testtools all the way. | 14:38 |
rellerreller | dave-mccowan I noticed that tests were run with nose but had testtools attributes. I thought if I simply changed the attributes that things would work. | 14:38 |
dave-mccowan | rellerreller ... and it would have, except there was the bug you found in paramterized | 14:38 |
rellerreller | dave-mccowan I think so, but maybe there are some other requirements for why we use both. | 14:38 |
rellerreller | dave-mccowan I think you are right that if I can fix the bug and change attributes to nose attributes then things would work. | 14:39 |
dave-mccowan | rellerreller using both has been a pain for me. i have a set of functional tests that can't be run concurrently. i have to tell testr not to do that one way, and nosetests not to do that another way. | 14:40 |
*** insequent has quit IRC | 14:41 | |
rellerreller | dave-mccowan That does not sound pleasant. | 14:41 |
rellerreller | dave-mccowan I know that I would prefer to use one. That way I can learn one and stick with it. I do not like have to learn the different command line args when running the tests manually to try and debug. | 14:42 |
dave-mccowan | rellerereller it works fine until code review when i have to justify two different tags. :-) | 14:42 |
dave-mccowan | rellerreller +1 | 14:42 |
*** diazjf has joined #openstack-barbican | 14:42 | |
rellerreller | dave-mccowan that code review sounds fun :-) | 14:43 |
dave-mccowan | rellerreller thanks. this chat helped a bunch. | 14:44 |
rellerreller | dave-mccowan Thank you as well. | 14:44 |
*** kebray has joined #openstack-barbican | 14:44 | |
*** xaeth_afk is now known as xaeth | 14:44 | |
dave-mccowan | hockeynut, therve: good read above ^^^ any reason why we can't purge barbican of either testr or nose, and stick with one? | 14:45 |
rellerreller | dave-mccowan I need a little time to digest this, but we should bring this up at status meeting and try to fix this. | 14:45 |
dave-mccowan | rellerreller +1 i'll add it to the agenda. | 14:45 |
hockeynut | I'm actually taking today off but I will catch up on the discussion. | 14:45 |
rellerreller | dave-mccowan sounds good. I need to check on my other project now :( | 14:46 |
*** darrenmoffat has quit IRC | 14:57 | |
*** darrenmoffat has joined #openstack-barbican | 14:58 | |
*** lisaclark1 has quit IRC | 15:02 | |
*** edtubill has joined #openstack-barbican | 15:03 | |
*** ccneill has joined #openstack-barbican | 15:03 | |
*** kebray has quit IRC | 15:07 | |
*** silos has joined #openstack-barbican | 15:09 | |
*** shohel has quit IRC | 15:15 | |
openstackgerrit | Kaitlin Farr proposed openstack/castellan: Update Barbican wrapper https://review.openstack.org/208569 | 15:15 |
openstackgerrit | Fernando Diaz proposed openstack/barbican: Allow debug flag in Barbican tox and debugging documentation https://review.openstack.org/208623 | 15:31 |
*** kebray has joined #openstack-barbican | 15:34 | |
*** SheenaG has joined #openstack-barbican | 15:39 | |
*** lisaclark1 has joined #openstack-barbican | 15:45 | |
*** insequent has joined #openstack-barbican | 15:45 | |
*** lisaclark1 has quit IRC | 15:46 | |
*** lisaclark1 has joined #openstack-barbican | 15:47 | |
*** vivek-ebay has joined #openstack-barbican | 15:52 | |
openstackgerrit | Elvin Tubillara proposed openstack/barbican: Add request ID to worker-side logs https://review.openstack.org/217775 | 15:57 |
*** kebray has quit IRC | 15:58 | |
*** vivek-ebay has quit IRC | 16:00 | |
openstackgerrit | Amy Marrich proposed openstack/barbican: Removes uwsgi and pyenv from barbican.sh https://review.openstack.org/211671 | 16:02 |
*** chadlung has joined #openstack-barbican | 16:02 | |
*** vivek-ebay has joined #openstack-barbican | 16:10 | |
*** vivek-ebay has quit IRC | 16:11 | |
*** woodster_ has joined #openstack-barbican | 16:20 | |
*** jaosorior has quit IRC | 16:25 | |
*** arunkant_ has joined #openstack-barbican | 16:49 | |
*** pglass has quit IRC | 16:53 | |
*** pglass has joined #openstack-barbican | 16:54 | |
*** tkelsey has joined #openstack-barbican | 16:59 | |
dave-mccowan | quotas patch review of the day: https://review.openstack.org/#/c/216253/ | 16:59 |
*** pglbutt has joined #openstack-barbican | 17:02 | |
rm_work | anyone have a moment to look at https://review.openstack.org/#/c/217458/ and give it a +1? So people on infra know that someone on barbican is actually aware of this? :P | 17:02 |
rm_work | dave-mccowan: i don't quite understand what is happening in your review -- why project_id vs. external_project_id? | 17:05 |
rm_work | like in quota.py you actually call self.repo.create_or_update_by_project_id(project.id, external_project_id, ...) | 17:05 |
*** pglass has quit IRC | 17:06 | |
rm_work | is this function "a user setting a quota for a project that isn't theirs"? | 17:06 |
dave-mccowan | rm_work: project_id is the id created by the barbican database. external_project_id is the id created by keystone that is used in the API. | 17:06 |
rm_work | oooh | 17:06 |
rm_work | ok | 17:06 |
dave-mccowan | rm_work yea. all the setting/reading of project-quotas is done by a service-admin managing all the customers' projects, not his own project. | 17:07 |
openstackgerrit | Kaitlin Farr proposed openstack/castellan: Update Barbican functional tests https://review.openstack.org/216247 | 17:10 |
openstackgerrit | Merged openstack/barbican: Remove rpmbuild directory https://review.openstack.org/212147 | 17:22 |
*** lisaclark1 has quit IRC | 17:26 | |
*** lisaclark1 has joined #openstack-barbican | 17:35 | |
*** vivek-ebay has joined #openstack-barbican | 17:35 | |
openstackgerrit | Adam Harwell proposed openstack/barbican: Use the new Devstack external plugin method https://review.openstack.org/167885 | 17:35 |
*** tkelsey has quit IRC | 17:36 | |
rm_work | is this seriously not something we want to do in the client still? Otherwise, this needs to be implemented in every project that takes barbican refs from users, which seems to violate DRY https://bugs.launchpad.net/python-barbicanclient/+bug/1383935 | 17:39 |
openstack | Launchpad bug 1383935 in python-barbicanclient "Retrieving secrets from untrusted URIs can leak auth tokens" [High,Won't fix] | 17:39 |
*** lisaclark1 has quit IRC | 17:42 | |
*** ccneill has quit IRC | 17:44 | |
*** SheenaG has quit IRC | 17:45 | |
*** vivek-ebay has quit IRC | 17:51 | |
*** ccneill has joined #openstack-barbican | 17:56 | |
*** lisaclark1 has joined #openstack-barbican | 18:00 | |
*** silos has left #openstack-barbican | 18:15 | |
*** DTadrzak has quit IRC | 18:17 | |
diazjf | hey everyone can you help me get this merged https://review.openstack.org/#/c/196876/ :-D. redrobot, got some time tomorrow to google hangout about the behaviors in the funct tests? | 18:21 |
*** lisaclark1 has quit IRC | 18:33 | |
*** pglbutt has quit IRC | 18:52 | |
*** silos has joined #openstack-barbican | 19:05 | |
* kfarr slaps kfarr around a bit with a large fishbot | 19:10 | |
kfarr | ^^ Anyone else using webchat.freenode.net ? FYI, for anyone in a room, you can 'ignore', 'query', 'whois', and now 'slap' someone. And I just found out that it shows up in the whole room for everyone to see | 19:17 |
*** ccneill_ has joined #openstack-barbican | 19:19 | |
*** ccneill has quit IRC | 19:22 | |
diazjf | thanks for the review kfarr!! :) | 19:23 |
*** ccneill_ is now known as ccneill | 19:26 | |
kfarr | diazjf sure thing! | 19:29 |
dave-mccowan | kfarr haha. i was wondering what a fishbot was | 19:33 |
*** rellerreller has quit IRC | 19:41 | |
*** mmdurrant has quit IRC | 19:44 | |
*** jorgem has left #openstack-barbican | 19:45 | |
*** mmdurrant has joined #openstack-barbican | 19:46 | |
*** silos has left #openstack-barbican | 19:50 | |
*** diazjf has quit IRC | 19:57 | |
*** silos1 has joined #openstack-barbican | 19:57 | |
*** ccneill_ has joined #openstack-barbican | 19:57 | |
*** ccneill has quit IRC | 19:59 | |
*** silos1 has left #openstack-barbican | 20:00 | |
*** diazjf has joined #openstack-barbican | 20:01 | |
*** pglass has joined #openstack-barbican | 20:25 | |
*** diazjf has quit IRC | 20:30 | |
*** silos has joined #openstack-barbican | 20:32 | |
*** diazjf has joined #openstack-barbican | 20:36 | |
*** dave-mccowan has quit IRC | 20:37 | |
*** alee has quit IRC | 20:38 | |
*** silos has left #openstack-barbican | 20:38 | |
rm_work | any barbican cores around to +1 this and add some legitimacy? possibly not necessary, but maybe useful: https://review.openstack.org/#/c/217458/ | 20:41 |
*** kebray has joined #openstack-barbican | 20:49 | |
*** gyee has joined #openstack-barbican | 20:51 | |
*** kebray has quit IRC | 21:09 | |
*** kfarr has quit IRC | 21:11 | |
*** insequent has quit IRC | 21:15 | |
*** mixos has joined #openstack-barbican | 21:30 | |
*** mixos has quit IRC | 21:35 | |
*** chadlung has quit IRC | 21:36 | |
rm_work | soooo close to having this job in to test new gating T_T | 21:46 |
rm_work | where is everyone this week anyway? seems very very quiet | 21:47 |
diazjf | rm_work, tooooo quiet | 21:48 |
*** alee has joined #openstack-barbican | 21:48 | |
*** diazjf has left #openstack-barbican | 21:52 | |
*** pglass has quit IRC | 21:55 | |
*** silos has joined #openstack-barbican | 21:56 | |
*** mixos has joined #openstack-barbican | 21:59 | |
rm_work | maybe someone's hunting wabbits | 22:03 |
*** edtubill has left #openstack-barbican | 22:06 | |
*** chadlung has joined #openstack-barbican | 22:07 | |
openstackgerrit | Christopher Solis proposed openstack/python-barbicanclient: Adds epilog to parser https://review.openstack.org/217938 | 22:10 |
*** xaeth is now known as xaeth_afk | 22:11 | |
*** ccneill_ has quit IRC | 22:12 | |
*** chadlung has quit IRC | 22:12 | |
*** insequent has joined #openstack-barbican | 22:12 | |
*** silos has left #openstack-barbican | 22:13 | |
*** ccneill_ has joined #openstack-barbican | 22:16 | |
*** SheenaG has joined #openstack-barbican | 22:25 | |
*** mixos has quit IRC | 22:43 | |
*** spotz is now known as spotz_zzz | 22:59 | |
*** ccneill_ has quit IRC | 23:07 | |
*** nelsnels_ has joined #openstack-barbican | 23:10 | |
*** nelsnelson has quit IRC | 23:12 | |
*** jlhinson has quit IRC | 23:13 | |
*** chadlung has joined #openstack-barbican | 23:19 | |
*** arunkant_ has quit IRC | 23:20 | |
*** chadlung has quit IRC | 23:24 | |
*** insequent has quit IRC | 23:25 | |
*** mixos has joined #openstack-barbican | 23:44 | |
*** SheenaG has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!