*** tdink has quit IRC | 00:10 | |
*** tdink has joined #openstack-barbican | 00:10 | |
*** tdink_ has joined #openstack-barbican | 00:22 | |
*** tdink has quit IRC | 00:22 | |
*** tdink_ has quit IRC | 00:37 | |
*** tdink has joined #openstack-barbican | 00:37 | |
*** tdink has quit IRC | 01:09 | |
*** tdink has joined #openstack-barbican | 01:10 | |
*** liujiong has joined #openstack-barbican | 01:41 | |
*** tdink has quit IRC | 01:42 | |
*** tdink has joined #openstack-barbican | 01:43 | |
*** tdink has quit IRC | 02:15 | |
*** tdink has joined #openstack-barbican | 02:21 | |
*** tdink has quit IRC | 02:28 | |
*** tdink has joined #openstack-barbican | 02:29 | |
*** tdink has quit IRC | 03:08 | |
*** tdink has joined #openstack-barbican | 03:09 | |
*** tdink_ has joined #openstack-barbican | 03:58 | |
*** tdink has quit IRC | 03:58 | |
*** tdink_ has quit IRC | 04:12 | |
*** tdink has joined #openstack-barbican | 04:12 | |
*** tdink_ has joined #openstack-barbican | 04:36 | |
*** tdink has quit IRC | 04:36 | |
*** tdink_ has quit IRC | 04:43 | |
*** tdink has joined #openstack-barbican | 04:44 | |
*** tdink_ has joined #openstack-barbican | 06:11 | |
*** tdink has quit IRC | 06:11 | |
*** openstackgerrit_ has joined #openstack-barbican | 06:23 | |
*** jaosorior has joined #openstack-barbican | 06:23 | |
*** openstackgerrit_ has quit IRC | 06:25 | |
*** openstackgerrit_ has joined #openstack-barbican | 06:26 | |
*** openstackgerrit_ has quit IRC | 06:27 | |
*** tdink_ has quit IRC | 06:28 | |
*** tdink has joined #openstack-barbican | 06:28 | |
*** openstackgerrit_ has joined #openstack-barbican | 06:34 | |
*** openstackgerrit_ has quit IRC | 06:35 | |
*** tdink has quit IRC | 06:42 | |
*** tdink has joined #openstack-barbican | 06:43 | |
*** openstackgerrit_ has joined #openstack-barbican | 06:59 | |
*** openstackgerrit_ has quit IRC | 07:00 | |
*** andreas_s has joined #openstack-barbican | 07:39 | |
*** jaosorior has quit IRC | 07:40 | |
*** jaosorior has joined #openstack-barbican | 08:00 | |
*** liujiong has quit IRC | 08:06 | |
*** liujiong has joined #openstack-barbican | 08:07 | |
*** shohel has joined #openstack-barbican | 08:13 | |
*** jsheeren has joined #openstack-barbican | 08:29 | |
*** pcaruana has joined #openstack-barbican | 08:30 | |
*** pcaruana has quit IRC | 08:37 | |
*** pcaruana has joined #openstack-barbican | 08:38 | |
*** jsheeren has quit IRC | 08:39 | |
*** jsheeren has joined #openstack-barbican | 08:40 | |
*** sapcc-bot2 has quit IRC | 09:25 | |
*** sapcc-bot has joined #openstack-barbican | 09:25 | |
*** mkoderer_ has joined #openstack-barbican | 09:25 | |
*** dgonzalez_ has joined #openstack-barbican | 09:25 | |
*** tommy_ has joined #openstack-barbican | 09:25 | |
*** databus23_ has joined #openstack-barbican | 09:25 | |
*** tpatzig_ has joined #openstack-barbican | 09:25 | |
*** carthaca_ has joined #openstack-barbican | 09:25 | |
*** david_1 has joined #openstack-barbican | 09:25 | |
*** tommy_ is now known as Guest42753 | 09:25 | |
*** david_1 has quit IRC | 09:27 | |
*** tpatzig_ has quit IRC | 09:27 | |
*** carthaca_ has quit IRC | 09:27 | |
*** dgonzalez_ has quit IRC | 09:27 | |
*** mkoderer_ has quit IRC | 09:27 | |
*** Guest42753 has quit IRC | 09:27 | |
*** databus23_ has quit IRC | 09:27 | |
*** strigazi_AFK is now known as strigazi | 09:49 | |
*** jamespag` is now known as jamespage | 09:53 | |
*** tdink has quit IRC | 09:53 | |
*** tdink has joined #openstack-barbican | 09:54 | |
*** tdink has quit IRC | 10:01 | |
*** tdink has joined #openstack-barbican | 10:05 | |
*** tdink has quit IRC | 10:10 | |
*** tdink has joined #openstack-barbican | 10:11 | |
*** tdink has quit IRC | 10:16 | |
*** tdink has joined #openstack-barbican | 10:17 | |
*** liujiong has quit IRC | 10:18 | |
*** tdink has quit IRC | 10:21 | |
*** tdink has joined #openstack-barbican | 10:23 | |
*** tdink has quit IRC | 10:28 | |
*** tdink has joined #openstack-barbican | 10:30 | |
*** tdink has quit IRC | 10:36 | |
*** tdink has joined #openstack-barbican | 10:37 | |
*** tdink has quit IRC | 10:43 | |
*** tdink has joined #openstack-barbican | 10:45 | |
*** tdink has quit IRC | 10:50 | |
openstackgerrit | Marc Koderer proposed openstack/barbican-tempest-plugin: Register client and add first test https://review.openstack.org/409725 | 10:51 |
---|---|---|
*** tdink has joined #openstack-barbican | 10:52 | |
*** mkoderer has joined #openstack-barbican | 10:52 | |
mkoderer | dmellado: ping | 10:53 |
mkoderer | dmellado: https://review.openstack.org/#/c/409725/1 | 10:53 |
dmellado | mkoderer: pong | 10:53 |
dmellado | let me check | 10:53 |
mkoderer | dmellado: just the first step with a client | 10:53 |
mkoderer | but already create & delete look to me as a broken API | 10:54 |
mkoderer | the secret create call returns a full URL instead of a UUID | 10:54 |
dmellado | mkoderer: huh | 10:54 |
dmellado | well, at least we're discovering this up with the tests ;) | 10:54 |
mkoderer | but the delete wants to have a uuid | 10:55 |
mkoderer | =broken ;) | 10:55 |
mkoderer | dmellado: we need to activate the tempest test for barbican at least for the plugin repo | 10:55 |
dmellado | mkoderer: I'll take a look from the infra side | 10:56 |
mkoderer | dmellado: we need to merge this before: https://review.openstack.org/#/c/406126/ | 10:56 |
dmellado | oh, thought this was already in | 10:56 |
dmellado | let me speed it up ;) | 10:56 |
*** tdink has quit IRC | 10:57 | |
mkoderer | dmellado: what do we do with APIs that are conceptional broken but we would break the API contract if we change them? ;) | 10:57 |
dmellado | mkoderer: hmmmm well, I guess that'd come from the barbican side itself | 10:58 |
dmellado | we'll have to agree on that before writing any proper test | 10:58 |
dmellado | or they will just break like the create and delete... | 10:58 |
* dmellado checking barbican api | 10:58 | |
mkoderer | dmellado: http://docs.openstack.org/developer/barbican/api/reference/secrets.html#post-v1-secrets | 10:59 |
mkoderer | dmellado: http://docs.openstack.org/developer/barbican/api/reference/secrets.html#delete-v1-secrets-uuid | 10:59 |
mkoderer | a POST response looks like: {"secret_ref": "http://192.168.33.25:9311/v1/secrets/271d239c-c7ba-43e4-b032-87ec331bb909"} | 11:00 |
dmellado | mkoderer: I see, so you're getting this | 11:00 |
dmellado | "secret_ref": "https://{barbican_host}/v1/secrets/{secret_uuid}" | 11:00 |
mkoderer | dmellado: yeah | 11:00 |
mkoderer | and the delete just needs the UUID | 11:00 |
mkoderer | so I need to parse the response and delete the URL.. but for me this makes no sense at all | 11:01 |
dmellado | mkoderer: yeah, fixing it it's just parsing that but I'd make it consistent | 11:01 |
dmellado | either both of them needs full url | 11:01 |
dmellado | or both of them are fine with uuid | 11:01 |
*** tdink has joined #openstack-barbican | 11:02 | |
mkoderer | dmellado: I don't think that full urls are in any case a good idea | 11:02 |
*** shohel has quit IRC | 11:02 | |
dmellado | I don't think so either | 11:02 |
mkoderer | keystone has the information about the endpoint and not barbican | 11:02 |
dmellado | +1 | 11:02 |
dmellado | but then we'll have to modify barbican api | 11:04 |
mkoderer | dmellado: that's why I am asking.. would break the API compatibilty | 11:04 |
dmellado | hmmm how about supporting both versions | 11:06 |
mkoderer | dmellado: ah we could add a UUID field in the response | 11:06 |
*** tdink has quit IRC | 11:06 | |
mkoderer | that would be a way | 11:06 |
dmellado | we could add the UUID in the response and then use it for the delte | 11:06 |
dmellado | delete | 11:06 |
dmellado | yes | 11:06 |
dmellado | and that shouldn't break backwards compatibility | 11:07 |
mkoderer | dmellado: ok let's check | 11:07 |
dmellado | mkoderer: yeah, and let's see what the barbican devs think about it later ;) | 11:07 |
dmellado | mkoderer: in any case we should meet at the PTG | 11:08 |
dmellado | I'm still not ack'ed but I'll most probably go | 11:08 |
mkoderer | dmellado: sure we should.. I am also not sure if I can go there | 11:09 |
* dmellado sighs and blames all those meetings' bureucracy | 11:09 | |
*** tdink has joined #openstack-barbican | 11:10 | |
openstackgerrit | Marc Koderer proposed openstack/barbican: Add uuid for secrete create API response https://review.openstack.org/409732 | 11:13 |
mkoderer | dmellado: so we need this: https://review.openstack.org/#/c/409732/ ;) | 11:14 |
mkoderer | works fine now | 11:14 |
dmellado | mkoderer: cool! | 11:14 |
dmellado | once that this is merged I can go backwards and enable the tempest tests for the barbican-tempest-test repo | 11:15 |
dmellado | I'll handle it ;) | 11:15 |
*** tdink has quit IRC | 11:16 | |
*** tdink has joined #openstack-barbican | 11:17 | |
*** shohel has joined #openstack-barbican | 11:20 | |
*** tdink has quit IRC | 11:22 | |
*** tdink has joined #openstack-barbican | 11:23 | |
*** tdink has quit IRC | 11:29 | |
*** tdink has joined #openstack-barbican | 11:31 | |
*** tdink has quit IRC | 11:34 | |
*** tdink has joined #openstack-barbican | 11:38 | |
*** tdink has quit IRC | 11:44 | |
*** tdink has joined #openstack-barbican | 11:45 | |
*** tdink has quit IRC | 11:50 | |
*** tdink has joined #openstack-barbican | 11:52 | |
*** sapcc-bot has quit IRC | 11:52 | |
*** tdink has quit IRC | 11:56 | |
*** tdink has joined #openstack-barbican | 11:58 | |
*** shohel has quit IRC | 12:00 | |
*** dave-mccowan has joined #openstack-barbican | 12:03 | |
*** tdink has quit IRC | 12:04 | |
*** tdink has joined #openstack-barbican | 12:07 | |
*** tdink has quit IRC | 12:12 | |
*** tdink has joined #openstack-barbican | 12:15 | |
*** shohel has joined #openstack-barbican | 12:19 | |
openstackgerrit | Marc Koderer proposed openstack/barbican: Add id for secrete create API response https://review.openstack.org/409732 | 12:19 |
openstackgerrit | Marc Koderer proposed openstack/barbican: Add id for secret create API response https://review.openstack.org/409732 | 12:21 |
*** tdink has quit IRC | 12:23 | |
*** tdink has joined #openstack-barbican | 12:26 | |
*** tdink has quit IRC | 12:35 | |
*** tdink has joined #openstack-barbican | 12:39 | |
*** tdink has quit IRC | 12:49 | |
*** tdink has joined #openstack-barbican | 12:51 | |
*** liujiong has joined #openstack-barbican | 12:52 | |
mkoderer | dave-mccowan: hi | 12:55 |
dave-mccowan | mkoderer hi marc | 12:55 |
mkoderer | dave-mccowan: I had a discussion with dmellado before... we are confused why create secrete returns a "url" instead of an id | 12:55 |
dave-mccowan | mkoderer tradition | 12:56 |
mkoderer | dave-mccowan: ok this would fix the "tradtion" https://review.openstack.org/#/c/409732/ :) | 12:56 |
mkoderer | dave-mccowan: the thing is that delete need a uuid and not an url. and the remote client in tempest does not accept full url (only partials) | 12:57 |
dave-mccowan | mkoderer we have a blueprint open to start returning the id, just like you propose. | 12:58 |
mkoderer | dave-mccowan: ok that's nice | 12:58 |
mkoderer | didn't know that | 12:58 |
*** tdink has quit IRC | 12:58 | |
mkoderer | dave-mccowan: are there other places too? | 12:58 |
dave-mccowan | mkoderer so we do recognize the need. to be consistent, there are probably other requests too. at the very least containers. | 12:59 |
mkoderer | dave-mccowan: ok I see.. | 13:00 |
mkoderer | dave-mccowan: are there already someone working on that BP? | 13:00 |
mkoderer | I don't want to parse the result of the client just to get uuid out of it | 13:01 |
dave-mccowan | mkoderer i thought redrobot was working on a spec for it, but i don't see it in the review queue. | 13:03 |
*** tdink has joined #openstack-barbican | 13:03 | |
mkoderer | dave-mccowan: ok, I can add these id's everywhere I find it.. shouldn't break the API since it's just an additional field | 13:05 |
dave-mccowan | mkoderer I think that would be OK. it's in the direction that we agreed on at summit. I'll add it to the agenda for the IRC meeting tonight to make sure no one has an objection. | 13:06 |
*** tdink has quit IRC | 13:12 | |
jaosorior | dave-mccowan: seems like we should start using micro-versions to indicate users that the API has additions | 13:15 |
*** tdink has joined #openstack-barbican | 13:15 | |
dave-mccowan | jaosorior mkoderer +1 that would be very user-friendly | 13:16 |
jaosorior | dave-mccowan: do you know if the API change in barbicanclient was fixed? The one of pass_phrase being replaced by passphrase? | 13:17 |
dave-mccowan | jaosorior i'm not sure. i still see pass_phrase in barbicanclient/orders.py | 13:22 |
jaosorior | dave-mccowan: this is the issue https://github.com/openstack/python-barbicanclient/blob/master/barbicanclient/orders.py#L301 | 13:23 |
jaosorior | it used to be pass_phrase on that object creation, so some projects built their API based on that | 13:24 |
jaosorior | subsequently it was replaced by passphrase (without the underscore) and that broke them | 13:24 |
*** tdink has quit IRC | 13:26 | |
dave-mccowan | jaosorior i remember talking about re-adding and keeping both spellings. but, no one has done the commit for that yet? | 13:27 |
*** tdink has joined #openstack-barbican | 13:29 | |
mkoderer | dave-mccowan: jaosorior: btw, I would need a review on that: https://review.openstack.org/#/c/406126/ | 13:32 |
mkoderer | we want to create a gate check with tempest enabled | 13:32 |
jaosorior | dave-mccowan: remember what was the bug's URL? I'll submit a patch but I don't find it | 13:32 |
liujiong | jaosorior, fyi, https://bugs.launchpad.net/barbican/+bug/1635213 | 13:33 |
openstack | Launchpad bug 1635213 in Barbican "Using pass_phrase for Barbican order resource fails" [Undecided,In progress] | 13:33 |
dave-mccowan | jaosorior https://bugs.launchpad.net/barbican/+bug/1635213 | 13:33 |
dave-mccowan | thanks liujiong! | 13:34 |
liujiong | my pleasure | 13:34 |
jaosorior | thanks | 13:35 |
*** tdink has quit IRC | 13:36 | |
*** agrebennikov_ has joined #openstack-barbican | 13:37 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Accept 'pass_phrase' for AsymmetricOrder constructor https://review.openstack.org/409795 | 13:39 |
*** tdink has joined #openstack-barbican | 13:40 | |
*** jsheeren has quit IRC | 13:41 | |
*** briancurtin has quit IRC | 13:42 | |
*** briancurtin has joined #openstack-barbican | 13:43 | |
*** tdink has quit IRC | 13:49 | |
*** tdink has joined #openstack-barbican | 13:53 | |
dmellado | mkoderer: dave-mccowan nice about the uuid | 13:57 |
dmellado | do you have the blueprint url around? | 13:57 |
*** tdink has quit IRC | 14:02 | |
*** shohel has quit IRC | 14:02 | |
dave-mccowan | dmellado we talked about it at the last summit (https://etherpad.openstack.org/p/barbican-ocata-design-summit0, but I don't see a bug or bp open it. | 14:02 |
dave-mccowan | https://etherpad.openstack.org/p/barbican-ocata-design-summit | 14:02 |
*** tdink has joined #openstack-barbican | 14:06 | |
*** arunkant has quit IRC | 14:09 | |
*** tdink has quit IRC | 14:14 | |
*** tdink has joined #openstack-barbican | 14:17 | |
*** tdink has quit IRC | 14:27 | |
*** tdink has joined #openstack-barbican | 14:29 | |
*** tdink has quit IRC | 14:36 | |
*** jamielennox is now known as jamielennox|away | 14:38 | |
openstackgerrit | dane-fichter proposed openstack/barbican-tempest-plugin: Add key manager client to barbican_tempest_plugin https://review.openstack.org/408278 | 14:38 |
*** tdink has joined #openstack-barbican | 14:40 | |
*** jamielennox|away is now known as jamielennox | 14:45 | |
*** nkinder has joined #openstack-barbican | 14:47 | |
*** tdink has quit IRC | 14:48 | |
*** arunkant has joined #openstack-barbican | 14:48 | |
mkoderer | jaosorior:: dave-mccowan: should we introduce microversions before landining the "uuid" fixes? I have a limited quota for working on all that - microversion + uuid + tempest tests is too much | 14:48 |
*** tdink has joined #openstack-barbican | 14:51 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient: Accept 'pass_phrase' for AsymmetricOrder constructor https://review.openstack.org/409795 | 14:52 |
*** arunkant has quit IRC | 14:53 | |
*** diazjf has joined #openstack-barbican | 14:54 | |
*** tdink has quit IRC | 15:01 | |
*** tdink has joined #openstack-barbican | 15:04 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting now to address acute performance issues, and will be back online momentarily. | 15:05 | |
dave-mccowan | mkoderer don't slow down your other work for microversion. keep going on what you're planning and we can recruit others to do the rest. | 15:09 |
*** tdink has quit IRC | 15:11 | |
liujiong | I believe that needs refactor on barbicanclient adopting microversion. | 15:11 |
*** spotz_zzz is now known as spotz | 15:31 | |
*** dave-mccowan has quit IRC | 15:31 | |
*** diazjf has quit IRC | 15:38 | |
*** tdink has joined #openstack-barbican | 15:41 | |
*** dave-mccowan has joined #openstack-barbican | 15:47 | |
dmellado | mkoderer: I could try to leverage some of that, even if I'm overloaded myself | 15:50 |
mkoderer | dmellado: I am currently trying to fix all the "url vs id" stuff | 15:50 |
mkoderer | the thing is without microversions we will have issues with older versions of barbican | 15:51 |
*** diazjf has joined #openstack-barbican | 15:51 | |
mkoderer | dmellado: I guess we would need microversions to really make us of it | 15:51 |
dmellado | yeah, make sense | 15:52 |
dmellado | so as always, whenever we start 'scratching' more work comes out | 15:52 |
dmellado | xD | 15:52 |
*** jmckind has joined #openstack-barbican | 15:54 | |
mkoderer | dmellado: I will put some magic in the api base test class to make it working for both cases | 15:54 |
dmellado | mkoderer: cool, keeping that backwards-compatible will require that | 15:55 |
*** jaosorior has quit IRC | 16:10 | |
*** jaosorior has joined #openstack-barbican | 16:10 | |
*** zz_dimtruck has joined #openstack-barbican | 16:16 | |
*** zz_dimtruck is now known as dimtruck | 16:17 | |
*** chris_hultin|AWA is now known as chris_hultin | 16:29 | |
*** andreas_s has quit IRC | 16:34 | |
*** liujiong has quit IRC | 16:54 | |
*** tdink has quit IRC | 16:59 | |
*** pcaruana has quit IRC | 16:59 | |
*** tdink has joined #openstack-barbican | 16:59 | |
*** diazjf has quit IRC | 17:17 | |
*** arunkant has joined #openstack-barbican | 17:44 | |
*** openstack has joined #openstack-barbican | 17:58 | |
*** jaosorior has quit IRC | 18:03 | |
openstackgerrit | Kaitlin Farr proposed openstack/python-barbicanclient: Add client list filter functionality https://review.openstack.org/400370 | 18:09 |
openstackgerrit | Kaitlin Farr proposed openstack/castellan: Remove outdated comment https://review.openstack.org/409887 | 19:03 |
*** jamielennox is now known as jamielennox|away | 19:46 | |
*** jamielennox|away is now known as jamielennox | 19:53 | |
*** kfarr has joined #openstack-barbican | 19:55 | |
redrobot | weekly meeting starting now in #openstack-meeting-alt | 20:00 |
*** woodster_ has joined #openstack-barbican | 20:01 | |
*** dimtruck is now known as zz_dimtruck | 20:03 | |
*** zz_dimtruck is now known as dimtruck | 20:32 | |
*** tdink has quit IRC | 20:32 | |
*** chlong has joined #openstack-barbican | 21:01 | |
*** tdink has joined #openstack-barbican | 21:24 | |
*** tdink has quit IRC | 21:45 | |
*** tdink has joined #openstack-barbican | 21:49 | |
*** tdink has quit IRC | 22:14 | |
*** tdink has joined #openstack-barbican | 22:18 | |
*** tdink has quit IRC | 22:35 | |
*** jmckind_ has joined #openstack-barbican | 22:39 | |
*** tdink has joined #openstack-barbican | 22:40 | |
*** jmckind has quit IRC | 22:40 | |
*** chris_hultin is now known as chris_hultin|AWA | 22:44 | |
*** jmckind has joined #openstack-barbican | 22:45 | |
*** jmckind_ has quit IRC | 22:47 | |
*** tdink has quit IRC | 22:49 | |
*** spotz is now known as spotz_zzz | 22:51 | |
*** tdink has joined #openstack-barbican | 22:56 | |
*** jmckind has quit IRC | 22:59 | |
*** tdink has quit IRC | 23:36 | |
*** mkoderer has quit IRC | 23:36 | |
*** tdink has joined #openstack-barbican | 23:38 | |
*** dave-mccowan has quit IRC | 23:53 | |
openstackgerrit | Kaitlin Farr proposed openstack/python-barbicanclient: Skip order with 'None' payload content type https://review.openstack.org/409978 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!