| *** randomhack has joined #openstack-barbican | 00:22 | |
| *** randomhack has quit IRC | 00:31 | |
| *** randomhack has joined #openstack-barbican | 00:32 | |
| *** randomhack has quit IRC | 00:37 | |
| *** liujiong has joined #openstack-barbican | 01:02 | |
| *** jamielennox has quit IRC | 01:08 | |
| *** jamielennox has joined #openstack-barbican | 01:15 | |
| *** jamielennox has quit IRC | 02:17 | |
| *** jamielennox has joined #openstack-barbican | 02:24 | |
| *** liujiong has quit IRC | 02:39 | |
| *** liujiong has joined #openstack-barbican | 02:43 | |
| *** randomhack has joined #openstack-barbican | 02:54 | |
| rm_work | heyas | 02:54 |
|---|---|---|
| rm_work | so | 02:54 |
| rm_work | https://github.com/openstack/python-barbicanclient/commit/4a3c7cd23a22cb9f8fd376e3de3a6f4f6c69da0d | 02:54 |
| rm_work | out of curiosity | 02:54 |
| rm_work | wouldn't one consider that a pretty breaking change to have no deprecation cycle? :P | 02:54 |
| * rm_work says, as the octavia gates suddenly explode on an upper-constraints bump | 02:55 | |
| *** randomhack has quit IRC | 02:58 | |
| liujiong | rm_work: How does octavia use barbicanclient? We moved APIs to v1/ but kept client initialization compatiable | 03:00 |
| rm_work | we import secrets and containers to use them | 03:01 |
| johnsom | It broke heat too | 03:01 |
| rm_work | i mean, to actually USE barbican you need to use secret and container objects... | 03:01 |
| rm_work | there's not really a way around that | 03:01 |
| rm_work | did you merge a fix for castellan at the same time? | 03:02 |
| rm_work | or did that break too? lol | 03:02 |
| liujiong | rm_work: OK, no related change is pushed for castellan, I havn't heard castellan breaks | 03:03 |
| rm_work | i don't know how it wouldn't | 03:03 |
| rm_work | one sec | 03:03 |
| rm_work | https://github.com/openstack/castellan/blob/master/castellan/key_manager/barbican_key_manager.py#L262 | 03:03 |
| rm_work | that right there is broken now | 03:04 |
| johnsom | neutron-lbaas is down too | 03:04 |
| rm_work | as is basically everything else, that's just the first example | 03:04 |
| rm_work | hmmm or maybe you get around it | 03:04 |
| rm_work | by doing the imports through the client? | 03:04 |
| * rm_work looks deeper | 03:04 | |
| liujiong | rm_work: yes | 03:05 |
| rm_work | interesting | 03:06 |
| liujiong | rm_work: things break if they directly import secrets or containers or else | 03:06 |
| rm_work | AFAIK that was the way to use it | 03:06 |
| johnsom | Right, same for the other projects that just broke | 03:07 |
| liujiong | rm_work: I'm not sure folks have to directly import secrets/containers. If so, that shouldn't be the right way to use barbicanclient | 03:07 |
| rm_work | I WROTE most of the barbicanclient | 03:07 |
| rm_work | rofl | 03:07 |
| liujiong | rm_work: Ohh | 03:08 |
| johnsom | +1 | 03:08 |
| rm_work | heh | 03:08 |
| rm_work | https://github.com/openstack/python-barbicanclient/blame/master/barbicanclient/v1/containers.py | 03:08 |
| rm_work | rm-you <-- | 03:09 |
| liujiong | rm_work: OK | 03:09 |
| rm_work | so this was somewhat surprising :P | 03:09 |
| rm_work | i'm trying to figure out how this works | 03:10 |
| rm_work | so | 03:11 |
| rm_work | https://github.com/openstack/castellan/blob/master/castellan/key_manager/barbican_key_manager.py#L262 | 03:11 |
| rm_work | container = barbican_client.containers.get(order.container_ref) | 03:11 |
| rm_work | barbican_client comes from: | 03:11 |
| rm_work | from barbicanclient import client as barbican_client | 03:11 |
| rm_work | but... | 03:11 |
| rm_work | https://github.com/openstack/python-barbicanclient/blob/master/barbicanclient/client.py | 03:11 |
| rm_work | there's no "containers" or "secrets" in there? AFAICT | 03:11 |
| rm_work | so that shouldn't actually work | 03:12 |
| rm_work | unless i'm missing something, Castellan is broken *now* | 03:12 |
| rm_work | in fact, they were removed in the same commit | 03:13 |
| rm_work | https://github.com/openstack/python-barbicanclient/commit/97906c853ee7e431b2684c37a0724d42e1c6a245#diff-402341e87b14ebf7b20bc2cde5f216e9 | 03:13 |
| rm_work | so not only did it move them to a different place if you were importing them directly, it removed the imports from the base client if you were importing them via that | 03:13 |
| rm_work | so yes, Castellan is also broken | 03:14 |
| rm_work | everything that used barbican in any capacity was broken by that patch | 03:14 |
| rm_work | IMO that needs to revert + re-release ASAP | 03:14 |
| rm_work | or we can fix it temporarily by changing upper-constraints | 03:14 |
| rm_work | proposing the upper-constraints revert | 03:17 |
| liujiong | rm_work: OK, we have to talk to dave about that | 03:18 |
| rm_work | nah that's a dims thing | 03:18 |
| rm_work | i'm taking care of it | 03:18 |
| liujiong | rm_work: thx | 03:19 |
| *** daidv has joined #openstack-barbican | 03:42 | |
| *** totadkiran has joined #openstack-barbican | 03:59 | |
| *** daidv has quit IRC | 04:19 | |
| *** totadkiran has quit IRC | 05:14 | |
| *** andreas_s has joined #openstack-barbican | 06:53 | |
| *** randomhack has joined #openstack-barbican | 06:54 | |
| *** randomhack has quit IRC | 06:58 | |
| openstackgerrit | Jeremy Liu proposed openstack/python-barbicanclient master: Workaround for importing objects from old path https://review.openstack.org/487721 | 07:13 |
| *** namnh has joined #openstack-barbican | 07:27 | |
| *** jaosorior has joined #openstack-barbican | 07:52 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-barbicanclient master: Revert "Refactor barbicanclient" https://review.openstack.org/487735 | 07:56 |
| *** salmankhan has joined #openstack-barbican | 09:10 | |
| *** daidv has joined #openstack-barbican | 09:49 | |
| openstackgerrit | Rajat Sharma proposed openstack/python-barbicanclient master: Add 'rm -f .testrepository/times.dbm' command in testenv https://review.openstack.org/487797 | 09:55 |
| *** pbourke_ has joined #openstack-barbican | 10:17 | |
| *** raildo has joined #openstack-barbican | 11:06 | |
| *** liujiong has quit IRC | 11:13 | |
| *** namnh has quit IRC | 11:20 | |
| *** catintheroof has joined #openstack-barbican | 12:11 | |
| *** dgonzalez_ has joined #openstack-barbican | 12:40 | |
| *** seife_ has joined #openstack-barbican | 12:40 | |
| *** seife_ has quit IRC | 12:41 | |
| *** dgonzalez_ has quit IRC | 12:41 | |
| *** rmascena has joined #openstack-barbican | 13:12 | |
| *** raildo has quit IRC | 13:15 | |
| *** rmascena is now known as raildo | 13:34 | |
| *** liujiong has joined #openstack-barbican | 13:36 | |
| *** pbourke has quit IRC | 13:37 | |
| *** pbourke has joined #openstack-barbican | 13:39 | |
| *** mathiasb has quit IRC | 13:52 | |
| *** diazjf has joined #openstack-barbican | 14:44 | |
| *** diazjf has quit IRC | 14:46 | |
| *** andreas_s has quit IRC | 15:29 | |
| *** liujiong has quit IRC | 15:49 | |
| *** pbourke_ has quit IRC | 16:40 | |
| *** hyakuhei has quit IRC | 17:02 | |
| *** hyakuhei has joined #openstack-barbican | 17:02 | |
| *** hyakuhei has joined #openstack-barbican | 17:02 | |
| *** salmankhan has quit IRC | 18:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/barbican master: Updated from global requirements https://review.openstack.org/487457 | 19:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/castellan master: Updated from global requirements https://review.openstack.org/487459 | 19:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/castellan master: Updated from global requirements https://review.openstack.org/487459 | 19:43 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-barbicanclient master: Updated from global requirements https://review.openstack.org/488109 | 19:56 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-barbicanclient master: Updated from global requirements https://review.openstack.org/488109 | 20:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/castellan master: Updated from global requirements https://review.openstack.org/487459 | 20:19 |
| *** salmankhan has joined #openstack-barbican | 20:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-barbicanclient master: Updated from global requirements https://review.openstack.org/488109 | 20:31 |
| *** salmankhan has quit IRC | 20:35 | |
| *** catintheroof has quit IRC | 22:27 | |
| *** openstack has joined #openstack-barbican | 22:43 | |
| *** pbourke has quit IRC | 22:44 | |
| *** pbourke has joined #openstack-barbican | 22:46 | |
| *** junousi has joined #openstack-barbican | 22:47 | |
| *** catintheroof has joined #openstack-barbican | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!