| *** noslzzp has joined #openstack-barbican | 00:19 | |
| *** liujiong has joined #openstack-barbican | 01:08 | |
| *** randomhack has joined #openstack-barbican | 01:17 | |
| *** randomhack has quit IRC | 01:21 | |
| *** rmascena has quit IRC | 01:58 | |
| *** https_GK1wmSU has joined #openstack-barbican | 02:10 | |
| *** https_GK1wmSU has left #openstack-barbican | 02:11 | |
| dave-mcc_ | johnsom rm_work can you confirm that barbican client 4.5.1 fixes the issues you had? i'll update global requirements for pike once we know that all is well again. | 02:29 |
|---|---|---|
| *** liujiong has quit IRC | 02:50 | |
| *** liujiong has joined #openstack-barbican | 02:51 | |
| *** raddaoui has quit IRC | 02:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-barbicanclient master: Updated from global requirements https://review.openstack.org/488109 | 03:03 |
| *** dave-mcc_ has quit IRC | 03:48 | |
| *** noslzzp has quit IRC | 04:02 | |
| rm_work | tonyb: ^^ we will test it with octavia at least, and tell you it is OK for us... the other project that had obvious problems was Heat, IIRC | 05:11 |
| rm_work | but i think the usage pattern is the same | 05:12 |
| tonyb | rm_work: Thanks. | 05:12 |
| tonyb | rm_work: ISTR that the glance/nova etc testign we did didn't show it up so I'm trying to get ahead of the game | 05:13 |
| tonyb | rm_work: I assume it's just a matter of a no-op change in octavia / heat that Depends-On the u-c bump right? | 05:13 |
| rm_work | we could do that, yes | 05:14 |
| rm_work | I was literally just going to test it locally and give you a thumbs up, but your idea is better :P | 05:14 |
| rm_work | i figured since I raised the issue originally, i would have some sort of extra sign-off credit maybe ^_^ | 05:15 |
| rm_work | umm... though interestingly, 4.5.1 doesn't seem to have solved it locally... not sure why actually | 05:16 |
| *** randomhack has joined #openstack-barbican | 05:17 | |
| tonyb | rm_work: Oh phooey :( | 05:18 |
| *** randomhack has quit IRC | 05:22 | |
| rm_work | yeah this sucks | 05:36 |
| rm_work | hmm. | 05:36 |
| rm_work | yeah crap, we were using BOTH import methods I mentioned | 05:41 |
| rm_work | so in the fix patch: https://review.openstack.org/#/c/487721/ | 05:42 |
| rm_work | I commented twice that this only fixed half of the problem | 05:42 |
| rm_work | and then somehow let myself be convinced that because the specific example I used wasn't actually doing it that way, that it was somehow still OK to not fix that too | 05:42 |
| rm_work | but WE are using it that was as well <_< | 05:43 |
| rm_work | so, I was correct | 05:43 |
| rm_work | "Note that they used to be available from within the client as well" | 05:43 |
| rm_work | """ | 05:43 |
| rm_work | secret = barbican_client.secrets.create(...) | 05:43 |
| rm_work | That's not using the client object... That's using the imported module: | 05:43 |
| rm_work | from barbicanclient import client as barbican_client | 05:43 |
| rm_work | THAT client doesn't have the imports anymore for the objects... | 05:43 |
| rm_work | """ | 05:43 |
| tonyb | rm_work: time for 4.5.2? | 05:51 |
| rm_work | yep | 05:54 |
| rm_work | should have stuck to my guns >_> | 05:54 |
| rm_work | because even if castellan didn't use it that way, SOMEONE could have | 05:56 |
| rm_work | (we did) | 05:56 |
| *** jaosorior has quit IRC | 06:05 | |
| tonyb | rm_work: :( | 06:06 |
| *** jaosorior has joined #openstack-barbican | 06:24 | |
| liujiong | tonyb rm_work: sad to hear that | 06:24 |
| rm_work | yeah | 06:25 |
| rm_work | basically, see my original comments | 06:25 |
| liujiong | rm_work: ok, now I know folks import barbicanclient.secrets or barbicanclient.client.secrets | 06:27 |
| *** pcaruana has joined #openstack-barbican | 07:06 | |
| openstackgerrit | Jeremy Liu proposed openstack/python-barbicanclient master: Support import modules from barbicanclient.client module https://review.openstack.org/489518 | 07:50 |
| liujiong | rm_work: I send a new patch https://review.openstack.org/#/c/489518/, can you confirm whether that's proper fix for octavia? thanks | 07:54 |
| *** randomhack has joined #openstack-barbican | 08:17 | |
| *** randomhack has quit IRC | 08:21 | |
| *** sapcc-bot2 has joined #openstack-barbican | 08:49 | |
| *** sapcc-bot has quit IRC | 08:53 | |
| *** salmankhan has joined #openstack-barbican | 08:58 | |
| rm_work | liujiong: i will have to do it tomorrow, sorry T_T | 09:03 |
| rm_work | in the morning, for me (about 8 hours) | 09:03 |
| liujiong | rm_work: ok, thank you! | 09:04 |
| *** liujiong has quit IRC | 10:12 | |
| *** tpatzig_ has joined #openstack-barbican | 11:29 | |
| *** seife_ has joined #openstack-barbican | 11:29 | |
| *** carthaca_ has joined #openstack-barbican | 11:29 | |
| *** mkoderer_ has joined #openstack-barbican | 11:29 | |
| *** seife_ has quit IRC | 11:31 | |
| *** tpatzig_ has quit IRC | 11:31 | |
| *** mkoderer_ has quit IRC | 11:31 | |
| *** carthaca_ has quit IRC | 11:31 | |
| *** raildo has joined #openstack-barbican | 12:10 | |
| *** catintheroof has joined #openstack-barbican | 12:20 | |
| *** dave-mccowan has joined #openstack-barbican | 12:54 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/castellan master: Use Stevedore for better extensions https://review.openstack.org/484015 | 13:04 |
| *** alee has quit IRC | 13:19 | |
| dave-mccowan | johnsom rm_work ping | 13:38 |
| *** noslzzp has joined #openstack-barbican | 13:47 | |
| *** liujiong has joined #openstack-barbican | 13:48 | |
| *** liujiong has quit IRC | 14:15 | |
| *** alee has joined #openstack-barbican | 14:16 | |
| alee | dave-mccowan, ping | 14:31 |
| dave-mccowan | alee pong | 14:32 |
| alee | dave-mccowan, note email from Luke Hinds upstream | 14:32 |
| alee | from security team | 14:32 |
| alee | (not sure if you responded yet) | 14:32 |
| dave-mccowan | alee yep. he pinged me earlier today too. | 14:32 |
| alee | I had thought you all had decided on first two days security and seconf two days barbican | 14:32 |
| alee | but it definitely makes sense for us to share etherpads etc. | 14:33 |
| alee | dave-mccowan, anyways will let you respond | 14:33 |
| dave-mccowan | yep, i replied and said we should share and co-ordinate. | 14:34 |
| alee | dave-mccowan, cool | 14:35 |
| dave-mccowan | alee i release barbican client 4.5.1 with the fix for object entry points. do you know anyone in heat or lbaas who is around today to confirm that everything is working for them now? | 14:36 |
| dave-mccowan | alee i want to confirm before getting feature-freeze exception to update global requirements | 14:37 |
| alee | dave-mccowan, dont know anyone on the top of my head | 14:37 |
| alee | dave-mccowan, maybe rm_work | 14:38 |
| alee | ? | 14:38 |
| *** pcaruana has quit IRC | 15:22 | |
| *** zz_dimtruck has quit IRC | 15:33 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/castellan master: [WIP] Vault based key manager https://review.openstack.org/483080 | 15:37 |
| *** pcaruana has joined #openstack-barbican | 15:40 | |
| *** rmascena has joined #openstack-barbican | 15:40 | |
| *** andreas_s has quit IRC | 15:41 | |
| *** raildo has quit IRC | 15:42 | |
| johnsom | dave-mccowan Hi | 15:48 |
| johnsom | I am just coming off some vacation time, so might not have the answers you are looking for, but I can at least ask | 15:48 |
| dave-mccowan | johnsom can you check if barbican client 4.5.1 is working for you now? | 15:49 |
| dave-mccowan | johnsom i need to request a feature-freeze-exemption to update global requirements, so i want to make sure everything is working before i do. | 15:49 |
| johnsom | I see there is a patch up with g-r changes, but there is a lot of red on it. It kind of looks like an infra blip though, rechecking. Though if the UC change hasn't happened yet, this must be unrelated. | 15:52 |
| johnsom | I will probably need to pull this down and test local. | 15:52 |
| dave-mccowan | johnsom i just noticed jeremy put up another patch for this. maybe it's not fixed yet. i'll check with him tonight. | 15:56 |
| johnsom | Ok, we will work to verify today. Where would you like results? Here? Is there bug? | 16:05 |
| dave-mccowan | https://bugs.launchpad.net/python-barbicanclient/+bug/1706841 | 16:31 |
| openstack | Launchpad bug 1706841 in python-barbicanclient "Client refactor broke all object entrypoints" [High,In progress] - Assigned to Jeremy Liu (liujiong) | 16:31 |
| dave-mccowan | johnsom ^^ and ping me here too please | 16:32 |
| dave-mccowan | thanks! | 16:32 |
| johnsom | Sure, NP | 16:32 |
| rm_work | dave-mccowan: you were off last night but | 16:41 |
| rm_work | i verified it is NOT | 16:41 |
| rm_work | and there is a new patch up | 16:41 |
| rm_work | johnsom / dave-mccowan i'm tracking this | 16:42 |
| johnsom | +1 | 16:42 |
| johnsom | Thanks! | 16:42 |
| dave-mccowan | rm_work thanks. do you know if the new patch works? | 16:42 |
| rm_work | dave-mccowan: if you go to eavesdrop for last night you can see our conversation | 16:42 |
| rm_work | it was about ... midnight | 16:42 |
| rm_work | no, i need to test it this morning | 16:42 |
| rm_work | but probably | 16:42 |
| dave-mccowan | dims ^^ fyi | 16:42 |
| dave-mccowan | rm_work thanks! | 16:43 |
| dims | thanks dave-mccowan. yes rm_work, i saw your chat with tonyb | 16:43 |
| rm_work | testing now | 16:43 |
| *** randomhack has joined #openstack-barbican | 16:50 | |
| rm_work | ok almost there | 16:51 |
| rm_work | i see one last bug >_< | 16:51 |
| rm_work | tracking it down | 16:51 |
| rm_work | appears some function signature changed | 16:51 |
| rm_work | ahh this one is maybe my fault | 16:51 |
| rm_work | I'm using an evil "isinstance" check | 16:52 |
| rm_work | hmm or maybe it is catching an actual bug, one sec | 16:53 |
| *** pcaruana has quit IRC | 16:58 | |
| *** randomhack has quit IRC | 16:58 | |
| mtreinish | dave-mccowan: did you see my response to your review on: https://review.openstack.org/#/c/476996/ | 17:02 |
| openstackgerrit | Matthew Treinish proposed openstack/barbican master: Use devstack functions for deploying barbican-svc https://review.openstack.org/476996 | 17:02 |
| rm_work | yeah this is an interesting one | 17:15 |
| rm_work | trying to figure out how to solve this testing issue without having the new stuff | 17:15 |
| rm_work | one sec, let me merge a patch | 17:21 |
| *** randomhack has joined #openstack-barbican | 17:21 | |
| rm_work | dave-mccowan: so here's the issue | 17:21 |
| rm_work | dave-mccowan: i was doing an isinstance on the returned client object in one test | 17:21 |
| rm_work | but it has moved to be a v1.client.Client | 17:21 |
| rm_work | so, do we consider that if someone did that, they deserve to be broken? | 17:22 |
| rm_work | I am willing to patch it in Octavia | 17:22 |
| rm_work | but there's technically no guarantee others didn't do this | 17:22 |
| rm_work | BUT... <_< well | 17:22 |
| rm_work | you can't catch EVERY way someone used your stuff | 17:22 |
| *** salmankhan has quit IRC | 17:23 | |
| rm_work | I've changed it to be more pythonic and just check for the things we expect exist in the object, rather than an "evil" isinstance() | 17:23 |
| dave-mccowan | rm_work :-( i hate breaking anyone, especially so close to release time. | 17:23 |
| rm_work | I am not sure how you fix an isinstance to pass | 17:24 |
| rm_work | is there a trick that allows you do pass that? | 17:24 |
| rm_work | I know that it is considered a very evil check | 17:24 |
| rm_work | basically the `barbicanclient.v1.client.Client` object needs to pass an isinstance() check that is looking for `barbicanclient.client.Client` | 17:25 |
| *** randomhack has quit IRC | 17:26 | |
| rm_work | but, that would technically be lieing in the case of wanting to know if you got the right thing | 17:26 |
| rm_work | because then the real `barbicanclient.client.Client` would also pass that test, but the test would be wrong | 17:26 |
| rm_work | I think maybe it's better to break a test that does that because it is a really bad test | 17:26 |
| dave-mccowan | rm_work i'll defer to you; if you're ok with patching to lbaas then we should be good to go. | 18:19 |
| rm_work | working on getting it merged | 18:19 |
| rm_work | you can merge that last fix | 18:19 |
| rm_work | and prepare the new versiob | 18:19 |
| dims | rm_work : this one to be sure :) https://review.openstack.org/#/c/489518/ | 18:23 |
| rm_work | yep | 18:41 |
| rm_work | you can cut the new release once that merges and it will be ok | 18:41 |
| rm_work | we'll still need to merge OUR fix but we can do that today | 18:41 |
| openstackgerrit | Merged openstack/python-barbicanclient master: Support import modules from barbicanclient.client module https://review.openstack.org/489518 | 18:47 |
| *** salmankhan has joined #openstack-barbican | 19:01 | |
| *** randomhack has joined #openstack-barbican | 19:02 | |
| *** peter-hamilton has joined #openstack-barbican | 19:33 | |
| *** peter-hamilton has quit IRC | 19:33 | |
| *** peter-hamilton has joined #openstack-barbican | 19:34 | |
| *** randomhack has quit IRC | 19:47 | |
| *** salmankhan has quit IRC | 20:29 | |
| *** dave-mccowan has quit IRC | 21:27 | |
| *** alee has quit IRC | 21:52 | |
| *** rmascena has quit IRC | 22:00 | |
| *** catintheroof has quit IRC | 22:23 | |
| *** dave-mccowan has joined #openstack-barbican | 22:43 | |
| *** alee has joined #openstack-barbican | 22:50 | |
| *** pbourke has quit IRC | 22:53 | |
| *** pbourke has joined #openstack-barbican | 22:55 | |
| -openstackstatus- NOTICE: osic nodes have been removed from nodepool due to a problem with the mirror host beginning around 22:20 UTC. please recheck any jobs with failures installing packages. | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!