| *** dave-mccowan has joined #openstack-barbican | 00:19 | |
| *** dave-mccowan has quit IRC | 00:30 | |
| redrobot | Hmm... I know it's been a while, but I don't understand why we're using `MagicMock`s for requests in the unit tests. It's pretty straightforward to make a real WebOb request. :-\ | 01:06 |
|---|---|---|
| redrobot | calling quits for today, I'll finish this patch up tomorrow morning. | 01:22 |
| *** namnh has joined #openstack-barbican | 01:48 | |
| namnh | alee_: | 01:52 |
| namnh | hi Ade, do you know why some barbican gates fail? | 01:53 |
| namnh | alee_: there are some failure gates when i run on master, even py27 | 01:55 |
| *** annp has joined #openstack-barbican | 02:13 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/barbican master: Follow the new PTI for document build https://review.openstack.org/571365 | 03:02 |
| *** annp has quit IRC | 03:25 | |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/barbican master: TrivialFix: Update block code to be more beautiful https://review.openstack.org/571370 | 03:29 |
| *** annp has joined #openstack-barbican | 03:31 | |
| jaosorior | namnh: it's being fixed by alee_, and redrobot | 04:40 |
| alee_ | namnh, there are issues due to webob and pykmip changes | 05:02 |
| alee_ | namnh, redrobot is fixing the webob changes -- I created a partial fix for the pykmip changes, but redrobot will finish it tommorow | 05:03 |
| alee_ | namnh, hopefuly we'll get all the gate issues resolved tommorow | 05:04 |
| *** namnh has quit IRC | 05:26 | |
| *** namnh has joined #openstack-barbican | 05:27 | |
| jaosorior | alee_: awesomeness | 05:44 |
| *** jaosorior has quit IRC | 05:58 | |
| *** serlex has joined #openstack-barbican | 06:01 | |
| *** jaosorior has joined #openstack-barbican | 06:14 | |
| namnh | jaosorior, alee_ thanks for your information. It's greate to know. | 06:37 |
| *** pcaruana has joined #openstack-barbican | 06:43 | |
| *** namnh has quit IRC | 07:04 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/barbican master: Follow the new PTI for document build https://review.openstack.org/571365 | 07:58 |
| *** salmankhan has joined #openstack-barbican | 09:08 | |
| *** tidwellr has joined #openstack-barbican | 09:30 | |
| *** salmankhan1 has joined #openstack-barbican | 09:32 | |
| *** salmankhan has quit IRC | 09:34 | |
| *** salmankhan1 is now known as salmankhan | 09:34 | |
| *** tidwellr has quit IRC | 09:35 | |
| *** pbourke has joined #openstack-barbican | 09:40 | |
| *** salmankhan has quit IRC | 10:33 | |
| *** salmankhan has joined #openstack-barbican | 10:49 | |
| *** salmankhan has quit IRC | 10:54 | |
| *** salmankhan has joined #openstack-barbican | 10:55 | |
| *** annp has quit IRC | 10:57 | |
| *** salmankhan has quit IRC | 11:01 | |
| *** salmankhan has joined #openstack-barbican | 11:11 | |
| *** abishop has joined #openstack-barbican | 11:23 | |
| *** dave-mccowan has joined #openstack-barbican | 11:35 | |
| *** dave-mcc_ has joined #openstack-barbican | 11:40 | |
| *** dave-mccowan has quit IRC | 11:43 | |
| *** raildo has joined #openstack-barbican | 12:00 | |
| *** alee_ has quit IRC | 12:28 | |
| *** alee_ has joined #openstack-barbican | 13:20 | |
| *** rmascena has joined #openstack-barbican | 13:26 | |
| *** raildo has quit IRC | 13:29 | |
| *** tidwellr has joined #openstack-barbican | 14:22 | |
| *** tidwellr has quit IRC | 14:23 | |
| *** tidwellr has joined #openstack-barbican | 14:23 | |
| *** tidwellr has quit IRC | 15:27 | |
| *** pcaruana has quit IRC | 15:28 | |
| *** tidwellr has joined #openstack-barbican | 15:29 | |
| redrobot | Heh... eventlet errors were not the rabbit hole I was expecting to go down. 😅 | 15:37 |
| alee_ | redrobot, how goes it? | 15:37 |
| redrobot | alee_, so there's this request mock that is mocking the way that webob==1.7.1 behaves | 15:40 |
| redrobot | that changed in 1.8.1 | 15:40 |
| redrobot | http://git.openstack.org/cgit/openstack/barbican/tree/barbican/tests/api/test_resources_policy.py#n127 | 15:40 |
| redrobot | specifically, `req.accept` is never `None` anymore | 15:40 |
| redrobot | but when I try to change the test case to pass an accept header I'm getting eventlet errors about the local context not having a request. :-\ | 15:41 |
| *** tidwellr has quit IRC | 15:57 | |
| *** tidwellr has joined #openstack-barbican | 16:06 | |
| *** tidwellr has quit IRC | 16:07 | |
| *** tidwellr has joined #openstack-barbican | 16:07 | |
| *** tidwellr has quit IRC | 16:07 | |
| *** tidwellr has joined #openstack-barbican | 16:07 | |
| *** tidwellr has quit IRC | 16:10 | |
| *** tidwellr has joined #openstack-barbican | 16:15 | |
| redrobot | got it! | 16:32 |
| redrobot | alee_, patch incoming | 16:32 |
| redrobot | What's the patch branch name and commit message flags for storyboard? | 16:44 |
| redrobot | used to be bug/XXXXXX for the branch wher XXXXXX was the launchpad bug | 16:44 |
| redrobot | is it story/XXXXXX now? | 16:44 |
| redrobot | the message used to include Closes-Bug: #XXXXXX | 16:45 |
| redrobot | is it Closes-Story: #XXXXXX now? | 16:45 |
| redrobot | found it | 16:50 |
| redrobot | it's `Story: XXXXXX` | 16:50 |
| alee_ | redrobot, excellent -- did you roll in my kmip changes too? | 17:00 |
| redrobot | alee_, making a dependent patch on top of yours | 17:00 |
| redrobot | just sorting out an issue with my yubikey ssh key right now | 17:00 |
| *** noslzzp has quit IRC | 17:03 | |
| *** rmascena has quit IRC | 17:13 | |
| *** raildo has joined #openstack-barbican | 17:13 | |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican master: Fix broken gate due to WebOb 1.8.1 https://review.openstack.org/571528 | 17:16 |
| *** salmankhan has quit IRC | 17:20 | |
| *** tidwellr has quit IRC | 17:29 | |
| alee_ | redrobot, yeah - problem is that mine wont merge without yours .. | 17:38 |
| alee_ | redrobot, but we can figure all that out once we have it all working | 17:38 |
| redrobot | alee_, I see. I can rebase-squash them into a single commit if the gate jobs pass on my patch. | 17:39 |
| redrobot | brb, lunchin' and walking ma' dawg. | 17:40 |
| *** tidwellr has joined #openstack-barbican | 17:42 | |
| *** noslzzp has joined #openstack-barbican | 18:02 | |
| redrobot | bak | 18:29 |
| redrobot | omg the gates are slooooooow | 18:30 |
| *** tidwellr has quit IRC | 18:31 | |
| *** tidwellr has joined #openstack-barbican | 18:37 | |
| *** tidwellr has quit IRC | 18:42 | |
| redrobot | looks like i need to fix 4 functional tests | 18:45 |
| alee_ | redrobot, yup - I saw those yesterday | 18:51 |
| alee_ | redrobot, there are also a few functional tests that fail on the kmip gate that I have not had a chance to look at | 18:51 |
| alee_ | Requests.exceptions.MissingSchema: Invalid URL 'None': No schema supplied. Perhaps you meant http://None? | 18:54 |
| redrobot | weird | 18:55 |
| *** tidwellr has joined #openstack-barbican | 18:55 | |
| redrobot | the gates on my patch should be testing both mine and your patches | 18:56 |
| *** serlex has quit IRC | 19:27 | |
| redrobot | having to read https://tools.ietf.org/html/rfc7231.html#section-5.3 to figure this out | 19:31 |
| redrobot | seems webob is not matching 'text/plain' to 'text/plain;charset=utf-8' | 19:31 |
| redrobot | although it claims to be compliant to that RFC | 19:32 |
| redrobot | :-\ | 19:32 |
| *** toabctl has quit IRC | 19:33 | |
| *** toabctl has joined #openstack-barbican | 19:36 | |
| redrobot | I think I found the solution to all our 406 test errors in that RFC: | 19:45 |
| redrobot | "the origin server can either honor the header field by sending a 406 (Not Acceptable) response or disregard the header field by treating the response as if it is not subject to content negotiation." | 19:46 |
| redrobot | DISREGARD ALL THE THINGS!!! :D | 19:46 |
| *** salmankhan has joined #openstack-barbican | 19:58 | |
| *** alee_ has quit IRC | 20:18 | |
| *** alee_ has joined #openstack-barbican | 20:52 | |
| *** salmankhan has quit IRC | 20:53 | |
| *** tidwellr has quit IRC | 21:11 | |
| *** abishop has quit IRC | 21:20 | |
| *** tidwellr has joined #openstack-barbican | 21:30 | |
| *** tidwellr has quit IRC | 21:35 | |
| redrobot | I think I just opened a big can of worms with this content negotiation stuff. | 21:35 |
| redrobot | I'm going to comment out the problematic functional tests to we can get the gate unclogged | 21:35 |
| redrobot | and then try to fix this mess | 21:36 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican master: Fix broken gate due to breaking dependency changes https://review.openstack.org/571528 | 21:49 |
| redrobot | alee_, ^ squashed your commit into mine and commented out the problematic functional tests | 21:50 |
| redrobot | gonna need some more elbow grease to fix the content negotiation | 21:50 |
| redrobot | I added a new task in Storyboard to track the skipped functional tests: https://storyboard.openstack.org/#!/story/2002122 | 22:03 |
| openstackgerrit | Douglas Mendizábal proposed openstack/barbican master: Fix broken gate due to breaking dependency changes https://review.openstack.org/571528 | 22:15 |
| redrobot | ^^ stupid pep8 error... 😅 | 22:23 |
| redrobot | alee_, almost there. The kmip gate is failing for some reason. I'll dig into it tomorrow. | 23:38 |
| *** tidwellr has joined #openstack-barbican | 23:52 | |
| *** tidwellr has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!