| *** openstack has joined #openstack-barbican | 04:21 | |
| *** ChanServ sets mode: +o openstack | 04:21 | |
| openstackgerrit | Jie Li proposed openstack/castellan master: add "verify_ssl_path" config for barbican key manager https://review.opendev.org/724653 | 05:01 |
|---|---|---|
| openstackgerrit | jacky06 proposed openstack/barbican-tempest-plugin master: Update hacking for Python3 https://review.opendev.org/628499 | 05:35 |
| *** tosky has joined #openstack-barbican | 07:30 | |
| *** openstackstatus has quit IRC | 07:46 | |
| *** openstack has joined #openstack-barbican | 07:48 | |
| *** ChanServ sets mode: +o openstack | 07:48 | |
| *** xek has joined #openstack-barbican | 08:39 | |
| *** strigazi has joined #openstack-barbican | 09:00 | |
| *** livelace has joined #openstack-barbican | 11:01 | |
| *** jmlowe has quit IRC | 11:03 | |
| *** jmlowe has joined #openstack-barbican | 11:07 | |
| *** raildo has joined #openstack-barbican | 11:37 | |
| *** livelace has quit IRC | 12:13 | |
| *** tkajinam has joined #openstack-barbican | 12:34 | |
| openstackgerrit | Jie Li proposed openstack/castellan master: add "verify_ssl_path" config for barbican key manager https://review.opendev.org/724653 | 12:59 |
| *** moguimar has joined #openstack-barbican | 13:18 | |
| tkajinam | ade_lee__, moguimar, redrobot hi. May I ask your review about https://review.opendev.org/#/c/721203/ ? | 13:26 |
| openstackgerrit | Jie Li proposed openstack/castellan master: add "verify_ssl_path" config for barbican key manager https://review.opendev.org/724653 | 13:31 |
| *** livelace has joined #openstack-barbican | 13:34 | |
| moguimar | tkajinam, done | 13:43 |
| *** livelace has quit IRC | 13:59 | |
| *** livelace has joined #openstack-barbican | 14:01 | |
| tkajinam | moguimar, thx! | 14:13 |
| tkajinam | moguimar, may I ask one question if you have time ? | 14:42 |
| moguimar | tkajinam, I have 8 minutes =D | 14:52 |
| tkajinam | moguimar, which content type do you usually expect. text/plain or application/octet-stream ? | 14:53 |
| tkajinam | usually expect for secrets | 14:53 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 14:54 |
| tkajinam | moguimar, it's not urgent because I should wait for CI result for the above updated patch... please find my replies to your comments ^^^ | 14:55 |
| moguimar | ok | 14:55 |
| moguimar | I'm not sure what content type is expected, I'm quite new to Barbican too | 14:56 |
| tkajinam | the same for me :-P | 14:56 |
| tkajinam | I think the change in content type was caused by mismatch between py2 string and py3 string | 14:57 |
| tkajinam | and the updated patch should revive the previous behavior in py2, so that cli creates secrets with octeat-stream... | 14:58 |
| tosky | I don't know that code, but I was thinking the same: maybe it's not a string (and read as text/plain) and not a bytearray (which would have read as octet-stream) | 15:02 |
| moguimar | tkajinam, thanks for the answers | 15:03 |
| tkajinam | tosky, yeah I agree with you. | 15:06 |
| tkajinam | moguimar, np. hope that the updated patch will pass ci without any new errors :-P | 15:07 |
| *** jmlowe has quit IRC | 15:08 | |
| *** jmlowe has joined #openstack-barbican | 15:09 | |
| tkajinam | I updated the patch to make sure that payload passed gets encoded to bytes... According to the current unit tests it seams octet-stream is generally expected in secrets created via CLI, but I'd like to ask some confirmation from Barbican team on the patch | 15:09 |
| tosky | as a non barbican developer, but potential barbican user, a change in the returned value may be an API break | 15:31 |
| tosky | tkajinam: looking at the old patches, have you see this one? https://review.opendev.org/#/c/676445/ | 15:32 |
| tkajinam | tosky, no... but it seems to be fixing another thing | 15:34 |
| tkajinam | because it only deals with the type of payload_content_type | 15:34 |
| tkajinam | I mean whether it is typed as unicode or string | 15:35 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 15:35 |
| tkajinam | though it sounds like another issue on Py3, which we might need to address :-P | 15:36 |
| tkajinam | Fortunately it seems that only cli is affected... so it shouldn't affect api behavior, IIUC | 15:39 |
| tosky | I guess all those fixes should go back to stable/ussuri as well, and a new release tagged there too | 15:48 |
| tkajinam | tosky, yeah... and as you know some downstream distro use py3 with train, so we should also fix stable/train | 15:51 |
| tosky | right (but with py2 compatibility on train) | 15:52 |
| tkajinam | I believe that all of my changes should be compatible with train, so I hope that I can just backport it to stable branches... | 15:58 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 16:53 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: DNM: allow byte to be passed to --payload value https://review.opendev.org/725934 | 16:58 |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 17:05 |
| *** irclogbot_2 has quit IRC | 17:20 | |
| *** irclogbot_1 has joined #openstack-barbican | 17:22 | |
| *** livelace has quit IRC | 17:44 | |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 17:45 |
| *** livelace has joined #openstack-barbican | 18:03 | |
| *** xek has quit IRC | 20:27 | |
| *** raildo_ has joined #openstack-barbican | 21:45 | |
| *** raildo has quit IRC | 21:48 | |
| *** raildo_ has quit IRC | 22:01 | |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 22:36 |
| *** tosky has quit IRC | 22:56 | |
| *** livelace has quit IRC | 23:07 | |
| openstackgerrit | Takashi Kajinami proposed openstack/python-barbicanclient master: Fix gate job failures https://review.opendev.org/721203 | 23:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!