| *** sylwesterB has joined #openstack-bareon | 07:50 | |
| *** sylwesterB has quit IRC | 07:55 | |
| *** sylwesterB has joined #openstack-bareon | 08:09 | |
| evgenyl | agordeev: sylwesterB review please https://review.openstack.org/#/c/269057/2 :) | 09:13 |
|---|---|---|
| sylwesterB | "BaseGrubBootloaderData" ? | 09:36 |
| openstackgerrit | Evgeniy L proposed openstack/bareon-specs: Fix rendering of specs by sphinx https://review.openstack.org/269516 | 09:42 |
| evgenyl | sylwesterB: ? | 09:42 |
| evgenyl | sylwesterB: what is the question? :) | 09:43 |
| evgenyl | sylwesterB: agordeev also fixed specs rendering in bareon-specs repo https://review.openstack.org/#/c/269516/ | 09:43 |
| sylwesterB | evgenyl: I rethinked that and actually that make sense | 09:59 |
| sylwesterB | I was wondering why not "*DataDriver" | 10:00 |
| sylwesterB | rethought* | 10:00 |
| evgenyl | sylwesterB: you are correct, it has to be datadriver | 10:01 |
| evgenyl | sylwesterB: put -1, I will fix that. | 10:01 |
| sylwesterB | Should that base classed represents bareon features like, partitioning, provisioning, image-build etc? | 10:01 |
| sylwesterB | And BaseConfigDriveData is more like a mixin | 10:02 |
| sylwesterB | damn | 10:02 |
| sylwesterB | Shouldn't that base classes represent bareon features like, partitioning, provisioning, image-build etc? * | 10:02 |
| sylwesterB | i.e. BaseConfigDriveMixin | 10:04 |
| sylwesterB | BaseGrubBootloaderMixin | 10:04 |
| evgenyl | sylwesterB: it's not a mixin, it's an inteface, and one data driver can implement different interfaces, so for Mixin is when you have a Base and you want to add something special to it, so I'm not sure if it makes sense to have a class which inherits from a mixin only. | 10:09 |
| sylwesterB | evgenyl: nope, it doesn't make sense ;) | 10:12 |
| evgenyl | sylwesterB: but probably we can inherit from BaseDataDriver and then add mixins :) | 10:12 |
| sylwesterB | evgenyl: exactly | 10:12 |
| evgenyl | sylwesterB: but any mixin will include BaseDataDriver :) | 10:13 |
| evgenyl | sylwesterB: so it's going to be weird. | 10:13 |
| sylwesterB | right.. | 10:14 |
| sylwesterB | hmm | 10:14 |
| sylwesterB | Maybe then do not inherit from BaseDataDriver in so called mixins? | 10:14 |
| evgenyl | sylwesterB: but in this case you will have problems with multiple inheritance of metaclasses :) | 10:15 |
| evgenyl | sylwesterB: there is no suitable syntax in python to do interfaces :( | 10:16 |
| sylwesterB | Another question. Will i.e. BaseConfigDriveDataDriver be used to create instances, not only to inherit from? | 10:16 |
| evgenyl | sylwesterB: only to inherit from. | 10:17 |
| sylwesterB | damn | 10:17 |
| sylwesterB | hmm | 10:17 |
| sylwesterB | sooo | 10:18 |
| sylwesterB | no, no.. | 10:19 |
| evgenyl | sylwesterB: ? :) | 10:19 |
| sylwesterB | I'm thinking how to do it right | 10:19 |
| evgenyl | agordeev: what do you think about names of abstract classes in my patch? Base*DataDriver vs *DataDriverMixin | 10:20 |
| sylwesterB | evgenyl: actually what will be the problem with abc metaclass? | 10:24 |
| evgenyl | sylwesterB: ok, seems no problem if metaclass is the same, otherwise you may get an error "metaclass multiple inheritance inconsistency" | 10:27 |
| sylwesterB | ok | 10:28 |
| sylwesterB | so it allows us to write mixins the proper way ;) | 10:29 |
| sylwesterB | without including BaseDataDriver | 10:29 |
| evgenyl | sylwesterB: yep, I've just tried, seems to work, will submit update after lunch :) | 10:30 |
| sylwesterB | ok | 10:30 |
| sylwesterB | great | 10:30 |
| sylwesterB | so I will put -1 now ;) | 10:30 |
| openstackgerrit | Evgeniy L proposed openstack/bareon: Make base class for data drivers more granular https://review.openstack.org/269057 | 11:05 |
| evgenyl | agordeev: sylwesterB updated the patch https://review.openstack.org/#/c/269057/ | 11:06 |
| sylwesterB | evgenyl: while waiting for response in specs review I can start the spec about the pipelines, what do you think?? | 12:04 |
| evgenyl | sylwesterB: you can prepare a patch, with stevedore | 12:04 |
| evgenyl | sylwesterB: also ping Igor, that we provided responses | 12:05 |
| evgenyl | sylwesterB: and fix stylistic comments, which Igor provided | 12:05 |
| sylwesterB | ok | 12:05 |
| evgenyl | sylwesterB: lets have everything "ready to review" for stevedore and after that yes, you may start working on pipeline spec. | 12:06 |
| openstackgerrit | Aleksandr Gordeev proposed openstack/bareon-specs: Add a spec for Pluggable do actions https://review.openstack.org/266416 | 12:50 |
| openstackgerrit | Evgeniy L proposed openstack/bareon: Accoding to pbr doc development version should have numeric postfix https://review.openstack.org/269630 | 13:41 |
| evgenyl | Small, but critical fix agordeev sylwesterB ^ | 13:42 |
| openstackgerrit | Merged openstack/bareon: Accoding to pbr doc development version should have numeric postfix https://review.openstack.org/269630 | 14:11 |
| *** sylwesterB has quit IRC | 15:45 | |
| openstackgerrit | Aleksandr Gordeev proposed openstack/bareon-specs: Add a spec for Pluggable do actions https://review.openstack.org/266416 | 16:31 |
| *** kozhukalov has quit IRC | 18:34 | |
| *** kozhukalov has joined #openstack-bareon | 18:34 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!