| *** sylwesterB has joined #openstack-bareon | 07:10 | |
| *** sylwesterB has quit IRC | 07:10 | |
| *** sylwesterB has joined #openstack-bareon | 07:10 | |
| evgenyl | sylwesterB: Carefully reviewed your spec https://review.openstack.org/#/c/263738/ , if don't agree with something, lets discuss it. Thanks for detailed description, good spec :) | 09:13 |
|---|---|---|
| sylwesterB | ok, I will check it out once I finish eating ;) | 09:14 |
| evgenyl | sylwesterB: could you please also find some time to review Alexander's spec https://review.openstack.org/#/c/266416/ ? There are comments from me and Vladimir, so Alexander have all required input. | 09:28 |
| evgenyl | sylwesterB: agordeev lets try to make them merged this week :) It's going to be more complicated for spec into Fuel, but we may try at least get the most reviews. | 09:29 |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-bareon | 10:02 | |
| sylwesterB | evgenyl: so actually do we plan to ship new extensions with Fuel? | 10:13 |
| sylwesterB | if yes then my assumptions are wrong: "All new extensions should be placed in separate packages. The `extensions` module in nailgun should be not extended anymore." | 10:14 |
| *** mihgen has quit IRC | 10:29 | |
| *** mihgen has joined #openstack-bareon | 10:39 | |
| evgenyl | sylwesterB: we plan to ship required extensions with Fuel. | 11:03 |
| openstackgerrit | Aleksandr Gordeev proposed openstack/bareon-specs: Add a spec for Pluggable do actions https://review.openstack.org/266416 | 13:59 |
| evgenyl | sylwesterB: agordeev updated the spec, could you please +1 if it's ok https://review.openstack.org/#/c/266416/ ? | 14:03 |
| agordeev | kozhukalov: please take a look too ^ | 14:04 |
| sylwesterB | looking into it | 14:04 |
| sylwesterB | agordeev: "Sometimes objects are the result of an action" | 14:06 |
| sylwesterB | I think I don't understand... any examples? | 14:06 |
| evgenyl | sylwesterB: I think there is an example with configdrive | 14:07 |
| evgenyl | agordeev: isn't it? | 14:07 |
| sylwesterB | yes it is | 14:07 |
| agordeev | yes, it is. https://github.com/openstack/bareon/blob/master/bareon/manager.py#L314-L331 | 14:07 |
| sylwesterB | but I don't understand it | 14:07 |
| sylwesterB | Oh ok | 14:08 |
| sylwesterB | so the action in the example is something in the shape of "make_config_drive" / | 14:08 |
| sylwesterB | ?* | 14:08 |
| agordeev | yes, indeed | 14:09 |
| evgenyl | sylwesterB: so there is an action which produces new partition, which is required for this specific action | 14:09 |
| sylwesterB | ok, so rephrasing: there at least two kinds of actions: (1) actions that produce objects, that are needed for (2) other actions | 14:10 |
| sylwesterB | right? | 14:10 |
| agordeev | there should be another example of an action which will detect that configdrive action is a part of flow and preserve partition for configdrive in partitioning scheme (At least, ironic is not using configdrive when provisions a node with fuel-agent driver) | 14:11 |
| sylwesterB | Ok I understand | 14:12 |
| agordeev | right now, it's done by conf file options. https://github.com/openstack/bareon/blob/master/bareon/manager.py#L127-L131 | 14:12 |
| evgenyl | sylwesterB: https://review.openstack.org/#/c/263738/ looks good, but couple of additional comments, which should be easy to fix. | 14:20 |
| sylwesterB | evgenyl: ok, thanks ;) | 14:20 |
| evgenyl | sylwesterB: also for some reasons you have -1 from CI | 14:21 |
| sylwesterB | Yeah... I'm afraid it's because of this bug https://bugs.launchpad.net/fuel/+bug/1536188 | 14:24 |
| openstack | Launchpad bug 1536188 in Fuel for OpenStack "verify-fuel-web is failed during setup virtualenv" [Critical,Confirmed] - Assigned to Fuel Python Team (fuel-python) | 14:24 |
| sylwesterB | at least the errors are the same | 14:25 |
| evgenyl | sylwesterB: oh, ok. | 14:25 |
| evgenyl | sylwesterB: there are concerns if we should have extension enable/disable per env or not, lets discuss it tomorrow here on irc. The problem is you cannot disable handlers per env, also it's not clear what to do with on_node_update and on_node_create if the node is not in the environment. | 15:45 |
| evgenyl | sylwesterB: it may require to shrink the spec to stevedore-extension-discovery only, but we should discuss it more | 15:47 |
| *** sylwesterB has quit IRC | 15:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!