Tuesday, 2018-01-23

*** gecong_ has joined #openstack-blazar00:59
*** hiro-kobayashi has joined #openstack-blazar01:06
*** openstackgerrit has joined #openstack-blazar02:51
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Add migration code for updating lease status  https://review.openstack.org/53664902:51
gecong_hiro-kobayahi ping02:58
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Add a document about the state machine  https://review.openstack.org/53240203:09
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Add a release note of the state machine  https://review.openstack.org/53240303:09
*** hiro-kobayashi has quit IRC03:24
*** gecong_ has quit IRC03:24
*** masahito has joined #openstack-blazar07:09
openstackgerritMasahito Muroi proposed openstack/blazar master: Spec: Suport multi availability zones  https://review.openstack.org/52416807:36
*** masahito_ has joined #openstack-blazar07:36
*** masahit__ has joined #openstack-blazar07:39
*** masahito has quit IRC07:40
*** masahito_ has quit IRC07:42
*** masahit__ has quit IRC08:12
*** hiro-kobayashi has joined #openstack-blazar08:19
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Add hosts operations to the API reference  https://review.openstack.org/53006508:28
*** masahito has joined #openstack-blazar08:57
*** priteau has joined #openstack-blazar09:02
openstackgerritPierre Riteau proposed openstack/blazar master: Add DevStack gate jobs for Python3  https://review.openstack.org/53354309:10
openstackgerritPierre Riteau proposed openstack/blazar master: Add a document about the state machine  https://review.openstack.org/53240209:23
openstackgerritPierre Riteau proposed openstack/blazar master: Add a release note of the state machine  https://review.openstack.org/53240309:24
openstackgerritPierre Riteau proposed openstack/blazar master: Add migration code for updating lease status  https://review.openstack.org/53664909:26
openstackgerritPierre Riteau proposed openstack/blazar master: Spec: Support multi availability zones  https://review.openstack.org/52416809:27
openstackgerritMerged openstack/python-blazarclient master: Align json indents  https://review.openstack.org/53350609:35
*** bertys has joined #openstack-blazar10:03
priteaumasahito: I didn't realize we had API schema tests in Tempest, where are they?10:03
masahitopriteau: I think Blazar hasn't have the tests never.10:04
priteauSo we only have the scenarios, right?10:04
masahitoWhen we revived Blazar, I saw only one scenario test that creates one host reservation.10:04
masahitopriteau: yes.10:05
bertysright. They should be added to blazar-tempest-plugin/tests/api10:05
priteauAnd for scenarios, we could use blazarclient?10:05
masahitoyes. I implemented tempest's blazar client to test both API and scenario with one scenario test in early stage.10:06
priteauI understand better now10:10
masahitoAdded this on Rocky PTG etherpad.10:10
masahitopriteau, hiro-kobayashi, bertys: I can't mention it in this weekly meeting...  I received our official mascot pictures.10:11
masahitoYou can download it here.10:12
masahitoI'm not sure how long the link is active. So please download it if needed :->10:13
priteauWill there be stickers at the PTG?10:13
masahitoIn previous PTG, there were stickers at PTG reception desk.10:14
bertysmasahito: Nice! are you planning to sign up to PTG interview?10:14
masahitoAnd a sign with the mascot in front of meeting room.10:15
masahitobertys: what's that?10:15
bertysmasahito: let me find the link10:15
masahitobertys: I can't read mail today because of technical issue in my office.10:15
bertys#link https://docs.google.com/spreadsheets/d/1MK7rCgYXCQZP1AgQ0RUiuc-cEXIzW5RuRzz5BWhV4nQ/edit#gid=167998023710:16
masahitoIt's announced in the ML?10:17
masahitoI'll check it later and sign Blazar there.10:19
bertysSee e.g. https://wiki.openstack.org/wiki/PTG/Rocky/Etherpads10:19
masahitobertys: thanks.10:20
masahitoWe planned to have review meeting today. It's okay to start?10:20
hiro-kobayashiI'm okay10:21
masahitoI didn't have much time to push codes after last review meeting.10:22
masahitoToday's items are mainly resource-monitoring and python-310:22
masahitohiro-kobayashi: Do you have other patches for review?10:22
hiro-kobayashifew patches for state-machine10:23
masahitogot it.10:24
masahitostarts with at least to review. Which patch is for state-machine? I don't see branch named state-machine.10:26
hiro-kobayashiI've pushed a patch for migration from older version: https://review.openstack.org/#/c/536649/10:27
hiro-kobayashiOther 2 patches a about documentation.10:27
masahitolooks like my query is wrong. I can't see the 2 patches for docs.10:27
hiro-kobayashidoc: https://review.openstack.org/#/c/532402/10:28
hiro-kobayashisecond one is release note10:28
hiro-kobayashiI'll push one more patch which change status literal to status object. e.g. 'pending' to blazar.status.reservation.PENDING.10:29
hiro-kobayashiI found some status literals in resource plugins code.10:29
hiro-kobayashiThen, this bp will be completed.10:29
hiro-kobayashiOh, and this patch https://review.openstack.org/#/c/526235/ for blazar-dashboard. It removes action and status_reason fields.10:31
masahitoLots of patches.10:33
masahitoQuestions for migration codes.10:33
hiro-kobayashiSorry I said few...10:33
hiro-kobayashimasahito: ok10:33
masahitoWe can add the codes in migration codes. If so, the upgrade and downgrade script works for state-machine.10:35
hiro-kobayashiDo you mean alembic migration code?10:35
hiro-kobayashiI could not find how to update existing field by alembic.10:36
masahitoCalling delive_stable_status() in upgrade()10:39
masahitoand set Null in downgrade() for all Lease.10:39
hiro-kobayashiI was thought of that but could not find how to update existing fields value. One idea was changing default value to derive status, but it's bad when registering a new record.10:40
priteauhiro-kobayashi: http://alembic.zzzcomputing.com/en/latest/ops.html#alembic.operations.Operations.execute10:42
hiro-kobayashipriteau: Oh, thanks!10:42
masahitoIIRC, migration scripts can execute any codes.10:42
priteaufound at https://stackoverflow.com/questions/24612395/how-do-i-execute-inserts-and-updates-in-an-alembic-upgrade-script10:43
priteauLook at the code in the first answer as well10:43
hiro-kobayashiThen I'll update the patch and related release note.10:43
priteauThat makes me remember, when I updated Chameleon, I had to do some manual data migrations in Blazar10:44
priteauMy notes from our upgrade:10:44
priteauActive reservations need another migration as the resource_id field has changed from aggregate ID to the ID in the computehost_reservations table:10:44
priteauUPDATE computehost_reservations SET aggregate_id=(SELECT resource_id FROM reservations WHERE id=computehost_reservations.reservation_id);10:45
priteauUPDATE reservations SET resource_id=(SELECT id FROM computehost_reservations WHERE reservation_id=reservations.id);10:45
hiro-kobayashipriteau: which do you prefer, current patch or alembic migration?10:45
priteauI prefer an alembic migration10:45
priteauOnce the migration is done, no need for backward compatibility code anymore10:45
masahitono more comments. Move on to patches for resource-monitoring.10:47
masahitopatches by implements instance recovery healing looks good to me.10:50
masahitoI have some questions for a patch of time windown.10:51
masahitoThe recursive approach is nice, but if an user delete lease in alloc_to_watch the watched allocation isn't removes.10:52
hiro-kobayashiOh, it's bad. It should be more resilient.10:54
masahitoAnd the new two config are bit complex to me. It looks first_recovery_window and second_and_later_recovery_window. Is it correct?10:55
masahitoThat's my question.10:55
hiro-kobayashiYes, these 2 time windows are described here: http://logs.openstack.org/88/532388/2/check/build-openstack-sphinx-docs/2fec947/html/_images/healing_time_window.png10:56
hiro-kobayashiNow that I think I should not have introduced 2 time windows. just 1 is simpler.10:57
masahitoOr I thought it's like DNS retrying.10:58
hiro-kobayashiI mean that we can introduce one config, e.g. 'recovery_check_interval' and gradually lengthening the interval. Like n * 'recovery_check_interval' where n is the number of recovery check.10:59
hiro-kobayashimasashito: right!10:59
hiro-kobayashiI'll update the patch based on your comment. thanks!11:00
hiro-kobayashiAny comments about the time window?11:00
-masahito- either looks okay for me.11:00
hiro-kobayashior anything11:00
masahitookay move on to last things.11:02
masahitopatches for python-311:02
masahitoAll of the patches LGTM.11:03
masahitoFor API patch, we discussed in weekly meeting.11:03
hiro-kobayashiI think we are almost completing this bp.11:04
hiro-kobayashiMore manual test may be needed, though.11:05
hiro-kobayashiAfter merging https://review.openstack.org/#/c/533543/ and solving the client problem, Let's change *-py35 tests to 'voting'.11:06
masahitoI think we've reviewed all the patches we need to do so?11:09
hiro-kobayashiYes, I think so.11:09
hiro-kobayashiapi-ref patches are okay for offline.11:10
masahitogot it.11:11
hiro-kobayashiOh, one more thing.11:11
bertysok for me, I personally also suggest to use 1.0.0b3 tag for Q3 release. Good progress overall11:11
hiro-kobayashimasahito: I've replied your comment on https://review.openstack.org/#/c/529262/ . Please check it.11:11
masahitogot it.11:12
masahitoone comment.11:12
masahitoFollowed except-block with different Exception type isn't executed in Python.11:13
hiro-kobayashiOh, really. I misunderstood.11:14
masahitoIn that case, if InvalidStatus exception is raised, block of 'except Exception' doesn't work.11:15
masahitoTry a similar codes in your local :-)11:15
hiro-kobayashiOh, yes i know.11:16
masahitoIf nothing more, we can end the meeting.11:18
hiro-kobayashimasahito: Got your comment. thanks!11:18
bertysthanks all! Have a good day,evening!11:19
masahitohiro-kobayashi, bertys: thanks! Have a good day and evening, too!11:20
hiro-kobayashiThanks! I have nothing and looks we can end meeting.11:20
hiro-kobayashiHave a nice day/evening!11:20
*** bertys has quit IRC11:21
*** hiro-kobayashi has quit IRC11:22
*** masahito has quit IRC11:26
*** masahito has joined #openstack-blazar11:28
*** masahito has quit IRC11:32
openstackgerritMerged openstack/blazar master: Fix exception message issues with Python3  https://review.openstack.org/53307511:51
openstackgerritMerged openstack/blazar master: Fix filter issues with Python3  https://review.openstack.org/53307811:51
*** masahito has joined #openstack-blazar12:04
*** nicolasbock has joined #openstack-blazar12:22
*** masahito has quit IRC12:24
openstackgerritGhanshyam Mann proposed openstack/blazar master: Remove use of unsupported TEMPEST_SERVICES variable  https://review.openstack.org/53683113:49
*** bauzas_ has joined #openstack-blazar15:08
*** bauzas_ has quit IRC15:09
*** bauzas_ has joined #openstack-blazar15:18
*** bauzas_ has quit IRC15:22
*** bauzas has quit IRC15:23
*** bauzas has joined #openstack-blazar15:24
*** nicolasbock has quit IRC15:47
*** openstackgerrit has quit IRC16:03
*** masahito has joined #openstack-blazar19:25
*** masahito has quit IRC19:30
*** nicolasbock has joined #openstack-blazar20:59
*** priteau has quit IRC22:03

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!