| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Update pylint https://review.openstack.org/574166 | 04:50 |
|---|---|---|
| *** masahito has joined #openstack-blazar | 04:57 | |
| openstackgerrit | Merged openstack/blazar master: Correct the project domain option for authorization https://review.openstack.org/578029 | 05:05 |
| *** masahito has quit IRC | 07:00 | |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Start to make placement client https://review.openstack.org/578017 | 07:00 |
| *** hiro-kobayashi has joined #openstack-blazar | 07:01 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/python-blazarclient master: Switch to stestr https://review.openstack.org/581224 | 07:04 |
| *** hiro-kobayashi has quit IRC | 07:14 | |
| *** masahito has joined #openstack-blazar | 07:17 | |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Change response code when start_date and end_date are invalid https://review.openstack.org/573647 | 07:51 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Return 400 Bad Request if an extra capability key is longer than 64 https://review.openstack.org/575699 | 07:51 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Add release note for response code fixes https://review.openstack.org/577747 | 07:51 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Support nova compute-api microversion '2.53' https://review.openstack.org/579513 | 08:01 |
| *** masahito has quit IRC | 08:24 | |
| *** hiro-kobayashi has joined #openstack-blazar | 08:47 | |
| *** priteau has joined #openstack-blazar | 08:55 | |
| *** masahito has joined #openstack-blazar | 09:01 | |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Update pylint https://review.openstack.org/574166 | 09:12 |
| openstackgerrit | Pierre Riteau proposed openstack/python-blazarclient master: Switch to stestr https://review.openstack.org/581224 | 09:30 |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Implement list and get allocation method to compute hosts plugin https://review.openstack.org/581286 | 09:31 |
| masahito | The placement spec is big and complex. So we should go next. | 10:01 |
| hiro-kobayashi | agree | 10:02 |
| masahito | The resource availability API is in same situation with the placement support. | 10:02 |
| *** tetsuro has joined #openstack-blazar | 10:02 | |
| masahito | Spec: https://review.openstack.org/#/c/574628/ | 10:02 |
| masahito | patch set #1: https://review.openstack.org/#/c/580577/ | 10:02 |
| masahito | patch set #2: https://review.openstack.org/#/c/581286/ | 10:03 |
| masahito | The patch sets are sample implementation because the spec is not merged yet. | 10:04 |
| tetsuro | This spec can go now, I think. I haven't reviewed the patches though. | 10:05 |
| masahito | But looks no objection to the spec, so I started to push some code on top of the spec. | 10:05 |
| hiro-kobayashi | I'm +2 to the spec but keep +1 not to hide other reviewer's -1 | 10:05 |
| hiro-kobayashi | I haven't reviewed the following patches | 10:06 |
| priteau | I am reading through the spec now | 10:06 |
| masahito | thanks all. | 10:06 |
| priteau | I would like to make some minor grammar changes if that's ok | 10:06 |
| masahito | priteau: Thanks. If you find something feel free to add your comment. | 10:07 |
| masahito | I'll revise it by next meeting and we'll have a chance to talk it again. | 10:08 |
| priteau | I don't quite understand the part about naming | 10:09 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add cleaning time https://review.openstack.org/575021 | 10:09 |
| priteau | You want to rename it "Resource allocation API"? In this case shouldn't it be the title of the spec? | 10:09 |
| masahito | I thought it when I started to writing the spec. | 10:10 |
| masahito | But resource "availability" API sounds the API returns free periods of the resource. | 10:11 |
| priteau | I think it's better to rename the spec | 10:12 |
| masahito | Based on the Dublin PTG discussion, this API returns "allocation" of reservation to resources. So I thought "allocation" is much better to its name. | 10:12 |
| masahito | Now this file name matches to blueprint url to easy track. Either is okay for me. | 10:14 |
| priteau | Can blueprint URL be changed? | 10:14 |
| priteau | Anyway, I wasn't thinking so much about the filename, but about the title header in the file | 10:15 |
| masahito | I see. I thought you mentioned about file name :-) Okay, change the title. | 10:16 |
| masahito | If no more comments, let's move on to next series. | 10:18 |
| priteau | Can I make direct (minor) changes to the files via edit? | 10:18 |
| priteau | Just to make wording clearer | 10:19 |
| masahito | priteau: Of course, np. | 10:19 |
| * tetsuro is good with the either title | 10:19 | |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Spec: Resource availability API https://review.openstack.org/574628 | 10:21 |
| masahito | Remaining series are Gabbi, Response Code fix, code structure and Dashboard support. | 10:21 |
| priteau | Dashboard support just needs another +2 | 10:22 |
| masahito | patch #1: https://review.openstack.org/#/c/580968/ | 10:23 |
| masahito | patch #2: https://review.openstack.org/#/c/580955 | 10:23 |
| hiro-kobayashi | Oh, I reviewed it and it was okay but forgot to +2 | 10:23 |
| masahito | Thanks | 10:24 |
| masahito | Code structure change looks good to me unless it solves merge conflict. | 10:25 |
| masahito | https://review.openstack.org/#/c/576028/ | 10:25 |
| hiro-kobayashi | me, too | 10:25 |
| tetsuro | ack will do. | 10:26 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/blazar master: Fix unit test to have appropriate FakeHost https://review.openstack.org/581311 | 10:28 |
| masahito | Move on to Gabbi support | 10:28 |
| masahito | patch #1: https://review.openstack.org/#/c/580537/ | 10:29 |
| masahito | patch #2: https://review.openstack.org/#/c/580563/ | 10:29 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Return 400 Bad Request for extra capability keys longer than 64 chars https://review.openstack.org/575699 | 10:29 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/blazar master: Fix directory structure https://review.openstack.org/576028 | 10:30 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add release note for response code fixes https://review.openstack.org/577747 | 10:30 |
| masahito | Just one question for Gabbi tests? | 10:30 |
| tetsuro | sure | 10:31 |
| masahito | Isn't some .zuul change required to use gabbi in gate job? | 10:31 |
| tetsuro | I don't think any tempest stuff is now in gate job, am I right? | 10:32 |
| priteau | I believe we run tempest during the gate job | 10:33 |
| hiro-kobayashi | *-dvsm-* uses tempest, right? | 10:33 |
| priteau | Yes, otherwise it wouldn't take ~40 minutes :-) | 10:34 |
| tetsuro | Okay, sorry. | 10:34 |
| masahito | I means the tempest job executes the gabbi test or not. | 10:35 |
| priteau | I don't know how to check that Gabbi tests are run | 10:35 |
| tetsuro | I haven't look into how these api tests are integrated to zuul. | 10:35 |
| tetsuro | No idea for now. | 10:35 |
| masahito | Before separating tempest plugin repo, the gate setting just execute test in blazar/tempest/scenario/test_*.py | 10:36 |
| priteau | We use a legacy dvsm job, so it's quite possible gabbi isn't integrated into it | 10:36 |
| masahito | The directory is different from gabbi's one. | 10:36 |
| openstackgerrit | Merged openstack/blazar master: Update pylint https://review.openstack.org/574166 | 10:37 |
| masahito | And looks no execution order between leases.yaml and hosts.yaml. It could fail because of no reservable host. | 10:38 |
| hiro-kobayashi | We also have to care https://review.openstack.org/#/c/580538/ | 10:39 |
| hiro-kobayashi | It will change API response codes. It affects the gabbi test. | 10:40 |
| tetsuro | masa: leases API works without reservable host if reservation field is empty | 10:40 |
| tetsuro | hiro: yes, I'm now working on it. | 10:41 |
| hiro-kobayashi | thanks! it's better to add #Depends-on tag to the gabbi patches | 10:42 |
| masahito | got it. | 10:42 |
| tetsuro | hiro: make sense. | 10:43 |
| masahito | Last series is response code fix. | 10:43 |
| hiro-kobayashi | I didn't know it's possible to create a lease without reservations :-) | 10:43 |
| masahito | patch #1: https://review.openstack.org/#/c/577747/ | 10:43 |
| masahito | patch #2: https://review.openstack.org/#/c/575699/ | 10:43 |
| masahito | releasenote: https://review.openstack.org/#/c/573647/ | 10:43 |
| masahito | sorry, releasenote: https://review.openstack.org/#/c/577747/ | 10:44 |
| priteau | Or the full topic :-) https://review.openstack.org/#/q/topic:fix-response-code+status:open | 10:44 |
| masahito | nice :-) | 10:44 |
| masahito | The two patch has already been reviewed by some of you and close to go. | 10:45 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Change response status code when start_date and end_date are invalid https://review.openstack.org/573647 | 10:46 |
| masahito | What I want to ask you is the releasenote patch should keep on top of response code change patch untile RC1? or Adding new releasenote that includes new response code change and exclude current one. | 10:47 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Return 400 Bad Request for extra capability keys longer than 64 chars https://review.openstack.org/575699 | 10:47 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add release note for response code fixes https://review.openstack.org/577747 | 10:47 |
| priteau | masahito: Is that for the other response code changes that hiro-kobayashi is working on? | 10:48 |
| priteau | Ideally we would have just one release note for everything | 10:48 |
| masahito | tetsuro will fix some response code. | 10:49 |
| masahito | Related to https://review.openstack.org/#/c/580538/ | 10:49 |
| priteau | Sorry, it was tetsuro, not hiro-kobayashi | 10:50 |
| tetsuro | np | 10:50 |
| priteau | Yes, I think we should hold the release note until 580538 is merged | 10:50 |
| masahito | Updating merged releasenote needs bit complex work. | 10:50 |
| hiro-kobayashi | agree | 10:50 |
| tetsuro | agreed | 10:50 |
| priteau | masahito: Can you put a W-1 on it to avoid accidental merge? | 10:50 |
| masahito | So I'd like to keep the releasenote patch in gerrit until RC1 | 10:50 |
| openstackgerrit | Van Hung Pham proposed openstack/blazar master: convert py35 jobs to py3 https://review.openstack.org/581316 | 10:51 |
| masahito | priteau: nice idea! :-) | 10:51 |
| tetsuro | I'll rebase my fix in the series before the relnote if I'm ready. | 10:52 |
| masahito | tetsuro: thank you | 10:52 |
| masahito | any other patches to review? | 10:53 |
| hiro-kobayashi | I think we covered all | 10:54 |
| masahito | The patch for blazar-nova fails because of miss config of zuulv3 and invalid constraints. https://review.openstack.org/#/c/555355/ | 10:54 |
| masahito | I'll try to fix it later. | 10:54 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Return 400 Bad Request for extra capability keys longer than 64 chars https://review.openstack.org/575699 | 10:55 |
| priteau | hiro-kobayashi: Can you please re-add a +2 to https://review.openstack.org/#/c/575699/ | 10:55 |
| priteau | I made a couple of minor changes | 10:56 |
| hiro-kobayashi | masahito: thanks! | 10:56 |
| hiro-kobayashi | ok | 10:56 |
| masahito | This meeting spends one hour and we had good progress. | 10:56 |
| priteau | Well done everyone | 10:57 |
| priteau | Let's revisit patches according to comments and try to merge more before next week? | 10:57 |
| masahito | yes. | 10:57 |
| masahito | If less time to review, we can revisit the patches in next week. | 10:58 |
| masahito | Almost 12pm in UK and 8pm in Japan. Let's finish the meeting. | 10:58 |
| priteau | Thanks a lot, bye everyone! | 10:59 |
| masahito | Thanks all! see you next week. | 10:59 |
| masahito | bye | 10:59 |
| hiro-kobayashi | thank you and good bye all! | 10:59 |
| tetsuro | thanks! | 11:00 |
| *** hiro-kobayashi has quit IRC | 11:00 | |
| *** tetsuro has quit IRC | 11:00 | |
| openstackgerrit | Merged openstack/blazar master: Support blazar-dashboard installation in DevStack https://review.openstack.org/580955 | 11:06 |
| *** masahito has quit IRC | 11:06 | |
| openstackgerrit | Merged openstack/blazar master: Change response status code when start_date and end_date are invalid https://review.openstack.org/573647 | 12:01 |
| openstackgerrit | Merged openstack/blazar master: Return 400 Bad Request for extra capability keys longer than 64 chars https://review.openstack.org/575699 | 12:41 |
| *** r-mibu has joined #openstack-blazar | 12:58 | |
| *** priteau has quit IRC | 15:36 | |
| *** r-mibu has quit IRC | 20:16 | |
| *** priteau has joined #openstack-blazar | 20:57 | |
| *** priteau has quit IRC | 21:37 | |
| *** priteau has joined #openstack-blazar | 21:37 | |
| *** priteau has quit IRC | 22:13 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!