| *** hiro-kobayashi has joined #openstack-blazar | 01:08 | |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Change the pylint requirement https://review.openstack.org/583080 | 02:18 |
|---|---|---|
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Add release note for response code fixes https://review.openstack.org/577747 | 02:40 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Fix POST and PUT status codes and update API Reference https://review.openstack.org/580538 | 02:51 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Fix unit test to have appropriate FakeHost https://review.openstack.org/581311 | 02:51 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Support nova compute-api microversion '2.53' https://review.openstack.org/579513 | 02:53 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Add release note for response code fixes https://review.openstack.org/577747 | 03:35 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Spec: Placement API support for instance reservation https://review.openstack.org/576343 | 05:32 |
| openstackgerrit | Merged openstack/python-blazarclient master: Catch exceptions for session client https://review.openstack.org/575686 | 06:17 |
| openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Set Tempest concurrency to one https://review.openstack.org/581939 | 06:42 |
| *** masahito has joined #openstack-blazar | 08:10 | |
| *** hiro-kobayashi has quit IRC | 08:11 | |
| *** hiro-kobayashi has joined #openstack-blazar | 08:52 | |
| *** priteau has joined #openstack-blazar | 08:55 | |
| openstackgerrit | Masahito Muroi proposed openstack/blazar master: Spec: Placement API support for instance reservation https://review.openstack.org/576343 | 08:58 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Change pylint requirement https://review.openstack.org/583080 | 09:45 |
| *** tetsuro has joined #openstack-blazar | 10:01 | |
| *** bertys_ has joined #openstack-blazar | 10:01 | |
| masahito | Followings are list of review target. | 10:02 |
| masahito | #1 PlacementAPI, #2 Cleaning Time, #3 Resource Allocation API, #4 Gabbi, #5 Response code fix | 10:03 |
| masahito | Let's start from PlacementAPI | 10:03 |
| masahito | https://review.openstack.org/#/q/status:open+project:openstack/blazar+branch:master+topic:bp/placement-api | 10:03 |
| masahito | There seems to be no objection to its contents. I'm okay to go the spec. | 10:05 |
| masahito | spec: https://review.openstack.org/#/c/576343/ | 10:05 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Spec: Placement API support for instance reservation https://review.openstack.org/576343 | 10:05 |
| priteau | I have just fixed a duplicated word | 10:05 |
| hiro-kobayashi | thanks! | 10:06 |
| masahito | patches: https://review.openstack.org/#/c/578017/ , https://review.openstack.org/#/c/578065, https://review.openstack.org/#/c/578073, https://review.openstack.org/#/c/578637 | 10:06 |
| hiro-kobayashi | The basic implementation LGTM, thank you tetsuro! I haven't see the following patches in detail yet. | 10:07 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar master: Spec: Placement API support for instance reservation https://review.openstack.org/576343 | 10:08 |
| masahito | tetsuro: My question for the client patch is the series of create and delete methods just creating and deleting Placement's resource. | 10:08 |
| masahito | As mentioned in the spec, some of naming pattern should be encapsulated the client class | 10:09 |
| priteau | tetsuro: I see you are using `Blueprint: placement-api` in the commit message. Shouldn't it be `Partially implements: blueprint placement-api` | 10:09 |
| hiro-kobayashi | nice catch! | 10:10 |
| tetsuro | masa: you're right, this is just placement client so we need to work on it for blazar additionally | 10:10 |
| tetsuro | priteau: Thanks! will do. | 10:11 |
| masahito | tetsuro: got it. If you have the plan, I'm okay :-) | 10:11 |
| tetsuro | An alternative is to use osc-placement library, but it supports only <1.17 microversion | 10:12 |
| priteau | Can we update osc-placement to use a newer microversion? | 10:13 |
| masahito | The repo looks only for CLI use. | 10:13 |
| tetsuro | That's one way, but the review velocity is not fast | 10:13 |
| priteau | Oh I see | 10:13 |
| masahito | https://github.com/openstack/osc-placement | 10:13 |
| priteau | "Python API binding is not implemented - Placement API consumers are encouraged to use the REST API directly, CLI is provided only for convenience of users." | 10:14 |
| priteau | (from https://github.com/openstack/osc-placement/blob/master/README.rst) | 10:14 |
| tetsuro | Actually nova isn't using osc-placement to use placement because of, I think, the same reason | 10:15 |
| masahito | Thanks for checking the Nova's situation. When Nova creates placement client as library we can move it. | 10:17 |
| masahito | any comments for PlacementAPI? | 10:18 |
| tetsuro | Yeah, we can move later since we don't use so many placement APIs. | 10:19 |
| priteau | I left comments on two patches. I can read the code in more details after the meeting. | 10:20 |
| tetsuro | Thanks in advance! | 10:20 |
| masahito | priteau: thanks. | 10:20 |
| masahito | Next is cleaning time. | 10:20 |
| masahito | https://review.openstack.org/#/c/575021/ | 10:20 |
| masahito | Looks remaining one question about "Partially Implements". | 10:21 |
| hiro-kobayashi | priteau: thank you for updating the patch | 10:21 |
| masahito | hiro-kobayashi: what's the remaining task for the bp? | 10:22 |
| hiro-kobayashi | Sorry, I think this blueprint completes. Is it okay to remove "Partially"? | 10:22 |
| masahito | Sure :-) | 10:23 |
| hiro-kobayashi | Then, I'll update the tag after the pylint patch is merged | 10:24 |
| masahito | Next is the allocation API | 10:25 |
| masahito | https://review.openstack.org/#/q/status:open+project:openstack/blazar+branch:master+topic:bp/resource-allocation-api | 10:25 |
| hiro-kobayashi | I think the spec is ready to be merged. | 10:26 |
| masahito | The spec looks okay and just waiting pylint patch. | 10:26 |
| priteau | Actually spec only runs pep8 and sphinx, so could be merged already? | 10:27 |
| masahito | maybe | 10:27 |
| masahito | I'm checking flask can find out the difference between the list API and the get API. | 10:28 |
| hiro-kobayashi | I guess the docs test also fails | 10:29 |
| hiro-kobayashi | without the pylint fix | 10:29 |
| priteau | Maybe. It should be merged soon. | 10:30 |
| hiro-kobayashi | masahito: if the url is available, then we can use it. | 10:30 |
| masahito | As hiro-kobayashi's comments the get API doesn't need query parameters. | 10:30 |
| hiro-kobayashi | I mean like flask.request.url | 10:30 |
| masahito | right. | 10:32 |
| masahito | I try to find it. | 10:32 |
| hiro-kobayashi | thanks | 10:33 |
| masahito | any comment? I try to push a patch which working well before r-3 and want to release it in Rocky at least with experimental. | 10:33 |
| masahito | Next is gabbi testing https://review.openstack.org/#/q/status:open+project:openstack/blazar-tempest-plugin+branch:master+topic:add-gabbi-tests | 10:35 |
| masahito | host testing is just waiting pylint fix | 10:35 |
| masahito | lease testing looks waiting tetsuro's fix, right? | 10:36 |
| tetsuro | I'm going to amend testing for leases api | 10:36 |
| tetsuro | masahito: right. | 10:36 |
| tetsuro | will submit shortly. | 10:37 |
| masahito | tetsuro: thanks. | 10:37 |
| bertys_ | just one question wrt lease testing (2nd test "post a new lease end_date missing"): Are we all ok with 400 here? | 10:37 |
| bertys_ | I would have had expected 201 here | 10:38 |
| priteau | what does our API ref say? | 10:38 |
| priteau | end_date is not listed as optional | 10:39 |
| masahito | IIRC, end_date is a required param. | 10:40 |
| priteau | In manager/service.py, not having end_date would raise an exception | 10:40 |
| priteau | It's a required param | 10:40 |
| masahito | So 400 looks fine to me. | 10:40 |
| masahito | in case of end_date missing | 10:41 |
| hiro-kobayashi | +1 | 10:41 |
| masahito | anything else for the gabbi testing? | 10:43 |
| masahito | Final is response code fixe. https://review.openstack.org/#/q/status:open+project:openstack/blazar+branch:master+topic:fix-response-code | 10:44 |
| masahito | All of the patch for the response code fix looks okay. | 10:45 |
| priteau | +1 | 10:46 |
| hiro-kobayashi | +1 | 10:46 |
| masahito | I'll merge it the releasenote patch after r-3. | 10:46 |
| masahito | tetsuro: did you hit any other wrong response code recently? | 10:46 |
| masahito | The soft string freeze happens at r-3 milestone. If we find other response code problem it's good to fix it asap. | 10:47 |
| tetsuro | Not really, but I feel I should look into it more closely looking into exceptions.py | 10:48 |
| masahito | It's not a 'string change' so could be okay to do after r-3. But it's nice to change before r-3. | 10:49 |
| masahito | got it. | 10:50 |
| tetsuro | That PolicyNotAuthorized and UnsupportedAPIVersion are 500 is suspicious... | 10:50 |
| masahito | uhh, looks not good. | 10:51 |
| masahito | any other patches we should review today? | 10:51 |
| priteau | Should NotEnoughHostsAvailable still be a 500 as well? | 10:51 |
| masahito | 406 Not acceptable or 409 Conflict is fine for NotEnoughHostAvailable? | 10:53 |
| priteau | 406 seems to be related to the data format requested by the client | 10:55 |
| tetsuro | IIRC, no valid host in nova is 400. | 10:55 |
| tetsuro | Will check it out. | 10:55 |
| masahito | thanks, tetsuro | 10:57 |
| masahito | if nothing more to review we can finish | 10:57 |
| tetsuro | ^sorry, that seems to be 500 | 10:58 |
| tetsuro | anyway, I can address it later. | 10:58 |
| tetsuro | nothing from me anymore | 10:59 |
| masahito | okay, let's finish the meeting. | 11:00 |
| priteau | thanks everyone! | 11:00 |
| tetsuro | thanks! | 11:00 |
| hiro-kobayashi | thanks! good day and night! | 11:01 |
| masahito | thanks all, see you in next week | 11:01 |
| *** tetsuro has quit IRC | 11:01 | |
| *** hiro-kobayashi has quit IRC | 11:01 | |
| *** bertys_ has quit IRC | 11:04 | |
| *** masahito has quit IRC | 11:09 | |
| openstackgerrit | Merged openstack/blazar master: Change pylint requirement https://review.openstack.org/583080 | 11:16 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/blazar-tempest-plugin master: Adds /os-hosts api tests using gabbi https://review.openstack.org/580537 | 11:32 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/blazar master: Fix directory structure https://review.openstack.org/576028 | 11:34 |
| openstackgerrit | Merged openstack/blazar-dashboard master: Add release notes link to README https://review.openstack.org/580425 | 11:48 |
| *** priteau has quit IRC | 20:31 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!