| *** masahito has joined #openstack-blazar | 04:52 | |
| openstackgerrit | Masahito Muroi proposed openstack/blazar-dashboard master: Support Affinity Rule column in the Virtual Instance Resource Type https://review.openstack.org/648001 | 04:57 |
|---|---|---|
| openstackgerrit | zhulingjie proposed openstack/blazar master: Update hacking version https://review.openstack.org/628500 | 04:58 |
| *** asmita has joined #openstack-blazar | 05:26 | |
| *** tetsuro has quit IRC | 05:35 | |
| *** tetsuro has joined #openstack-blazar | 07:46 | |
| *** asmita has quit IRC | 08:40 | |
| *** asmita has joined #openstack-blazar | 08:41 | |
| *** priteau has joined #openstack-blazar | 09:54 | |
| priteau | masahito: Hi. Would you be able to review https://review.openstack.org/#/c/647723/ | 10:04 |
| priteau | It helps avoiding Zuul failures | 10:04 |
| *** tetsuro has quit IRC | 10:11 | |
| asmita | priteau: Hi | 11:20 |
| priteau | Hi asmita | 11:20 |
| asmita | priteau: Can I push patch https://review.openstack.org/#/c/630026 by removing the affinity validation, since Tetsuro san has suggested to push another new patch for https://bugs.launchpad.net/blazar/+bug/1821576? | 11:23 |
| openstack | Launchpad bug 1821576 in Blazar "Lease creation should fail if affinity is passed with invalid input" [Undecided,In progress] - Assigned to Asmita Singh (asmita2018) | 11:23 |
| priteau | Yes, you can remove all the affinity validation from 630026 and use another patch for it. | 11:25 |
| asmita | Thank you.:) | 11:26 |
| openstackgerrit | Asmita Singh proposed openstack/blazar master: Lease creation/updation should fail if amount is 0 https://review.openstack.org/630026 | 11:34 |
| asmita | priteau : Kindly request you to review patch https://review.openstack.org/#/c/630026. | 12:32 |
| asmita | priteau: If it is a good time now, I needed some pointers from you regarding the before_request method of flask. | 12:47 |
| asmita | blazar/v1 uses flask whereas blazar/v2 uses pecan. | 12:48 |
| asmita | Everytime request is sent to flask app, before_request method is called automatically. | 12:51 |
| asmita | But through test cases, it is not called. | 12:51 |
| asmita | That is my hurdle. | 12:52 |
| priteau | asmita: What is the context of your question? Do you need to use before_request for something special? | 12:54 |
| asmita | I am trying to set api_version_request for adding micro-versioning in blazar. | 12:58 |
| asmita | Hence using before_request method to add a attribute api_version_request in the Request object. | 12:59 |
| priteau | I don't know enough about flask, sorry. | 12:59 |
| priteau | Have you checked how other projects do it? | 13:00 |
| asmita | priteau: Checked into valence.. but not able to figure. | 13:01 |
| asmita | priteau : Checked into openstack/valence,, but not able to figure out. | 13:02 |
| asmita | flask is pretty confusing | 13:02 |
| priteau | Have you checked keystone? | 13:03 |
| *** masahito has quit IRC | 13:03 | |
| asmita | Yes , i did. Still no success. | 13:03 |
| *** asmita has quit IRC | 14:22 | |
| openstackgerrit | Pierre Riteau proposed openstack/blazar-tempest-plugin master: Add API tests for List and Get Allocation API https://review.openstack.org/586859 | 19:27 |
| *** priteau has quit IRC | 19:27 | |
| *** openstackgerrit has quit IRC | 21:07 | |
| *** openstackgerrit has joined #openstack-blazar | 22:03 | |
| openstackgerrit | Pierre Riteau proposed openstack/blazar-tempest-plugin master: Add API tests for List and Get Allocation API https://review.openstack.org/586859 | 22:03 |
| openstackgerrit | Pierre Riteau proposed openstack/blazar-tempest-plugin master: Add API tests for List and Get Allocation API https://review.openstack.org/586859 | 22:52 |
| *** masahito has joined #openstack-blazar | 23:16 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!