*** gordc has quit IRC | 00:10 | |
*** david-lyle is now known as david-lyle_afk | 00:14 | |
*** ViswaV has quit IRC | 00:51 | |
*** sbfox1 has quit IRC | 00:56 | |
*** fnaval has quit IRC | 01:04 | |
*** ViswaV has joined #openstack-ceilometer | 01:23 | |
*** rwsu is now known as rwsu-afk | 01:27 | |
*** _cjones_ has quit IRC | 01:31 | |
*** amalagon has joined #openstack-ceilometer | 01:38 | |
*** ViswaV has quit IRC | 01:48 | |
*** ddieterly has joined #openstack-ceilometer | 01:49 | |
*** ddieterly has quit IRC | 02:02 | |
*** ddieterl_ has joined #openstack-ceilometer | 02:02 | |
*** ddieterl_ has quit IRC | 02:30 | |
*** ddieterly has joined #openstack-ceilometer | 02:58 | |
*** ddieterly has quit IRC | 03:02 | |
openstackgerrit | ZhiQiang Fan proposed openstack/ceilometer: drop deprecated novaclient.v1_1 https://review.openstack.org/159331 | 03:03 |
---|---|---|
openstackgerrit | ZhiQiang Fan proposed openstack/ceilometer: fix config opts in objectstore.rgw https://review.openstack.org/159333 | 03:27 |
*** deepthi has joined #openstack-ceilometer | 03:51 | |
*** nijaba has quit IRC | 04:06 | |
*** nijaba has joined #openstack-ceilometer | 04:08 | |
*** nijaba has quit IRC | 04:08 | |
*** nijaba has joined #openstack-ceilometer | 04:08 | |
*** sbfox has joined #openstack-ceilometer | 04:55 | |
*** ddieterly has joined #openstack-ceilometer | 05:00 | |
*** ddieterly has quit IRC | 05:04 | |
*** fnaval has joined #openstack-ceilometer | 05:32 | |
*** fnaval has quit IRC | 05:32 | |
*** amalagon has quit IRC | 05:36 | |
*** ParsectiX has quit IRC | 05:59 | |
*** ParsectiX has joined #openstack-ceilometer | 06:00 | |
*** ddieterly has joined #openstack-ceilometer | 06:01 | |
*** ParsectiX has quit IRC | 06:04 | |
*** ParsectiX has joined #openstack-ceilometer | 06:04 | |
*** ddieterly has quit IRC | 06:05 | |
*** ParsectiX has quit IRC | 06:05 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/155197 | 06:09 |
*** ViswaV has joined #openstack-ceilometer | 06:11 | |
*** ViswaV_ has joined #openstack-ceilometer | 06:15 | |
*** ViswaV has quit IRC | 06:16 | |
*** yatin has joined #openstack-ceilometer | 06:43 | |
*** ddieterly has joined #openstack-ceilometer | 07:01 | |
*** ddieterly has quit IRC | 07:06 | |
*** ildikov has quit IRC | 07:21 | |
*** ddieterly has joined #openstack-ceilometer | 08:02 | |
*** ddieterly has quit IRC | 08:06 | |
*** ildikov has joined #openstack-ceilometer | 08:09 | |
*** ViswaV_ has quit IRC | 08:15 | |
*** karimb has joined #openstack-ceilometer | 08:49 | |
*** Ala has joined #openstack-ceilometer | 08:49 | |
*** ccrouch has quit IRC | 08:56 | |
*** ccrouch has joined #openstack-ceilometer | 09:11 | |
openstackgerrit | Mehdi Abaakouk proposed stackforge/gnocchi: ceph: don't rely on a particular agg. method https://review.openstack.org/154786 | 09:14 |
*** sbfox has quit IRC | 09:24 | |
*** ddieterly has joined #openstack-ceilometer | 10:04 | |
*** ddieterly has quit IRC | 10:08 | |
*** EmilienM|afk is now known as EmilienM | 10:11 | |
vrovachev | eglynn-officeafk: jd__: I just want to remind about integration tests :) https://review.openstack.org/#/c/150794/ | 10:26 |
*** IvanBerezovskiy_ has joined #openstack-ceilometer | 10:27 | |
*** eglynn-officeafk is now known as eglynn-office | 10:35 | |
eglynn-office | vrovachev: thanks for the reminder! ... will get to it today | 10:36 |
vrovachev | eglynn-office: Okay, thank you :) | 10:36 |
*** _nadya_ has joined #openstack-ceilometer | 10:37 | |
*** _nadya_ has quit IRC | 10:37 | |
*** eglynn has joined #openstack-ceilometer | 10:38 | |
*** _nadya_ has joined #openstack-ceilometer | 10:38 | |
eglynn-office | vrovachev: just a couple of minor nitpicks, otherwise pretty much good to go IMO | 10:52 |
*** himangi has joined #openstack-ceilometer | 10:54 | |
ildikov | eglynn-office: hi | 10:57 |
eglynn-office | ildikov: hey | 10:57 |
*** gzhai_mob has joined #openstack-ceilometer | 10:57 | |
ildikov | eglynn-office: maybe I'm missing some basics regarding to integration tests | 10:58 |
ildikov | eglynn-office: those have to live in-tree too? | 10:58 |
ildikov | eglynn-office: I mean functional test != integration test | 10:58 |
ildikov | eglynn-office: or does that Nova folder cover both? | 10:59 |
eglynn-office | ildikov: well it's arguable where the boundary lies between a func test and an integration test | 11:00 |
eglynn-office | ildikov: IIUC in the nova case, there are tests to for example spin up a server | 11:00 |
eglynn-office | ildikov: that would require glance IIUC | 11:00 |
eglynn-office | ildikov: unless they mock that out in some | 11:01 |
eglynn-office | way | 11:01 |
*** gzhai_mob has quit IRC | 11:02 | |
ildikov | eglynn-office: ok, I see | 11:03 |
ildikov | eglynn-office: but do we have our own boundary? | 11:03 |
ildikov | eglynn-office: or is it a decision to keep everything in-tree? | 11:04 |
*** ddieterly has joined #openstack-ceilometer | 11:04 | |
eglynn-office | ildikov: in order for ceilometer to consume actual notifications and poll actual services, we need to run a DSVM no? | 11:05 |
ildikov | eglynn-office: yes | 11:06 |
eglynn-office | just checked with the nova folks BTW and glance is mocked for those tests | 11:06 |
eglynn-office | also the olso.messaging bus is faked out | 11:06 |
eglynn-office | so only the nova services run | 11:06 |
ildikov | eglynn-office: I wasn't sure about that part in the functional tests, we have some patches in NOva with gibi, but it's a mess in my head that which test was in which folder, but we had issues with RPC in that oslo.messaging mock... | 11:07 |
eglynn | ildikov: call starting, bbiab | 11:07 |
ildikov | eglynn: ok | 11:08 |
openstackgerrit | Vadim Rovachev proposed openstack/ceilometer-specs: Add specification for integration tests. https://review.openstack.org/150794 | 11:09 |
*** ddieterly has quit IRC | 11:09 | |
*** nellysmitt has joined #openstack-ceilometer | 11:10 | |
vrovachev | eglynn: ildikov: Thank you so much for review, I answered and resolved comments. | 11:11 |
*** cdent has joined #openstack-ceilometer | 11:11 | |
openstackgerrit | ZhiQiang Fan proposed openstack/ceilometer: Add the function of deleting alarm history https://review.openstack.org/87869 | 11:14 |
vrovachev | ildikov: Hi, all tests for differents DBs it's functional tests, DSVM-style tests(not yet written) it's integration tests. | 11:16 |
ildikov | vrovachev: I'm fine with DB tests and that those are functional tests | 11:17 |
ildikov | vrovachev: as for integration tests I thought it will remain in Tempest conceptually | 11:17 |
ildikov | vrovachev: therefore I got confused a bit | 11:18 |
cdent | ildikov: from the conversataions I’ve had with the tempest folk, long term they want to shrink tempest | 11:19 |
*** pcaruana has joined #openstack-ceilometer | 11:19 | |
cdent | especially with regard to what they consider non-core projects | 11:19 |
ildikov | cdent: shrink == remove or smth like? | 11:19 |
vrovachev | ildikov: QAs don't wants them to have such specific tests on tempest. This was discussed at the summit. | 11:19 |
cdent | I don’t think it is black and white: It’s a progression: the projects take on greater responsibility for self-hosting their own test code, whatever the type. | 11:20 |
cdent | (the type of tests) | 11:20 |
ildikov | vrovachev: well, functional tests are the less specific I guess :) | 11:21 |
vrovachev | ildikov: If QAs were not against it, tests in temset would of course it's much easier :) | 11:21 |
cdent | biab | 11:21 |
*** cdent has quit IRC | 11:21 | |
ildikov | cdent: in case of integration with other services I guess this a very "grey" question... | 11:22 |
vrovachev | ildikov: so, functional tests were originally in-tree :) We want just move these to different folder | 11:22 |
ildikov | vrovachev: as I said the functional test folder is fine, just like how eglynn-office mentioned Nova as an example | 11:23 |
vrovachev | ildikov: ah, okay :) | 11:23 |
ildikov | vrovachev: just the integration test folder looks odd a bit | 11:24 |
ildikov | vrovachev: as the part is not only for testing our code | 11:25 |
vrovachev | ildikov: It's extreme measures, unfortunately. | 11:25 |
vrovachev | ildikov: In fact, many stackforge projects are practicing this approach | 11:26 |
ildikov | vrovachev: sure, well, even if it will be this way I will not like it, but obviously that's not your fault :) | 11:27 |
vrovachev | ildikov: ah, thanks :) | 11:28 |
ildikov | vrovachev: so as a sum of the above discussion, the thing is that we would like to have the integration tests in Tempest, but it's not inline with what the QA folks think, so we now plan to implement these in-tree to still have coverage | 11:32 |
ildikov | vrovachev: did I understand right the "issue"? | 11:33 |
vrovachev | ildikov: allright | 11:33 |
ildikov | vrovachev: that sounds a bit sad to me :(, but thanks for clarification :) | 11:34 |
ildikov | vrovachev: just one more quick question | 11:35 |
vrovachev | ildikov: yes? | 11:35 |
ildikov | vrovachev: would that be possible to move these integration tests to Tempest in the future, if that wouldn't be blocked conceptually? | 11:36 |
ildikov | vrovachev: I mean if let's say a half year later someone would tell that we are free to put our tests there, then it would mean a complete rewrite or just some modifications? | 11:38 |
*** _nadya_ has quit IRC | 11:39 | |
vrovachev | ildikov: i think. that it's blocked conceptually. Because of on DSVMs JOBs uses mysql or postgres and on these DB and with very more strong tempest load for these DB adding notification to DB is very long(~20min in end of tests) | 11:40 |
ildikov | vrovachev: uh, this sounds bad in general :( | 11:41 |
vrovachev | ildikov: We wanted to create Job with Mongo, but that QAs did not take | 11:41 |
ildikov | vrovachev: got it :( | 11:42 |
ildikov | vrovachev: I just have the feeling with all the integartion tests in-tree that we kinda take the responsibility for the sender side of notifications and every other stuff that is affected | 11:45 |
ildikov | vrovachev: but I guess I just have to change my viewpoint... :) | 11:45 |
*** deepthi has quit IRC | 11:46 | |
eglynn | vrovachev, ildikov: sorry, on a call, back now | 11:49 |
vrovachev | ildikov: I think, when we will finish to write integration tests, we will to see backward compatibility for all integrated projects. So, I think it's not so bad. | 11:49 |
eglynn | so as cdent said above, the long term preference of QA is for things to migrate out of Tempest | 11:49 |
eglynn | so that Tempest ends up as a slimed down set of pure API tests IIUC | 11:50 |
ildikov | eglynn: hmm, so API testing in the functional tests and in Tempest too? | 11:50 |
ildikov | eglynn: well, it will be easier to maintain that scope for sure | 11:51 |
eglynn | ildikov: some duplication initially with a view to removing eventually from Tempest | 11:51 |
eglynn | so take notification driven tests | 11:51 |
eglynn | the QA don't like that we have them currently in tempest | 11:51 |
eglynn | so we replicate equivalent tests in tree | 11:51 |
eglynn | run experimentally for a while | 11:52 |
eglynn | then eventually deprecate the equivalent tests in tempests | 11:52 |
ildikov | eglynn: I got the process, I just had a memory snippet that Tempest will keep the integration test part, which did not mean only API tests for me | 11:52 |
vrovachev | ildikov: For example, if some project makes changes in notification code(eg change in notification json), then we will to see it on fails job. And will can to create a bug for ceilo or for some project. | 11:53 |
ildikov | eglynn: so I clearly understand what and how we would like to do, I just didn't really understand the why part | 11:53 |
*** cdent has joined #openstack-ceilometer | 11:54 | |
eglynn | ildikov: well, part of it is that Tempest has just grown into a monster that the QA team are finding very difficult to manage | 11:54 |
ildikov | vrovachev: as for notifications, I hope that the notification schema initiative will not die before the implementation phase to make life easier for everyone | 11:54 |
eglynn | ildikov: specifically when unexplained failure arise | 11:55 |
eglynn | ildikov: they can't see that approach of throwing the kitchen sink into tempest as being sustainable | 11:55 |
vrovachev | ildikov: Oh, that's for sure, I hope so too. | 11:55 |
eglynn | ildikov: esp. in the context of big tent | 11:55 |
ildikov | eglynn: for a monster like OpenStack QA is hell anyway IMHO... | 11:56 |
cdent | ildikov: the last I heard from the notification schema folk is that they are currently codifying existing stuff. I'm not sure this is the best way forward, nor is their lack of visibility great. | 11:57 |
ildikov | eglynn: I just did not have the information that inetgration tests are not really welcomed there, I know that our integration tests are even more difficult to get in | 11:57 |
*** _nadya_ has joined #openstack-ceilometer | 11:58 | |
ildikov | cdent: the progress is good, otherwise we will not get anywhere ever, but the lack of visibility is a problem I agree | 11:58 |
eglynn | ildikov: giving us the flexibility to write integration tests that wouldn't pass muster in tempest (e.g. because they need to do odd things like restarting services) is one of the big motivations from our PoV | 11:59 |
eglynn | ildikov: i.e. the motivation is not just ... we're doing this to keep the qa folks happy ;) | 11:59 |
cdent | THE WOLVES ARE AT THE DOOR!!!! | 12:00 |
cdent | :) | 12:00 |
ildikov | eglynn: I have my opinion about that part... :) | 12:00 |
cdent | I think the biggest win of in tree integration and functional tests is that I can run them (given suitable tooling) before I ever submit code. | 12:00 |
ildikov | eglynn: but hopefully we will not restart those services till the end of our or OpenStack's life ;) | 12:01 |
ildikov | cdent: you can run tempest tests too | 12:01 |
cdent | yes, but it is a good deal more painful and less focused | 12:02 |
cdent | (assuming we do it right on our side) | 12:02 |
eglynn | ildikov: end of openstack's life? ... this reich will last a thousand beers! ... sorry, years! | 12:04 |
ildikov | well, I'm still not convinced to like this, but I can accept that we do not have (m)any other choices | 12:04 |
eglynn | ildikov: more seriouslu, it allows us the flexibility to take "tactical" approaches in the meantime even if restarting services etc. won't be needed forevere | 12:04 |
*** ddieterly has joined #openstack-ceilometer | 12:05 | |
cdent | ildikov: I may have missed you saying this already, but why do you prefer in tempest? | 12:05 |
ildikov | eglynn: let's try to make integration as easy as it possible rather than have many tactics in the test suite | 12:06 |
ildikov | cdent: I wrote above that I think I have to change my viewpoint | 12:07 |
vrovachev | cdent: because of integration test must be with other integration tests :) | 12:07 |
ildikov | cdent: integration is one level higher for than just simply how our code works | 12:08 |
_nadya_ | actually it's interesting how is tempest doing? is it under active development now? vrovachev, have you committed anything there in this cycle? | 12:09 |
*** ddieterly has quit IRC | 12:09 | |
_nadya_ | hi folks :) | 12:09 |
vrovachev | ildikov: Yes, that is why we will to create DSVM style job | 12:09 |
ildikov | cdent: like we would be the only responsibles to fully adapt to everyones continuously changing notification formats | 12:09 |
ildikov | vrovachev: yeap, sure, that's all good | 12:10 |
vrovachev | _nadya_: in tempest I have two not merged patches, on in-tree integration tests I have spec :) | 12:11 |
ildikov | vrovachev: it's just I'm the "big picture girl" here, it looks annoying from the outside I guess, but well, that's me :) and I usually think that it's better to share concerns coming from this way of thinking as it gives a chance to consider even more pros and cons | 12:11 |
ildikov | but I don't think it's a problem if someone has another opinion | 12:13 |
vrovachev | ildikov: okay :) | 12:13 |
ildikov | cdent, eglynn: as for other opinion, I had time to only quickly check the asyncio patch | 12:14 |
eglynn | ildikov: thanks! | 12:15 |
* eglynn forages for food | 12:15 | |
*** eglynn is now known as eglynn-lunch | 12:15 | |
ildikov | vrovachev: so I'm not against your patch, just wanted to see the whole picture :) | 12:15 |
ildikov | cdent, eglynn-lunch: I learnt that it's still not a 100% welcomed change and I still have my concern regarding to it will be too much for us as for changes | 12:16 |
*** rodrigods is now known as rodrigods_ | 12:16 | |
*** rodrigods_ is now known as rodrigods__ | 12:16 | |
*** rodrigods__ is now known as rodrigod` | 12:16 | |
*** rodrigod` is now known as rodrigods | 12:17 | |
cdent | sorry ildikov was on the phone | 12:17 |
* cdent catches up | 12:17 | |
vrovachev | ildikov: Okay, I understand this :) | 12:17 |
ildikov | cdent, eglynn-lunch: so I have my vote against it currently, but if we will consider this anyways, then I support cdent's idea about having a small scope | 12:18 |
ildikov | cdent, eglynn-lunch: just sharing now as I will not be able to attend the meeting today sadly :( | 12:18 |
cdent | It looks like the proposer has already started to code and started with the collector instead of the notification agent | 12:18 |
ildikov | vrovachev: ok, cool, tnx :) | 12:18 |
_nadya_ | ildikov: what change are you discussing? could you please give a link? | 12:19 |
_nadya_ | ildikov: or spec | 12:19 |
cdent | re integration tests: I don't think tempest should stop doing multi-party integration testing or really much of what it is already doing, just that each project should also do more of their own testing, with critical partners | 12:19 |
ildikov | _nadya_: hi, sorry for the late response :) | 12:19 |
cdent | some people think that will lead to duplication, but I think it will lead to more tests, which is not quite the same thing as duplication | 12:19 |
ildikov | _nadya_: you mean now? | 12:19 |
cdent | in other words there are many layers of integration and we can distribute them between tempest and us | 12:19 |
*** himangi has quit IRC | 12:20 | |
ildikov | _nadya_: https://review.openstack.org/#/c/153298/3 | 12:20 |
_nadya_ | ildikov: aha, thanks | 12:20 |
ildikov | cdent: that is why I asked if there will be a chance to move some tests to tempest later if there is a chance for having this distribution for instance | 12:21 |
vrovachev | cdent: Question for delete ceilo tests on tempest is secondary, but I think that ceilo tests on tempest should not be removed | 12:24 |
cdent | I think that there are plenty of opportunities for tests to go in _both_ directions | 12:25 |
cdent | but we don't really need to decide what and when, yet. First we need to just get started with providing the in-tree structure that divides up unit from not-unit tests | 12:25 |
ildikov | _nadya_: we have a meeting topic for this, or at least I kept it in the agenda as I remembered that we will discuss this today | 12:27 |
_nadya_ | tests for Ceilo should be in all test-related projects: Tempest, Rally,... do we have more:)? | 12:27 |
_nadya_ | ildikov: ok, great! | 12:28 |
_nadya_ | guys, haven't you discussed https://review.openstack.org/#/c/142592/ on the last meeting? Or anywhere else? I'd like to know what cores think about this implementation in general... | 12:28 |
ildikov | _nadya_: it's on my todo list to review it in details | 12:29 |
ildikov | _nadya_: I like the base idea to move the pipeline config into DB, but I need to look deeper in the actual implementation | 12:29 |
_nadya_ | ildikov: cool! As I understood, me and Gordon are a little bit confused about complexity :) | 12:30 |
ildikov | _nadya_: well, I already should have... :( | 12:30 |
*** akrivoka has joined #openstack-ceilometer | 12:31 | |
ildikov | _nadya_: yeap, I remember those discussions on gerrit | 12:31 |
ildikov | _nadya_: the DB based dynamic config idea should be achievable, but unfortunately I'm not the expert of DB and DB model optimization for this... :( | 12:33 |
ildikov | _nadya_: so reviewing it will take a shorter while, but we should have more eyes on it for sure, so thanks for bring it up | 12:33 |
ildikov | _nadya_: I will not be able to attend the today's meeting, but maybe a few words about this topic on the meeting would be good for having a bit more attention | 12:36 |
_nadya_ | ildikov: yep, I cannot understand why it's better to store config in db and "to decide the interval in which you want to evaluate pipeline changes". We can use the same "interval" and just load the file again in memory. Without db at all... I still think that I may miss something important | 12:37 |
akrivoka | is there a way to use substrings in a query? e.g. somethink like: ceilometer sample-list -m hardware.ipmi.current -q 'resource_id.startswith("blahblah")' | 12:38 |
ildikov | _nadya_: it gives some flexibility to the way how the data collection process is configured | 12:39 |
ildikov | _nadya_: like using an API endpoint and later having more fine grained config like based on projects or even lower than that | 12:40 |
eglynn-lunch | akrivoka: regex matching is now supported, but only for "complex queries" | 12:41 |
eglynn-lunch | akrivoka: see https://github.com/openstack/ceilometer-specs/blob/master/specs/kilo/regexp-in-complex-query.rst | 12:41 |
akrivoka | eglynn-lunch: thanks! | 12:42 |
_nadya_ | ildikov: I will think about it, thanks for pointing on API again | 12:43 |
ildikov | _nadya_: cool, np | 12:43 |
cdent | linuxhermit: I've had some feedback from sdague, he thinks we should be commenting the gabbi yaml files much more. I've thought this too but was waiting for someone to say it (to not preload people's thinking). | 12:48 |
* cdent needs lunch | 12:51 | |
cdent | brb | 12:51 |
*** rodrigods is now known as rodrigod` | 12:51 | |
*** rodrigod` is now known as rodrigods | 12:53 | |
linuxhermit | like explaining each test? cdent | 13:00 |
cdent | pretty much linuxhermit | 13:02 |
cdent | "because those might all seem obvious now about why, but as I'm sifting through 3 year old tests in the nova tree, lots of things are non obvious :)" | 13:03 |
*** _nadya_ has quit IRC | 13:04 | |
*** jkraj has joined #openstack-ceilometer | 13:05 | |
*** yatin has quit IRC | 13:06 | |
*** ddieterly has joined #openstack-ceilometer | 13:06 | |
linuxhermit | cdent okay althought that is case with all tests | 13:09 |
linuxhermit | and comment refactor rarely happens | 13:09 |
cdent | I'm not entirely sold on the idea that it is needed, just something to think about | 13:10 |
cdent | (that quote is from sdague, not me, in case it wasn't clear) | 13:10 |
cdent | If, for example there's a sequence being represented it might make sense to say so | 13:11 |
*** ddieterly has quit IRC | 13:11 | |
cdent | and for an especially long sequence it might make sense for it to be its own file | 13:11 |
linuxhermit | oh like a process of create alarm send data destory alarm etc | 13:11 |
linuxhermit | or workflow processes | 13:12 |
* cdent nods | 13:17 | |
cdent | basically if one of the original goals of gabbi is to make the http api learnable and visible, the tests need to be readable sort of like a story | 13:18 |
cdent | I know that I was better at that in the first few experiments, but as I've moved along I've become a bit sloppy, so need to remind myself of the point... | 13:18 |
cdent | the latest resources stuff I've done for gnocchi is too hairy | 13:19 |
linuxhermit | okay | 13:20 |
linuxhermit | I'll go back and comment up my events one | 13:20 |
ildikov | eglynn-lunch: I need to run soon, my "feelings" about asyncio are above, as I will not be able to join the meeting today | 13:20 |
linuxhermit | it doesn't have any workflow type things | 13:20 |
linuxhermit | but a good narative never hurts | 13:20 |
eglynn-lunch | ildikov: ok, thanks for heads-up | 13:21 |
*** eglynn-lunch is now known as eglynn | 13:21 | |
ildikov | eglynn: np | 13:23 |
*** moravec has joined #openstack-ceilometer | 13:26 | |
openstackgerrit | Chris Dent proposed stackforge/gnocchi: Cover the basic resource API with gabbi tests https://review.openstack.org/159204 | 13:37 |
*** ildikov has quit IRC | 13:38 | |
*** ildikov has joined #openstack-ceilometer | 13:51 | |
*** ildikov is now known as ildikov_afk | 13:51 | |
*** ddieterly has joined #openstack-ceilometer | 13:51 | |
*** ddieterly has quit IRC | 13:58 | |
*** ddieterly has joined #openstack-ceilometer | 13:58 | |
openstackgerrit | Nelly Kuznetsova proposed stackforge/gnocchi: Driver for KairosDB with Cassandra https://review.openstack.org/159476 | 14:02 |
openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 14:07 |
*** _nadya_ has joined #openstack-ceilometer | 14:08 | |
openstackgerrit | Merged openstack/ceilometer-specs: Add specification for integration tests. https://review.openstack.org/150794 | 14:09 |
openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 14:10 |
*** exploreshaifali has joined #openstack-ceilometer | 14:11 | |
*** thomasem has joined #openstack-ceilometer | 14:13 | |
*** changbl has quit IRC | 14:17 | |
*** gordc has joined #openstack-ceilometer | 14:17 | |
openstackgerrit | Merged stackforge/gnocchi: Add a py27-cover tox target https://review.openstack.org/158672 | 14:22 |
openstackgerrit | Merged stackforge/gnocchi: Remove a redundant existence check in resource PATCH https://review.openstack.org/159186 | 14:22 |
openstackgerrit | Dina Belova proposed stackforge/gnocchi: [WIP] Driver for KairosDB with Cassandra https://review.openstack.org/159476 | 14:25 |
openstackgerrit | gordon chung proposed openstack/ceilometer: create a developer section and refactor https://review.openstack.org/156413 | 14:31 |
*** j_king_ is now known as j_king | 14:43 | |
*** ccrouch has quit IRC | 14:44 | |
gordc | cdent: i saw big lebowski. great movie. | 14:54 |
cdent | I feel better about you now | 14:54 |
gordc | :) | 14:55 |
gordc | goodman's character is the best though. | 14:55 |
cdent | yes | 14:55 |
cdent | Have you seen Barton Fink? | 14:56 |
gordc | never heard of it. | 14:57 |
*** eglynn-office has quit IRC | 14:58 | |
gordc | oh. i've seen the poster. (or image) | 14:58 |
gordc | another coen brothers film eh? i'll add it to the list. | 14:58 |
cdent | much different style, but goodman is awesome in that too | 14:59 |
*** exploreshaifali has quit IRC | 14:59 | |
*** prad has joined #openstack-ceilometer | 15:00 | |
gordc | nice... will have to check that out. | 15:00 |
cdent | If this were a slightly less public irc channel we could quote big lebowski all day | 15:01 |
gordc | lol yeah, i was going to start referencing stuff. than i realised i'd probably be booted | 15:05 |
*** ccrouch has joined #openstack-ceilometer | 15:06 | |
*** ccrouch has left #openstack-ceilometer | 15:07 | |
*** ccrouch has joined #openstack-ceilometer | 15:12 | |
*** robsparker has joined #openstack-ceilometer | 15:13 | |
*** yeungp has joined #openstack-ceilometer | 15:14 | |
*** nellysmitt has quit IRC | 15:19 | |
openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 15:40 |
*** thomasem has quit IRC | 15:51 | |
*** thomasem has joined #openstack-ceilometer | 15:57 | |
*** thomasem has quit IRC | 15:57 | |
*** thomasem has joined #openstack-ceilometer | 16:00 | |
*** ildikov_afk is now known as ildikov | 16:01 | |
ildikov | eglynn: hi | 16:01 |
ildikov | eglynn: I've just arrived back, I checked the logs and I'm satisfied with the outcome, so will check that branch to see what's going on :) | 16:02 |
*** mikedillion has joined #openstack-ceilometer | 16:03 | |
gordc | open question to all: should we order list of traits returned with events when querying get_events? https://bugs.launchpad.net/ceilometer/+bug/1423714 | 16:03 |
openstack | Launchpad bug 1423714 in Ceilometer "tests wrongly assume trait ordering" [Medium,In progress] - Assigned to gordon chung (chungg) | 16:03 |
gordc | ie. should we fix test or fix code. i'm indifferent. | 16:03 |
*** himangi has joined #openstack-ceilometer | 16:03 | |
*** himangi has quit IRC | 16:08 | |
*** himangi has joined #openstack-ceilometer | 16:08 | |
*** changbl has joined #openstack-ceilometer | 16:09 | |
*** mikedillion has quit IRC | 16:11 | |
*** himangi has quit IRC | 16:12 | |
*** himangi has joined #openstack-ceilometer | 16:13 | |
eglynn | ildikov: cool enough | 16:14 |
*** exploreshaifali has joined #openstack-ceilometer | 16:22 | |
ildikov | gordc: is there any easonable order that we could set as default? | 16:22 |
gordc | ildikov: trait key name. that's what mongo/es/hbase default to. it might be because that's what the test case assumes and those dbs were all written after test cases | 16:24 |
gordc | tbh, i'd probably lean more to the no order side but just barely. | 16:25 |
ildikov | gordc: well, then I guess that could be the default behaviour if that is returned in case of most drivers already | 16:28 |
ildikov | gordc: at least there will not be any bug about this in the future that whatever backend returns traits in different order than others | 16:30 |
ildikov | gordc: but it's just an opinion :) | 16:30 |
gordc | ildiko: fair enough. | 16:31 |
sileht | cdent, I have started looking on gabby, and wonder if you have a plan to inject default headers via os.environ or fixtures | 16:32 |
sileht | cdent, I'm trying to see how I can provide for a keystone token | 16:32 |
sileht | cdent, in live tests context | 16:33 |
sileht | s/gabby/gabbi | 16:33 |
cdent | there is a defaults key that can be in the yaml file | 16:33 |
cdent | which forms the base dictionary for all the tests in that single file | 16:33 |
* cdent looks for example | 16:33 | |
cdent | sileht: https://github.com/cdent/gabbi/blob/master/gabbi/gabbits_intercept/self.yaml | 16:34 |
cdent | anywhere url is not used in one of the tests, the default /cow?alpha=1 will be used | 16:34 |
cdent | you can put any valid keys in defaults | 16:34 |
cdent | so a request_header x-roles or similar to be used by the whole file would be possible | 16:34 |
cdent | does that make sense? | 16:34 |
*** david-lyle_afk is now known as david-lyle | 16:36 | |
sileht | cdent, I try to see how I can replace this line by the gabbi tests suite you have written: https://github.com/stackforge/gnocchi/blob/master/devstack/gate/post_test_hook.sh#L34 | 16:36 |
sileht | cdent, I don't want to rewrite tests, and the content of the token will change between each gate run | 16:36 |
cdent | at the moment all the tests I've written have been to the internal gnocchi wsgi-app with keystone disabled | 16:37 |
cdent | to use a real keystone token one option would be to read it in from disk at test run time (the harness would generate the token and save it somewhere known then the yaml file would read the token) | 16:38 |
cdent | however, at the moment reading from disk is only supported for body data, not for headers but that could change | 16:39 |
cdent | however, I'm not sure how much we want gabbi carting around keystone tokens | 16:39 |
sileht | cdent, WDYT about adding a template thing that looks: $ENVIRON['KEYSTONE_TOKEN'] ? | 16:39 |
cdent | that would probably be okay | 16:40 |
cdent | but to what extent do we want to think of keystone as an integral part of API testing? | 16:40 |
cdent | I've generally been on the side of leaving that out of it, but there are certainly ways to do it. | 16:40 |
sileht | cdent, yes to have some tests check the acl stuffs | 16:41 |
cdent | you don't need a token to check the acl's do you? you need to pass in the headers that the token gets changed to by the middleware? | 16:41 |
cdent | x-user-id, x-projecd-id, x-roles | 16:42 |
sileht | that's true | 16:42 |
cdent | so whereas we want to do AuthZ in gabbi tests, doing AuthN isn't really required? | 16:42 |
*** himangi has quit IRC | 16:42 | |
sileht | your right, i will make some check and probably disable keystone too | 16:44 |
sileht | cdent, thanks | 16:44 |
cdent | you're welcome, it's great to see more people looking into it | 16:44 |
cdent | I'm sure you will find things that are incomplete, please let me know and I'll fix what I can | 16:44 |
cdent | the $ENVIRON thing is a good idea but I'd like to hold off on adding it until something really requires it | 16:45 |
*** fnaval has joined #openstack-ceilometer | 16:45 | |
*** himangi has joined #openstack-ceilometer | 16:46 | |
*** pcaruana has quit IRC | 16:50 | |
*** rwsu-afk is now known as rwsu | 16:50 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: order traits returned within events https://review.openstack.org/157615 | 16:54 |
openstackgerrit | Mehdi Abaakouk proposed stackforge/gnocchi: [TEST] launch gabbi live tests https://review.openstack.org/159538 | 16:56 |
openstackgerrit | Mehdi Abaakouk proposed stackforge/gnocchi: Add the nova shiny test output https://review.openstack.org/159539 | 16:56 |
sileht | cdent, I have run all tests on an live gnocchi (apache+mod_wsgi) and I got 3 failures | 16:59 |
cdent | I was just going to look at that, give me a sec to read it | 16:59 |
sileht | cdent, I will investigate on them tomorow and review the new tests you have written | 17:00 |
sileht | bbl | 17:00 |
linuxhermit | cdent gordc can I bug you to look at https://review.openstack.org/#/c/156667/ again only change is more comments and removal of a duplicated test | 17:03 |
cdent | ✔ | 17:03 |
*** yatin has joined #openstack-ceilometer | 17:04 | |
gordc | linuxhermit: cool with me. | 17:05 |
*** lsmola has quit IRC | 17:06 | |
*** Ala has quit IRC | 17:08 | |
*** thomasem_ has joined #openstack-ceilometer | 17:08 | |
*** thomasem has quit IRC | 17:11 | |
*** thomasem_ has quit IRC | 17:12 | |
*** akrivoka has quit IRC | 17:13 | |
*** eglynn-office has joined #openstack-ceilometer | 17:14 | |
*** thomasem has joined #openstack-ceilometer | 17:16 | |
*** nellysmitt has joined #openstack-ceilometer | 17:20 | |
*** ViswaV has joined #openstack-ceilometer | 17:20 | |
*** _cjones_ has joined #openstack-ceilometer | 17:21 | |
*** nellysmitt has quit IRC | 17:25 | |
*** sbfox has joined #openstack-ceilometer | 17:28 | |
*** ViswaV_ has joined #openstack-ceilometer | 17:28 | |
*** ViswaV has quit IRC | 17:28 | |
*** IvanBerezovskiy_ has quit IRC | 17:29 | |
*** thomasem has quit IRC | 17:37 | |
*** fabiog has joined #openstack-ceilometer | 17:38 | |
*** karimb has quit IRC | 17:39 | |
*** nellysmitt has joined #openstack-ceilometer | 17:41 | |
*** karimb has joined #openstack-ceilometer | 17:43 | |
*** zul has quit IRC | 17:43 | |
*** karimb has quit IRC | 17:43 | |
*** thomasem has joined #openstack-ceilometer | 17:46 | |
*** kbyrne has quit IRC | 18:03 | |
*** fabiog has quit IRC | 18:03 | |
*** thomasem has quit IRC | 18:04 | |
*** kbyrne has joined #openstack-ceilometer | 18:05 | |
*** thomasem has joined #openstack-ceilometer | 18:08 | |
*** zul has joined #openstack-ceilometer | 18:09 | |
*** cdent has quit IRC | 18:34 | |
*** _nadya_ has quit IRC | 18:38 | |
*** yatin has quit IRC | 18:53 | |
*** eglynn-office is now known as eglynn-officeafk | 18:54 | |
*** exploreshaifali has quit IRC | 18:55 | |
*** Ctina has joined #openstack-ceilometer | 18:55 | |
Ctina | hey i was wondering if someone had a second to help me with some potentially dumb ceilometer questions? | 18:56 |
Ctina | I'm having trouble getting the cpu meter to show up, i started an instance and i see the disk.root.size, instance.scheduled, instance:<flavor> meters along with memory and vcpu, just not cpu or cpu_util | 18:57 |
openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 18:58 |
*** prad has quit IRC | 19:01 | |
*** eglynn has quit IRC | 19:08 | |
gordc | Ctina: the meters you mentioned tend to come from notification messages that nova emits | 19:11 |
Ctina | gordc: so do you think it sounds like i'm missing a config in my nova.conf? | 19:12 |
gordc | cpu meter comes from ceilometer's compute agent... by default that polls every 10 minutes so it may be because it hasn't actually polled yet. | 19:12 |
Ctina | I updated the pipeline.yaml to poll every 60 seconds and i'm still not seeing anything | 19:13 |
gordc | Ctina: if you have disk.root.size it means you should be ok in regards to nova.conf. you may want to look at the ceilometer-acompute logs to make sure that is functioning properly | 19:13 |
gordc | it seems like you're missing logs from polling agent and not the notification agent. | 19:14 |
gordc | missing meters* | 19:14 |
Ctina | So i see the polling for cpu and cpu_util in the ceilometer/compute.log actually | 19:14 |
Ctina | 2015-02-26 16:24:35.235 31966 INFO ceilometer.agent [-] Polling pollster cpu_util | 19:15 |
Ctina | I'm running Icehouse if that helps | 19:17 |
Ctina | it looks like those logs i'm seeing are about 3 hours old too..hmm | 19:17 |
gordc | Ctina: i see.. it could be your service is stopped. probably try restarting it and check if the logs are throwing any errors. | 19:19 |
Ctina | i restarted the ceilometer-compute service and my ceilometer/compute.log wasn't updated at all | 19:21 |
Ctina | my alarm-evaluator just started throwing unauthorized errors, would that cause issues with the ceilometer-compute service? | 19:23 |
gordc | no teh compute service can run separately from the alarm. | 19:24 |
gordc | the service should log some configuration steps at start up so it's strange you see nothing in compute log | 19:25 |
*** sbfox has quit IRC | 19:26 | |
*** himangi has quit IRC | 19:26 | |
gordc | are you using vmware by any chance? | 19:27 |
*** sbfox has joined #openstack-ceilometer | 19:27 | |
*** sbfox has quit IRC | 19:28 | |
Ctina | nope, not using vmware | 19:29 |
*** exploreshaifali has joined #openstack-ceilometer | 19:30 | |
*** thomasem has quit IRC | 19:31 | |
gordc | ok. i was just looking through backlog and i noticed there was a vmware related issue that hasn't been backported to icehouse... looking at automated builds there doesn't appear to be any noticeable issues with compute agent in icehouse | 19:32 |
Ctina | boo yeah this isn't devstack or anything. The last message in my ceilometer/compute.log is caught sigterm, exiting but it hasn't updated since i restarted the service :-\ | 19:34 |
gordc | sorry, i'm not really sure what is happening without logs. there might be some stray process that you might need to kill that is blocking compute agent from restarting | 19:44 |
openstackgerrit | Jim Rollenhagen proposed openstack/ceilometer: Do not default pecan_debug to CONF.debug https://review.openstack.org/159591 | 19:45 |
Ctina | okay, at least I have an avenue to head down now, get the compute service logging! thank you for your help!! | 19:46 |
gordc | np. good luck | 19:47 |
*** ddieterly has quit IRC | 19:47 | |
*** ddieterly has joined #openstack-ceilometer | 19:47 | |
*** jkraj has quit IRC | 19:55 | |
*** exploreshaifali has quit IRC | 19:56 | |
*** Ctina_ has joined #openstack-ceilometer | 20:01 | |
*** himangi has joined #openstack-ceilometer | 20:03 | |
*** Ctina has quit IRC | 20:05 | |
*** Ctina_ has quit IRC | 20:06 | |
*** thomasem has joined #openstack-ceilometer | 20:07 | |
*** nellysmitt has quit IRC | 20:09 | |
*** himangi has quit IRC | 20:15 | |
*** rbak_ has joined #openstack-ceilometer | 20:16 | |
*** rbak has quit IRC | 20:16 | |
dhellmann | jroll: as a config change, does ^^ need a DocImpact tag in the commit message? | 20:21 |
jroll | dhellmann: mmm, that's a good point, I don't know | 20:22 |
jroll | dhellmann: I can't imagine that's something a deployer would want to enable, but maybe | 20:22 |
dhellmann | jroll: well, it's more of a release-note thing, I think, since the default behavior is changing. Maybe ask annegentle? | 20:23 |
jroll | yeah | 20:24 |
jroll | dhellmann: don't see her online though | 20:24 |
dhellmann | hmm | 20:25 |
dhellmann | jroll: let's err on the side of caution and add the tag | 20:25 |
jroll | yeah, just didn't want to slow it down unnecessarily | 20:26 |
* jroll does it | 20:26 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ceilometer: Do not default pecan_debug to CONF.debug https://review.openstack.org/159591 | 20:26 |
dhellmann | jroll: I think it's async to the code review process, so it shouldn't be an issue | 20:26 |
jroll | gordc: can you re-approve that please? | 20:26 |
jroll | dhellmann: I meant it going back to the end of the gate | 20:27 |
*** himangi has joined #openstack-ceilometer | 20:27 | |
dhellmann | jroll, gordc : done | 20:30 |
openstackgerrit | Charles Crouch proposed openstack/ceilometer: Fix a few typos in the docs https://review.openstack.org/159598 | 20:30 |
jroll | thanks | 20:31 |
*** himangi has quit IRC | 20:33 | |
ccrouch | gordc: +1 on your last update to https://github.com/openstack/ceilometer/blob/master/doc/source/architecture.rst | 20:34 |
ccrouch | I'm so glad "Push Agents" section was removed :-) | 20:34 |
ccrouch | it was kinda blowing my mind :-) | 20:34 |
*** himangi has joined #openstack-ceilometer | 20:40 | |
gordc | sorry, was on a call. thanks dhellmann | 20:46 |
gordc | ccrouch: :) yeah. i was hoping to redirect some ops to the docs we had. then i realised they were pretty patchy. ildikov and i are working on the main openstack docs so things should be better as we work on it. | 20:48 |
ccrouch | great i'm looking through them too trying to come up to speed with more of the details, so I'll try to do some reviews on your changes | 20:49 |
gordc | ccrouch: cool cool. most of my changes are just cleanup/refactoring. thanks for the reviews. | 20:55 |
*** changbl has quit IRC | 21:21 | |
*** sbfox has joined #openstack-ceilometer | 21:26 | |
*** claudiub has joined #openstack-ceilometer | 21:45 | |
openstackgerrit | gordon chung proposed openstack/ceilometer: create a developer section and refactor https://review.openstack.org/156413 | 21:55 |
*** karimb has joined #openstack-ceilometer | 21:58 | |
openstackgerrit | Merged openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 22:04 |
*** gordc has quit IRC | 22:04 | |
*** rwsu has quit IRC | 22:06 | |
*** claudiub has quit IRC | 22:16 | |
*** rwsu has joined #openstack-ceilometer | 22:30 | |
*** rodrigods is now known as rodrigod` | 22:42 | |
*** rodrigod` is now known as rodrigods | 22:43 | |
*** rodrigods is now known as rodrigod` | 22:51 | |
*** rodrigod` is now known as rodrigods | 22:51 | |
*** thomasem has quit IRC | 22:51 | |
*** yeungp has quit IRC | 23:15 | |
*** yeungp has joined #openstack-ceilometer | 23:15 | |
openstackgerrit | Merged openstack/ceilometer: Do not default pecan_debug to CONF.debug https://review.openstack.org/159591 | 23:47 |
*** EmilienM is now known as EmilienM|afk | 23:49 | |
*** ddieterly has quit IRC | 23:53 | |
*** himangi has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!